[PATCH] Add missing macro argument for devm_release_* family

Previous thread: [PATCH 0/5] x86: signal works for unification by Hiroshi Shimamoto on Friday, September 5, 2008 - 4:22 pm. (7 messages)

Next thread: [RFC 2/4] x86: HPET_MSI Refactor code in preparation for HPET_MSI by venkatesh.pallipadi on Friday, September 5, 2008 - 6:02 pm. (1 message)
From: Hiroshi DOYU
Date: Friday, September 5, 2008 - 6:00 pm

From: ext Hiroshi DOYU <Hiroshi.DOYU@nokia.com>

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 include/linux/ioport.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/ioport.h b/include/linux/ioport.h
index 22d2115..c813c63 100644
--- a/include/linux/ioport.h
+++ b/include/linux/ioport.h
@@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
 				struct resource *parent, resource_size_t start,
 				resource_size_t n, const char *name);
 
-#define devm_release_region(start,n) \
+#define devm_release_region(dev,start,n) \
 	__devm_release_region(dev, &ioport_resource, (start), (n))
-#define devm_release_mem_region(start,n) \
+#define devm_release_mem_region(dev,start,n) \
 	__devm_release_region(dev, &iomem_resource, (start), (n))
 
 extern void __devm_release_region(struct device *dev, struct resource *parent,
-- 
1.5.5.1.357.g1af8b

--

From: Andrew Morton
Date: Friday, September 5, 2008 - 6:52 pm

um, OK.

But none of these things appear to have any callers anywhere.  Why
don't we just delete it all?

--

From: Hiroshi DOYU
Date: Friday, September 5, 2008 - 10:18 pm

From: "ext Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] Add missing macro argument for devm_release_* family

Not sure for others, but at least, I am using this in my developing
driver;)
--

From: Andrew Morton
Date: Friday, September 5, 2008 - 10:23 pm

yeah, I was just trolling ;)

I queued this fix for 2.6.27.
--

Previous thread: [PATCH 0/5] x86: signal works for unification by Hiroshi Shimamoto on Friday, September 5, 2008 - 4:22 pm. (7 messages)

Next thread: [RFC 2/4] x86: HPET_MSI Refactor code in preparation for HPET_MSI by venkatesh.pallipadi on Friday, September 5, 2008 - 6:02 pm. (1 message)