Home » Mailing list archives » linux-kernel » 2008 » September » 4

Re: [PATCH] VM: Implements the swap-out page-clustering technique

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton
Subject: Re: [PATCH] VM: Implements the swap-out page-clustering technique
Date: Thursday, September 4, 2008 - 4:14 pm

On Thu, 04 Sep 2008 15:34:30 +0330
"Hamid R. Jahanjou" <hamid.jahanjou@gmail.com> wrote:


I tried that once.  The code all worked as-designed but didn't seem to
improve performance much across a spread of workloads.


Benchmarks are essential, please.  Good ones.

The whole point of the patch is to improve performance.  If we don't
know whether it improves performance, we cannot proceed in any way.


Secondly, please don't just dump a pile of new code in our laps and
expect us to pick through it and work out what it does and how it does
it.  Please at least provide a carefully-written english-language
description of the design and implementation.

Thirdly, I'd suggest that this code be converted into vaguely standard
kernel coding style sooner rather than later.  Convert it to use
eight-column hard tabs then check it with scripts/checkpatch.pl,
thanks.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] VM: Implements the swap-out page-clustering technique, Hamid R. Jahanjou, (Thu Sep 4, 5:04 am)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Rik van Riel, (Thu Sep 4, 4:14 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Andrew Morton, (Thu Sep 4, 4:14 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Andrew Morton, (Thu Sep 4, 11:58 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Hamid R. Jahanjou, (Fri Sep 5, 12:45 am)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Andi Kleen, (Fri Sep 5, 2:19 am)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Andi Kleen, (Fri Sep 5, 12:45 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Hamid R. Jahanjou, (Fri Sep 5, 1:27 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Rik van Riel, (Fri Sep 5, 10:42 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Zan Lynx, (Sun Sep 7, 5:28 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Rik van Riel, (Sun Sep 7, 5:55 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Li Yu, (Sun Sep 7, 8:50 pm)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., hamidreza jahanjou, (Mon Sep 8, 2:51 am)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Hamid R. Jahanjou, (Wed Sep 10, 1:16 am)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Ray Lee, (Wed Sep 10, 10:08 am)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Rik van Riel, (Wed Sep 10, 10:39 am)
Re: [PATCH] VM: Implements the swap-out page-clustering te ..., Luiz Fernando N. Cap ..., (Wed Sep 24, 6:56 am)