login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
September
»
4
Re: [TIP/SCHED/DEVEL PATCH v3 4/6] sched: add sched_class->needs_post_schedule() member
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Gregory Haskins
Subject:
Re: [TIP/SCHED/DEVEL PATCH v3 4/6] sched: add sched_class->needs_post_schedule() member
Date: Thursday, September 4, 2008 - 1:36 pm
Steven Rostedt wrote:
quoted text
> On Thu, 4 Sep 2008, Gregory Haskins wrote: > =20 >> diff --git a/kernel/sched.c b/kernel/sched.c >> index af4c6fa..ddc3877 100644 >> --- a/kernel/sched.c >> +++ b/kernel/sched.c >> @@ -2525,6 +2525,14 @@ static void finish_task_switch(struct rq *rq, s=
truct task_struct *prev)
quoted text
>> { >> struct mm_struct *mm =3D rq->prev_mm; >> long prev_state; >> +#ifdef CONFIG_SMP >> + int post_schedule =3D 0; >> + >> + if (current->sched_class->needs_post_schedule) { >> + BUG_ON(!current->sched_class->post_schedule); >> =20 > > The only one to ever hit this BUG_ON is a kernel developer creating a n=
ew
quoted text
> sched class. Since they should be smart enough to figure out why they g=
et=20
quoted text
> a segv later on, we really don't need it. Because this BUG_ON is also i=
n=20
quoted text
> a hot path, I strongly suggest nuking it. > =20
Ack. Will do a respin after you review the last few patches. -Greg
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 0/5] sched: misc rt fixes for tip/sched/devel
, Gregory Haskins
, (Mon Aug 25, 1:15 pm)
[PATCH 1/5] sched: only try to push a task on wakeup if it ...
, Gregory Haskins
, (Mon Aug 25, 1:15 pm)
[PATCH 2/5] sched: pull only one task during NEWIDLE balan ...
, Gregory Haskins
, (Mon Aug 25, 1:15 pm)
[PATCH 3/5] sched: make double-lock-balance fair
, Gregory Haskins
, (Mon Aug 25, 1:15 pm)
[PATCH 4/5] sched: add sched_class->needs_post_schedule() ...
, Gregory Haskins
, (Mon Aug 25, 1:15 pm)
[PATCH 5/5] sched: create "pushable_tasks" list to limit p ...
, Gregory Haskins
, (Mon Aug 25, 1:15 pm)
Re: [PATCH 3/5] sched: make double-lock-balance fair
, Nick Piggin
, (Mon Aug 25, 11:14 pm)
Re: [PATCH 2/5] sched: pull only one task during NEWIDLE b ...
, Nick Piggin
, (Mon Aug 25, 11:21 pm)
Re: [PATCH 2/5] sched: pull only one task during NEWIDLE b ...
, Gregory Haskins
, (Tue Aug 26, 4:36 am)
Re: [PATCH 3/5] sched: make double-lock-balance fair
, Gregory Haskins
, (Tue Aug 26, 5:23 am)
[PATCH v2 0/6] Series short description
, Gregory Haskins
, (Tue Aug 26, 10:34 am)
[PATCH v2 1/6] sched: only try to push a task on wakeup if ...
, Gregory Haskins
, (Tue Aug 26, 10:34 am)
[PATCH v2 2/6] sched: pull only one task during NEWIDLE ba ...
, Gregory Haskins
, (Tue Aug 26, 10:34 am)
[PATCH v2 3/6] sched: make double-lock-balance fair
, Gregory Haskins
, (Tue Aug 26, 10:35 am)
[PATCH v2 4/6] sched: add sched_class->needs_post_schedule ...
, Gregory Haskins
, (Tue Aug 26, 10:35 am)
[PATCH v2 5/6] plist: fix PLIST_NODE_INIT to work with deb ...
, Gregory Haskins
, (Tue Aug 26, 10:35 am)
[PATCH v2 6/6] sched: create "pushable_tasks" list to limi ...
, Gregory Haskins
, (Tue Aug 26, 10:35 am)
Re: [PATCH v2 0/6] sched: misc rt fixes for tip/sched/deve ...
, Gregory Haskins
, (Tue Aug 26, 11:16 am)
Re: [PATCH 3/5] sched: make double-lock-balance fair
, Nick Piggin
, (Tue Aug 26, 11:36 pm)
Re: [PATCH 2/5] sched: pull only one task during NEWIDLE b ...
, Nick Piggin
, (Tue Aug 26, 11:41 pm)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Peter Zijlstra
, (Wed Aug 27, 1:21 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Peter Zijlstra
, (Wed Aug 27, 1:25 am)
Re: [PATCH v2 0/6] Series short description
, Peter Zijlstra
, (Wed Aug 27, 1:33 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Nick Piggin
, (Wed Aug 27, 3:26 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Peter Zijlstra
, (Wed Aug 27, 3:41 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Nick Piggin
, (Wed Aug 27, 3:56 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Nick Piggin
, (Wed Aug 27, 3:57 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Peter Zijlstra
, (Wed Aug 27, 4:07 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Russell King
, (Wed Aug 27, 4:17 am)
Re: [PATCH 3/5] sched: make double-lock-balance fair
, Gregory Haskins
, (Wed Aug 27, 4:41 am)
Re: [PATCH 2/5] sched: pull only one task during NEWIDLE b ...
, Gregory Haskins
, (Wed Aug 27, 4:50 am)
Re: [PATCH 3/5] sched: make double-lock-balance fair
, Nick Piggin
, (Wed Aug 27, 4:53 am)
Re: [PATCH 2/5] sched: pull only one task during NEWIDLE b ...
, Nick Piggin
, (Wed Aug 27, 4:57 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Gregory Haskins
, (Wed Aug 27, 5:00 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Gregory Haskins
, (Wed Aug 27, 5:02 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Gregory Haskins
, (Wed Aug 27, 5:03 am)
Re: [PATCH 3/5] sched: make double-lock-balance fair
, Gregory Haskins
, (Wed Aug 27, 5:10 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Gregory Haskins
, (Wed Aug 27, 5:13 am)
Re: [PATCH v2 3/6] sched: make double-lock-balance fair
, Ralf Baechle
, (Fri Aug 29, 5:49 am)
Re: [PATCH v2 6/6] sched: create "pushable_tasks" list to ...
, Gregory Haskins
, (Fri Aug 29, 6:24 am)
[TIP/SCHED/DEVEL PATCH v3 0/6] sched: misc rt fixes
, Gregory Haskins
, (Thu Sep 4, 5:54 am)
[TIP/SCHED/DEVEL PATCH v3 1/6] sched: only try to push a t ...
, Gregory Haskins
, (Thu Sep 4, 5:55 am)
[TIP/SCHED/DEVEL PATCH v3 2/6] sched: pull only one task d ...
, Gregory Haskins
, (Thu Sep 4, 5:55 am)
[TIP/SCHED/DEVEL PATCH v3 3/6] sched: make double-lock-bal ...
, Gregory Haskins
, (Thu Sep 4, 5:55 am)
[TIP/SCHED/DEVEL PATCH v3 4/6] sched: add sched_class->nee ...
, Gregory Haskins
, (Thu Sep 4, 5:55 am)
[TIP/SCHED/DEVEL PATCH v3 5/6] plist: fix PLIST_NODE_INIT ...
, Gregory Haskins
, (Thu Sep 4, 5:55 am)
[TIP/SCHED/DEVEL PATCH v3 6/6] sched: create "pushable_tas ...
, Gregory Haskins
, (Thu Sep 4, 5:55 am)
Re: [TIP/SCHED/DEVEL PATCH v3 4/6] sched: add sched_class- ...
, Gregory Haskins
, (Thu Sep 4, 1:36 pm)
Re: [TIP/SCHED/DEVEL PATCH v3 4/6] sched: add sched_class- ...
, Steven Rostedt
, (Thu Sep 4, 1:36 pm)
Re: [TIP/SCHED/DEVEL PATCH v3 6/6] sched: create "pushable ...
, Steven Rostedt
, (Thu Sep 4, 2:16 pm)
Re: [TIP/SCHED/DEVEL PATCH v3 6/6] sched: create "pushable ...
, Gregory Haskins
, (Thu Sep 4, 2:26 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Eric Sandeen
Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages
Daniel Hazelton
Re: x86: 4kstacks default
Mathieu Desnoyers
Re: Linux 2.6.25-rc2
Alexandre Oliva
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Andi Kleen
Re: [Xen-devel] Re: [PATCH 00 of 36] x86/paravirt: groundwork for 64-bit Xen support
git
:
Felipe Contreras
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Johannes Schindelin
[PATCH] fetch: refuse to fetch into the current branch in a non-bare repository
Johannes Schindelin
Re: [PATCH] Fix install-doc-quick target
Nicolas Pitre
Re: About git and the use of SHA-1
Alex Riesen
Re: git exclude patterns for directory
linux-netdev
:
Andi Kleen
Re: RFC: Nagle latency tuning
Herbert Xu
Re: Oops in tun: bisected to Limit amount of queued packets per device
gregkh
Patch "IPv6: keep route for tentative address" has been added to the 2.6.34-stable...
Paul Gortmaker
[PATCH net-next 09/16] tipc: Relocate trivial link status functions to header file
Patrick McHardy
Re: [rfc 02/13] [RFC 02/13] netfilter: nf_conntrack_sip: Add callid parser
git-commits-head
:
Linux Kernel Mailing List
sh: Fix compile error by operands(mov.l) in sh3/entry.S
Linux Kernel Mailing List
New device ID for sc92031 [1088:2031]
Linux Kernel Mailing List
tmpfs: depend on shmem
Linux Kernel Mailing List
drivers/acpi: use kasprintf
Linux Kernel Mailing List
Staging: et131x: prune all the debug code
openbsd-misc
:
Andres Salazar
About priorities in /etc/resolv.conf
Tonnerre LOMBARD
Re: bge0: watchdog timeout
Rob Shepherd
x86 hardware for router system
Damien Miller
Re: Patching a SSH 'Weakness'
ropers
Re: Real men don't attack straw men
Colocation donated by:
Syndicate