Same questions here that I had for the ARI stuff. Does this
dev_info add value, or is it more noise, and is this message
Do you want to emit a kobject_uevent here after success?
Alternatively, have you investigated making these virtual
functions into real struct device's? You get a lot of sysfs stuff
for free if you do so, including correct place in sysfs hierarchy
and uevents, etc.
My major complaints from last round (more documentation,
shouldn't be a PCI hotplug driver) have been addressed. I'll let
others comment about the other parts of your patch series.
> + ctrl = pci_ari_enabled(dev) ? PCI_IOV_CTRL_ARI : 0;
> + pci_write_config_word(dev, pos + PCI_IOV_CTRL, ctrl);
> + ssleep(1);
You seem to sleep for 1 second wherever you write the IOV_CTRL
register. Why is this? Is this specified by PCI, or is it coming from