Re: [PATCH 4/6 v3] PCI: support SR-IOV capability

Previous thread: [PATCH 3/6 v3] PCI: support ARI capability by Zhao, Yu on Saturday, September 27, 2008 - 1:28 am. (5 messages)

Next thread: [PATCH 5/6 v3] PCI: reserve bus range for SR-IOV by Zhao, Yu on Saturday, September 27, 2008 - 1:28 am. (1 message)
From: Zhao, Yu
Date: Saturday, September 27, 2008 - 1:28 am

[Empty message]
From: Alex Chiang
Date: Tuesday, September 30, 2008 - 3:38 pm

Same questions here that I had for the ARI stuff. Does this
dev_info add value, or is it more noise, and is this message

Do you want to emit a kobject_uevent here after success?

Alternatively, have you investigated making these virtual
functions into real struct device's? You get a lot of sysfs stuff
for free if you do so, including correct place in sysfs hierarchy
and uevents, etc.

My major complaints from last round (more documentation,
shouldn't be a PCI hotplug driver) have been addressed. I'll let
others comment about the other parts of your patch series.

Thanks.

/ac

--

From: Zhao, Yu
Date: Friday, October 10, 2008 - 12:24 am

The virtual functions are rpresented by 'struct pci_dev', so same as 


--

From: Roland Dreier
Date: Tuesday, September 30, 2008 - 3:40 pm

> +       ctrl = pci_ari_enabled(dev) ? PCI_IOV_CTRL_ARI : 0;
 > +       pci_write_config_word(dev, pos + PCI_IOV_CTRL, ctrl);
 > +       ssleep(1);

You seem to sleep for 1 second wherever you write the IOV_CTRL
register.  Why is this?  Is this specified by PCI, or is it coming from
somewhere else?

 - R.
--

From: Zhao, Yu
Date: Tuesday, October 7, 2008 - 7:49 pm

This is specified by on pp. 39 PCI SR-IOV specification 1.0. You can find it at: http://www.pcisig.com/members/downloads/specifications/iov/sr-iov1.0_11Sep07.pdf

--

Previous thread: [PATCH 3/6 v3] PCI: support ARI capability by Zhao, Yu on Saturday, September 27, 2008 - 1:28 am. (5 messages)

Next thread: [PATCH 5/6 v3] PCI: reserve bus range for SR-IOV by Zhao, Yu on Saturday, September 27, 2008 - 1:28 am. (1 message)