On Tue, Sep 30, 2008 at 2:37 PM, H. Peter Anvin  wrote:

quoted text
> Yinghai Lu wrote:

>>

>> On Tue, Sep 30, 2008 at 12:59 PM, H. Peter Anvin  wrote:

>>>

>>> Yinghai Lu wrote:

>>>>

>>>> On Tue, Sep 30, 2008 at 11:47 AM, H. Peter Anvin  wrote:

>>>>>

>>>>> Ingo Molnar wrote:

>>>>>>>

>>>>>>> early_param("enble_mtrr_cleanup", enable_mtrr_cleanup_setup);

>>>>>>>           ^^^^^^

>>>>>>>

>>>>>>> Nice ;)

>>>>>>

>>>>>> heh. Could you send a patch with a changelog please?

>>>>>

>>>>> These options are also named inconsistently with all other options.

>>>>>

>>>>> The standard way to name an boolean option is "foo" versus "nofoo", in

>>>>> this

>>>>> case, "mtrrcleanup" vs "nomtrrcleanup".

>>>>>

>>>> ok, we could change it...

>>>

>>> If we're fixing a typo anyway I'd suggest so.  We know we're not breaking

>>> anyone's working setup...

>>

>> mtrr_cleanup and no_mtrr_cleanup?

>>

>

> Dashes seem to be used more than underscores, so it probably should be

> "mtrr-cleanup" and "nomtrr-cleanup" if you want a separator.

>

i need to document the mtrr_cleanup_debug too...change it to

mtrrcleanup_debug ? just like initcall_debug?
YH

--

unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

the body of a message to majordomo@vger.kernel.org

More majordomo info at  http://vger.kernel.org/majordomo-info.html

Please read the FAQ at  http://www.tux.org/lkml/