Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Russell King - ARM Linux <linux@...>
Cc: Christoph Lameter <cl@...>, lkml <linux-kernel@...>
Date: Tuesday, September 30, 2008 - 5:09 pm

On Tue, 30 Sep 2008, Russell King - ARM Linux wrote:


I just tried this:

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 70dba16..8f609cc 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -148,7 +148,6 @@ config ARCH_MAY_HAVE_PC_FDC
 
 config ZONE_DMA
 	bool
-	default y
 
 config GENERIC_ISA_DMA
 	bool

with no other changes what so ever.  And the resulting kernel still 
works fine, with this difference:

|On node 0 totalpages: 131072
|free_area_init_node: node 0, pgdat c03c5e00, node_mem_map c03e7000
|  Normal zone: 130048 pages, LIFO batch:31

instead of:

|On node 0 totalpages: 131072
|free_area_init_node: node 0, pgdat c03c7e58, node_mem_map c03e9000
|  DMA zone: 130048 pages, LIFO batch:31

And the resulting kernel is also smaller:

|   text    data     bss     dec     hex filename
|3826182  102384  111700 4040266  3da64a vmlinux
|3823593  101616  111700 4036909  3d992d vmlinux.nodmazone

So maybe CONFIG_DMA_ZONE could be selected only by those machines 
actually defining arch_adjust_zones() ?


Indeed.  But still...


Nicolas
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
wrong usage of MAX_DMA_ADDRESS in bootmem.h, Nicolas Pitre, (Tue Sep 30, 3:35 pm)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Christoph Lameter, (Tue Sep 30, 3:56 pm)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Russell King - ARM Linux, (Tue Sep 30, 4:12 pm)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Christoph Lameter, (Wed Oct 1, 8:07 am)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Russell King - ARM Linux, (Wed Oct 1, 10:06 am)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Christoph Lameter, (Wed Oct 1, 10:50 am)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Russell King - ARM Linux, (Wed Oct 1, 11:02 am)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Christoph Lameter, (Thu Oct 2, 12:49 pm)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Russell King - ARM Linux, (Thu Oct 2, 3:06 pm)
Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h, Nicolas Pitre, (Tue Sep 30, 5:09 pm)