Re: [regression] CD-DA delay needed after insertion (http://bugzilla.kernel.org/show_bug.cgi?id=10974)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Geert Uytterhoeven
Date: Tuesday, September 30, 2008 - 7:51 am

On Tue, 30 Sep 2008, Monty Montgomery wrote:

With latest cdparanoia git-^H^H^H^Hsvn, the problem still happens.
After applying the patch below, there's no more crash thanks to your last
commit, and It Just Works(tm):

    eject; sg_start -i -l /dev/scd0; cdparanoia -d /dev/scd0 -Z -q 1-1[:1] /dev/null || echo failed

diff --git a/interface/scan_devices.c b/interface/scan_devices.c
index bfe5403..df08906 100644
--- a/interface/scan_devices.c
+++ b/interface/scan_devices.c
@@ -614,7 +614,7 @@ cdrom_drive *cdda_identify_scsi(const char *generic_device,
 
   if(specialized_device) {
     if(use_sgio)
-      i_fd=open(specialized_device,O_RDWR|O_NONBLOCK);
+      i_fd=open(specialized_device,O_RDONLY);
     else
       i_fd=open(specialized_device,O_RDONLY|O_NONBLOCK);
   }

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[regression] CD-DA delay needed after insertion, Geert Uytterhoeven, (Fri Jun 13, 4:57 am)
Re: [regression] CD-DA delay needed after insertion, Boaz Harrosh, (Sun Jun 15, 5:46 am)
Re: [regression] CD-DA delay needed after insertion, James Bottomley, (Sun Jun 15, 7:33 am)
Re: [regression] CD-DA delay needed after insertion, James Bottomley, (Sun Jun 15, 7:39 am)
Re: [regression] CD-DA delay needed after insertion, Geert Uytterhoeven, (Mon Jun 16, 8:05 am)
Re: [regression] CD-DA delay needed after insertion, James Bottomley, (Mon Jun 16, 1:30 pm)
Re: [regression] CD-DA delay needed after insertion, Geert Uytterhoeven, (Tue Jun 17, 6:31 am)
Re: [regression] CD-DA delay needed after insertion, Chuck Ebbert, (Tue Jun 17, 3:56 pm)
Re: [regression] CD-DA delay needed after insertion, James Bottomley, (Tue Jun 17, 3:59 pm)
Re: [regression] CD-DA delay needed after insertion, James Bottomley, (Wed Jun 18, 1:40 pm)
Re: [regression] CD-DA delay needed after insertion, Geert Uytterhoeven, (Thu Jun 19, 2:34 am)
Re: [regression] CD-DA delay needed after insertion, James Bottomley, (Fri Jun 27, 3:27 pm)
Re: [regression] CD-DA delay needed after insertion (http: ..., Geert Uytterhoeven, (Mon Jun 30, 2:25 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Geert Uytterhoeven, (Wed Jul 30, 6:06 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Geert Uytterhoeven, (Wed Sep 17, 8:05 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Geert Uytterhoeven, (Tue Sep 30, 5:33 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Geert Uytterhoeven, (Tue Sep 30, 6:37 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Geert Uytterhoeven, (Tue Sep 30, 7:51 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Geert Uytterhoeven, (Tue Sep 30, 8:21 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Monty Montgomery, (Tue Sep 30, 10:32 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Monty Montgomery, (Tue Sep 30, 11:10 am)
Re: [regression] CD-DA delay needed after insertion (http: ..., Geert Uytterhoeven, (Wed Oct 1, 12:51 am)