login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
September
»
30
Re: [PATCH 1/4] memcg: account swap cache under lock
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Balbir Singh <balbir@...>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...>
Cc: linux-mm@kvack.org <linux-mm@...>, LKML <linux-kernel@...>, xemul@openvz.org <xemul@...>, nishimura@mxp.nes.nec.co.jp <nishimura@...>
Subject:
Re: [PATCH 1/4] memcg: account swap cache under lock
Date: Tuesday, September 30, 2008 - 4:05 am
KAMEZAWA Hiroyuki wrote:
quoted text
> While page-cache's charge/uncharge is done under page_lock(), swap-cache > isn't. (anonymous page is charged when it's newly allocated.) > > This patch moves do_swap_page()'s charge() call under lock. > I don't see any bad problem *now* but this fix will be good for future > for avoiding unneccesary racy state. > > > Changelog: (v5) -> (v6) > - mark_page_accessed() is moved before lock_page(). > - fixed missing unlock_page() > (no changes in previous version)
Looks good to me Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com> -- Balbir --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 0/4] memcg: ready-to-go series (was memcg update v6)
, KAMEZAWA Hiroyuki
, (Mon Sep 29, 6:19 am)
Re: [PATCH 0/4] memcg: ready-to-go series (was memcg update ...
, Balbir Singh
, (Mon Oct 6, 1:15 pm)
[PATCH 4/4] memcg: optimze cpustat
, KAMEZAWA Hiroyuki
, (Mon Sep 29, 6:24 am)
Re: [PATCH 4/4] memcg: optimze cpustat
, Daisuke Nishimura
, (Mon Sep 29, 7:44 am)
[PATCH 3/4] memcg: avoid account not-on-LRU pages
, KAMEZAWA Hiroyuki
, (Mon Sep 29, 6:23 am)
Re: [PATCH 3/4] memcg: avoid account not-on-LRU pages
, Balbir Singh
, (Tue Sep 30, 4:14 am)
[PATCH/stylefix 3/4] memcg: avoid account not-on-LRU pages
, KAMEZAWA Hiroyuki
, (Mon Sep 29, 9:17 pm)
Re: [PATCH/stylefix 3/4] memcg: avoid account not-on-LRU pages
, Balbir Singh
, (Tue Sep 30, 11:49 pm)
Re: [PATCH/stylefix 3/4] memcg: avoid account not-on-LRU pages
, KAMEZAWA Hiroyuki
, (Wed Oct 1, 12:50 am)
Re: [PATCH 3/4] memcg: avoid account not-on-LRU pages
, Daisuke Nishimura
, (Mon Sep 29, 7:19 am)
Re: Re: [PATCH 3/4] memcg: avoid account not-on-LRU pages
,
, (Mon Sep 29, 7:59 am)
[PATCH 2/4] memcg: set page->mapping NULL before uncharge
, KAMEZAWA Hiroyuki
, (Mon Sep 29, 6:22 am)
Re: [PATCH 2/4] memcg: set page->mapping NULL before uncharge
, Balbir Singh
, (Tue Sep 30, 11:50 pm)
Re: [PATCH 2/4] memcg: set page->mapping NULL before uncharge
, Daisuke Nishimura
, (Mon Sep 29, 7:39 am)
[PATCH 1/4] memcg: account swap cache under lock
, KAMEZAWA Hiroyuki
, (Mon Sep 29, 6:21 am)
Re: [PATCH 1/4] memcg: account swap cache under lock
, Balbir Singh
, (Tue Sep 30, 4:05 am)
Re: [PATCH 1/4] memcg: account swap cache under lock
, Daisuke Nishimura
, (Mon Sep 29, 7:33 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Andy Whitcroft
clam
Ingo Molnar
[patch] paravirt: VDSO page is essential
git
:
linux-netdev
:
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Lovich, Vitali
RE: [PATCH] Packet socket: mmapped IO: PACKET_TX_RING
David Miller
[GIT]: Networking
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
667 guests
online.
Syndicate