linux-kernel mailing list

FromSubjectsort iconDate
J.A.
Strange mtrrs in Aspire One
Hi all... My aspire one is giving some strange MTRR settings with rc7-git5 (and prevous kernels, but that is what I run now...): one:~> cat /proc/mtrr reg00: base=0xfffe0000 (4095MB), size= 128KB: write-protect, count=1 reg01: base=0xfffc0000 (4095MB), size= 128KB: uncachable, count=1 reg02: base=0x00000000 ( 0MB), size= 256MB: write-back, count=1 reg03: base=0x10000000 ( 256MB), size= 256MB: write-back, count=1 reg04: base=0x1f800000 ( 504MB), size= 8MB: uncachable, count=1 reg05: ...
Sep 29, 4:57 pm 2008
Andi Kleen
Please pull arch perfmon update
Robert, Here are the arch perfmon changes ported to your latest oprofile tree. I didn't include the forcepmu=... change yet, that will come later. Right now the force option is just removed. Please pull. Thanks, -Andi The following changes since commit 22d87103484983035cf46891428819573ec7508d: Robert Richter (1): Merge branch 'oprofile/powerpc-for-paul' into oprofile/master are available in the git repository at: ...
Sep 29, 4:52 pm 2008
Matt Mackall
Re: [RFC PATCH 1/2] Shrink compat_ioctl.c
The original hash table was 256 pointers into the main table. I simply rearrange the main table so the first 256 entries have an appropriate hash. Basically: for i in len(table): h = hash(table[i]) swap(table[i], table[hash]) At the end of this loop, table[0:256] will contain an appropriate table entry, if it exists. So no secondary table is needed. -- Mathematics is the supreme nostalgia of our time. --
Sep 29, 4:38 pm 2008
Matt Mackall
[RFC PATCH 2/2] Shrink compat_ioctl.c
compat-ioctl: further compactify table Most entries use the basic compat handler, which means for most entries it's redundant. Rather than store a handler for each entry, we split the table so that there are two entry types, the 'basic stuff' and the handler pointer. At build time, the table is sorted so that each entry with a handler pointer is two entries, handler pointer first. At init time we re-sort the list so that all the handler pointers are at the end of the table and each basic ...
Sep 29, 4:29 pm 2008
Matt Mackall
[RFC PATCH 1/2] Shrink compat_ioctl.c
I'm throwing this out untested as I don't have a mixed 64/32 system handy at the moment. compat_ioctl: shrink structures Initially, compat_ioctl.c has a ~18k table of translated ioctls. Each table entry is 24 bytes but we can shrink this to 16: - use short table indexes rather than a pointer for .next values - use unsigned ints for cmd numbers (they're 32-bit ioctls, after all) In addition, there's a 2k hash table that we can do away with simply by hashifying the main table in place at ...
Sep 29, 4:27 pm 2008
Andi Kleen
Re: [RFC PATCH 1/2] Shrink compat_ioctl.c
You mean by using a closed hash? Acked-by: Andi Kleen <ak@linux.intel.com> -Andi --
Sep 29, 4:38 pm 2008
Chad Zanonie
[PATCH] oom-killer kills more than needed
Signed-off-by: Chad Zanonie This mod firstly replaces a !p->mm check with PF_KTHREAD to more accurately identify kthreads. Secondly, it adds a (p->state & TASK_DEAD) check to identify processes that have released their mm entirely. Not waiting for a process to finish releasing its memory entirely can cause the OOM killer to kill another application unnecessarily (while p->mm is null but memory isn't yet available). diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 64e5b4b..f325a87 ...
Sep 29, 4:09 pm 2008
gettinther
sata dvdroms fails to be recognized by MCP55 controller ...
Hi, I'm currently trying to get the 2.6.26.5 kernel to work but cannot get the sata dvdrom to be recognized by the MCP55. The controller works with the 2.6.24.4 and 2.6.25.17 kernels. I had to use CONFIG_ACPI_DOCK=y for the 2.6.25.17 but this did not work with the 2.6.26.5. The problem has been confirmed on at least 2 machines. I have tried various boot options (pci=nomsi, acpi=off and any other relevant code I could find) but nothing seems to work. The odd thing is the sata dvdrom was ...
Sep 29, 4:01 pm 2008
Dylan Taft
Re: questions about x86: mtrr cleanup for converting con ...
I think a workaround in the kernel is absolutely necessary. A lot of newer motherboards have this issue, where a whole section of memory will be marked as write-back, and write-combining can't be embedded/nested. As far as I'm aware, changing MTRRs won't make a system unstable, especially if done so early on, when the kernel is starting up. All it does is change the behavior on how the CPU will cache write requests to memory. All system memory should be marked as write-back, how many MTRRs ...
Sep 29, 3:46 pm 2008
Jiri Kosina
Re: Linux 2.6.27-rc8
If 2.6.27 is released with e1000e driver corrupting EEPROM contents on many systems out there, rendering the cards unusable for most of the i-am-not-a-hacker users (and remember, even Dave Airlie bricked his laptop completely to death, when trying to restore eeprom contents), well, I personally find that very scary. Intel is working with us on tracking down and resolving the issue, but this is not going as well as one would like to see (one attempt, one card with completely hosed EEPROM ...
Sep 29, 4:33 pm 2008
Linus Torvalds
Linux 2.6.27-rc8
So yet another week, another -rc. This one should be the last one: we're certainly not running out of regressions, but at the same time, at some point I just have to pick some point, and on the whole the regressions don't look _too_ scary. And -rc8 obviously does fix more of them. Most of the changes since -rc7 are pretty small, and there aren't even a whole lot of them. The shortlog (appended) is just a couple of pages, and the diffstat is even smaller, but since the dirstat is a dense ...
Sep 29, 3:39 pm 2008
david
Re: Linux 2.6.27-rc8
unless there is news that I missed, the E1000 bricking bug is still out there. that is a particularly nasty one. --
Sep 29, 4:09 pm 2008
Paul E. McKenney
Re: [GIT pull] timer fixes for .27
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --
Sep 29, 3:44 pm 2008
Thomas Gleixner
[GIT pull] timer fixes for .27
Linus, Please pull the latest timers-fixes-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-fixes-for-linus The patches fix hard to trigger bugs in the CPU offline code of hrtimers which were noticed by Paul McKenney recently. In the worst case they can leave migrated hrtimers in a stale state. Thanks, tglx ------------------> Thomas Gleixner (4): hrtimer: migrate pending list on cpu offline hrtimer: fix migration ...
Sep 29, 3:15 pm 2008
Chuck Ebbert
[patch 1/2] revert: x86: move prefill_possible_map calli ...
From: Chuck Ebbert <cebbert@redhat.com> revert: x86: move prefill_possible_map calling early, fix revert 4a7017370aa0a94a00ae5b5705e9169cdcae5fb8 This is the wrong fix: prefill_possible_map() needs to be available even when CONFIG_HOTPLUG_CPU is not set. A followon patch will do that. Signed-off-by: Chuck Ebbert <cebbert@redhat.com> --- --- b/include/asm-x86/smp.h +++ a/include/asm-x86/smp.h @@ -116,6 +116,8 @@ extern int __cpu_disable(void); extern void __cpu_die(unsigned int ...
Sep 29, 3:27 pm 2008
Chuck Ebbert
[patch 2/2] x86: move prefill_possible_map calling early ...
From: Chuck Ebbert <cebbert@redhat.com> x86: move prefill_possible_map calling early, fix, V2 fix: Fix this by making prefill_possible_map() available even when CONFIG_HOTPLUG_CPU is not set. The function is needed so that the number of possible CPUs can be determined. Tested on uniprocessor machine with CPU hotplug disabled. From boot log: Before: NR_CPUS: 512, nr_cpu_ids: 512, nr_node_ids 1 After: NR_CPUS: 512, nr_cpu_ids: 1, nr_node_ids 1 Signed-off-by: Chuck Ebbert ...
Sep 29, 3:29 pm 2008
Jeremy Fitzhardinge Sep 29, 4:52 pm 2008
Chuck Ebbert
[patch] xen: make CONFIG_XEN_SAVE_RESTORE depend on CONFIG_XEN
From: Chuck Ebbert <cebbert@redhat.com> xen: make CONFIG_XEN_SAVE_RESTORE depend on CONFIG_XEN Xen options need to depend on XEN. Also, add newline at end of file. Without this patch you need to disable CONFIG_PM in order to disable CPU hotplugging. Signed-off-by: Chuck Ebbert <cebbert@redhat.com> --- Index: linux-2.6.26.noarch/arch/x86/xen/Kconfig =================================================================== --- linux-2.6.26.noarch.orig/arch/x86/xen/Kconfig +++ ...
Sep 29, 3:24 pm 2008
Jon Smirl
Re: [RFC PATCH 0/4] Implementation of IR support using t ...
On Mon, Sep 29, 2008 at 6:18 PM, Emmanuel Fusté I've been considering a sysfs interface for raw signals. Specialized apps that can handle raw signal could use this interface. It's not hard to add support for raw codes, maybe in the next pass. Something like a "raw" attribute. Write ints to it and they get sent, read ints from it to see what was received. -- Jon Smirl jonsmirl@gmail.com --
Sep 29, 4:02 pm 2008
Maxim Levitsky
Re: [RFC PATCH 0/4] Implementation of IR support using t ...
Just one question, Suppose I have non-standard remote, and I want to teach lirc to use it, and I have general purpose receiver, how can I do this? Best regards, --
Sep 29, 4:17 pm 2008
Emmanuel Fusté
Re: [RFC PATCH 0/4] Implementation of IR support using t ...
Yes, in kernel clean/smalls (encoding/)decoding engines abstracted by the input subsystem are a good thing. But you still need a way to send and received raw IR signal to be able to send or decode very out of spec signals like RC5 timing dependent Philips service mode codes. Or simply to decode / reverse engineer an IR protocol not already implemented Best regards, Emmanuel. --
Sep 29, 3:18 pm 2008
Rafael J. Wysocki Sep 29, 3:25 pm 2008
Karol Lewandowski
Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a ...
It doesn't help (and -rc8 doesn't help either). Thanks. --
Sep 29, 4:40 pm 2008
Karol Lewandowski
BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a mak ...
Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21 to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output fn-f7, etc.) after resume. It's regression from 2.6.25. 2.6.26 and 2.6.27-rc7 are broken, reverting that commit on 2.6.27-rc7 makes keys work again. Thanks. [Rafael added for regression tracking ;] commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a Author: Alexey Starikovskiy <astarikovskiy@suse.de> Date: Fri Jun 6 11:49:33 2008 -0400 ...
Sep 29, 3:16 pm 2008
Tyler Hicks
[PATCH] eCryptfs: Remove netlink transport
The netlink transport code has not worked for a while and the miscdev transport is a simpler solution. This patch removes the netlink code and makes the miscdev transport the only eCryptfs kernel to userspace transport. Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com> --- fs/ecryptfs/Makefile | 2 +- fs/ecryptfs/ecryptfs_kernel.h | 28 +---- fs/ecryptfs/keystore.c | 32 +++--- fs/ecryptfs/main.c | 19 ++-- fs/ecryptfs/messaging.c | 118 ...
Sep 29, 3:16 pm 2008
Russ Anderson
[PATCH 4/4] Add sysfs entries for UV
[PATCH 4/4] Add sysfs entries for UV Create /sys/firmware/sgi_uv sysfs entries for partition_id and coherence_id. Signed-off-by: Russ Anderson <rja@sgi.com> --- arch/x86/kernel/Makefile | 2 - arch/x86/kernel/uv_sysfs.c | 72 +++++++++++++++++++++++++++++++++++++++++++++ include/asm-x86/uv/bios.h | 1 3 files changed, 74 insertions(+), 1 deletion(-) Index: linux/arch/x86/kernel/Makefile =================================================================== --- ...
Sep 29, 3:03 pm 2008
Russ Anderson
[PATCH 3/4] Add UV partition call
[PATCH 3/4] Add UV partition call Add a bios call to return partitioning related info. Signed-off-by: Russ Anderson <rja@sgi.com> --- arch/x86/kernel/bios_uv.c | 44 ++++++++++++++++++++++++++++++++++----- arch/x86/kernel/genx2apic_uv_x.c | 14 +++++++----- include/asm-x86/uv/bios.h | 22 ++++++++++++++++--- 3 files changed, 66 insertions(+), 14 deletions(-) Index: ...
Sep 29, 3:03 pm 2008
Russ Anderson
[PATCH 2/4] Add UV bios call infrastructure
[PATCH 2/4] Add UV bios call infrastructure Add the UV wrapper code to call OEM runtime service. Signed-off-by: Russ Anderson <rja@sgi.com> Signed-off-by: Paul Jackson <pj@sgi.com> --- arch/x86/kernel/bios_uv.c | 73 ++++++++++++++++++++++++++++++++-------------- include/asm-x86/uv/bios.h | 62 ++++++++++++++++++--------------------- 2 files changed, 82 insertions(+), 53 deletions(-) Index: ...
Sep 29, 3:02 pm 2008
Russ Anderson
[PATCH 1/4] Add EFI OEM runtime services entry
[PATCH 1/4] Add EFI OEM runtime services entry Add oem runtime services function pointer. Signed-off-by: Russ Anderson <rja@sgi.com> Signed-off-by: Paul Jackson <pj@sgi.com> --- include/linux/efi.h | 1 + 1 file changed, 1 insertion(+) Index: linux/include/linux/efi.h =================================================================== --- linux.orig/include/linux/efi.h 2008-09-29 15:20:53.000000000 -0500 +++ linux/include/linux/efi.h 2008-09-29 15:20:59.000000000 -0500 @@ -156,6 ...
Sep 29, 3:02 pm 2008
Russ Anderson
[PATCH 0/4] x86: UV runtime bios calls
[PATCH 0/4] x86: UV runtime bios calls Purpose: Create an interface to allow calls into bios to return platform specific information. The interface adds a new EFI runtime call for OEMs. EFI provides a mechanism for defining runtime calls to firmware routines. This patchset builds on the EFI mechanism to provide access to those firmware routines. Version 3 changes: Add function (oem) to efi_runtime_services_t, replacing uv_systab. Use efi_call_virt<n>. Remove efi_call<n> ...
Sep 29, 3:02 pm 2008
Andi Kleen
Re: Faster getcpu() and sched_getcpu()
It's unnecessary to have frame pointer in the kernel functions I meant. I agree with you that disabling redzone is needed for kernel code, but without frame pointers (which are generally a bad idea for performance and should not have been added to the 64bit port ever) redzone is also not particularly expensive and it shouldn't be needed to do anything complicated (like splitting files) just for the few cycles. -Andi -- ak@linux.intel.com --
Sep 29, 3:07 pm 2008
dean gaudet
Re: Faster getcpu() and sched_getcpu()
[attempting resend in plain-text only because thunderbird lost the battle vs. vger] --
Sep 29, 2:59 pm 2008
Jesse Brandeburg
[PATCH] x86: export set_memory_ro and set_memory_rw
From: Bruce Allan <bruce.w.allan@intel.com> Export set_memory_ro() and set_memory_rw() calls for use by drivers that need to have more debug information about who might be writing to memory space. this was initially developed for use while debugging a memory corruption problem with e1000e. patch was modified with this suggestion. Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Acked-by: Ingo Molnar <mingo@elte.hu> --- ...
Sep 29, 2:39 pm 2008
Jesse Brandeburg
[PATCH] x86: export set_memory_ro and set_memory_rw
From: Bruce Allan <bruce.w.allan@intel.com> Export set_memory_ro() and set_memory_rw() calls for use by drivers that need to have more debug information about who might be writing to memory space. this was initially developed for use while debugging a memory corruption problem with e1000e. patch was modified with this suggestion. Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Acked-by: Ingo Molnar <mingo@elte.hu> --- ...
Sep 29, 2:38 pm 2008
Vincent Legoll
[PATCH] PCI probing debug message uniformization
Hello, Here is a patch to uniformize PCI probing debug messages at boot with dev_printk() intead of manual printk() for example, it goes from the mixed-style: PCI: 0000:00:1b.0 reg 10 64bit mmio: [f4280000, f4283fff] pci 0000:00:1b.0: PME# supported from D0 D3hot D3cold to uniform: pci 0000:00:1b.0: reg 10 64bit mmio: [f4280000, f4283fff] pci 0000:00:1b.0: PME# supported from D0 D3hot D3cold If people prefer the UPPERCASE "PCI:" prefix from dev_printk(), that would be matter for ...
Sep 29, 2:03 pm 2008
Andi Kleen
Re: Faster getcpu() and sched_getcpu()
Seems unnecessarily complicated. -Andi -- ak@linux.intel.com --
Sep 29, 1:50 pm 2008
Yinghai Lu
[PATCH] x86: mtrr_cleanup safe to get more spare regs now
don't need to break earlier, could get more optimized setting automatically results: 1. hpa reg00: base=0xc0000000 (3072MB), size=1024MB: uncachable, count=1 reg01: base=0x13c000000 (5056MB), size= 64MB: uncachable, count=1 reg02: base=0x00000000 ( 0MB), size=4096MB: write-back, count=1 reg03: base=0x100000000 (4096MB), size=1024MB: write-back, count=1 reg04: base=0xbf700000 (3063MB), size= 1MB: uncachable, count=1 reg05: base=0xbf800000 (3064MB), size= 8MB: uncachable, ...
Sep 29, 1:39 pm 2008
Yinghai Lu
(No subject)
don't need to break earlier, could get more optimized setting automatically results: 1. hpa reg00: base=0xc0000000 (3072MB), size=1024MB: uncachable, count=1 reg01: base=0x13c000000 (5056MB), size= 64MB: uncachable, count=1 reg02: base=0x00000000 ( 0MB), size=4096MB: write-back, count=1 reg03: base=0x100000000 (4096MB), size=1024MB: write-back, count=1 reg04: base=0xbf700000 (3063MB), size= 1MB: uncachable, count=1 reg05: base=0xbf800000 (3064MB), size= 8MB: uncachable, ...
Sep 29, 1:38 pm 2008
Jeffrey W. Baker
Put unused PCI devices in D3
My laptop computer has half a dozen unused PCI devices that could be put in the D3 power state, but they loiter in D0. The audio codec, the ethernet adapter, the unused PCI Express port, all the USB controllers, the IEEE1394 controller, the SD/MMC card controller, and the cardbus bridge all support D3(hot) power state. Currently it looks to me from browsing the code that D3 is only used in Linux when the whole machine is headed for S3, and the drivers are asked to suspend. I think the drivers ...
Sep 29, 1:11 pm 2008
Gary Hade
[PATCH] mm: show node to memory section relationship wit ...
Show node to memory section relationship with symlinks in sysfs Add /sys/devices/system/node/nodeX/memoryY symlinks for all the memory sections located on nodeX. For example: /sys/devices/system/node/node1/memory135 -> ../../memory/memory135 indicates that memory section 135 resides on node1. Successfully tested with 2.6.27-rc7 source on 2-node x86_64, 2-node ppc64, and 2-node ia64 systems. Also revises documentation to cover this change as well as ...
Sep 29, 1:05 pm 2008
Chris Mason
[RFC] Btrfs mainline plans
Hello everyone, Thanks to help from David Woodhouse and Linus, I have btrfs source repos migrated over to git. My goal is to make the sources easier for people to review, and to start some discussions around the best time to merge Btrfs. The current code has a number of problems (and this is not a complete list): * The disk format is not finalized * ENOSPC can result in BUG() * blocksize != pagesize does not work * Error handling is missing in a number of places But, the code is very ...
Sep 29, 12:44 pm 2008
Christoph Lameter
[patch 1/4] Make the per cpu reserve configurable
The per cpu reserve from which loadable modules allocate their percpu sections is currently fixed at 8000 bytes. Add a new kernel parameter percpu=<dynamically allocatable percpu bytes> The per cpu reserve area will be used in following patches by the per cpu allocator. Signed-off-by: Christoph Lameter <cl@linux-foundation.org> --- arch/ia64/include/asm/percpu.h | 1 + include/linux/percpu.h | 7 ++++++- init/main.c | 13 +++++++++++++ 3 files ...
Sep 29, 12:35 pm 2008
Christoph Lameter
[patch 3/4] cpu alloc: The allocator
The per cpu allocator allows dynamic allocation of memory on all processors simultaneously. A bitmap is used to track used areas. The allocator implements tight packing to reduce the cache footprint and increase speed since cacheline contention is typically not a concern for memory mainly used by a single cpu. Small objects will fill up gaps left by larger allocations that required alignments. The size of the cpu_alloc area can be changed via the percpu=xxx kernel parameter. Signed-off-by: ...
Sep 29, 12:35 pm 2008
Christoph Lameter
[patch 0/4] Cpu alloc V6: Replace percpu allocator in mo ...
Just do the bare mininum to establish a per cpu allocator. Later patchsets will gradually build out the functionality. The most critical issue that came up awhile back was how to configure the size of the percpu area. Here we simply use a kernel parameter and use the static size of the existing percpu allocator for modules as a default. The effect of this patchset is to make the size of percpu data for modules configurable. Its no longer fixed at 8000 bytes. Changes: V5->V6: - Fix various ...
Sep 29, 12:35 pm 2008
Christoph Lameter
[patch 2/4] percpu: Rename variables PERCPU_ENOUGH_ROOM ...
Rename PERCPU_ENOUGH_ROOM to PERCPU_AREA_SIZE since its really specifying the size of the percpu areas. Rename PERCPU_MODULE_RESERVE to PERCPU_RESERVE_SIZE in anticipation of more general use of that reserve. Signed-off-by: Christoph Lameter <cl@linux-foundation.org> --- arch/ia64/include/asm/percpu.h | 2 +- arch/powerpc/kernel/setup_64.c | 4 ++-- arch/sparc64/kernel/smp.c | 2 +- arch/x86/kernel/setup_percpu.c | 3 +-- include/linux/percpu.h | 10 ...
Sep 29, 12:35 pm 2008
Christoph Lameter
[patch 4/4] cpu alloc: Use cpu allocator instead of the ...
Remove the builtin per cpu allocator from modules.c and use cpu_alloc instead. Signed-off-by: Christoph Lameter <cl@linux-foundation.org> --- include/linux/module.h | 1 kernel/module.c | 178 ++++--------------------------------------------- 2 files changed, 17 insertions(+), 162 deletions(-) Index: linux-2.6/kernel/module.c =================================================================== --- linux-2.6.orig/kernel/module.c 2008-09-19 08:12:10.000000000 -0500 +++ ...
Sep 29, 12:35 pm 2008
Nicholas A. Bellinger
[ANNOUNCE]: ConfigFS enabled Generic Target Mode and iSC ...
Greetings all, I am happy to announce that the first ConfigFS configurable generic target engine (target_core_mod) and iSCSI Target Stack (iscsi_target_mod) are now able to use ConfigFS symlinks for the creation of Linux Storage Objects from drivers/scsi, block, or fs/ storage objects to iSCSI Target Port Endpoints. The code is available currently running on v2.6.27-rc7 and has been broken up into a number of commits ...
Sep 29, 12:21 pm 2008
Adam Jackson
[PATCH] x86: IOMMU setup failures should not be KERN_ERR
The number of BIOSes that have an option to enable the IOMMU, or fix anything about its configuration, is vanishingly small. There's no good reason to punish quiet boot for this. Signed-off-by: Adam Jackson <ajax@redhat.com> --- arch/x86/kernel/aperture_64.c | 6 +++--- include/asm-x86/gart.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c index 44e2182..9a32b37 100644 --- ...
Sep 29, 11:52 am 2008
Adam Jackson
[PATCH] Don't print an error message just because there' ...
From: Peter Jones <pjones@redhat.com> Some systems, such as EFI-based Apple systems, won't necessarily have an i8042 to initialize. We shouldn't be printing an error message in this case, since not detecting the chip is the correct behavior. Signed-off-by: Adam Jackson <ajax@redhat.com> --- drivers/input/serio/i8042.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 170f71e..4f3e632 100644 --- ...
Sep 29, 11:36 am 2008
Frederic Weisbecker
[PATCH -tip 4/4] Tracing/ftrace: adapt the boot tracer t ...
This patch adapts the boot tracer to the new type of the print_line callback. It still relays entries it doesn't support to default output functions. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> --- kernel/trace/trace_boot.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c index d5c9e2e..48186b1 100644 --- a/kernel/trace/trace_boot.c +++ b/kernel/trace/trace_boot.c @@ -45,21 +45,24 @@ ...
Sep 29, 11:31 am 2008
Adam Jackson
[PATCH] ACPI: Reduce blacklist-by-date failures to KERN_INFO
No reason to punish quiet boot for these. Signed-off-by: Adam Jackson <ajax@redhat.com> --- drivers/acpi/blacklist.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index ea92bac..00498fe 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c @@ -81,18 +81,18 @@ static int __init blacklist_by_year(void) int year = dmi_get_year(DMI_BIOS_DATE); /* Doesn't exist? Likely an old system */ if ...
Sep 29, 11:29 am 2008
Frederic Weisbecker
[PATCH V2 -tip 3/4] Tracing/ftrace: Adapt mmiotrace to t ...
Adapt mmiotrace to the new print_line type. By default, it ignores (and consumes) types it doesn't support. Acked-by: Pekka Paalanen <pq@iki.fi> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> --- kernel/trace/trace_mmiotrace.c | 25 ++++++++++++------------- 1 files changed, 12 insertions(+), 13 deletions(-) diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c index a108c32..be0a6b0 100644 --- a/kernel/trace/trace_mmiotrace.c +++ ...
Sep 29, 11:27 am 2008
Pekka Paalanen
Re: [PATCH V2 -tip 3/4] Tracing/ftrace: Adapt mmiotrace ...
On Mon, 29 Sep 2008 20:27:42 +0200 Ack! All four patches looking good. -- Pekka Paalanen http://www.iki.fi/pq/ --
Sep 29, 12:19 pm 2008
Frederic Weisbecker
[PATCH -tip 2/4] Tracing/ftrace: Fix pipe breaking
From: Pekka Paalanen <pq@iki.fi> This patch fixes a bug which break the pipe when the seq is empty. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> --- kernel/trace/trace.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 61f33da..ed10a68 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -2610,7 +2610,6 @@ tracing_read_pipe(struct file *filp, char __user *ubuf, sret = ...
Sep 29, 11:23 am 2008
Hiroshi Shimamoto
[PATCH -tip] sched: fix using uninilialzed rq in task_de ...
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> compiler warnings; CC kernel/sched.o kernel/sched.c: In function 'task_delta_exec': kernel/sched.c:4055: warning: unused variable 'flags' kernel/sched.c:4054: warning: 'rq' is used uninitialized in this function calling task_delta_exec() may cause unexpected pointer access. Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> --- kernel/sched.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git ...
Sep 29, 11:23 am 2008
Brandeburg, Jesse
e1000e NVM corruption issue status (updated 29-Sept-2008)
Here is my latest information regarding this bug. Problem: some users report that with many of the latest beta distros, during a reboot when e1000e loads it says "NVM checksum is not valid" and the driver fails to load. updated hardware affected list: laptops and desktops with 82566 or 82567 based LAN parts, which are machines with the ICH8, ICH9, ICH10R chipsets and a variety of processors. The machines I know of that have reported the issue include Lenovo X300 HP 2510p Intel ...
Sep 29, 11:22 am 2008
Pekka Paalanen
A style question: repeated return value check
On Mon, 29 Sep 2008 20:18:34 +0200 Off-thread style question: Would it be better or worse to write the above as ret = trace_seq_printf(s, "%16s-%-5d ", comm, field->pid); ret = ret && trace_seq_printf(s, "[%03d] ", iter->cpu); ret = ret && trace_seq_printf(s, "%5lu.%06lu: ", secs, usec_rem); if (!ret) return TRACE_TYPE_PARTIAL_LINE; which would do exactly the same, but is more compact. Good or bad style? Well, it could be rolled into a single trace_seq_printf() call, too. -- ...
Sep 29, 12:14 pm 2008
Frederic Weisbecker
[PATCH V2 -tip 1/4] Tracing/ftrace: Change the type of t ...
We need a kind of disambiguation when a print_line callback returns 0. _There is not enough space to print all the entry. Please flush the seq and retry. _I can't handle this type of entry This patch changes the type of this callback for better information. Also some changes have been made in this V2. _ Only relay to default functions after the print_line callback fails. _ This patch doesn't fix the issue with the broken pipe (see patch 2/4 for that) Some things are still in ...
Sep 29, 11:18 am 2008
Adam Jackson
[PATCH] PIIX3: Warn softer about enabling passive release.
All the other quirks are dev_info() not dev_err(), this one isn't special. This makes 'quiet' boot in qemu really quiet. Signed-off-by: Adam Jackson <ajax@redhat.com> --- drivers/pci/quirks.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 9236e7f..a299724 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -47,7 +47,7 @@ static void quirk_passive_release(struct pci_dev *dev) while ((d = ...
Sep 29, 11:10 am 2008
Marin Mitov
Re: [PATCH] pci: introduce users of ioremap_pcibar()
Hi all, What about: pci_iomap_bar(pdev, bar) that uses pci_iomap (with the patch of Grant, http://lkml.org/lkml/2008/9/29/172) and simplifies the arguments of pci_iomap() and makes all the checks of the proposed by Arjan for ioremap_pcibar()? Best of both worlds? ;-) I like the simplification proposed by Arjan. Regards. Marin Mitov P.S. I am not on the list. --
Sep 29, 11:08 am 2008
H. Peter Anvin
Re: [PATCH] x86: do not allow to optimize flag_is_change ...
I suspect we should also out-of-line this function. It's actually relatively sizable and certainly there is no point in inlining it. -hpa --
Sep 29, 11:17 am 2008
Krzysztof Helt Sep 29, 11:06 am 2008
Mike Travis
[PATCH 16/31] cpumask: clean apic files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/apic.c | 10 - arch/x86/kernel/genapic_flat_64.c | 38 +++---- arch/x86/kernel/genx2apic_cluster.c | 16 +-- arch/x86/kernel/genx2apic_phys.c | 16 +-- arch/x86/kernel/genx2apic_uv_x.c | 18 +-- arch/x86/kernel/io_apic.c | 157 +++++++++++++++---------------- arch/x86/kernel/ipi.c | 6 - include/asm-x86/bigsmp/apic.h | 2 ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 18/31] cpumask: clean sched files
Signed-of-by: Mike Travis <travis@sgi.com> --- include/linux/sched.h | 18 +- kernel/sched.c | 450 +++++++++++++++++++++++--------------------------- kernel/sched_cpupri.c | 6 kernel/sched_cpupri.h | 8 kernel/sched_fair.c | 2 kernel/sched_rt.c | 50 ++--- 6 files changed, 252 insertions(+), 282 deletions(-) --- struct-cpumasks.orig/include/linux/sched.h +++ struct-cpumasks/include/linux/sched.h @@ -248,7 +248,7 @@ extern void init_idle_bootup_task(struct ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 23/31] cpumask: clean pci files
Signed-of-by: Mike Travis <travis@sgi.com> --- drivers/pci/pci-driver.c | 7 ++++--- drivers/pci/pci-sysfs.c | 8 ++++---- drivers/pci/probe.c | 4 ++-- include/asm-x86/pci.h | 2 +- 4 files changed, 11 insertions(+), 10 deletions(-) --- struct-cpumasks.orig/drivers/pci/pci-driver.c +++ struct-cpumasks/drivers/pci/pci-driver.c @@ -180,11 +180,12 @@ static int pci_call_probe(struct pci_dri allocates its local memory on the right node without any need to change ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 24/31] cpumask: clean cpu files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/cpu/common.c | 2 arch/x86/kernel/cpu/intel_cacheinfo.c | 16 +++---- arch/x86/kernel/cpu/mcheck/mce_64.c | 4 - arch/x86/kernel/cpu/mcheck/mce_amd_64.c | 44 +++++++++++---------- arch/x86/kernel/setup_percpu.c | 8 +-- drivers/base/cpu.c | 6 +- include/linux/cpuset.h | 12 ++--- include/linux/percpu.h | 7 +-- kernel/cpu.c ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 25/31] cpumask: clean rcu files
Signed-of-by: Mike Travis <travis@sgi.com> --- include/linux/rcuclassic.h | 2 +- kernel/rcuclassic.c | 2 +- kernel/rcupreempt.c | 2 +- kernel/rcutorture.c | 12 ++++++------ 4 files changed, 9 insertions(+), 9 deletions(-) --- struct-cpumasks.orig/include/linux/rcuclassic.h +++ struct-cpumasks/include/linux/rcuclassic.h @@ -53,7 +53,7 @@ struct rcu_ctrlblk { int signaled; spinlock_t lock ____cacheline_internodealigned_in_smp; - cpumask_t cpumask; ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 31/31] cpumask: clean misc files
Signed-of-by: Mike Travis <travis@sgi.com> --- drivers/base/node.c | 6 +++--- drivers/base/topology.c | 20 +++++++++++--------- drivers/firmware/dcdbas.c | 6 +++--- drivers/net/sfc/efx.c | 2 +- drivers/oprofile/buffer_sync.c | 2 +- include/asm-x86/paravirt.h | 6 +++--- include/asm-x86/processor.h | 2 +- include/asm-x86/topology.h | 14 +++++++------- include/asm-x86/uv/uv_bau.h | 2 +- include/linux/interrupt.h ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 30/31] cpumask: clean kernel files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/apm_32.c | 24 ++++++++++++++---------- arch/x86/kernel/microcode_core.c | 6 +++--- arch/x86/kernel/nmi.c | 4 ++-- arch/x86/kernel/process.c | 2 +- kernel/compat.c | 24 ++++++++++++------------ kernel/fork.c | 2 +- kernel/kthread.c | 2 +- kernel/profile.c | 10 +++++----- kernel/stop_machine.c | 6 ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 26/31] cpumask: clean tlb files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/tlb_32.c | 24 ++++++++++++------------ arch/x86/kernel/tlb_64.c | 23 ++++++++++++----------- arch/x86/kernel/tlb_uv.c | 12 ++++++------ include/asm-x86/tlbflush.h | 6 +++--- 4 files changed, 33 insertions(+), 32 deletions(-) --- struct-cpumasks.orig/arch/x86/kernel/tlb_32.c +++ struct-cpumasks/arch/x86/kernel/tlb_32.c @@ -20,7 +20,7 @@ DEFINE_PER_CPU(struct tlb_state, cpu_tlb * Optimizations Manfred Spraul ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 29/31] cpumask: clean trace files
Signed-of-by: Mike Travis <travis@sgi.com> --- kernel/trace/trace.c | 14 +++++++------- kernel/trace/trace_sysprof.c | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) --- struct-cpumasks.orig/kernel/trace/trace.c +++ struct-cpumasks/kernel/trace/trace.c @@ -40,7 +40,7 @@ unsigned long __read_mostly tracing_max_ unsigned long __read_mostly tracing_thresh; static unsigned long __read_mostly tracing_nr_buffers; -static cpumask_t ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 28/31] cpumask: clean smp files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/smp.c | 6 +++--- arch/x86/kernel/smpboot.c | 20 ++++++++++++-------- include/asm-x86/smp.h | 6 +++--- include/linux/smp.h | 8 ++++---- kernel/smp.c | 15 ++++++++------- 5 files changed, 30 insertions(+), 25 deletions(-) --- struct-cpumasks.orig/arch/x86/kernel/smp.c +++ struct-cpumasks/arch/x86/kernel/smp.c @@ -118,15 +118,15 @@ static void native_smp_send_reschedule(i ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 27/31] cpumask: clean time files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/hpet.c | 4 ++-- arch/x86/kernel/i8253.c | 2 +- arch/x86/kernel/time_64.c | 2 +- include/linux/clockchips.h | 4 ++-- include/linux/tick.h | 4 ++-- kernel/time/clocksource.c | 2 +- kernel/time/tick-broadcast.c | 26 +++++++++++++------------- kernel/time/tick-common.c | 6 +++--- 8 files changed, 25 insertions(+), 25 deletions(-) --- ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 22/31] cpumask: clean irq files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/irq_64.c | 6 +++--- include/asm-x86/irq.h | 2 +- include/linux/irq.h | 10 +++++----- kernel/irq/manage.c | 12 ++++++------ kernel/irq/migration.c | 6 +++--- kernel/irq/proc.c | 13 +++++++------ 6 files changed, 25 insertions(+), 24 deletions(-) --- struct-cpumasks.orig/arch/x86/kernel/irq_64.c +++ struct-cpumasks/arch/x86/kernel/irq_64.c @@ -242,14 +242,14 @@ asmlinkage unsigned int ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 21/31] cpumask: clean acpi files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/acpi/boot.c | 4 ++-- arch/x86/kernel/acpi/cstate.c | 2 +- drivers/acpi/processor_perflib.c | 6 +++--- drivers/acpi/processor_throttling.c | 12 ++++++------ include/acpi/processor.h | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) --- struct-cpumasks.orig/arch/x86/kernel/acpi/boot.c +++ struct-cpumasks/arch/x86/kernel/acpi/boot.c @@ -520,7 +520,7 @@ static int __cpuinit ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 20/31] cpumask: clean mm files
Signed-of-by: Mike Travis <travis@sgi.com> --- include/linux/mm_types.h | 2 +- mm/allocpercpu.c | 18 +++++++++--------- mm/page_alloc.c | 6 +++--- mm/pdflush.c | 6 +++--- mm/quicklist.c | 4 ++-- mm/slab.c | 4 ++-- mm/slub.c | 4 ++-- mm/vmscan.c | 8 ++++---- mm/vmstat.c | 6 +++--- 9 files changed, 29 insertions(+), 29 deletions(-) --- ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 17/31] cpumask: clean cpufreq files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 46 +++++++++++----------- arch/x86/kernel/cpu/cpufreq/p4-clockmod.c | 2 arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 43 ++++++++++---------- arch/x86/kernel/cpu/cpufreq/powernow-k8.h | 2 arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c | 48 +++++++++++------------ arch/x86/kernel/cpu/cpufreq/speedstep-ich.c | 2 drivers/cpufreq/cpufreq.c ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 19/31] cpumask: clean xen files
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/xen/enlighten.c | 9 +++++---- arch/x86/xen/smp.c | 12 ++++++------ arch/x86/xen/suspend.c | 2 +- arch/x86/xen/time.c | 2 +- arch/x86/xen/xen-ops.h | 2 +- drivers/xen/events.c | 6 +++--- 6 files changed, 17 insertions(+), 16 deletions(-) --- struct-cpumasks.orig/arch/x86/xen/enlighten.c +++ struct-cpumasks/arch/x86/xen/enlighten.c @@ -626,16 +626,17 @@ static void xen_flush_tlb_single(unsigne ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 15/31] cpumask: remove node_to_cpumask_ptr
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/setup_percpu.c | 65 +++++++++++++---------------------------- drivers/base/node.c | 2 - drivers/pci/pci-driver.c | 7 +--- include/asm-generic/topology.h | 13 -------- include/asm-x86/topology.h | 56 ++++++++++------------------------- include/linux/topology.h | 3 - kernel/sched.c | 10 +++--- mm/page_alloc.c | 2 - mm/quicklist.c | ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 14/31] cpumask: change first/next_cpu to cpus_fir ...
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/acpi/boot.c | 2 - arch/x86/kernel/apic.c | 2 - arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 4 +-- arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 6 ++--- arch/x86/kernel/cpu/intel_cacheinfo.c | 4 +-- arch/x86/kernel/cpu/mcheck/mce_amd_64.c | 2 - arch/x86/kernel/cpu/proc.c | 4 +-- arch/x86/kernel/genapic_flat_64.c | 4 +-- ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 13/31] cpumask: modify for_each_cpu_mask
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 6 +-- arch/x86/kernel/cpu/cpufreq/p4-clockmod.c | 6 +-- arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 8 ++-- arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c | 10 ++--- arch/x86/kernel/cpu/cpufreq/speedstep-ich.c | 4 +- arch/x86/kernel/cpu/intel_cacheinfo.c | 2 - arch/x86/kernel/cpu/mcheck/mce_amd_64.c | 4 +- ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 11/31] cpumask: remove set_cpus_allowed_ptr
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/acpi/cstate.c | 4 ++-- arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 12 ++++++------ arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 20 ++++++++++---------- arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c | 12 ++++++------ arch/x86/kernel/cpu/cpufreq/speedstep-ich.c | 12 ++++++------ arch/x86/kernel/cpu/intel_cacheinfo.c | 4 ++-- arch/x86/kernel/cpu/mcheck/mce_amd_64.c ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 12/31] cpumask: remove CPU_MASK_ALL_PTR
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/cpu/mcheck/mce_amd_64.c | 4 ++-- include/asm-generic/topology.h | 2 +- init/main.c | 2 +- kernel/kmod.c | 2 +- kernel/kthread.c | 4 ++-- kernel/sched.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) --- struct-cpumasks.orig/arch/x86/kernel/cpu/mcheck/mce_amd_64.c +++ ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 09/31] cpumask: get rid of _nr functions
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 6 +-- arch/x86/kernel/cpu/cpufreq/p4-clockmod.c | 6 +-- arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 8 ++--- arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c | 10 +++--- arch/x86/kernel/cpu/cpufreq/speedstep-ich.c | 4 +- arch/x86/kernel/cpu/intel_cacheinfo.c | 2 - arch/x86/kernel/cpu/mcheck/mce_amd_64.c | 4 +- ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 10/31] cpumask: clean cpumask_of_cpu refs
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/acpi/cstate.c | 2 +- arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 6 +++--- arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 8 ++++---- arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c | 4 ++-- arch/x86/kernel/cpu/cpufreq/speedstep-ich.c | 2 +- arch/x86/kernel/cpu/intel_cacheinfo.c | 2 +- arch/x86/kernel/microcode_core.c | 6 +++--- ...
Sep 29, 11:03 am 2008
Mike Travis
[PATCH 08/31] cpumask: Change cpumask maps
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/smpboot.c | 20 ++++++++++---------- include/asm-x86/smp.h | 20 ++++++++++---------- 2 files changed, 20 insertions(+), 20 deletions(-) --- struct-cpumasks.orig/arch/x86/kernel/smpboot.c +++ struct-cpumasks/arch/x86/kernel/smpboot.c @@ -102,20 +102,20 @@ EXPORT_SYMBOL(smp_num_siblings); DEFINE_PER_CPU(u16, cpu_llc_id) = BAD_APICID; /* bitmap of online cpus */ -cpumask_t cpu_online_map __read_mostly; +cpumask_map_t ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 02/31] cpumask: modify send_IPI_mask interface to ...
* Change genapic interfaces to accept cpumask_t pointers and to not return cpumask function values. * Modify external callers to use these cpumask_t pointers in their calls. * Create new send_IPI_mask_allbutself which is the same as the send_IPI_mask functions but removes smp_processor_id() from list. This removes another common need for a temporary cpumask_t variable. * Rewrite functions that used a temp cpumask_t variable for: cpumask_t allbutme = ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 07/31] cpumask: changes to compile init/main.c
Signed-of-by: Mike Travis <travis@sgi.com> --- include/linux/sched.h | 6 +++--- include/linux/seq_file.h | 4 ++-- init/main.c | 11 ++++++----- kernel/cpu.c | 5 +++++ 4 files changed, 16 insertions(+), 10 deletions(-) --- struct-cpumasks.orig/include/linux/sched.h +++ struct-cpumasks/include/linux/sched.h @@ -1583,10 +1583,10 @@ extern cputime_t task_gtime(struct task_ #ifdef CONFIG_SMP extern int set_cpus_allowed_ptr(struct task_struct ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 04/31] cpumask: move cpu_alloc to separate file
Signed-of-by: Mike Travis <travis@sgi.com> --- include/linux/cpumask.h | 40 ------------- include/linux/cpumask_alloc.h | 127 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 127 insertions(+), 40 deletions(-) --- struct-cpumasks.orig/include/linux/cpumask.h +++ struct-cpumasks/include/linux/cpumask.h @@ -67,37 +67,6 @@ * CPU_MASK_NONE Initializer - no bits set * unsigned long *cpus_addr(mask) Array of unsigned long's in mask * - * CPUMASK_ALLOC kmalloc's a ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 01/31] cpumask: Documentation
Signed-of-by: Mike Travis <travis@sgi.com> --- cpumask.txt | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) --- /dev/null +++ struct-cpumasks/cpumask.txt @@ -0,0 +1,73 @@ + + CPUMASKS + -------- + + [PRELIMINARY] + +Introduction + +Cpumask variables are used to represent (with a single bit) all the +CPU's in a system. With the prolific increase in the number of CPU's +in a single system image (SSI), managing this large ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 03/31] cpumask: remove min from first_cpu/next_cpu
Seems like this has been here forever, but I can't see why: find_first_bit and find_next_bit both return >= NR_CPUS on failure. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Mike Travis <travis@sgi.com> --- lib/cpumask.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- masklongs.orig/lib/cpumask.c +++ masklongs/lib/cpumask.c @@ -5,21 +5,20 @@ int __first_cpu(const cpumask_t *srcp) { - return min_t(int, NR_CPUS, find_first_bit(srcp->bits, ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 06/31] cpumask: new lib/cpumask.c
Signed-of-by: Mike Travis <travis@sgi.com> --- lib/cpumask.c | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) --- struct-cpumasks.orig/lib/cpumask.c +++ struct-cpumasks/lib/cpumask.c @@ -3,34 +3,40 @@ #include <linux/cpumask.h> #include <linux/module.h> -int __first_cpu(const cpumask_t *srcp) +int cpus_first(const_cpumask_t srcp) { - return find_first_bit(srcp->bits, NR_CPUS); + return find_first_bit(srcp->bits, nr_cpu_ids); ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 05/31] cpumask: Provide new cpumask API
Provide new cpumask interface API. The relevant change is basically cpumask_t becomes an opaque object. I believe this results in the minimum amount of editing while still allowing the inline cpumask functions, and the ability to declare static cpumask objects. /* raw declaration */ struct __cpumask_data_s { DECLARE_BITMAP(bits, NR_CPUS); }; /* cpumask_map_t used for declaring static cpumask maps */ typedef struct __cpumask_data_s cpumask_map_t[1]; /* cpumask_t used ...
Sep 29, 11:02 am 2008
Mike Travis
[PATCH 00/31] cpumask: Provide new cpumask API
Here's one(*) proposal for a new cpumask interface API in a patch that's compilable. Obviously with a change of this magnitude, a large number of files are affected. I tried to group them into functional changes, but there are a lot of "clean up" types of patches, so these are grouped in the second half by sections. Hopefully this minimizes the interdependencies between patches. [* - Rusty has an alternative approach that he'll be submitting shortly.] The patches in this patchset ...
Sep 29, 11:02 am 2008
David P. Quigley
[PATCH 13/14] NFS: Extend NFS xattr handlers to accept t ...
The existing NFSv4 xattr handlers do not accept xattr calls to the security namespace. This patch extends these handlers to accept xattrs from the security namespace in addition to the default NFSv4 ACL namespace. Signed-off-by: Matthew N. Dodd <Matthew.Dodd@sparta.com> Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov> --- fs/nfs/nfs4proc.c | 52 ++++++++++++++++++++++++++++++++++++++++---------- security/security.c | 1 + 2 files changed, 42 insertions(+), 11 ...
Sep 29, 10:06 am 2008
David P. Quigley
[PATCH 05/14] SELinux: Add new labeling type native labels
There currently doesn't exist a labeling type that is adequate for use with labeled NFS. Since NFS doesn't really support xattrs we can't use the use xattr labeling behavior. For this we developed a new labeling type. The native labeling type is used solely by NFS to ensure NFS inodes are labeled at runtime by the NFS code instead of relying on the SELinux security server on the client end. Signed-off-by: Matthew N. Dodd <Matthew.Dodd@sparta.com> Signed-off-by: David P. Quigley ...
Sep 29, 10:06 am 2008
David P. Quigley
[PATCH 11/14] NFS/RPC: Add the auth_seclabel security fl ...
This patch adds a new RPC flavor that allows the NFSv4 client to pass the process label of the calling process on the client to the server to make an access control decision. This is accomplished by taking the credential from the wire and replacing the acting credential on the server for the NFSD process with that new context. Signed-off-by: Matthew N. Dodd <Matthew.Dodd@sparta.com> Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov> --- fs/nfs/nfs4proc.c | 6 +- ...
Sep 29, 10:06 am 2008
David P. Quigley
[PATCH 01/14] VFS: Factor out part of vfs_setxattr so it ...
This factors out the part of the vfs_setxattr function that performs the setting of the xattr and its notification. This is needed so the SELinux implementation of inode_setsecctx can handle the setting of it's xattr while maintaining the proper separation of layers. Signed-off-by: Matthew N. Dodd <Matthew.Dodd@sparta.com> Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov> --- fs/xattr.c | 55 +++++++++++++++++++++++++++++++++++++----------- include/linux/xattr.h | 1 + ...
Sep 29, 10:06 am 2008
David P. Quigley
[PATCH 10/14] NFSv4: Introduce new label structure
In order to mimic the way that NFSv4 ACLs are implemented we have created a structure to be used to pass label data up and down the call chain. This patch adds the new structure and new members to the required NFSv4 call structures. Signed-off-by: Matthew N. Dodd <Matthew.Dodd@sparta.com> Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov> --- include/linux/nfs4.h | 6 ++++++ include/linux/nfs_xdr.h | 3 +++ include/linux/nfsd/xdr4.h | 3 +++ 3 files changed, 12 ...
Sep 29, 10:06 am 2008
David P. Quigley
[PATCH 08/14] NFS: Add security_label text mount option ...
This patch adds two new text options to to the NFS mount options to specify security labeling. It also sends certain LSM related mount options into the module for handling. Signed-off-by: Matthew N. Dodd <Matthew.Dodd@sparta.com> Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov> --- fs/nfs/super.c | 9 +++++++++ include/linux/nfs4_mount.h | 6 +++++- security/selinux/hooks.c | 2 +- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/fs/nfs/super.c ...
Sep 29, 10:06 am 2008
David P. Quigley
[PATCH 06/14] KConfig: Add KConfig entries for Labeled NFS
This patch adds two entries into the fs/KConfig file. The first entry NFS_V4_SECURITY_LABEL enables security label support for the NFSv4 client while the second entry NFSD_V4_SECURITY_LABEL enables security labeling support on the server side. Signed-off-by: Matthew N. Dodd <Matthew.Dodd@sparta.com> Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov> --- fs/Kconfig | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index ...
Sep 29, 10:06 am 2008
David P. Quigley
[RFC v3] Security Label Support for NFSv4
I sent this patchset out just before LPC so I think it might have been overlooked by some people. I am resending the patchset with some corrections based on comments by Casey and Steve in hopes that it gets more attention this time. It has been six months since the last time we submitted a patch set to the mailing list for review. In this time we have fixed almost all of the issues that people have had with the last patch set and have added a new feature to allow for process labels to be ...
Sep 29, 10:06 am 2008
Krzysztof Helt
[PATCH] x86: enable CPUID on Cyrix cpus with CPUID disabled
From: Krzysztof Helt <krzysztof.h1@wp.pl> The macros setCx86_old() and getCx86_old() do not work as a comment says in the processor-cyrix.h. Use working inline functions instead to enable the CPUID instriction on Cyrix cpus. Tested on IBM 6x86MX cpu with disabled the CPUID instruction. Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl> --- This patch is against the linux-next tree (20080819) as it contains the following patch: x86, cyrix: debug Signed-off-by: Ingo Molnar ...
Sep 29, 10:24 am 2008
Yinghai Lu Sep 29, 10:56 am 2008
Gerald Schaefer
Re: setup_per_zone_pages_min(): zone->lock vs. zone->lru_lock
I just noticed that the spin_lock in that function is much older than the call to setup_zone_migrate_reserve(), which then calls move_freepages(). So it seems that the zone->lru_lock there does (did?) have another purpose, maybe protecting zone->present_pages/pages_min/etc. Looks like the need for a zone->lock (if any) was added later, but I'm not sure if makes sense to take both locks together, or if the lru_lock is still needed at all. Thanks, Gerald --
Sep 29, 2:20 pm 2008
Andy Whitcroft
Re: setup_per_zone_pages_min(): zone->lock vs. zone->lru_lock
The allocator protects it freelists using zone->lock (as we can see in rmqueue_bulk), so anything which manipulates those should also be using that lock. move_freepages() is scanning the cmap and picking up free pages directly off the free lists, it is expecting those lists to be stable; it would appear to need zone->lock. It does look like setup_per_zone_pages_min() is holding the wrong thing at first look. -apw --
Sep 29, 10:36 am 2008
Gerald Schaefer
setup_per_zone_pages_min(): zone->lock vs. zone->lru_lock
Hi, is zone->lru_lock really the right lock to take in setup_per_zone_pages_min()? All other functions in mm/page_alloc.c take zone->lock instead, for working with page->lru free-list or PageBuddy(). setup_per_zone_pages_min() eventually calls move_freepages(), which is also manipulating the page->lru free-list and checking for PageBuddy(). Both should be protected by zone->lock instead of zone->lru_lock, if I understood that right, or else there could be a race with the other functions ...
Sep 29, 10:10 am 2008
Maxim Levitsky
Re: [RFC PATCH 0/4] Implementation of IR support using t ...
Hi, One thing worries me, there are bazillion of different IR protocols, but in-kernel decode support will mean that only handful of known protocols will work. Suppose I take an old remote which has some unknown protocol. I want to be able to teach the system to listen to it. But how this can be done if protocols are hard coded? I think that it would be much better to pass raw ir codes to userspace, and make it deal with bazillion protocols, and you can always make it auto learn too, and ...
Sep 29, 1:14 pm 2008
Jon Smirl
[RFC PATCH 2/4] Example of PowerPC device tree support f ...
--- arch/powerpc/boot/dts/dspeak01.dts | 19 ++++++++----------- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/boot/dts/dspeak01.dts b/arch/powerpc/boot/dts/dspeak01.dts index 1d10f0a..cbb22a1 100644 --- a/arch/powerpc/boot/dts/dspeak01.dts +++ b/arch/powerpc/boot/dts/dspeak01.dts @@ -131,16 +131,6 @@ #gpio-cells = <2>; }; - gpt7: timer@670 { /* General Purpose Timer in GPIO mode */ - compatible = ...
Sep 29, 9:17 am 2008
Jon Smirl
[RFC PATCH 0/4] Implementation of IR support using the i ...
Second pass at implementing evdev support for IR. The goal of in-kernel IR is to integrate IR events into the evdev input event queue and maintain ordering of events from all input devices. Note that user space IR device drivers can use the existing support in evdev to inject events into the input queue. Send and receive are implemented. Received IR messages are decoded and sent to user space as input messages. Send is done via an IOCTL on the input device. Two drivers are supplied. mceusb2 ...
Sep 29, 9:17 am 2008
Jon Smirl
Re: [RFC PATCH 0/4] Implementation of IR support using t ...
There's not a bazillion different protocols. For example thirty different vendors may use the NEC encoding. They will each use a unique device number and their own commands. While each of the thirty vendors may assign different device/command codes they are all still using the NEC encoding. These remotes won't trigger the other devices because the device fields won't match. This code only converts raw IR timing of NEC/etc encoding into device/command. User space has to then figure out how ...
Sep 29, 1:52 pm 2008
Jon Smirl
[RFC PATCH 1/4] Changes to core input subsystem to allow ...
Received IR messages generate event in the input queue. IR messages are sent using an input IOCTL. Jon Smirl <jonsmirl@gmail.com> --- drivers/input/Kconfig | 2 drivers/input/Makefile | 3 drivers/input/evdev.c | 55 +++++ drivers/input/input.c | 4 drivers/input/ir-core.c | 523 +++++++++++++++++++++++++++++++++++++++++++++ drivers/input/ir/Kconfig | 14 + drivers/input/ir/Makefile | 5 include/linux/input.h | 70 ++++++ 8 files changed, 675 ...
Sep 29, 9:17 am 2008
Jon Smirl
[RFC PATCH 3/4] GPT driver for in-kernel IR support.
GPT is a GPIO pin that is cable able of measuring the lenght of pulses. GPTs are common on embedded systems --- drivers/input/ir/Kconfig | 6 + drivers/input/ir/Makefile | 1 drivers/input/ir/ir-gpt.c | 214 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 221 insertions(+), 0 deletions(-) create mode 100644 drivers/input/ir/ir-gpt.c diff --git a/drivers/input/ir/Kconfig b/drivers/input/ir/Kconfig index 8afd2d6..b80ab31 100644 --- a/drivers/input/ir/Kconfig +++ ...
Sep 29, 9:17 am 2008
Jon Smirl
[RFC PATCH 4/4] Microsoft mceusb2 driver for in-kernel I ...
USB device commonly found on Microsoft Media Center boxes. Hardware can send and recieve at all common IR frequencies - 36K, 38K, 40K, 56K --- drivers/input/ir/Kconfig | 6 drivers/input/ir/Makefile | 1 drivers/input/ir/ir-mceusb2.c | 729 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 736 insertions(+), 0 deletions(-) create mode 100644 drivers/input/ir/ir-mceusb2.c diff --git a/drivers/input/ir/Kconfig b/drivers/input/ir/Kconfig index b80ab31..29657d0 ...
Sep 29, 9:17 am 2008
Bjorn Helgaas
[patch 2/2] PNP: don't check disabled PCI BARs for confl ...
quirk_system_pci_resources() checks PNP motherboard resource for conflicts with PCI device BARs. When doing this, we should ignore disabled PCI BARs, because they often contain zero and look like they would conflict with legacy devices at low addresses. This patch addresses this regression from 2.6.26: http://bugzilla.kernel.org/show_bug.cgi?id=11550 Thanks to Frans Pop for reporting this issue and testing the fixes. Signed-off-by: Bjorn Helgaas ...
Sep 29, 8:57 am 2008
Bjorn Helgaas
[patch 1/2] PCI: add pci_resource_enabled()
Add pci_resource_enabled() to determine whether a PCI BAR is enabled. Sometimes firmware leaves PCI BARs unconfigured, and this interface is a way for the OS to identify that situation. This is based on section 3.5 of the PCI Firmware spec, which says: Since not all devices may be configured prior to the operating system handoff, the operating system needs to know whether a specific BAR register has been configured by firmware. The operating system makes the determination by ...
Sep 29, 8:56 am 2008
Linus Torvalds
Re: [patch 2/2] PNP: don't check disabled PCI BARs for c ...
But that is irrelevant. If we have registered them in the resource tree, then PnP must ignore them. The fact is, this is not about being enabled or disabled. This is about the PnP tree containing resources that we already parsed from the PCI stuff, and once we've seen them as PCI resources, there's not really anything valuable in the PnP information. Linus --
Sep 29, 12:13 pm 2008
Bjorn Helgaas
[patch 0/2] don't check disabled PCI BARs for conflicts ...
These two patches address this 2.6.26 regression, so they should go in before 2.6.27: http://bugzilla.kernel.org/show_bug.cgi?id=11550 This PNP/PCI resource conflict area has been a trouble spot in the past: http://thread.gmane.org/gmane.linux.acpi.devel/27312 https://bugzilla.redhat.com/show_bug.cgi?id=280641 https://bugzilla.redhat.com/show_bug.cgi?id=313491 It would be great if Matthew, Avuton, Karl, and Willem could test these patches to make sure they don't re-introduce ...
Sep 29, 8:53 am 2008
Rene Herman
Re: [patch 2/2] PNP: don't check disabled PCI BARs for c ...
I believe the possible issue is that resources that do _not_ (seem to) start at zero might also be disabled. Bjorn commented that pci_resource_start() returns a CPU address for I/O which might not be the actual I/O address on some platforms. I haven't a clue if that's actually possible "wherever PnP is relevent" as you put it but that seems to otherwise make sense. If it does though, it might for all I know also be possible to check against some ARCH_SPECIFIC_INVALID_IO_ADDRESS instead ...
Sep 29, 11:31 am 2008
Linus Torvalds
Re: [patch 2/2] PNP: don't check disabled PCI BARs for c ...
I really don't think this is the right approach. Maybe the PCI device has been turned off, but the *resource* may still be valid. Wouldn't it be much better to just check whether the resource is inserted in the resource tree or not? Quite frankly, it looks like your change will basically cause us to look over *every* system PnP resource, and for each of them, it will look at *every* PCI device, and for each PCI device it will look at *every* BAR, and for each BAR it finds it ...
Sep 29, 9:34 am 2008
Daniel Lezcano
sysfs per namespace
Hi, Greg told us last week he will retain the sysfs with namespace support until you review them. Is there any chance you have time to look at them this week ? Thanks in advance -- Daniel --
Sep 29, 8:46 am 2008
Kiyoshi Ueda
[PATCH 1/1] block: add lld busy state exporting interface
Hi Jens, I hope the previous RFC patch(*) would be no problem, since I haven't gotten any negative comment. (*) http://lkml.org/lkml/2008/9/25/262 So could you take this patch for 2.6.28 additionally? This patch adds a new interface for request stacking drivers. There should be no regression risk. This patch was created on top of the commit below of for-2.6.28. --------------------------------------------------------------------- commit ...
Sep 29, 8:35 am 2008
Andrey Borzenkov
2.6.27-rc7: unsafe lock order/inconsistent lock state af ...
--Boundary-01=_txO4IuP7tKQ441R Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline I needed to quickly check some things on multipath; I only had available notebook with USB stick so I arranged for single path multipath with faked WWID (which worked by the way). Testing what happans when last path is lost, I started IO from dm and removed USB stick. It resulted in quite a long kernel warning about unsafe lock order. I tested several ...
Sep 29, 7:55 am 2008
James Bottomley
[GIT PATCH] SCSI bug fixes for 2.6.27-rc6
Just three. One is to prevent an I/O hang when we get an error on a split request (affects USB devices with the last sector bug). One is to defer enabling qla2xxx interrupts until the device is fully initialised (fixes intermittent oops on NULL deref in the driver) and one is to make the qlogicpti fill its continuation segments correctly (fixes data corruption on various sun systems) The patch is available here: master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git The ...
Sep 29, 7:10 am 2008
Chris Snook
Re: mounted file system bottleneck
You're posting a support question to a developer list. This is frowned upon. You might get more attention here if you conduct a more scientific test and This is also frowned upon. Please send your data directly to the list, unless Offhand, I'd guess atime updates. Unless you're seeing this on a new upstream kernel, you should contact your vendor for support. Or NetApp. -- Chris --
Sep 29, 10:20 am 2008
Jason Czerak
mounted file system bottleneck
I believe I found some sort of bottleneck with mounted networked file systems over 10Gig Ethernet. I've posted a question to linux-net with zero response since Friday. http://www.uwsg.indiana.edu/hypermail/linux/net/0809.3/0013.html Could a few of you folks here take a look at this and tell me what you think is the issue? -- Jason Czerak --
Sep 29, 6:45 am 2008
Jack Steiner
[PATCH] - New UV genapic functions for x2apic
Add functions that use the infrastructure added by the x2apic code. These functions were originally stubbed out since the UV code went into the tree prior to the x2apic code. Signed-off-by: Jack Steiner <steiner@sgi.com> --- arch/x86/kernel/genx2apic_uv_x.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) Index: linux/arch/x86/kernel/genx2apic_uv_x.c =================================================================== --- ...
Sep 29, 6:45 am 2008
Stefan Bader Sep 29, 6:39 am 2008
Alejandro Riveira
[libata] Spurious error msg on ahci controller
Linux varda 2.6.27-rc7 #9 SMP PREEMPT Mon Sep 22 01:37:23 CEST 2008 x86_64 GNU/Linux I got this on dmesg although nothing is attached to that port.=20 [ 415.871744] ata1: exception Emask 0x10 SAct 0x0 SErr 0x4000000 action 0x= e frozen [ 415.873390] ata1: irq_stat 0x00000040, connection status changed [ 415.874642] ata1: SError: { DevExch } [ 415.875472] ata1: hard resetting link [ 416.599282] ata1: SATA link down (SStatus 0 SControl 300) [ 416.600523] ata1: EH ...
Sep 29, 6:05 am 2008
Soeren Sonnenburg
2.6.27-rc7, freezes with > 1 s2ram cycle
Dear all, my macbook pro1,1 works rock solid with -rc7 when it is freshly booted. However as soon as I perform a suspend to ram + wakeup cycle, it might freeze in the middle of some operation (e.g. backup or updatedb etc). This is now with all the drivers being open source (xorg-ati, ath5k) but exactly what I was observing before when only the closed source drivers were available (so this is not a regression but a long standing bug > 1 year now). Is anyone else observing this or has an ...
Sep 29, 4:29 am 2008
KAMEZAWA Hiroyuki
[PATCH 0/4] memcg: ready-to-go series (was memcg update v6)
Cut out 4 patches from memcg update v5 series. (Then, this is a part of v6) I think we got some agreement on these 4. please ack if ok. [1/4] ... account swap under lock [2/4] ... make page->mapping to be NULL before uncharge cache. [3/4] ... avoid accounting not-on-LRU pages. [4/4] ... optimize cpu stat I still have 6 patches but it's under test and needs review and discussion. Thanks, -Kame --
Sep 29, 3:19 am 2008
Daisuke Nishimura Sep 29, 4:39 am 2008
KAMEZAWA Hiroyuki
[PATCH 1/4] memcg: account swap cache under lock
While page-cache's charge/uncharge is done under page_lock(), swap-cache isn't. (anonymous page is charged when it's newly allocated.) This patch moves do_swap_page()'s charge() call under lock. I don't see any bad problem *now* but this fix will be good for future for avoiding unneccesary racy state. Changelog: (v5) -> (v6) - mark_page_accessed() is moved before lock_page(). - fixed missing unlock_page() (no changes in previous version) Signed-off-by: KAMEZAWA Hiroyuki ...
Sep 29, 3:21 am 2008
KAMEZAWA Hiroyuki
[PATCH 2/4] memcg: set page->mapping NULL before uncharge
This patch tries to make page->mapping to be NULL before mem_cgroup_uncharge_cache_page() is called. "page->mapping == NULL" is a good check for "whether the page is still radix-tree or not". This patch also adds BUG_ON() to mem_cgroup_uncharge_cache_page(); Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> mm/filemap.c | 2 +- mm/memcontrol.c | 1 + mm/migrate.c | 9 +++++++-- 3 files changed, 9 insertions(+), 3 deletions(-) Index: ...
Sep 29, 3:22 am 2008
KAMEZAWA Hiroyuki
[PATCH 4/4] memcg: optimze cpustat
Some obvious optimization to memcg. I found mem_cgroup_charge_statistics() is a little big (in object) and does unnecessary address calclation. This patch is for optimization to reduce the size of this function. And res_counter_charge() is 'likely' to success. Changlog: v5->v6 - patch series was reordered and needs some adjustment. no changes in logic. Changelog v3->v4: - merged with an other leaf patch. Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Acked-by: ...
Sep 29, 3:24 am 2008
kamezawa.hiroyu
Re: Re: [PATCH 3/4] memcg: avoid account not-on-LRU pages
Oh, thanks. I'll post fixed one, tomorrow. Thanks, --
Sep 29, 4:59 am 2008
Daisuke Nishimura Sep 29, 4:33 am 2008
Daisuke Nishimura
Re: [PATCH 4/4] memcg: optimze cpustat
Reviewed-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> I'll test with all the patches applied tonight. Thanks, --
Sep 29, 4:44 am 2008
Daisuke Nishimura
Re: [PATCH 3/4] memcg: avoid account not-on-LRU pages
checkpatch reports a warning here. I think it should be like @@ -2585,7 +2581,8 @@ static int __do_fault(struct mm_struct *mm, struct vm_area_struct *vma, /* no need to invalidate: a not-present page won't be cached */ update_mmu_cache(vma, address, entry); } else { - mem_cgroup_uncharge_page(page); + if (charged) + mem_cgroup_uncharge_page(page); if (anon) page_cache_release(page); else Thanks, --
Sep 29, 4:19 am 2008
KAMEZAWA Hiroyuki
[PATCH 3/4] memcg: avoid account not-on-LRU pages
There are not-on-LRU pages which can be mapped and they are not worth to be accounted. (becasue we can't shrink them and need dirty codes to handle specical case) We'd like to make use of usual objrmap/radix-tree's protcol and don't want to account out-of-vm's control pages. When special_mapping_fault() is called, page->mapping is tend to be NULL and it's charged as Anonymous page. insert_page() also handles some special pages from drivers. This patch is for avoiding to account special ...
Sep 29, 3:23 am 2008
Amit K. Arora
[PATCH] sched: minor optimizations in wake_affine and se ...
Hello, Please consider this patch. It makes a few minor changes to sched_fair.c. sched: Minor optimizations in wake_affine and select_task_rq_fair This patch does following: o Reduces the number of arguments to wake_affine(). o Removes unused variable "rq". o Optimizes one of the "if" conditions in wake_affine() - i.e. if "balanced" is true, we need not do rest of the calculations in the condition. o If this cpu is same as the previous cpu (on which woken up task was running ...
Sep 29, 3:02 am 2008
Chris Friesen
Re: [PATCH] sched: minor optimizations in wake_affine an ...
At what point is it cheaper to pass items as args rather than recalculating them? If reducing the number of args is desirable, what about removing the "this_cpu" and "prev_cpu" args and recalculating them in wake_affine()? Chris --
Sep 29, 9:09 am 2008
BERTRAND Joel
Fwd: 2.6.26.x hangs on amd64/smp
From: BERTRAND Joel <joel.bertrand@systella.fr> Newsgroups: linux.kernel Subject: 2.6.26.x hangs on amd64/smp Some bad news... I'm now able to reproduce this bug _without_ X. Test configuration : debian/testing up to date (minimal system with 2.6.26.5 kernel from ftp.kernel.org build with gcc-4.3). I have started my test program on a ssh connection. Console enters in DPMS mode (power off). When system crashes, screen can be switch on when I press on a key. But, there is not ...
Sep 29, 2:00 am 2008
John Kacur
[PATCH]Real-time kernel compile-fix for 32-bit when disa ...
If you start with the real-time kernel linux-2.6.26.5-rt9 and configure it to disable CONFIG_PREEMPT_RT, for example CONFIG_PREEMPT_DESKTOP=y # CONFIG_PREEMPT_RT is not set you will get the following compile error on 32-bit i386. (actually, this will happen on any platform that doesn't use CONFIG_RWSEM_GENERIC_SPINLOCK) In file included from include/linux/notifier.h:14, from include/linux/memory_hotplug.h:6, from include/linux/mmzone.h:560, ...
Sep 29, 1:10 am 2008
Paul Gortmaker
Re: [PATCH]Real-time kernel compile-fix for 32-bit when ...
I saw this too, and was about to send a fix along with some other fixes I'd stumbled across. However, looking at the other arch implementations, I think the fix is different from what you've posted -- i.e. I think it should be simply this: -static inline int rwsem_is_locked(struct compat_rw_semaphore *sem) +static inline int compat_rwsem_is_locked(struct compat_rw_semaphore *sem) I'll get the actual patch for this and two other compile fixes sent along in a few minutes. Paul. --
Sep 29, 7:17 am 2008
Mathieu Desnoyers
[PATCH] Markers : marker_synchronize_unregister()
Create marker_synchronize_unregister() which must be called before the end of exit() to make sure every probe callers have exited the non preemptible section and thus are not executing the probe code anymore. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Ingo Molnar <mingo@elte.hu> CC: Rusty Russell <rusty@rustcorp.com.au> CC: akpm@linux-foundation.org CC: "Frank Ch. Eigler" <fche@redhat.com> --- include/linux/marker.h | 7 +++++++ 1 file changed, 7 ...
Sep 29, 8:05 am 2008
Mathieu Desnoyers
Re: [PATCH] markers: fix unregister bug and reenter bug
Hi Lai, I'll have to nack this fix : One fix I already posted makes sure every marker unregister callers call synchronize_sched() _at some point_ before module unload. It thus makes sure we can do batch unregistration without doing multiple synchronize_sched calls. Also, there is no need to do the synchronize_sched with the marker mutex held. call_rcu_sched takes care of making sure the previous quiescent state is over before calling kfree. This means that when we return from the ...
Sep 29, 8:03 am 2008
Mathieu Desnoyers
[PATCH] RCU read sched
(probably already in -tip) Add rcu_read_lock_sched() and rcu_read_unlock_sched() to rcupdate.h to match the recently added write-side call_rcu_sched() and rcu_barrier_sched(). They also match the no-so-recently-added synchronize_sched(). It will help following matching use of the update/read lock primitives. Those new read lock will replace preempt_disable()/enable() used in pair with RCU-classic synchronization. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Acked-by: ...
Sep 29, 8:06 am 2008
Lai Jiangshan
[PATCH] markers: fix unregister bug and reenter bug
unregister bug: codes using makers are typically calling marker_probe_unregister() and then destroying the data that marker_probe_func needs(or unloading this module). This is bug when the corresponding marker_probe_func is still running(on other cpus), it is using the destroying/ed data. we should call synchronize_sched() after marker_update_probes(). reenter bug: marker_probe_register(), marker_probe_unregister() and marker_probe_unregister_private_data() are not reentrant ...
Sep 29, 1:00 am 2008
Mathieu Desnoyers
Re: [PATCH] Markers use rcu_read_lock_sched()
Use the new rcu_read_lock_sched/unlock_sched() in marker code around the call site instead of preempt_disable/enable(). It helps reviewing the code more easily. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Ingo Molnar <mingo@elte.hu> CC: Peter Zijlstra <peterz@infradead.org> CC: Paul E McKenney <paulmck@linux.vnet.ibm.com> CC: akpm@linux-foundation.org --- kernel/marker.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) Index: ...
Sep 29, 8:08 am 2008
Mathieu Desnoyers
[PATCH] Markers : documentation fix teardown
Document the need for a marker_synchronize_unregister() before the end of exit() to make sure every probe callers have exited the non preemptible section and thus are not executing the probe code anymore. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Ingo Molnar <mingo@elte.hu> CC: Rusty Russell <rusty@rustcorp.com.au> CC: akpm@linux-foundation.org CC: "Frank Ch. Eigler" <fche@redhat.com> --- Documentation/markers.txt | 10 ++++++---- 1 file changed, 6 insertions(+), ...
Sep 29, 8:10 am 2008
Christoph Hellwig Sep 29, 8:13 am 2008
Mathieu Desnoyers
[PATCH] Markers : probe example fix teardown
Need a marker_synchronize_unregister() before the end of exit() to make sure every probe callers have exited the non preemptible section and thus are not executing the probe code anymore. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Ingo Molnar <mingo@elte.hu> CC: Rusty Russell <rusty@rustcorp.com.au> CC: akpm@linux-foundation.org CC: "Frank Ch. Eigler" <fche@redhat.com> --- samples/markers/probe-example.c | 1 + 1 file changed, 1 insertion(+) Index: ...
Sep 29, 8:09 am 2008
Ingo Molnar
Re: [PATCH] markers: fix unregister bug and reenter bug
applied to tip/tracing/markers, thanks! Mathieu, i've reactivated tip/tracing/markers for linux-next integration, it propagates into auto-ftrace-next. Tracepoints are what we use in the scheduler/etc. in tip/master, but until there's marker use elsewhere there's no reason not to apply fix patches. Ingo --
Sep 29, 1:27 am 2008
Mathieu Desnoyers
Re: [PATCH] markers: fix unregister bug and reenter bug
nack for this patch. I'll my fix patchset. -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 --
Sep 29, 8:03 am 2008
Mathieu Desnoyers
[PATCH] sputrace : use marker_synchronize_unregister()
We need a marker_synchronize_unregister() before the end of exit() to make sure every probe callers have exited the non preemptible section and thus are not executing the probe code anymore. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Ingo Molnar <mingo@elte.hu> CC: Jeremy Kerr <jk@ozlabs.org> CC: linuxppc-dev@ozlabs.org CC: Christoph Hellwig <hch@infradead.org> --- arch/powerpc/platforms/cell/spufs/sputrace.c | 1 + 1 file changed, 1 insertion(+) Index: ...
Sep 29, 8:11 am 2008
Krishna Kumar Sep 29, 12:03 am 2008
Oleg Nesterov
Re: [REV2: PATCH 2/2]: workqueue: Modify some users to u ...
Looks good, but I don't understand this code. Krishna, I'd suggest you to send each change in a separate patch with the maintainer cc'ed. And please don't forget to mention that update() != cancel() + queue(). Otherwise maintainer can miss this fact. Oleg. --
Sep 29, 7:45 am 2008
Krishna Kumar
[REV2: PATCH 2/2]: workqueue: Modify some users to use t ...
From: Krishna Kumar <krkumar2@in.ibm.com> Modify some users to use the new API. Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com> --- drivers/net/wireless/ipw2100.c | 12 ++++++------ drivers/net/wireless/libertas/scan.c | 5 ++--- drivers/net/wireless/libertas/wext.c | 7 +++---- fs/afs/vlocation.c | 11 +++-------- fs/ocfs2/cluster/heartbeat.c | 5 ++--- 5 files changed, 16 insertions(+), 24 deletions(-) diff -ruNp ...
Sep 29, 12:03 am 2008
Oleg Nesterov
Re: [REV2: PATCH 1/2]: workqueue: Implement the kernel API
Please note that the above is the open-coded queue_delayed_work(). I'd suggest to just start with if (queue_delayed_work(...)) return 1; ... slow path ... I can't understand why do you want to optimize this very unlikely case. Afaics, it can only improve the benchmark, when we are doing queue_update_delayed_work() in a loop with the same timeout, no? But more importantly, this is not right. We can not trust timer->expires. For example, let's suppose we are ...
Sep 29, 7:27 am 2008
Krishna Kumar
[REV2: PATCH 0/2] workqueue: Two API's to update delayed ...
From: Krishna Kumar <krkumar2@in.ibm.com> Implement two API's for quickly updating delayed works: int schedule_update_delayed_work(struct delayed_work *dwork, unsigned long delay); int queue_update_delayed_work(struct workqueue_struct *wq, struct delayed_work *dwork, unsigned long delay); I tested the following combinations, after Oleg suggested some improvements: A. - Original submission. 1 CPU -> Org: 474213 New: 55365 Time saved: 88.3% 4 CPU -> Org: ...
Sep 29, 12:03 am 2008
Alan Young
Re: [kernel-abi] symbol versioning vs. out-of-tree modules.
I still use the ES56-PI modem driver @ http://tx.technion.ac.il/~raindel. It has a 2.6 port up to 2.6.24, but it's not more current than that due to serial/tty interface changes. And there's a challenge that it uses a binary blob. :-( Best case would be to see if the vendor could open up like Atheros (Thanks! Yea!) did. If not, I wonder if the blob could be minimalized to the bare modem functions and the serial interfaces be brought out into open code. Alan --
Sep 28, 11:51 pm 2008
Greg KH
Re: [kernel-abi] symbol versioning vs. out-of-tree modules.
If the blob is removed, then yes, we can include it into the kernel tree and I will be glad to help get it there. But until then, sorry, there's not much we can do. thanks, greg k-h --
Sep 29, 8:42 am 2008
Borislav Petkov
[PATCH 0/3] ide-cd: debug log enhancements
Hi Bart, here are some trivial enhancements to ide-cd which resulted from the debugging sessions lately. drivers/ide/ide-cd.c | 44 ++++++++++++++++++++++++++------------------ 1 files changed, 26 insertions(+), 18 deletions(-) --
Sep 28, 11:29 pm 2008
Borislav Petkov
[PATCH 3/3] ide-cd: shorten ide_cd_request_sense_fixup's ...
... since HWGROUP(drive)->rq points to the same rq as in the irq handler. While at it, remove stale comment. There should be no functionality change resulting from this patch. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-cd.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index e41b94d..bf92cd6 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -843,12 +843,11 @@ static ...
Sep 28, 11:29 pm 2008
Borislav Petkov
[PATCH 2/3] ide-cd: small drive type print fix
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-cd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 9ffce7f..e41b94d 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -1784,7 +1784,7 @@ static int ide_cdrom_probe_capabilities(ide_drive_t *drive) if ((cdi->mask & CDC_DVD_R) == 0 || (cdi->mask & CDC_DVD_RAM) == 0) printk(KERN_CONT " DVD%s%s", (cdi->mask & CDC_DVD_R) ? ...
Sep 28, 11:29 pm 2008
Borislav Petkov
[PATCH 1/3] ide-cd: debug log enhancements
Add some more verbosity to key function calls in ide-cd debug code. While at it, delete a superfluous comment. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-cd.c | 33 +++++++++++++++++++++------------ 1 files changed, 21 insertions(+), 12 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 474bb1d..9ffce7f 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -340,8 +340,8 @@ static int cdrom_decode_status(ide_drive_t *drive, ...
Sep 28, 11:29 pm 2008
Andrey Borzenkov
Building two (external) modules from the same sources
I have here driver that can be built for two different types of hardware from basically the same sources (this is port of old Agere drivers for Hermes-I/Hermes-II chipsets). Build differs only in one define -DHERMES2 and single file with different firmware. Unfortunately "if HII" are spread over sources which makes splitting of sources rather questionable. What is the best way (from kbuild POV) to build two modules - for H-I and H-II - from the same set of source files? TIA -andrey
Sep 28, 10:49 pm 2008
Tom Zanussi
[RFC PATCH 8/11] relay - Clean up remaining padding-rela ...
Clean up remaining padding-related junk. Removes the rest of the padding-related junk. Also simplifies the subbuf_start callback a bit. Signed-off-by: Tom Zanussi <zanussi@comcast.net> --- block/blktrace.c | 5 +++-- include/linux/relay.h | 12 ++---------- kernel/relay.c | 20 ++++---------------- virt/kvm/kvm_trace.c | 7 ++++--- 4 files changed, 13 insertions(+), 31 deletions(-) diff --git a/block/blktrace.c b/block/blktrace.c index 150c5f7..271b7b7 ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 11/11] relay - Remove vmap of relay buffers.
Remove vmap of relay buffers. Also removes relay_reserve and switches callers over to relay_write. Signed-off-by: Tom Zanussi <zanussi@comcast.net> --- block/blktrace.c | 8 ++++- include/linux/relay.h | 47 +++++++++--------------------------- kernel/relay.c | 63 +++++++++++++++++++++--------------------------- 3 files changed, 46 insertions(+), 72 deletions(-) diff --git a/block/blktrace.c b/block/blktrace.c index 84a9cb4..f60665e 100644 --- ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 10/11] relay - Remove sub-buffers from relay.
Remove sub-buffers from relay. This patch removes the concept of sub-buffers from relay - everything now just operates on pages. relay_open() was also changed accordingly; instead of specifying buffer sizes in terms of sub-buffer sizes and numbers, the buffer size is specfied in pages. There's also a new param that specifies how often to wake up consumers, in terms of every n pages produced. If 0 is given for this param, consumers are never woken up. Signed-off-by: Tom Zanussi ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 9/11] relay - Replace subbuf_start and notify ...
Replace subbuf_start and notify_consumers callbacks with new_subbuf. The subbuf_start callback was too confusing and there's no reason to have a separate callback to notify consumers; this patch combines them both and simplifies the interface. It's only called when there actually has been a switch to a new sub-buffer and there's now no return value saying whether the buffer is full or not - that's now handled internally. Keeping a count of dropped events is also now done internally, so the ...
Sep 28, 10:40 pm 2008
Mathieu Desnoyers
Re: [RFC PATCH 7/11] relay - Remove padding-related code ...
Hi Tom, This question might sound a bit dumb, but I'll ask anyway : why do you implement a splice_read rather than a splice_write in relay ? splice_read allows reading information from a file or from a socket to a pipe, while splice_write does the opposite. So if you implement a relay splice_read, you probably consider the relay buffers to be a "file", so you really have to send the information to a pipe, and then you have to use this pipe to send the data elsewhere. My first reaction ...
Sep 29, 9:27 am 2008
Tom Zanussi
[RFC PATCH 7/11] relay - Remove padding-related code fro ...
Remove padding-related code from relay_read()/relay_splice_read() et al. Because we no longer write padding, we no longer have to read it or account for it anywhere else, greatly simplifying the related code. Signed-off-by: Tom Zanussi <zanussi@comcast.net> --- kernel/relay.c | 149 ++++++++------------------------------------------------ 1 files changed, 20 insertions(+), 129 deletions(-) diff --git a/kernel/relay.c b/kernel/relay.c index d382528..b55466d 100644 --- ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 6/11] relay - Replace relay_reserve/relay_wri ...
Replace relay_reserve/relay_write with non-padded versions. The old versions of relay_reserve/relay_write would write/reserve an event only if the whole thing could fit in the remaining space of the current sub-buffer; if it couldn't it would add padding to the current sub-buffer and reserve in the next. The new versions don't add padding but use up all the space in a sub-buffer and write the remainder in the next sub-buffer. They won't however write a partial event - if there's not enough ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 5/11] relay - Map the first sub-buffer at the ...
Map the first sub-buffer at the end of the buffer, for temporary convenience. Make relay buffers 'circular' for writing by mapping the first subbuf at end of last subbuf. This is so we can do writes across last subbuf boundary without adding special write logic. This is a temporary state of affairs and it all goes away in a future patch, but it's here now so things will still work. Signed-off-by: Tom Zanussi <zanussi@comcast.net> --- kernel/relay.c | 26 +++++++++++++++----------- 1 ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 4/11] relay - Add reserved param to switch-su ...
Add reserved param to switch-subbuf, in preparation for non-pad write/reserve. Because a write/reserve can now cross sub-buffer boundaries, we use the length returned as a remainder for the new sub-buffer, and use the reserved param to return a pointer to the reserved space, or NULL if it couldn't be reserved. This patch also changes write/reserve to preserve their current behavior despite that change. This all goes away in a future patch, but is here now so things don't ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 3/11] relay - Add channel flags to relay, rem ...
Add channel flags to relay, remove global callback param. relay should probably have had a flags param from the beginning; it wasn't originally added because it wasn't originally needed - it probably would have helped avoided some of the callback contortions that were added due to a lack of flags. This adds them and does a small amount of low-hanging cleanup, and is also in preparation for some new flags in future patches. Signed-off-by: Tom Zanussi <zanussi@comcast.net> --- ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 2/11] relay - Make the relay sub-buffer switc ...
Make the relay sub-buffer switch code replaceable. With this patch, tracers now have complete control over the relay write (or reserve) path if they choose to do so, by implementing their own version of the sub-buffer switch function (switch_subbuf()), in addition to their own local write/reserve functions. Tracers who choose not to do so automatically default to the normal behavior. Signed-off-by: Tom Zanussi <zanussi@comcast.net> --- include/linux/relay.h | 23 ...
Sep 28, 10:40 pm 2008
Tom Zanussi
[RFC PATCH 1/11] relay - Clean up relay_switch_subbuf() ...
Clean up relay_switch_subbuf() and make waking up consumers optional. Over time, relay_switch_subbuf() has accumulated some cruft - this patch cleans it up and at the same time makes available some of it available as common functions that any subbuf-switch implementor would need (this is partially in preparation for the next patch, which makes the subbuf-switch function completely replaceable). It also removes the hard-coded reader wakeup and moves it into a replaceable callback called ...
Sep 28, 10:39 pm 2008
Tom Zanussi
[RFC PATCH 0/11] relay revamp, fourth installment
Here's the final installment of the relay cleanup patchset. 1-2 make the write path completely replaceable. 3 adds flags along with some related cleanup. 4-8 remove the padding in several stages. 9 simplifies the callbacks 10 removes the concept of sub-buffers The new patches in this set are: 11 - remove the vmap of relay buffers I think I've basically accomplished what I wanted to with this patchset - getting rid of everything that was unnecessary and unused and fixing a couple of ...
Sep 28, 10:39 pm 2008
Jeff Garzik Sep 28, 9:38 pm 2008
Jeff Garzik
[git patch] libata regression fix
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/sata_nv.c | 46 ++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 40 insertions(+), 6 deletions(-) Tejun Heo (1): sata_nv: reinstate nv_hardreset() for non generic controllers diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c index 1e1f3f3..14601dc 100644 --- ...
Sep 28, 9:36 pm 2008
zippel
[PATCH 2/2] readd lost change count
f072181e6403b0fe2e2aa800a005497b748fd284 simply dropped the warnings, but it does a little more than that, it also marks the current .config as needed saving, so add this back. Signed-off-by: Roman Zippel <zippel@linux-m68k.org> Index: linux-2.6/scripts/kconfig/confdata.c =================================================================== --- linux-2.6.orig/scripts/kconfig/confdata.c +++ linux-2.6/scripts/kconfig/confdata.c @@ -222,8 +222,10 @@ load: continue; if (def == ...
Sep 28, 8:27 pm 2008
zippel
[PATCH 1/2] fix silentoldconfig
Recent changes to oldconfig have mixed up the silentoldconfig handling, so this fixes that by clearly separating that special mode, e.g. KCONFIG_NOSILENTUPDATE is only relevant here, the .config is written as needed. This will also properly close Bug 11230. Signed-off-by: Roman Zippel <zippel@linux-m68k.org> --- scripts/kconfig/conf.c | 123 ++++++++++++++++++++++--------------------------- 1 file changed, 57 insertions(+), 66 deletions(-) Index: ...
Sep 28, 8:27 pm 2008
zippel
[PATCH 0/2] kconfig regression fixes
Hi, I've sent these changes already some time ago, but I haven't heard anything back, but they really should go into 2.6.27. I only dropped the kbuild parts, silentoldconfig is now a little misnamed, as oldconfig is now silent as well, but it still has a special role within kbuild. The naming can still be changed later. bye, Roman -- --
Sep 28, 8:27 pm 2008
Jesse Barnes
Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, ba ...
Yeah... Looks like that function isn't that widely used though. Is the maxlen param really needed? Looks like the drivers that use it often pass 0 or the BAR length anyway, and Arjan converted existing drivers too, which is where the real work is. Jesse --
Sep 29, 10:20 am 2008
Rolf Eike Beer
Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, ba ...
This is the same like pci_iomap(pdev, number, 0), no? Greetings, Eike
Sep 29, 10:02 am 2008
Alan Cox
Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, ba ...
He could have converted them to the existing perfectly good API not invented another one. He still can - I'm sure its a perl one liner to redo them in terms of pci_iomap() Alan --
Sep 29, 10:45 am 2008
Arjan van de Ven
Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, ba ...
On Mon, 29 Sep 2008 18:45:19 +0100 pci_iomap() assumes you're using the rest of the iomap API as well! most drivers do not do that. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org --
Sep 29, 11:15 am 2008
Jesse Barnes
Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, ba ...
Right, I'm definitely not suggesting that we don't provide a way to provide length, but if 90+% of callers don't need it, we should probably have a simpler API that does the bare minimum. Jesse --
Sep 29, 11:26 am 2008
Marcel Holtmann
Re: BUG kmalloc-16: Object already free
I haven't verified it yet, but it looks like a good catch. Let me double check this on my test machine. Weird that we never noticed this before since I have been using the btusb driver for a very long time now. Regards Marcel --
Sep 29, 4:47 pm 2008
Justin Mattock
Re: BUG kmalloc-16: Object already free
Cool, depending on the status of this patch. either I'll apply this one, or just wait until it gets commited,and then just do a git-pull. -- Justin P. Mattock --
Sep 29, 12:22 pm 2008
Rabin Vincent
Re: BUG kmalloc-16: Object already free
There's a commit in the latest git which looks like it will solve the btusb suspend/resume issues: 5fbcd260.. ("[Bluetooth] Fix USB disconnect handling of btusb driver"). Marcel / linux-bluetooth, I think this double free is a separate issue with the error handling, and the following patch should fix it. --- From: Rabin Vincent <rabin@rab.in> Subject: [PATCH] btusb, bpa10x: fix double frees on error paths Justin Mattock reported this double free in btusb: BUG kmalloc-16: Object ...
Sep 29, 11:17 am 2008
Matthew Garrett
Re: sdhci: Loads of scary messages during suspend/resume ...
More to the point, how about this one? It should also handle the resume case, but I haven't tested it yet. diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index ea8d7a3..806bcd8 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -48,23 +48,6 @@ config MMC_SDHCI_PCI If unsure, say N. -config MMC_RICOH_MMC - tristate "Ricoh MMC Controller Disabler (EXPERIMENTAL)" - depends on MMC_SDHCI_PCI - help - This selects the disabler for the Ricoh ...
Sep 29, 5:11 am 2008
Frans Pop
Re: sdhci: Loads of scary messages during suspend/resume ...
Thanks Matthew. For the second part of the quirk the device name is incorrect. It should be r5c832 instead of rl5c832 and the DECLAREs also have the wrong device. I think it would probably be good to add a printk for an info or debug message saying that the proprietary controller has been disabled. After fixing that it compiles correctly and does improve things a lot, but there are still remaining issues. I suspect these are probably unrelated to the proprietary controller though. During ...
Sep 29, 11:00 am 2008
Matthew Garrett
Re: sdhci: Loads of scary messages during suspend/resume ...
Eep! I'm sure that doesn't sound like a good idea. ricoh-mmc is suspending before sdhci is. In the process, it flips the hardware back into non-sdhci mode and the sdhci controller stops being able to talk to the card. I suspect that this upsets its own suspend routine rather a lot. Does this help at all? Not a complete fix, I suspect you'll still have issues on resume. diff --git a/drivers/mmc/host/ricoh_mmc.c b/drivers/mmc/host/ricoh_mmc.c index a16d760..015c248 100644 --- ...
Sep 29, 4:38 am 2008
Ingo Molnar
Re: [PATCH] x86: merge winchip-2 and winchip-2a cpu choices
applied to tip/x86/core, thanks Krzysztof! (I left out the UML defconfig update - that can be done later and it doesnt hurt anyway.) Ingo --
Sep 29, 2:19 am 2008
H. Peter Anvin
Re: [PATCH] x86: merge winchip-2 and winchip-2a cpu choices
Looks good to me. Acked-by: H. Peter Anvin <hpa@zytor.com> --
Sep 29, 2:07 am 2008
Ingo Molnar
kmemcheck: Caught 32-bit read from uninitialized memory ...
got the report below - config attached. This is probably bitfield initialization related. tip-072062d5. Ingo -----------------> kmemcheck: Caught 32-bit read from uninitialized memory (f6038ec0) 0000000000000000d0e86bc0d0fa6bc070446cc060fa6bc0205c71c0103772c0 u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u ^ Pid: 0, comm: swapper Tainted: G W (2.6.27-rc7-tip-00980-g072062d-dirty #37099) System Product Name EIP: 0060:[<c06beba6>] EFLAGS: 00010282 CPU: 0 EIP is ...
Sep 29, 4:57 am 2008
Ingo Molnar
Re: [GIT PULL] kmemcheck fixlets (for -tip)
branches are hard to kill in Git (anyone pushing back from a tree that still has the old branch will re-create it). The name is sufficiently generic so we keep keep it. The name can be reused in the future pulled into tip/kmemcheck-bitfields, thanks Vegard. I've also propagated this new branch into the integration rules of auto-kmemcheck-next. Ingo --
Sep 29, 12:54 am 2008
Vegard Nossum Sep 29, 2:13 am 2008
Ingo Molnar
Re: [GIT PULL] kmemcheck fixlets (for -tip)
got another type of warning: PM: Adding info for No Bus:vcs1 PM: Adding info for No Bus:vcsa1 ------------[ cut here ]------------ WARNING: at kernel/smp.c:331 smp_call_function_mask+0x182/0x190() Modules linked in: Pid: 1261, comm: gzip Not tainted 2.6.27-rc7-tip-00980-g072062d-dirty #37099 [<c012cdb4>] warn_on_slowpath+0x54/0x70 [<c011eebe>] ? kmemcheck_pte_lookup+0xe/0x30 [<c011e744>] ? kmemcheck_show_addr+0x44/0x60 [<c011ae3f>] ? lookup_address+0x7f/0xa0 [<c011eebe>] ? ...
Sep 29, 4:13 am 2008
Ingo Molnar Sep 29, 12:59 am 2008
Ingo Molnar
Re: kmemcheck: Caught 32-bit read from uninitialized mem ...
another crash is below - config attached. Ingo -----------------> initcall 0xc08eabf0 returned 0 after 7 msecs calling 0xc08eae70 @ 1 PnPBIOS: Scanning system for PnP BIOS support... PnPBIOS: Found PnP BIOS installation structure at 0xc00fc550 PnPBIOS: PnP BIOS version 1.0, entry 0xf0000:0xc580, dseg 0xf0000 BUG: unable to handle kernel paging request at 0000c6ef IP: [<c011ee33>] *pde = 00000000 Oops: 0000 [#1] SMP Modules linked in: Pid: 1, comm: swapper Not tainted ...
Sep 29, 6:14 am 2008
Ingo Molnar
Re: [GIT PULL] kmemcheck fixlets (for -tip)
a kernel log line beginning with: INFO: WARNING: BUG: would be noticed. (That pattern has to be at the beginning of the line. Otherwise we'd match on things like 'DEBUG: ' - such printouts exist) Ingo --
Sep 29, 2:25 am 2008
Ingo Molnar
Re: [GIT PULL] kmemcheck fixlets (for -tip)
ok, it crashed with that, see below. Config attached - kernel was latest tip/master. Let me know if you need more debug info. Ingo [ 372.600318] memmap_init+0x0/0xc0 called from 1 returned 0 after 7 msecs [ 372.600318] pci_mmcfg_late_insert_resources+0x0/0x150 called from 1 returned 0 after 0 msecs [ 372.600318] tcp_congestion_default+0x0/0x10 called from 1 returned 0 after 0 msecs [ 372.600318] ip_auto_config+0x0/0xff0 called from 1 returned 0 after 0 msecs [ 372.600318] ...
Sep 29, 2:43 am 2008
Ingo Molnar
Re: [GIT PULL] kmemcheck fixlets (for -tip)
FYI, i've reactivated kmemcheck on one of the -tip auto-test boxes earlier today and it's looking good so far - for example a 32-bit allyesconfig-ish config booted in just fine with kmemcheck enabled. Also, the box is very usable interactively - while previous one could always tell whether there's kmemcheck active. [ only one CPU is active, but we knew that. We've still got this test-commit: 21d01a4: x86: add functions for duplicating page tables it's not in tip/master ...
Sep 29, 1:55 am 2008
jmerkey
Re: [REQUEST] Clarification from Copyright Holders on ...
Hi Ted, The figures I am quoting are based on who is downloading not how many. I had over 27,000 downloads the first week but only a few of them were from fortune 1000 of 500 companies. After two weeks it dropped off sharply to a very low level. Most of the downloads are still from my primary servers, and not google or sourceforge. I agree Linux is pervasive and its use is increasing among the US customer base, but its interest from technology companies (distributors) is ...
Sep 28, 8:27 pm 2008
Theodore Tso
Re: [REQUEST] Clarification from Copyright Holders on FU ...
You're assuming that your metrics of people downloading your kernel debugger is an accurate way of measuring how many people are You may find these research reports interesting: http://www.linuxfoundation.org/publications/linuxkerneldevelopment.php http://www.linux-foundation.org/publications/IDC_Workloads.pdf The former shows that the development rate is if anything, increasing based on analyzing the rate that changes are flowing into the Linus's git tree --- something which I think ...
Sep 28, 6:57 pm 2008
Ingo Molnar
Re: [GIT PULL] kmemcheck updates (for -tip)
pulled into tip/kmemcheck, thanks Vegard! Ingo --
Sep 29, 12:45 am 2008
vincen
Re: PATCH linux-2.6.27-rc7-git5]ARM:Add the Nuvoton w90P ...
Dear sir, Thank you for your help. -- www.mcuos.com Best Regarts, Vincen --
Sep 29, 5:14 am 2008
Ben Dooks
Re: PATCH linux-2.6.27-rc7-git5]ARM:Add the Nuvoton w90P ...
If posting large patches, it would generally be much easier to split them into smaller chunks of logical changes. For an example, the defconfig -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' --
Sep 29, 2:15 am 2008
Daniel Rosenthal
Re: linux object file containing all kernel symbols and ...
> These are provided by the linker script. Ok, I took a look at both vmlinux_32.lds.S and uml.lds.S (I'm assuming these are the linker scripts). I also took a look at vmlinux. I didn't realize at first that vmlinux actually has some symbols in it. I linked vmlinux to my programs using gcc and it compiled, but I got a segmentation fault when I ran it. What is the appropriate binary format to use to output the kernel binary so it won't segfault in userspace? Ideally, I would like to add ...
Sep 28, 11:18 pm 2008
Tino Keitel
Re: [Bug #11654] Devices enabled in /proc/acpi/wakeup do ...
The above patches fix the problems for me. Thanks and regards, Tino --
Sep 29, 2:21 pm 2008
Miller, Mike (OS Dev) Sep 29, 8:00 am 2008
Andi Kleen
Re: [PATCH 1/3] ioctl: generic ioctl dispatcher
The basic idea is good, but i don't like the proliferation of callbacks, which tends to make complicated code and is ugly for simple code (which a lot of ioctls are) How about you make it return an number that can index a switch() instead? Then everything could be still kept in the same function. -Andi --
Sep 29, 10:16 am 2008
Steven Rostedt
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
I forgot to mention one important detail. The "head" index will stay on the page frame. That way we do not need to figure out which head_page we are on. We grab the head_page, we atomically (local_inc_return) the head pointer on that page. If the return value is still on the page, we succeeded. We can also increment a value on this page frame that will prevent recording if we somehow overflowed the buffer before relinquishing the stack. That is reserve_event() IRQ-> ...
Sep 29, 12:54 pm 2008
Mathieu Desnoyers
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
As I already told you in person, if you have, say 16 pages for your buffer, you could peek into all the pages which are not being currently written into (15 other pages). This would permit to remove unnecessary writer synchronization from a cmpxchg scheme : it would only have to push the readers upon page switch rather than at every single even. Pushing the readers involves, at best, a fully synchronized cmpxchg, (I notice the comment in your v10 says that minimum size for event is 8 bytes, ...
Sep 29, 11:38 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
Well, this is my answer to Steven's "this is too complex" comments, which I suspect is really a "this is too implement to implement". Sorry Steven, but you do not actually propose anything to address my concerns, which are : I want to export this data to userspace without tricky dependencies on the compiler ABI. I also don't want to be limited in locking infrastructure implementation. Those are the kind of concerns that are much easier to address in a layered and modular implementation. If we ...
Sep 29, 9:06 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
Ok, I'll try to explain my point of view. The thing is : I want those binary buffers to be exported to userspace, and I fear that the approach taken by Steven (let's write "simple" C structure directly into the buffers) will in fact be much more _complex_ (due to subtle compiler dependencies) that doing our own event payload (event data) format. Also, things such as ring_buffer_lock: A way to lock the entire buffer. ring_buffer_unlock: unlock the buffer. will probably become a problem when ...
Sep 29, 8:50 am 2008
Peter Zijlstra
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
The only compiler dependant thing in there is the bitfield, which could be recoded using regular bitops. You can do stop: cpu_buffer->stop=1; smp_wmb(); sched_sync(); start: smp_wmb(); cpu_buffer->stop=0; write: if (unlikely(smp_rmb(), cpu_buffer->stop))) { return -EBUSY; or while (cpu_buffer->stop) cpu_relax(); } Sure, its probably possible to rework the merge-iterator to use consume, but that would require it having storage for 1 event, which might be ...
Sep 29, 10:30 am 2008
Steven Rostedt
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
Actually, I also have been looking at doing things lockless. Note, the peek operation is for the iteration mode of read, which must disable writes (for now). The iteration mode does not consume the reader, in fact there is no consumer. It is used to give a trace after the fact. No writer should be present anyway. the peek operation will not be used for a consumer read, which allows for I force a zero type payload to have a len of 1. This keeps the minimum at Because my focus is ...
Sep 29, 12:40 pm 2008
Steven Rostedt
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
Remember, I plan on supporting two modes. An iterator mode and a consumer producer mode. Do you have an iterator mode? That's what most of the ftrace tools use. The iterator mode will disable writing and use the "peek" mode. The consumer mode will not, and have its own ways to read. As is right I do that too. Yes I have duplicate info. But I still like the robustness False. It is a "special" event that can actually be in 4 bytes. Which is what would be wasted anyway. Lenght ...
Sep 29, 2:24 pm 2008
Mathieu Desnoyers
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
+struct ring_buffer_event { + u32 type:2, len:3, time_delta:27; + u32 array[]; +}; I am mostly talking about what goes in the array[] part of the event. That will stop tracing if you want to read a trace at the same time you want to write it, which does not permit continuous streaming. I agree that such start/stop is needed to control tracing on/off, but it Sure, I plan to support this. This would be a subset of userspace data extraction. The ...
Sep 29, 1:31 pm 2008
Steven Rostedt
Re: [RFC PATCH] LTTng relay buffer allocation, read, write
I now have both. But I think userspace can now easily see when there I wanted to push the event ids out of the ring buffer logic. Only a few internal ones are used. Otherwise, we'll have one hell of a bit enum Well, you need to record wraps. Probably more often then you record delta As Linus said, anything bigger than a page should be outside this buffer. All the buffer would then need is a pointer to the data. Then the tracer -- Steve --
Sep 29, 9:38 am 2008
Takashi Iwai
Re: [alsa-devel] [PATCH] Drop Vladimir Barinov's e-mail ...
At Sat, 27 Sep 2008 12:51:54 +0100, Applied now. Thanks for checking. Takashi --
Sep 29, 3:50 am 2008
Serge E. Hallyn
Re: [PATCH 5/6] file capabilities: remove needless inlin ...
Here is a patch (on top of the others) doing that. thanks, -serge Subject: [PATCH] capabilities: remove target argument from capset_check and set Since it is no longer possible to set capabilities on another task, remove the 'target' option from capset_set and capset_check. Since the userspace API shouldn't change, we maintain 'pid' as a valid option to the actual sys_capset(), continuing to return -EPERM when pid is not current's pid. Signed-off-by: Serge E. Hallyn ...
Sep 29, 2:53 pm 2008
Jeremy Fitzhardinge
Re: Use CPUID to communicate with the hypervisor.
I think using fixed offsets is unwise, since there's already contention for the same leaves. Making sure that each block of leaves (where a block is 16, 256 or some other number of leaves) is self-describing via ABI signatures is the only sane way to go. There's still the issue of assigning ABI signatures to vendors, but that's 1) less of an issue, and 2) can be self-assigned with very low likelihood of collision. That way a guest can scan that region of leaf space for ABI signatures ...
Sep 29, 2:28 pm 2008
Gerd Hoffmann
Re: Use CPUID to communicate with the hypervisor.
Nice idea. Problem with that is that approach is that we don't have full control here. It probably isn't that a hard to have vmware, xen and kvm agree here, given vmware proposes this and for xen+kvm one can send patches. But even that you can't take for granted, see the discussion of the "tsc-may-change-on-migration" problem. The real big problem are other closed-source hypervisors (VirtualPC / Hyper-V / Parallels / ...). How can we be sure they don't define that The fudamental issue ...
Sep 29, 11:46 am 2008
Gleb Natapov
Re: Use CPUID to communicate with the hypervisor.
There is a need to tunnel those somehow since ACPI/DMI tables resides in a guest memory. Guest BIOS can build them, but some folks want to pass additional ACPI tables from command line. So if CPUID is not suitable for this there have to be another channel. CPUID can provide info if this channel is available. -- Gleb. --
Sep 29, 2:33 am 2008
Bernd Eckenfels
Re: Use CPUID to communicate with the hypervisor.
Besides that, nobody stops a Hypervisor to offer valid and usefull DMI and ACPI tables in the first place. I dont see a need to tunnel those through CPUID. Gruss Bernd --
Sep 29, 2:08 am 2008
H. Peter Anvin
Re: Use CPUID to communicate with the hypervisor.
This is only true if you can also except M$ and other hypervisor vendors to stick to it. So far, hypervisor vendors have hardly shown any inclination toward standardization. Hence I really don't think it is sane. -hpa --
Sep 29, 10:58 am 2008
Avi Kivity
Re: Use CPUID to communicate with the hypervisor.
This was discussed at the virtualization mini summit (can't remember who brought it up). -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. --
Sep 29, 2:44 am 2008
Avi Kivity
Re: Use CPUID to communicate with the hypervisor.
In theory it can, but it would be a bad idea. cpuid is best used to communicate cpu features; ACPI and DMI are (mostly) system features. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. --
Sep 29, 12:37 am 2008
H. Peter Anvin
Re: Use CPUID to communicate with the hypervisor.
If you can't mix and match, there is no point, since very likely all Yes, see my previous "half-baked" sketch. -hpa --
Sep 29, 2:49 pm 2008
Nakajima, Jun
RE: Use CPUID to communicate with the hypervisor.
For example, we can set the following ranges so that so that each VMM vender can define and implement features avoiding conflicts: vmware to define 0x4000001X xen to define 0x4000002X kvm to define 0x4000003X ... The point here is that all the features are generic because we don't make them exclusive. To that end, we don't check the signature. Whatever common features can be found in the above, and each hypervisor can choose to implement what was defined by other hypervisors. Detection of ...
Sep 29, 1:55 pm 2008
Karel Zak
Re: Use CPUID to communicate with the hypervisor.
Yes. It would be nice to have "Hypervisor vendor id" somewhere in /sys or /proc. It seems that userspace is already hungry for that information: http://article.gmane.org/gmane.linux.utilities.util-linux-ng/1788 Karel -- Karel Zak <kzak@redhat.com> --
Sep 29, 1:56 pm 2008
Tim Deegan
Re: Use CPUID to communicate with the hypervisor.
I was talking about checking every 256 leaves from 0x40000000, but I can't remember where I heard it. The only relevant reference I can find is the MS hypervisor interface spec's description of leaf 0x40000001: "Hypervisor vendor-neutral interface identification. This determines the semantics of the leaves from 0x40000002 through 0x400000FF" Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Citrix Systems (R&D) Ltd. [Company #02300071, SL9 0DZ, ...
Sep 29, 2:28 am 2008
Zachary Amsden
Re: Use CPUID to communicate with the hypervisor.
Aren't we overthinking / overdesigning this a bit? It's not rocket science. We'd like to have a leaf set aside for TSC frequency, and maybe another leaf in the future. We think other vendors might find a static clock frequency leaf to be useful, so if that happens to be the case, feel free to re-use the leaf. We don't expect to see lots of proliferation of CPU leaves at all, in fact, we'd be flummoxed to propose more than one right now. So basically a nicely written comment section ...
Sep 29, 4:20 pm 2008
Nakajima, Jun
RE: Use CPUID to communicate with the hypervisor.
Also, we have reserved the MSRs from 0x40000000 - 0x400000FF for software use. We could use such MSRs, but what's the benefits of using those when ACPI already defined the detection mechanism? . Jun Nakajima | Intel Open Source Technology Center --
Sep 29, 8:32 am 2008
H. Peter Anvin
Re: Use CPUID to communicate with the hypervisor.
Unless there is a central authority assigning these, "we" can do all we want, enough people will not pay attention. Basically, there needs to be a standards document that describes the architecture, *and* needs to either have universal buy-in with all the vendors or imposed by an authority with enough clout to do so (Intel might.) -hpa --
Sep 29, 2:07 pm 2008
Alok Kataria
Re: Use CPUID to communicate with the hypervisor.
Yep. And please note that this does allow either Xen/KVM to propose a new leaf and the rest of the hypervisor players can decide to export that I may have been unclear in my first attempt to this question, let me try again. If the frequency of tsc changes during migration, it should be the task of hypervisor to handle it. There could be multiple ways to solve that problem, either the hypervisor emulates the old frequency (by whatever way) or there are cpufreq drivers in the guest which ...
Sep 29, 12:38 pm 2008
Gerd Hoffmann
Re: Use CPUID to communicate with the hypervisor.
Likewise, I think this should be HYPERVISOR_VMWARE_TIMING_LEAF. Or we need some way to (a) standardize hypervisor cpuid leafes (or parts of it) and (b) handle sparsely filled cpuid info. Right now both kvm and xen use the first one or two leafes (after info), but in incompatible ways, so for these the signature *must* be checked before using the info found there. 0x40000010 doesn't clash with anything as far I know, so we could attempt to make that standard accross ...
Sep 29, 1:24 am 2008
Alok Kataria
Re: Use CPUID to communicate with the hypervisor.
Hi Gerd, Nope the whole idea of not checking the hypervisor signature is that we should keep this interface generic. In the current code, before poking the TIMING_LEAF, we do check if the maximum supported cpuid level is greater than that leaf. If it is we go ahead and probe that cpuid leaf. Also one thing to remember is, that a hypervisor can decide to not implement this level and just return "0" the kernel can then just ignore Exactly. Returning zero for the fields which are not ...
Sep 29, 10:55 am 2008
H. Peter Anvin
Re: Use CPUID to communicate with the hypervisor.
I don't think this is a realistic point of view, especically given who we're dealing with in the closed-source world. Without any kind of tagging of the information, it's realistically futile. Intel/AMD haven't helped any by reserving a space which is entirely too small. -hpa --
Sep 29, 1:31 pm 2008
Gerd Hoffmann
Re: Use CPUID to communicate with the hypervisor.
This small print is part of the guest/host ABI though, so hypervisors must agree here too, be it "tsc is constant" or "re-read tsc freq on Although we are working on world domination I think we are not close Oh, ok. I expected the check explicitly coded within the hypervisor_tsc_freq() function. This deserves at least a comment saying that this side effect is actually intentional. cheers, Gerd --
Sep 29, 3:46 pm 2008
Gleb Natapov
Re: Use CPUID to communicate with the hypervisor.
Can this interface be used to pass variable sized data from a hypervisor to a gust? ACPI or DMI tables for instance. -- Gleb. --
Sep 28, 11:55 pm 2008
Arjan van de Ven
Re: [PATCH] pci: introduce users of ioremap_pcibar()
On Mon, 29 Sep 2008 11:10:49 -0600 pci_iomap() does "stuff" but it assumes you're using the iomap APIs across the driver. MANY don't. And pci_iomap() takes more parameters than most driver writers want or need. Most of the time it's "I want the whole bar"; even if my patch wraps around that, making the API simpler is still worth it imo --
Sep 29, 10:23 am 2008
Arjan van de Ven
Re: [PATCH] pci: introduce users of ioremap_pcibar()
On Mon, 29 Sep 2008 01:26:43 -0600 we should detect this and DTRT inside the implementation, not in the drivers. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org --
Sep 29, 6:42 am 2008
Alan Cox
Re: [PATCH] pci: introduce users of ioremap_pcibar()
And pci_iomap is cleaner still. Plus pcim_iomap does resource tracking so There are exceptions - I2O for example and there are other cards that use write merging when possible beyond video. Also btw vidoe depends on the chip - if you cache/write merge the framebuffer on a Voodoo 1/2 card you must be in 24/32bit video modes for example. Generally though PCI = controlled by hardware = uncached Alan --
Sep 29, 2:20 am 2008
Grant Grundler
Re: [PATCH] pci: introduce users of ioremap_pcibar()
*nod* FTR, I like this interface better since most drivers use ioremap() instead Should the comment be deleted? It made sense (sort of) for the orginal code and maybe including a comment like it in the new ioremap_pcibar() would be good. Alternatively, the ioremap_pcibar() code needs to check for Is there any easy way to tell if the device driver should be using uncached mappings vs cacheable mappings? (Just from looking at the source code) This patch changes that behavior of the ...
Sep 29, 12:26 am 2008
Grant Grundler
Re: [PATCH] pci: introduce users of ioremap_pcibar()
On Mon, Sep 29, 2008 at 06:42:20AM -0700, Arjan van de Ven wrote: Ok...it was using cacheable mapping on ia64 until this commit in 2007: http://www.gelato.unsw.edu.au/archives/linux-ia64/0703/20211.html I stopped paying close attention on ia64 in 2006 for the most part. It's always been uncacheable on parisc. After finding willy's patch (March 2006) on lwn.net, I remember the discussion around changing the behavior of ioremap() to be uncached: http://lwn.net/Articles/178084/ And ...
Sep 29, 10:10 am 2008
Michael Renzmann
Re: Release of Atheros 802.11abg HAL under the ISC
Hi. It's not particularly on-topic here, so just a short note: #ath9k should not be invite-only (but I will check again). It forwards to #madwifi, which is used for discussion about MadWifi, ath5k and ath9k. Bye, Mike --
Sep 28, 8:50 pm 2008
Greg KH
Re: [PATCH 4/4] x86: Add sysfs entries for UV v2
Heh you got the documentation in before the code, that seems to be an interesting trend these days :) thanks, greg k-h --
Sep 29, 8:43 am 2008
Russ Anderson
Re: [PATCH 2/4] x86: Add UV bios call infrastructure v2
After thinking about this, if a new runtime call was added to efi_runtime_services_t, then the existing efi_call_virt<n> could be used. This would remove the need to create uv_systab. I'll post a patch shortly. -- Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc rja@sgi.com --
Sep 29, 7:31 am 2008
Takashi Iwai
[GIT PULL] ALSA fixes (v2)
Linus, please pull ALSA updates for 2.6.27-rc7 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git for-linus This contains the fixes for ASoC cs4270 codec driver (to make it running on 2.6.27) in addition to two deadlock fixes in the last pull request. Thanks! Takashi == Jean Delvare (1): ALSA: ASoC: Fix another cs4270 error path Takashi Iwai (2): ALSA: fix locking in snd_pcm_open*() and snd_rawmidi_open*() ALSA: remove unneeded ...
Sep 29, 7:19 am 2008
Ingo Molnar
Re: [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to ...
good. Frederic, please just resubmit all fixes you have against tip/master, with Pekka's Acked-by added. You can submit Pekka's patch as well, so that it's a coherent series. The customary way for that is to add in a From line as the first line of the changelog: From: Pekka Paalanen <pq@iki.fi> and add your signoff to the end of the changelog. This way Git will show Pekka as the author and the path of the patch is well understood. Thanks, Ingo --
Sep 29, 2:02 am 2008
Ingo Molnar
Re: [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to ...
yeah - resend any bits not yet in tip/master, and also add Pekka's Correct. Also mark it v2 perhaps in the announcement. when there's NACKs and discussion it's (much) easier to pick up a new series than picking out the bits from the discussion. That way the resubmission might be redundant in a large part, but it's a summary of your discussion with Pekka and the result of a consensus. I.e. not redundant in terms of a workflow step. Ingo --
Sep 29, 2:47 am 2008
Frédéric Weisbecker Sep 29, 2:20 am 2008
Frédéric Weisbecker
Re: [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to ...
Ok so... I resend my patches (without changes?) but I adapt them to latest -tip master? And I add the pekka's patches (whit appropriate "from" line) with them? Sorry I 'm a bit lost.... --
Sep 29, 2:28 am 2008
Frédéric Weisbecker
Re: trace_pipe tentative fix
Tested! And, no problem as far as I can see :) So I'm going to send the new patchset. Thanks. --
Sep 29, 10:49 am 2008
Frédéric Weisbecker
Re: [Path -tip 1/3] Tracing/ftrace: Change the type of t ...
Actually it should be enum print_line_t. I forgot to change its type. At this moment they don't. But I just wanted to set a security in case I made a new patch this week-end and I found a way to prevent from closing the pipe. I should look at this possible issue too. I didn't think about it yet. --
Sep 29, 2:11 am 2008
Pekka Paalanen
Re: [Path -tip 1/3] Tracing/ftrace: Change the type of t ...
On Mon, 29 Sep 2008 11:11:15 +0200 Is print_line_t necessary? Does it have to return any other information than "this entry was handled somehow" vs. "this entry must be handled later"? Currently it's just a flag to say "please flush and retry". -- Pekka Paalanen http://www.iki.fi/pq/ --
Sep 29, 8:04 am 2008
Frédéric Weisbecker
Re: [Path -tip 1/3] Tracing/ftrace: Change the type of t ...
It would just make the code more readable in the read_pipe function. if (sret == TRACE_TYPE_PARTIAL_LINE) tells us more than if (!sret). And it would avoid some tests to return a boolean in print_trace_line. No? --
Sep 29, 8:56 am 2008
Eric W. Biederman
Re: 2.6.27-rc7-sha1: EIP at proc_sys_compare+0x36/0x50
We definitely have a race between d_kill setting dentry->d_inode = NULL and proc_sys_compare reading d_inode. We don't generate negative dentries for /proc/sys. In dput atomic_dec_and_lock takes the lock before setting the count to 0. So there is no race there. Testing for d_unhashed and getting us out of rcu limbo before calling into the filesystem methods makes the reasoning a lot clearer. Looks good to me. Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com> --
Sep 28, 8:05 pm 2008
apgmoorthy
RE: [ANNOUNCE] [PATCH] [MTD] Flex-OneNAND MTD Driver ava ...
Hi David, Please do comment on this patch. "Not to expose whole OOB" suggestion by Kyungmin should be fine , but looking for your suggestion. With Regards Gangheyamoorthy.A.P -----Original Message----- From: Artem Bityutskiy [mailto:dedekind@infradead.org] Sent: Friday, September 26, 2008 1:50 PM To: Amit Kumar Sharma Cc: Kyungmin Park; apgmoorthy; linux-mtd@lists.infradead.org; Kyungmin Park; lkml; David Woodhouse Subject: Re: [ANNOUNCE] [PATCH] [MTD] Flex-OneNAND MTD ...
Sep 29, 2:28 am 2008
Jens Axboe
Re: disk IO directly from PCI memory to block device sectors
Just for kicks, I did the read part of the fast bdev interface as well. As with the write, it's totally untested (apart from compiled). Just in case anyone is curious... I plan to do a bit of testing on this this week. IMHO, this interface totally rocks. It's really async like splice was intended, and it's fast too. I may have to look into some generic IO mechanism to unify them all, O_DIRECT/page cache/splice. Famous last words, I'm sure. diff --git a/fs/block_dev.c ...
Sep 29, 6:02 am 2008
Jiri Kosina
RE: e1000e NVM corruption issue status
Hmm, this happens even if I put the e1000e module completely out of way (and it happens when userspace is starting postfix), so it might be a completely separate issue. -- Jiri Kosina SUSE Labs --
Sep 29, 10:36 am 2008
Jiri Kosina
RE: e1000e NVM corruption issue status
Verified, this is something completely separate, started triggering at the very same time I have fixed the 09-e1000e-allow-bad-checksum.patch only by coincidence. Please disregard this. -- Jiri Kosina SUSE Labs --
Sep 29, 3:43 pm 2008
Jiri Kosina
Re: e1000e NVM corruption issue status
When using this patchset (plus patch that adds check for address range in pci_mmap_resource() by Jesse Barnes), the machine (that already has corrupted (but not completely erased)) hangs after dumping eeprom contents: 0000:00:19.0: 0000:00:19.0: The NVM Checksum Is Not Valid /*********************/ Current EEPROM Checksum : 0x2259 Calculated : 0xa259 Offset Values ======== ====== 00000000: 00 15 58 c6 4a ff 00 08 ff ff 30 00 ff ff ff ff 00000010: ff ff ff ff c7 10 b9 ...
Sep 29, 8:52 am 2008
Brandeburg, Jesse
RE: e1000e NVM corruption issue status
fixed Karsten's email, apologies for the bounces. Yep, I think you're right. I'm almost done prepping our current patch series, I'll include that fix. Please let me know if your test shows it fixes it. --
Sep 29, 9:24 am 2008
Jiri Kosina
Re: e1000e NVM corruption issue status
And I believe that this is because of this code in 09-e1000e-allow-bad-checksum.patch: for (i = 0;; i++) { if (e1000_validate_nvm_checksum(hw) >= 0) { /* copy the MAC address out of the NVM */ if (e1000e_read_mac_addr(&adapter->hw)) e_err("NVM Read Error reading MAC address\n"); break; } if (i == 2) { ...
Sep 29, 9:20 am 2008
Jiri Kosina
RE: e1000e NVM corruption issue status
Yes, it fixed the hang. It crashed later though BUG: unable to handle kernel NULL pointer dereference at 0000000000000050 IP: [<ffffffffa045211b>] inet6_net_init+0x98/0xf2 [ipv6] PGD 39d15067 PUD 39d14067 PMD 0 Oops: 0000 [1] SMP last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:15:00.0/0000:16:00.0/local_cpus which is probably related I guess. -- Jiri Kosina SUSE Labs --
Sep 29, 10:18 am 2008
Mathieu Desnoyers
Re: [PATCH v10 Golden] Unified trace buffer
* Steven Rostedt (rostedt@goodmis.org) wrote: Hi Steven, You should have a look at mm/slob.c free_slob_page(). I think your page free will generate a "bad_page" call due to mapping != NULL and mapcount != 0. I just ran into this in my own code. :) Regards, Mathieu -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 --
Sep 29, 4:35 pm 2008
Steven Rostedt
[PATCH v10 Golden] Unified trace buffer
[ This is the final version of this patch. From now on, I will be sending changes on top of this patch. Changes since v9: All suggestions from Ingo Molnar. - Changed comment of enum to DocBook style. - Replaced the RB_TYPE_ enums with RINGBUF_TYPE_ prefixes to avoid name collision with rbtree. Note, I did not use the TB_ extension because I envision a "trace_buffer" layer on top of this layer in the future. - Moved ring_buffer_event_{length,data} into the ...
Sep 29, 9:10 am 2008
Steven Rostedt
Re: [PATCH v10 Golden] Unified trace buffer
Ingo, I will add this patch to my linux-tip and then I will start porting ftrace over to it in an incremental fashion. -- Steve --
Sep 29, 9:11 am 2008
Steven Rostedt
Re: [PATCH v9] Unified trace buffer
OK, I did a quick survey of what others did in include/linux to handle multi line comments for enums. I ignored the single line comments since that is pretty standard. Here's what I found: Those that do: enum myenum { ENUM_PING_PONG, /* Bounce a ball back and forth till you have a winner. */ ENUM_HONEY_CONE, /* Soft and sweet a yummy for the tummy. ...
Sep 29, 8:05 am 2008
Tilman Baumann
Re: SMACK netfilter smacklabel socket match
I'm essentially using this as some kind of iptables owner-match on steroids. Owner match allows to filter on the processes uid, gid, and some other process attributes. Unfortunately owner match is pretty much useless because of it's limited matching capabilities. I'm really just abusing the way how security contexts of processes are transfered to all it's sockets. This way I can label a process with a specific label which then gets transfered to all of it's sockets. With this match ...
Sep 29, 9:21 am 2008
Greg KH
Re: CONFIG_SECURITY_ROOTPLUG [was: Re: 2.6.27-rc7 no ini ...
If you enable that option, you have to have the specific USB device plugged into your system in order for any process to run as root (like init). So, odds are you don't have this specific device, so either specify a different device id, or don't build it into your kernel :) thanks, greg k-h --
Sep 29, 4:11 pm 2008
Christian Borntraeger
Re: [patch 1/6] kmsg: tagged kernel messages.
Rusty, Since Kernel message levels are used directly by syslog, the Open Group Base Specifications Issue 6 defines what these levels are: http://www.opengroup.org/onlinepubs/009695399/basedefs/syslog.h.html LOG_EMERG A panic condition was reported to all processes. LOG_ALERT A condition that should be corrected immediately. LOG_CRIT A critical condition. LOG_ERR An error message. LOG_WARNING A warning message. LOG_NOTICE A condition requiring special handling. LOG_INFO A general ...
Sep 29, 1:35 am 2008
Andres Freund
Re: bad DMAR interaction with iwlagn and SATA
Hi, On Friday 26 September 2008, you wrote in "Re: bad DMAR interaction with=20 Could not reproduce so far - it is rather hard working on the machine with= =20 DMAR enabled because I get 1-5s lockups all the time like described above... Andres
Sep 29, 1:26 am 2008
Tomas Winkler
Re: bad DMAR interaction with iwlagn and SATA
I've posted few patches lately to address some RX buffers issues you may to try those. Not sure it will help though. http://marc.info/?l=linux-wireless&m=122241327108723&w=2 http://marc.info/?l=linux-wireless&m=122241327208729&w=2 Thanks Tomas --
Sep 29, 1:40 am 2008
Andres Freund
Re: bad DMAR interaction with iwlagn and SATA
Hi, On Saturday 27 September 2008, Tomas Winkler wrote in "Re: bad DMAR=20 Would it help to test on 32bit? I have some dissk with 32bit system install= ed=20 lying around somewhere... Any other patches to try? Andres
Sep 29, 1:27 am 2008
Gregory Haskins
Re: [BUG][PPC64] BUG in 2.6.26.5-rt9 causing Hang
Thanks to help from Darren I got around this issue. Unfortunately both tests pass so I cannot reproduce this issue, nor do I see the problem via code inspection. Ill keep digging but I am currently at a loss. I may need to send you some diagnostic patches to find this, if that is ok with you Chirag?
Sep 29, 3:00 pm 2008
Gregory Haskins
Re: [BUG][PPC64] BUG in 2.6.26.5-rt9 causing Hang
Hi Chirag FYI I am looking at this now. I suspect a dequeue_pushable_task() probably found its way inside a conditional for GROUP_SCHED and inadventently gets compiled away if you disable the feature.=20 Investigating now..
Sep 29, 11:13 am 2008
Gregory Haskins
Re: [BUG][PPC64] BUG in 2.6.26.5-rt9 causing Hang
Hi Chirag Call me an LTP newbie, but where can I get the sbrk_mutex/async_handler tests. I installed the LTP rpm and I dont seem to have tests by that name. I have a 26.5-rt9 kernel all configured and ready to go but no way to reproduce this issue. Please advise. Regards,
Sep 29, 2:18 pm 2008
Gregory Haskins
Re: [BUG][PPC64] BUG in 2.6.26.5-rt9 causing Hang
Ok, I figured out this part. I needed a newer version of the .rpm from a different repo. However, both async_handler and sbrk_mutex seem to segfault for me. Hmm --- ghaskins@test:~> uname -a Linux test 2.6.26.5-rt9-rt #1 SMP PREEMPT RT Mon Sep 29 14:26:45 EDT 2008 x86_64 x86_64 x86_64 GNU/Linux test:/home/ghaskins # /usr/lib64/ltp/testcases/realtime/func/async_handler/async_handler ----------------------------------- Asynchronous Event Handling ...
Sep 29, 2:34 pm 2008
Frédéric Weisbecker Sep 29, 2:29 am 2008
FUJITA Tomonori
Re: [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of mem ...
On Mon, 29 Sep 2008 10:56:47 +0200 I'm not sure we are talking about the same thing. Surely, I and Joerg are talking different things. GART driver doesn't need to use the IOMMU hardware at all times. GART does a virtual mapping only when necessary (a device needs to handle an address that it can't access to). But as I wrote, if you use iommu=force, GART driver always use the IOMMU hardware. Other x86 IOMMU drivers always use the IOMMU hardware. Except for Intel VT-D, they manage free ...
Sep 29, 7:11 am 2008
Ingo Molnar
Re: [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of mem ...
yes - could you please make a new option for it, CONFIG_IOMMU_DEBUG_FORCE=y or so - and cover all iommus that support it? Ingo --
Sep 29, 1:56 am 2008
Pallipadi, Venkatesh
RE: [PATCH 7/7] x86: print out irq nr for msi/ht -v2
Doesn't look like this patch is doing anything with respect to "hpet compiling". It is just adding some debug prints. I guess we need a better patch description. Thanks, Doesn't look like the patch below is doing anything with respect to "hpet compiling". It is just adding some debug prints. I guess we need a different patch description. Thanks, --
Sep 29, 10:45 am 2008
Cyrill Gorcunov
Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2
[Jesse Barnes - Mon, Sep 29, 2008 at 10:05:02AM -0700] | On Saturday, September 27, 2008 12:02 pm Cyrill Gorcunov wrote: | > [Ingo Molnar - Sat, Sep 27, 2008 at 08:53:06PM +0200] | > | > ... | > | > A bit offtopic...well...completely offtopic I would say :) | > | > Ingo maybe you have any PCI specs? I've asked several people | > for this. Peter adviced to ask HW vendors but I don't have | > friends who has access to a such docs. Evgeniy Polyakov | > promised to ask someone but I think there ...
Sep 29, 10:29 am 2008
Grant Grundler
Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2
Not probably. You will find them that way. It is illegal for anyone to redistribute PCISIG copyrighted documents. That hasn't stopped it from happening. I've pointed this out in the past (and got a polite "please don't point that out again publicly"). +1 --
Sep 29, 12:57 pm 2008
Jesse Barnes
Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2
I think if you use google you can find the PCI spec in pdf form (search for pci pdf probably). The MindShare books are also quite good, and cover PCI, PCI-X, and PCI Express in great detail (far more readable than the spec too). -- Jesse Barnes, Intel Open Source Technology Center --
Sep 29, 10:05 am 2008
KAMEZAWA Hiroyuki
Re: [PATCH 0/12] memcg updates v5
On Mon, 29 Sep 2008 08:32:07 +0530 I'll add -EBUSY behavior to force_empty. I'm now adding(merging) code to move_account.patch for supporing force_empty. Thanks. no major changes in my current stack from already posted one. Thanks, --
Sep 28, 8:27 pm 2008
Balbir Singh
Re: [PATCH 0/12] memcg updates v5
Yes a long way to go, I want to add 1) Multi-hierarchy support 2) Support for soft-limits 3) get swappiness working (there are patches posted for it by Yamamoto-San, but -- Balbir --
Sep 28, 8:02 pm 2008
Benjamin Herrenschmidt
Re: Fix PCI in Holly device tree
I've picked it up, I need to check a thing or two and I'll send patches for .27 to Linus tomorrow (Paulus is on vacation for a week). With a bit of luck he won't have closed .27 before that :-) Cheers Ben. --
Sep 29, 1:53 am 2008
Magnus Damm
Re: [patch 2.6.27-rc7] gpiolib: request/free hooks
In the SuperH case GPIO pin direction selection is done in the same way as selecting pin function. So in and out directions can be seen as two pin functions. And since we want to support GPIO pin direction we may as well support setting pin functions as well. Thank you! / magnus --
Sep 28, 8:48 pm 2008
David Brownell
Re: [patch 2.6.27-rc7] gpiolib: request/free hooks
Just don't expect the GPIO framework to address the problem of how to configure one of those pins for a non-GPIO function. Such pinmux problems deserve different programming interfaces. ... after I come up with a happy fix for the locking goofs; those new methods may not be called under spinlock protection. - Dave --
Sep 29, 10:21 am 2008
Ingo Molnar
Re: [PATCH] x86_64: be less annoying on boot
applied to tip/x86/debug, thanks Diego. If anyone can see other too-verbose-bootup-message annoyances during default distro bootups, please send patches. Ingo --
Sep 29, 1:06 am 2008
Nicolas Pitre
Re: [PATCH 1/2] MN10300: Move asm-arm/cnt32_to_63.h to i ...
Nope. That disables preemption which is against the purpose of this That's to ensure that __x.hi is always (re)read before __x.lo, and not factorized out of a possible outer loop if gcc felt like doing such an optimization. However I didn't want other unrelated variables to be affected by an undiscriminating barrier(). But that's a weak argument as I suspect in most case inserting a barrier() between the 2 reads will But again, the original code had no such restriction. It works ...
Sep 28, 6:42 pm 2008
Nicolas Pitre Sep 28, 6:21 pm 2008
Todor Gyumyushev
Re: bug report
Tejun Heo wrote: > Simon Holm Th
Sep 29, 1:30 am 2008
Tejun Heo
Re: bug report
Hmm... This shouldn't happen. Can you please attach full kernel log including the boot messages? Thanks. -- tejun --
Sep 28, 6:36 pm 2008
Kentaro Takeda
Re: [TOMOYO #9 (2.6.27-rc7-mm1) 1/6] LSM adapter functions.
Do you mean that we should move DAC code to all the caller of vfs_* ? If we move DAC code to the caller of vfs_*(), we need not to introduce seucrity_path_*() because we can move security_inode_*() together. Furthermore, each filesystem must perform DAC by itself. It There are two approaches to perform DAC before MAC using security_path_*(). One is cloning DAC functions in security/security.c . The other is modifying fs/namei.c to make DAC functions visible to security/security.c . Which ...
Sep 28, 9:04 pm 2008
Tino Keitel
Re: Regression in 2.6.27-rc7: Wake On LAN with sky2 broken
With the attached patch, WOL works as intended the hang also didn't happen. Thanks and regards, Tino --
Sep 29, 2:18 pm 2008
Martin K. Petersen
Re: [PATCH] md: Add support for data integrity to MD
>>>>> "Neil" == Neil Brown <neilb@suse.de> writes: Neil> But what if we subsequently add a different device to that array Neil> which uses a different protection format. Would we be able to Neil> tell the filesystem that integrity protection isn't available Neil> any more? Or can we detect if the filesystem is using integrity Neil> protection, and reject the new device if it doesn't match? Generally the filesystem will look at the block device's integrity profile every time it prepares an ...
Sep 29, 7:51 am 2008
Pardo
Re: Faster getcpu() and sched_getcpu()
>[Maybe disable frame pointers for vsyscall.c and the vdso?] IIRC, some vsyscall.c code needs them enabled, so Dean's earlier patch split vsyscall.c, creating a vsyscall_user.c for code which can run without them. Seem reasonable? --
Sep 29, 11:02 am 2008
Andi Kleen
Re: Faster getcpu() and sched_getcpu()
Ok frame pointers are always a performance disasters on some CPUs. Perhaps they should be just unconditionally disabled for vsyscall.c and the vdso -Andi -- ak@linux.intel.com --
Sep 29, 7:54 am 2008
dean gaudet
Re: Faster getcpu() and sched_getcpu()
it depends on the processor involved and the kernel config options -- i.e. if frame pointers are enabled then the stack frame guarantees a store operation (push rbp) and on processors which do memops in-order this delays the other memops in the vsyscall (i.e. testing the cache or executing SIDT). it was 2 or 3 cycles difference in most cases iirc. -dean --
Sep 29, 12:27 am 2008
Tino Keitel
Re: Wakeup from suspend via keyboard and mouse doesn't w ...
On Fri, Sep 26, 2008 at 00:35:08 +0200, Rafael J. Wysocki wrote: Yes, with this patch wakeup using the keyboard works as it did with 2.6.26. Thanks and regards, Tino --
Sep 29, 2:19 pm 2008
Rafael J. Wysocki
Re: Wakeup from suspend via keyboard and mouse doesn't w ...
Thanks for testing. Can you also check if this patch is sufficient to fix the sky2 issue, or if you need the patch I sent in the sky2 thread in addition to it? Thanks, Rafael --
Sep 29, 2:58 pm 2008
Muli Ben-Yehuda
Re: [PATCH 9/9] x86/iommu: use dma_ops_list in get_dma_ops
We could be, if we add a check to the register function that verifies it isn't being called after DMAs have started. Something like: in register: if (dma_started) yell loudly before PCI device initialization and after IOMMU initialization: dma_started = true Cheers, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ xxx SYSTOR 2009---The Israeli Experimental Systems ...
Sep 29, 2:25 am 2008
Joerg Roedel
Re: [PATCH 0/9][RFC] stackable dma_ops for x86
Yes. But mind that this patchset adds complexity to one point (at dma_ops initialization) while we can avoid and remove it Sure. Therefore this patchset is RFC and I cc'ed them. Joerg -- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD ...
Sep 29, 6:51 am 2008
FUJITA Tomonori
Re: [PATCH 9/9] x86/iommu: use dma_ops_list in get_dma_ops
On Mon, 29 Sep 2008 11:36:52 +0200 Nobody cares about the performance of dma_alloc_coherent. Only the performance of map_single/map_sg matters. I'm not sure how expensive the hypercalls are, but they are more expensive than bounce buffering coping lots of data for every I/Os? --
Sep 29, 6:16 am 2008
Joerg Roedel
Re: [PATCH 9/9] x86/iommu: use dma_ops_list in get_dma_ops
I don't think that we can avoid bounce buffering into the guests at all (with and without my idea of a paravirtualized IOMMU) when we want to handle dma_masks and requests that cross guest physical pages properly. With mapping/unmapping through hypercalls we add the world-switch overhead to the copy-overhead. We can't avoid this when we have no hardware support at all. But already with older IOMMUs like Calgary and GART we can at least avoid the world-switch. And since, for example, every 64 ...
Sep 29, 6:33 am 2008
Joerg Roedel
Re: [PATCH 9/9] x86/iommu: use dma_ops_list in get_dma_ops
The bounce buffering is needed for map_single/map_sg allocations. For dma_alloc_coherent we can directly allocate from that range. The performance loss of the bounce buffering may be lower than the hypercalls we need as the alternative (we need hypercalls for map, unmap and sync). Joerg --
Sep 29, 2:36 am 2008
Joerg Roedel
Re: [PATCH 0/9][RFC] stackable dma_ops for x86
Ok, the name "stackable" is misleading and was a bad choice. I will rename it to "multiplexing". This should make it more clear what it is. Like you pointed out, the problems are solved with per-device dma_ops, but in the current implementation it needs special hacks in the IOMMU drivers to use these per-device dma_ops. I see this patchset as a continuation of the per-device dma_ops idea. It moves the per-device handling out of the specific drivers to a common place. So we can avoid or remove ...
Sep 29, 6:26 am 2008
FUJITA Tomonori
Re: [PATCH 0/9][RFC] stackable dma_ops for x86
On Sun, 28 Sep 2008 20:49:26 +0200 I know that. As I wrote in the previous mail, we already solved that problem with per-device-dma-ops. My question is what unsolved problems this patchset can fix? This patchset is named "stackable dma_ops" but it's different from what we discussed as "stackable dma_ops". This patchset provides IOMMUs a generic mechanism to set up "stackable dma_ops". But this patchset doesn't solve the problem that a hardware IOMMU does not handle all devices (it was ...
Sep 29, 6:16 am 2008
Muli Ben-Yehuda Sep 29, 2:30 am 2008
FUJITA Tomonori
Re: [PATCH 0/9][RFC] stackable dma_ops for x86
On Mon, 29 Sep 2008 15:26:47 +0200 Basically, I'm not against this patchset. It simplify Calgary and AMD IOMMUs code to set up per-device-dma-ops (though it makes dma_ops a bit complicated). But it doesn't solve any problems including the paravirtualized device passthrough. When I wrote per-device-dma-ops, I expected that KVM people want more changes (such as stackable dma_ops) to dma_ops for the paravirtualized device passthrough. I'd like to hear what they want first. --
Sep 29, 6:42 am 2008
Joerg Roedel
Re: [PATCH 9/9] x86/iommu: use dma_ops_list in get_dma_ops
Good idea. I will change this in my patchset, thanks. Joerg --
Sep 29, 2:29 am 2008
Tejun Heo
Re: exception Emask 0x0 SAct 0x1 / SErr 0x0 action 0x2 frozen
Can you post full kernel log including the boot messages and the error messages? Also, please attach the output of hdparm -I on the drive which fails the smart command. (cc'ing Bruce, hi!) Bruce, this is the second report I see about drive timing out SMART ENABLE OPERATIONS. Does anything ring a bell? Thanks. -- tejun --
Sep 29, 1:13 am 2008
Srinivasa DS
Re: [RFC][PATCH] Demultiplexing SIGTRAP signal -v2
Roland That sounds like a good idea. Let me go through code and get back to you. Thanks Srinivasa DS --
Sep 29, 6:34 am 2008
Pavel Machek
Re: [RFC] List of maintainers (draft #3)
Yes please. Manually searching MAINTAINERS is boring and hard... 'Is it NETWORK BLOCK DEVICE' or 'NBD'? 'ALSA' or 'ADVANCED LINUX SOUND SYSTEM'? ... plus if you want subsystem maintainer, search tends to give you about 179 individual driver maintainers, first. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Sep 29, 10:56 am 2008
Martin K. Petersen
Re: [dm-devel] [PATCH 2/2] dm: Add support for data inte ...
>>>>> "Kiyoshi" == Kiyoshi Ueda <k-ueda@ct.jp.nec.com> writes: Kiyoshi> Creating another function (e.g. dm_table_set_integrity(t, Kiyoshi> md)) may be better, since then you wouldn't need dm_queue() Kiyoshi> nor need to change the function interface of Kiyoshi> dm_table_set_restrictions() I think. You are right. Originally I had more reasons for having that calling interface change but that's no longer the case. I'll fan the integrity bits out to a separate function. -- Martin K. ...
Sep 29, 8:05 am 2008
Ingo Molnar
Re: How how latent should non-preemptive scheduling be?
hm, that's weird indeed. You could try to trace the full battery readout itself, via a script like this: cat /debug/tracing/trace > /dev/null # drain trace cat /proc/acpi/whatever cat /debug/tracing/trace > trace.txt this way you should be seeing a full trace of the whole thing. (with the 'ftrace' tracer plugin set in current_tracer) then, assuming the trace.txt is complete, you can check where it reschedules and why. Search for 'schedule' calls. Compare the debug ...
Sep 29, 1:37 am 2008
Sitsofe Wheeler
Re: How how latent should non-preemptive scheduling be?
(Something bad seems to be happening with my kernels as I have been finding strange problems like network-manager detecting the wifi as a wired interface unless I did a make clean on my kernel sources before compiling). The stalling issue seems to keep coming and going and is currently showing up in both debug and non debug kernels. There are traces when looking at battery information on both AC (where the problem is never there) and battery (where the problem always is there) ...
Sep 29, 4:11 pm 2008
Chris Friesen
Re: unpredictability in scheduler test results -- still ...
Just enabling it in the .config is enough to trigger the behaviour change. I'm not explicitly activating any traces. Chris --
Sep 29, 8:43 am 2008
Pavel Emelyanov
Re: dm-ioband + bio-cgroup benchmarks
If by "fairly share the given bandwidth" you mean "share according to their IO-nice values" then you're right on this, Hirokazu. We always use a two-level schedulers and would like to see the same behavior in anything that will be --
Sep 29, 5:13 am 2008
Hirokazu Takahashi
Re: dm-ioband + bio-cgroup benchmarks
This is possible but I wonder if this is really the way we should go. It looks like you tried implementing another ioctl-like interface on the cgroup control file interface. You can do anything you want with this interface though. I guess there should be at least some rules to implement this kind of ioctl-like interface if they don't want to enhance the cgroup interface, Thank you, Hirokazu Takahashi. --
Sep 29, 3:40 am 2008
Hirokazu Takahashi
Re: dm-ioband + bio-cgroup benchmarks
I ever thought the same thing but this approach breaks the compatibility. I think we should make ionice only effective for the processes in the same cgroup. A system gives some amount of bandwidths to its cgroups, and the processes in one of the cgroups fairly share the given bandwidth. I think this is the straight approach. What do you think? I think all the CFQ-cgroup the NEC guys are working, OpenVZ team's CFQ scheduler and dm-ioband with bio-cgroup work like this. Thank ...
Sep 29, 5:07 am 2008
Tejun Heo
Re: libata flooding syslog
Sorry about the delay. I've been traveling for quite some time. The bug is being tracked via the following bugzilla bug and patch has been posted. http://bugzilla.kernel.org/show_bug.cgi?id=11615 Thanks. -- tejun --
Sep 28, 5:02 pm 2008
Stephen Smalley
Re: [Bug #11500] /proc/net bug related to selinux
FWIW, a fix for this issue has been applied to: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next The particular commit can be viewed at: http://git.kernel.org/?p=linux/kernel/git/jmorris/security-testing-2.6.git;a=commit;h=... This should address not only the /proc/net breakage but also any future changes to turn existing directories into symlinks. -- Stephen Smalley National Security Agency --
Sep 29, 9:49 am 2008
Christoph Hellwig
Re: [PATCH 3/3] Add timeout feature
But why would the filesystem every unfreeze itself? That defeats the whole point of freezing it. --
Sep 29, 7:37 am 2008
Takashi Sato
Re: [PATCH 3/3] Add timeout feature
Hi Ric and Christoph, Thank you for your comments. Christoph, do you have any comments about this solution? If it's OK, I will change the freeze patch so that the unfreeze ioctl sets ETIMEDOUT to errno when the timeout occurs. Cheers, Takashi --
Sep 29, 4:11 am 2008
jim owens
Re: [PATCH 3/3] Add timeout feature
Eric Sandeen wrote: > Christoph Hellwig wrote: >> But why would the filesystem every unfreeze itself? That defeats the >> whole point of freezing it. > > I agree. Was just trying to clarify the above point. > > But there have been what, 12 submissions now, with the unfreeze timeout > in place so it's a persistent theme ;) > > Perhaps a demonstration of just how easy (or not easy) it is to deadlock > a filesystem by freezing the root might be in order, at least. > > And even ...
Sep 29, 3:08 pm 2008
Eric Sandeen
Re: [PATCH 3/3] Add timeout feature
I agree. Was just trying to clarify the above point. But there have been what, 12 submissions now, with the unfreeze timeout in place so it's a persistent theme ;) Perhaps a demonstration of just how easy (or not easy) it is to deadlock a filesystem by freezing the root might be in order, at least. And even if it is relatively easy, I still maintain that it is the administrator's role to not inflict damage on the machine being administered. There are a lot of potentially dangerous tools ...
Sep 29, 7:45 am 2008
Eric Sandeen
Re: [PATCH 3/3] Add timeout feature
The suggestion was that *UN*freeze would return ETIMEDOUT if the filesystem had already unfrozen itself, I think. That way you know that the snapshot you just took is worthless, at least. I'm still not really sold on the timeout, but I think the above was the intent. -Eric --
Sep 29, 7:36 am 2008
Christoph Hellwig
Re: [PATCH 3/3] Add timeout feature
What timeout should happen? the freeze ioctl must not return until the filesystem is a clean state and all writes are blocked. --
Sep 29, 7:13 am 2008
Rafael J. Wysocki
[PATCH 4/6] SATA AHCI: Blacklist system that spins off d ...
From: Rafael J. Wysocki <rjw@sisk.pl> SATA AHCI: Blacklist system that spins off disks during ACPI power off Some notebooks from HP have the problem that their BIOSes attempt to spin down hard drives before entering ACPI system states S4 and S5. This leads to a yo-yo effect during system power-off shutdown and the last phase of hibernation when the disk is first spun down by the kernel and then almost immediately turned on and off by the BIOS. This, in turn, may result in shortening the ...
Sep 29, 3:15 pm 2008
Rafael J. Wysocki
[PATCH 6/6] SATA PIIX: Blacklist system that spins off d ...
From: Rafael J. Wysocki <rjw@sisk.pl> SATA PIIX: Blacklist system that spins off disks during ACPI power off Some notebooks from HP have the problem that their BIOSes attempt to spin down hard drives before entering ACPI system states S4 and S5. This leads to a yo-yo effect during system power-off shutdown and the last phase of hibernation when the disk is first spun down by the kernel and then almost immediately turned on and off by the BIOS. This, in turn, may result in shortening the ...
Sep 29, 3:18 pm 2008
Rafael J. Wysocki
[PATCH 0/6] SATA: Blacklist systems that spin off disks ...
Here you go (sorry for the delay). I have also split the SATA changes so that the driver patches are droppable individually if there are problems with them (not anticipated). Thanks, Rafael --- SATA: Blacklist systems that spin off disks during ACPI power off Some notebooks from HP have the problem that their BIOSes attempt to spin down hard drives before entering ACPI system states S4 and S5. This leads to a yo-yo effect during system power-off shutdown and the last phase of ...
Sep 29, 3:06 pm 2008
Rafael J. Wysocki
[PATCH 3/6] SATA: Blacklisting of systems that spin off ...
From: Rafael J. Wysocki <rjw@sisk.pl> SATA: Blacklisting of systems that spin off disks during ACPI power off Introduce new libata flags ATA_FLAG_NO_POWEROFF_SPINDOWN and ATA_FLAG_NO_HIBERNATE_SPINDOWN that, if set, will prevent disks from being spun off during system power off and hibernation, respectively (to handle the hibernation case we need the new system state SYSTEM_HIBERNATE_ENTER that can be checked against by libata, in analogy with SYSTEM_POWER_OFF). Signed-off-by: Rafael J. ...
Sep 29, 3:14 pm 2008
Rafael J. Wysocki
[PATCH 1/6] Hibernation: Introduce new system state for ...
From: Rafael J. Wysocki <rjw@sisk.pl> Hibernation: Introduce new system state for the last phase of hibernation Replace unused SYSTEM_SUSPEND_DISK with a new system_state value SYSTEM_HIBERNATE_ENTER that can be used by device drivers to check if the system is in the last phase of hibernation. In particular, some SATA drivers are going to use it for blacklisting systems in which the disks should not be spun down during the last phase of hibernation (the BIOS will do that ...
Sep 29, 3:10 pm 2008
Rafael J. Wysocki
[PATCH 2/6] DMI: Introduce dmi_first_match to make the i ...
From: Rafael J. Wysocki <rjw@sisk.pl> DMI: Introduce dmi_first_match to make the interface more flexible Some notebooks from HP have the problem that their BIOSes attempt to spin down hard drives before entering ACPI system states S4 and S5. This leads to a yo-yo effect during system power-off shutdown and the last phase of hibernation when the disk is first spun down by the kernel and then almost immediately turned on and off by the BIOS. This, in turn, may result in shortening the disk's ...
Sep 29, 3:13 pm 2008
Rafael J. Wysocki
[PATCH 5/6] SATA Sil: Blacklist system that spins off di ...
From: Rafael J. Wysocki <rjw@sisk.pl> SATA Sil: Blacklist system that spins off disks during ACPI power off Some notebooks from HP have the problem that their BIOSes attempt to spin down hard drives before entering ACPI system states S4 and S5. This leads to a yo-yo effect during system power-off shutdown and the last phase of hibernation when the disk is first spun down by the kernel and then almost immediately turned on and off by the BIOS. This, in turn, may result in shortening the disk's ...
Sep 29, 3:16 pm 2008
Jeff Garzik Sep 28, 9:34 pm 2008
Mike Travis
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmal ...
I will, and the full "allyesconfig" does compile. And it's basically a benign change in that the functionality is still the same. I'm currently reordering it a bit to clean it up. Thanks, Mike --
Sep 29, 7:33 am 2008
Tejun Heo
Re: Another one for fixup-storage
Can you please attach the result of "smartctl -a" output? Thanks. -- tejun --
Sep 29, 12:22 am 2008
Robert Krawitz
Re: Another one for fixup-storage
Date: Mon, 29 Sep 2008 16:22:51 +0900 From: Tejun Heo <tj@kernel.org> Robert Krawitz wrote: > This is for a Dell Inspiron E1705/9400. I'm using a non-OEM disk (a > Hitachi 320 GB drive). > > Note that matching on "MP061" doesn't work -- it needs to be "MP061*" > due to the way dmidecode seems to return the data (with a bunch of > spaces after the tag). Hence I've attached the data rather than merely > > I've only had this thing a month or so and already ...
Sep 29, 4:41 am 2008
Jeff Garzik Sep 28, 9:17 pm 2008
previous daytodaynext day
September 28, 2008September 29, 2008September 30, 2008