Home » Mailing list archives » linux-kernel » 2008 » September » 29

Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

Previous thread: [PATCH] eCryptfs: Remove netlink transport by Tyler Hicks on Monday, September 29, 2008 - 3:16 pm. (1 message)

Next thread: Re: [RFC PATCH 0/4] Implementation of IR support using the input subsystem by Emmanuel Fusté on Monday, September 29, 2008 - 3:18 pm. (4 messages)
[view original message]
From: Karol Lewandowski
Subject: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume
Date: Monday, September 29, 2008 - 3:16 pm

Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21
to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output
fn-f7, etc.) after resume.

It's regression from 2.6.25.  2.6.26 and 2.6.27-rc7 are broken,
reverting that commit on 2.6.27-rc7 makes keys work again.

Thanks.

[Rafael added for regression tracking ;]


commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Fri Jun 6 11:49:33 2008 -0400

    ACPI: EC: Use msleep instead of udelay while waiting for event.
    
    http://bugzilla.kernel.org/show_bug.cgi?id=10724
    
    Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
    Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 0924992..5622aee 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -194,7 +194,7 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll)
 		while (time_before(jiffies, delay)) {
 			if (acpi_ec_check_status(ec, event))
 				return 0;
-			udelay(ACPI_EC_UDELAY);
+			msleep(1);
 		}
 	}
 	pr_err(PREFIX "acpi_ec_wait timeout, status = 0x%2.2x, event = %s\n",


--


[ message continues ]
[view original message]
From: Rafael J. Wysocki
Subject: Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume
Date: Monday, September 29, 2008 - 3:25 pm

Can you see if the patch at
http://bugzilla.kernel.org/attachment.cgi?id=18044&action=view
(against current -git) helps?

Thanks,
Rafael
--


[ message continues ]
[view original message]
From: Karol Lewandowski
Subject: Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume
Date: Monday, September 29, 2008 - 4:40 pm

It doesn't help (and -rc8 doesn't help either).

Thanks.
--


[ message continues ]
[view original message]
From: Alexey Starikovskiy
Subject: Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume
Date: Monday, September 29, 2008 - 9:46 pm

could you please uncomment "#define DEBUG" in the beginning of drivers/acpi/ec.c?
please also open bug report in bugzilla.kernel.org against ACPI and
attach dmesg from working and broken kernel with enabled DEBUG.
Let me know the number of bug report.
Thanks,
Alex.
--


[ message continues ]
[view original message]
From: Karol Lewandowski
Subject: Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume
Date: Tuesday, September 30, 2008 - 7:08 am

It's http://bugzilla.kernel.org/show_bug.cgi?id=11674

Thanks.
--


[ message continues ]
Previous thread: [PATCH] eCryptfs: Remove netlink transport by Tyler Hicks on Monday, September 29, 2008 - 3:16 pm. (1 message)

Next thread: Re: [RFC PATCH 0/4] Implementation of IR support using the input subsystem by Emmanuel Fusté on Monday, September 29, 2008 - 3:18 pm. (4 messages)