BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alexey Starikovskiy <astarikovskiy@...>
Cc: Len Brown <len.brown@...>, Rafael J. Wysocki <rjw@...>, <linux-kernel@...>
Date: Monday, September 29, 2008 - 6:16 pm

Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21
to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output
fn-f7, etc.) after resume.

It's regression from 2.6.25.  2.6.26 and 2.6.27-rc7 are broken,
reverting that commit on 2.6.27-rc7 makes keys work again.

Thanks.

[Rafael added for regression tracking ;]


commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Fri Jun 6 11:49:33 2008 -0400

    ACPI: EC: Use msleep instead of udelay while waiting for event.
    
    http://bugzilla.kernel.org/show_bug.cgi?id=10724
    
    Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
    Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 0924992..5622aee 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -194,7 +194,7 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll)
 		while (time_before(jiffies, delay)) {
 			if (acpi_ec_check_status(ec, event))
 				return 0;
-			udelay(ACPI_EC_UDELAY);
+			msleep(1);
 		}
 	}
 	pr_err(PREFIX "acpi_ec_wait timeout, status = 0x%2.2x, event = %s\n",


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes s..., Karol Lewandowski, (Mon Sep 29, 6:16 pm)
Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a mak..., Rafael J. Wysocki, (Mon Sep 29, 6:25 pm)
Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a mak..., Karol Lewandowski, (Mon Sep 29, 7:40 pm)
Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a mak..., Alexey Starikovskiy, (Tue Sep 30, 12:46 am)
Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a mak..., Karol Lewandowski, (Tue Sep 30, 10:08 am)