Re: [RFC PATCH] LTTng relay buffer allocation, read, write

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Steven Rostedt
Date: Monday, September 29, 2008 - 12:54 pm

On Mon, 29 Sep 2008, Steven Rostedt wrote:

I forgot to mention one important detail. The "head" index will stay
on the page frame. That way we do not need to figure out which 
head_page we are on. We grab the head_page, we atomically 
(local_inc_return) the head pointer on that page. If the return value is 
still on the page, we succeeded. We can also increment a value on this 
page frame that will prevent recording if we somehow overflowed the buffer 
before relinquishing the stack.

That is

  reserve_event()

     IRQ->
            reserve_event();

      [...]

     IRQ->reserve_event() came back to original head!

      Here we do not have a big enough buffer, and this is just stupid ;-)
      We would drop packets in this case, and should drop the guy on his
      head who came up with the too small buffer.

-- Steve

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Sat Sep 27, 6:40 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Peter Zijlstra, (Sat Sep 27, 10:10 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Peter Zijlstra, (Sun Sep 28, 1:59 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Mon Sep 29, 8:50 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Mon Sep 29, 9:06 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Steven Rostedt, (Mon Sep 29, 9:38 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Peter Zijlstra, (Mon Sep 29, 10:30 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Mon Sep 29, 11:38 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Steven Rostedt, (Mon Sep 29, 12:40 pm)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Steven Rostedt, (Mon Sep 29, 12:54 pm)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Mon Sep 29, 1:31 pm)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Steven Rostedt, (Mon Sep 29, 2:24 pm)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Tue Sep 30, 11:14 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Steven Rostedt, (Tue Sep 30, 11:22 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Tue Sep 30, 11:35 am)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Steven Rostedt, (Tue Sep 30, 12:43 pm)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Tue Sep 30, 12:54 pm)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Frank Ch. Eigler, (Tue Sep 30, 1:01 pm)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Steven Rostedt, (Tue Sep 30, 1:21 pm)
Re: [RFC PATCH] LTTng relay buffer allocation, read, write, Mathieu Desnoyers, (Tue Sep 30, 1:55 pm)