Home » Mailing list archives » linux-kernel » 2008 » September » 29

[PATCH] Don't print an error message just because there's no i8042 chip

Previous thread: [PATCH -tip 4/4] Tracing/ftrace: adapt the boot tracer to the new print_line type by Frederic Weisbecker on Monday, September 29, 2008 - 11:31 am. (1 message)

Next thread: [PATCH] x86: IOMMU setup failures should not be KERN_ERR by Adam Jackson on Monday, September 29, 2008 - 11:52 am. (2 messages)
[view original message]
From: Adam Jackson
Subject: [PATCH] Don't print an error message just because there's no i8042 chip
Date: Monday, September 29, 2008 - 11:36 am

From: Peter Jones <pjones@redhat.com>

Some systems, such as EFI-based Apple systems, won't necessarily have an
i8042 to initialize.  We shouldn't be printing an error message in this
case, since not detecting the chip is the correct behavior.

Signed-off-by: Adam Jackson <ajax@redhat.com>
---
 drivers/input/serio/i8042.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 170f71e..4f3e632 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -701,10 +701,8 @@ static int __devinit i8042_check_aux(void)
 
 static int i8042_controller_check(void)
 {
-	if (i8042_flush() == I8042_BUFFER_SIZE) {
-		printk(KERN_ERR "i8042.c: No controller found.\n");
+	if (i8042_flush() == I8042_BUFFER_SIZE)
 		return -ENODEV;
-	}
 
 	return 0;
 }
-- 
1.6.0.1

--


[ message continues ]
Previous thread: [PATCH -tip 4/4] Tracing/ftrace: adapt the boot tracer to the new print_line type by Frederic Weisbecker on Monday, September 29, 2008 - 11:31 am. (1 message)

Next thread: [PATCH] x86: IOMMU setup failures should not be KERN_ERR by Adam Jackson on Monday, September 29, 2008 - 11:52 am. (2 messages)