login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
September
»
29
Re: [PATCH] x86: do not allow to optimize flag_is_changeable_p()
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: H. Peter Anvin
Subject:
Re: [PATCH] x86: do not allow to optimize flag_is_changeable_p()
Date: Monday, September 29, 2008 - 11:17 am
Krzysztof Helt wrote:
quoted text
> From: Krzysztof Helt <krzysztof.h1@wp.pl> > > The flag_is_changeable_p() is used by > has_cpuid_p() which can return different results > in the code sequence below: > > if (!have_cpuid_p()) > identify_cpu_without_cpuid(c); > > /* cyrix could have cpuid enabled via c_identify()*/ > if (!have_cpuid_p()) > return; > > Otherwise, the gcc 3.4.6 optimizes these two calls > into one which make the code not working correctly. > Cyrix cpus have the CPUID instruction enabled but > it is not detected due to the gcc optimization. > Thus the ARR registers (mtrr like) are not detected > on such a cpu. >
I suspect we should also out-of-line this function. It's actually relatively sizable and certainly there is no point in inlining it. -hpa --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] x86: do not allow to optimize flag_is_changeable_p()
, Krzysztof Helt
, (Mon Sep 29, 11:06 am)
Re: [PATCH] x86: do not allow to optimize flag_is_changeab ...
, H. Peter Anvin
, (Mon Sep 29, 11:17 am)
Re: [PATCH] x86: do not allow to optimize flag_is_changeab ...
, Jeremy Fitzhardinge
, (Mon Sep 29, 11:14 pm)
Re: [PATCH] x86: do not allow to optimize flag_is_changeab ...
, Yinghai Lu
, (Mon Sep 29, 11:34 pm)
Re: [PATCH] x86: do not allow to optimize flag_is_changeab ...
, Jeremy Fitzhardinge
, (Mon Sep 29, 11:54 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Francis Moreau
Re: Disk geometry from /sys
Rafael J. Wysocki
[Bug #11407] suspend: unable to handle kernel paging request
Christoph Lameter
Re: [bug] SLUB + mm/slab.c boot crash in -rc9
Jeremy Fitzhardinge
Re: [2.6.25] compat VDSO option not disabling
Rafael J. Wysocki
[Bug #11551] Semi-repeatable hard lockup on 2.6.27-rc6
git
:
Pat Thoyts
[PATCH] git-gui: use themed tk widgets with Tk 8.5
Tait
Re: [PATCH] Replace hard-coded path with one from <paths.h>
Frans Pop
'git gc --aggressive' effectively unusable
Stephan Beyer
Re: git sequencer prototype
Lynn Lin
Re: clearcase migration to git
linux-netdev
:
William Allen Simpson
[net-next-2.6 PATCH v8 0/7] TCPCT part 1: cookie option exchange
Eric Dumazet
Re: [PATCH net-next-2.6] net: Introduce skb_orphan_try()
David Miller
Re: [PATCH] IPv6: preferred lifetime of address not getting updated
Eric Dumazet
Re: [PATCH net-next-2.6] net: Introduce skb_orphan_try()
Mark McLoughlin
Re: [PATCH 2/3] virtio: fix delayed xmit of packet and freeing of old packets.
git-commits-head
:
Linux Kernel Mailing List
.gitignore: ignore *.lzo files
Linux Kernel Mailing List
sparc64: Fix sun4u execute bit check in TSB I-TLB load.
Linux Kernel Mailing List
init: Open /dev/console from rootfs
Linux Kernel Mailing List
udp: fix for unicast RX path optimization
Linux Kernel Mailing List
imxfb: Fix margin settings
openbsd-misc
:
nixlists
Re: Which laptops do the developers use?
Robert
disklabel - cylinder rounding
admin
Drive a 2009 car from R799p/m
L. V. Lammert
OT, .. but has anyone seen a crontab editor
Darrin Chandler
Re: That whole "Linux stealing our code" thing
Colocation donated by:
Syndicate