Re: [PATCH] x86_64: be less annoying on boot

Previous thread: [PATCH 1/1] Use RCU for the UDP hash lock by Corey Minyard on Wednesday, September 24, 2008 - 10:28 am. (9 messages)

Next thread: [LOCKDEP linux-2.6.27-rc7] reiserfs circular locking by Jesse Brandeburg on Wednesday, September 24, 2008 - 11:39 am. (4 messages)
From: Bill Nottingham
Date: Wednesday, September 24, 2008 - 11:35 am

As long as we're printing mostly useless messages on every boot regardless
of debug level, make them 5% more amusing.

Signed-off-by: Bill Nottingham <notting@redhat.com>

(Alternatively, just remove them, of course...)
From: Ingo Molnar
Date: Thursday, September 25, 2008 - 2:15 am

LOL :) Applied the commit below to tip/x86/debug, thanks Bill!

	Ingo

-------------------->
From f6476774f1fe32593d3d71903b1e98514efbf685 Mon Sep 17 00:00:00 2001
From: Bill Nottingham <notting@redhat.com>
Date: Wed, 24 Sep 2008 14:35:17 -0400
Subject: [PATCH] x86_64: be less annoying on boot

Remove mostly useless message on every boot.

Signed-off-by: Bill Nottingham <notting@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/head64.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index 9bfc4d7..11aa501 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/kernel/head64.c
@@ -112,8 +112,6 @@ void __init x86_64_start_kernel(char * real_mode_data)
 
 	x86_64_init_pda();
 
-	early_printk("Kernel really alive\n");
-
 	x86_64_start_reservations(real_mode_data);
 }
 

--

From: Bill Nottingham
Date: Thursday, September 25, 2008 - 9:13 am

Does the 'kernel alive' right before it serve any purpose either?

Bill
--

From: Ingo Molnar
Date: Saturday, September 27, 2008 - 11:50 am

that has some marginal use: it shows that we are past the really basic 
system setup code, we decompressed the kernel and entered protected mode 
with boot paging enabled.

we had bugs in the past where we'd hang/crash after GRUB starts us and 
before we reach this printk.

OTOH ... forcing it upon all users is strong. Feel free to send another 
patch that removes it.

	Ingo
--

From: Ingo Molnar
Date: Saturday, September 27, 2008 - 11:51 am

(Cc: added. Mail-Followup-To is evil.)

--

From: dcg
Date: Saturday, September 27, 2008 - 12:11 pm

What I find annoying about that printk is that I see it even with the "quiet"
boot flag.
--

From: Ingo Molnar
Date: Saturday, September 27, 2008 - 12:18 pm

that's a property of early_printk() - it just doesnt listen to any of 
the normal printk modifiers. (and that's the point of early_printk())

could you please send a patch that only calls that early_printk() if 
console_loglevel == 10? (i.e. if "debug" has been passed)

	Ingo
--

From: dcg
Date: Sunday, September 28, 2008 - 9:49 am

Sure, here it is.



Honour "quiet" boot parameter in early_printk() calls


Signed-off-by: Diego Calleja <diegocg@gmail.com>
---
 arch/x86/kernel/head64.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Index: 2.6/arch/x86/kernel/head64.c
===================================================================
--- 2.6.orig/arch/x86/kernel/head64.c	2008-09-27 22:54:41.000000000 +0200
+++ 2.6/arch/x86/kernel/head64.c	2008-09-27 23:14:02.000000000 +0200
@@ -108,11 +108,13 @@
 	}
 	load_idt((const struct desc_ptr *)&idt_descr);
 
-	early_printk("Kernel alive\n");
+	if (console_loglevel == 10)
+		early_printk("Kernel alive\n");
 
 	x86_64_init_pda();
 
-	early_printk("Kernel really alive\n");
+	if (console_loglevel == 10)
+		early_printk("Kernel really alive\n");
 
 	x86_64_start_reservations(real_mode_data);
 }


--

From: Ingo Molnar
Date: Monday, September 29, 2008 - 1:06 am

applied to tip/x86/debug, thanks Diego.

If anyone can see other too-verbose-bootup-message annoyances during 
default distro bootups, please send patches.

	Ingo
--

From: Andi Kleen
Date: Sunday, September 28, 2008 - 9:53 am

[Empty message]
Previous thread: [PATCH 1/1] Use RCU for the UDP hash lock by Corey Minyard on Wednesday, September 24, 2008 - 10:28 am. (9 messages)

Next thread: [LOCKDEP linux-2.6.27-rc7] reiserfs circular locking by Jesse Brandeburg on Wednesday, September 24, 2008 - 11:39 am. (4 messages)