> On Friday, September 26, 2008 11:23 am Jesse Barnes wrote:
> > On Friday, September 26, 2008 10:52 am Jesse Barnes wrote:
> > > On Friday, September 26, 2008 4:49 am Arjan van de Ven wrote:
> > > > Jiri Kosina wrote:
> > > > > On Thu, 25 Sep 2008, Brandeburg, Jesse wrote:
> > > > >> this is the current set of patches that I have to help us debug
> > > > >> and/or fix e1000e issues found during this debug effort for
> > > > >> the corrupt NVM. the "drop stats lock" - "reset swflag" patches
> > > > >> allow Thomas' patch for a mutex in the SWFLAG acquire function to
> > > > >> run without any errors.
> > > > >
> > > > > Thanks. Also Jesse Barnes' patch shouldn't be forgotten, could you
> > > > > please add it to that lineup?
> > > > >
> > > > >
http://marc.info/?l=linux-kernel&m=122237193628087&w=2
> > > >
> > > > can we (for now) also stick a WARN_ON() into that failure path? that
> > > > way we can at least catch if/when this happens more visibly..... if
> > > > it happens consistently in say the new distros we can be more
> > > > confident that we're down the right path in diagnosing the issue.
> > >
> > > I'm spinning a new one now with some debug output, stay tuned (just
> > > gotta boot my test box).
> >
> > Ok here's an updated one. Jesse (Br) can you add it to your list? If
> > the X driver really is mapping too much this should catch it, as long as
> > it goes through sysfs.
>
> Arjan pointed out I may as well just use WARN() these days. Updated patch
> attached.