Home » Mailing list archives » linux-kernel » 2008 » September » 26

Re: [PATCH v5] Unified trace buffer

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds
Subject: Re: [PATCH v5] Unified trace buffer
Date: Friday, September 26, 2008 - 10:37 am

On Fri, 26 Sep 2008, Arnaldo Carvalho de Melo wrote:

Indeed. And on some architectures 'packed' will actually mean that the 
compiler may think that it's unaligned, and then generate much worse code 
to access the fields. So if you align things anyway (and you do), then 
'packed' is the wrong thing to do.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC PATCH 1/2 v3] Unified trace buffer, Steven Rostedt, (Thu Sep 25, 11:51 am)
[RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Thu Sep 25, 6:02 pm)
Re: [RFC PATCH v4] Unified trace buffer, Masami Hiramatsu, (Thu Sep 25, 6:52 pm)
Re: [RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Thu Sep 25, 7:11 pm)
Re: [RFC PATCH v4] Unified trace buffer, Masami Hiramatsu, (Thu Sep 25, 7:47 pm)
Re: [RFC PATCH v4] Unified trace buffer, Mathieu Desnoyers, (Thu Sep 25, 8:20 pm)
Re: [RFC PATCH v4] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 12:18 am)
Re: [RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 3:45 am)
Re: [RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 3:47 am)
Re: [RFC PATCH v4] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 4:00 am)
Re: [RFC PATCH v4] Unified trace buffer, Mathieu Desnoyers, (Fri Sep 26, 9:04 am)
Re: [RFC PATCH v4] Unified trace buffer, Masami Hiramatsu, (Fri Sep 26, 9:57 am)
[PATCH v5] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 10:11 am)
Re: [RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 10:14 am)
Re: [PATCH v5] Unified trace buffer, Arnaldo Carvalho de Melo, (Fri Sep 26, 10:31 am)
Re: [PATCH v5] Unified trace buffer, Linus Torvalds, (Fri Sep 26, 10:37 am)
Re: [PATCH v5] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 10:46 am)
[PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 11:05 am)
Re: [PATCH v6] Unified trace buffer, Richard Holden, (Fri Sep 26, 11:30 am)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 11:39 am)
Re: [PATCH v6] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 11:59 am)
Re: [PATCH v6] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 12:14 pm)
Re: [PATCH v6] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 12:17 pm)
Re: [PATCH v6] Unified trace buffer, Martin Bligh, (Fri Sep 26, 12:46 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 12:52 pm)
Re: [PATCH v6] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 1:08 pm)
[PATCH v7] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 2:13 pm)
Re: [PATCH v6] Unified trace buffer, Masami Hiramatsu, (Fri Sep 26, 2:14 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 2:26 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 2:37 pm)
Re: [PATCH v6] Unified trace buffer, Mike Travis, (Fri Sep 26, 3:28 pm)
Re: [PATCH v6] Unified trace buffer, Arnaldo Carvalho de Melo, (Fri Sep 26, 3:31 pm)
Re: [PATCH v6] Unified trace buffer, Arjan van de Ven, (Fri Sep 26, 4:16 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 4:56 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 4:58 pm)
Re: [PATCH v6] Unified trace buffer, Mike Travis, (Fri Sep 26, 5:05 pm)
Re: [PATCH v6] Unified trace buffer, Linus Torvalds, (Fri Sep 26, 5:13 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 5:18 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 5:23 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 5:28 pm)
Re: [PATCH v6] Unified trace buffer, Mike Travis, (Fri Sep 26, 5:46 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 5:52 pm)
[PATCH v8] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 7:02 pm)
[PATCH v9] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 11:06 pm)
Re: [PATCH v5] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 10:02 am)
Re: [PATCH v5] Unified trace buffer, Steven Rostedt, (Sat Sep 27, 10:18 am)
Re: [PATCH v9] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 11:39 am)
Re: [PATCH v9] Unified trace buffer, Steven Rostedt, (Sat Sep 27, 12:24 pm)
Re: [PATCH v9] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 12:41 pm)
Re: [PATCH v9] Unified trace buffer, Steven Rostedt, (Sat Sep 27, 12:54 pm)
Re: [PATCH v9] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 1:00 pm)
Re: [PATCH v9] Unified trace buffer, Martin Bligh, (Sat Sep 27, 1:07 pm)
Re: [PATCH v9] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 1:34 pm)
Re: [PATCH v9] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 8:05 am)
[PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 9:10 am)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 9:11 am)
Re: [PATCH v10 Golden] Unified trace buffer, Mathieu Desnoyers, (Mon Sep 29, 4:35 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 5:01 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Mathieu Desnoyers, (Mon Sep 29, 5:03 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 5:12 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Mathieu Desnoyers, (Mon Sep 29, 8:46 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 9:00 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Jonathan Corbet, (Tue Sep 30, 8:20 am)
Re: [PATCH v10 Golden] Unified trace buffer, Peter Zijlstra, (Tue Sep 30, 8:54 am)
Re: [PATCH v10 Golden] Unified trace buffer, Linus Torvalds, (Tue Sep 30, 9:38 am)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 9:48 am)
Re: [PATCH v10 Golden] Unified trace buffer, Peter Zijlstra, (Tue Sep 30, 10:00 am)
Re: [PATCH v10 Golden] Unified trace buffer, Linus Torvalds, (Tue Sep 30, 10:01 am)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 10:41 am)
Re: [PATCH v10 Golden] Unified trace buffer, Peter Zijlstra, (Tue Sep 30, 10:49 am)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 10:56 am)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 11:02 am)
[PATCH] ring_buffer: allocate buffer page pointer, Steven Rostedt, (Wed Oct 1, 8:14 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Mathieu Desnoyers, (Wed Oct 1, 10:36 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Steven Rostedt, (Wed Oct 1, 10:49 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Mathieu Desnoyers, (Wed Oct 1, 11:21 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Ingo Molnar, (Thu Oct 2, 1:50 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Ingo Molnar, (Thu Oct 2, 1:51 am)
[PATCH] ring-buffer: fix build error, Ingo Molnar, (Thu Oct 2, 2:05 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Andrew Morton, (Thu Oct 2, 2:06 am)
[boot crash] Re: [PATCH] ring-buffer: fix build error, Ingo Molnar, (Thu Oct 2, 2:38 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Ingo Molnar, (Thu Oct 2, 2:41 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Steven Rostedt, (Thu Oct 2, 6:06 am)
Re: [boot crash] Re: [PATCH] ring-buffer: fix build error, Steven Rostedt, (Thu Oct 2, 6:16 am)
Re: [boot crash] Re: [PATCH] ring-buffer: fix build error, Steven Rostedt, (Thu Oct 2, 6:17 am)
Re: [boot crash] Re: [PATCH] ring-buffer: fix build error, Ingo Molnar, (Thu Oct 2, 8:50 am)
Re: [boot crash] Re: [PATCH] ring-buffer: fix build error, Steven Rostedt, (Thu Oct 2, 11:27 am)
Re: [boot crash] Re: [PATCH] ring-buffer: fix build error, Ingo Molnar, (Thu Oct 2, 11:55 am)
[PATCH] ring_buffer: map to cpu not page, Steven Rostedt, (Thu Oct 2, 4:18 pm)
Re: [PATCH] ring_buffer: map to cpu not page, Steven Rostedt, (Thu Oct 2, 4:36 pm)
[PATCH] x86 Topology cpu_to_node parameter check, Mathieu Desnoyers, (Thu Oct 2, 9:56 pm)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Steven Rostedt, (Thu Oct 2, 10:20 pm)
Re: [PATCH] ring_buffer: map to cpu not page, Ingo Molnar, (Fri Oct 3, 12:27 am)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Mathieu Desnoyers, (Fri Oct 3, 8:56 am)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Steven Rostedt, (Fri Oct 3, 9:26 am)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Mathieu Desnoyers, (Fri Oct 3, 10:21 am)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Steven Rostedt, (Fri Oct 3, 10:54 am)
[PATCH] topology.h define mess fix, Mathieu Desnoyers, (Fri Oct 3, 11:53 am)
RE: [PATCH] topology.h define mess fix, Luck, Tony, (Fri Oct 3, 1:14 pm)
[PATCH] topology.h define mess fix v2, Mathieu Desnoyers, (Fri Oct 3, 3:47 pm)