Re: [PATCH 0/12] memcg updates v5

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: KAMEZAWA Hiroyuki

Subject: Re: [PATCH 0/12] memcg updates v5

Date: Friday, September 26, 2008 - 3:36 am

On Fri, 26 Sep 2008 15:01:46 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

quoted text> KAMEZAWA Hiroyuki wrote:
> > On Fri, 26 Sep 2008 13:48:58 +0530
> > Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > 
> >> KAMEZAWA Hiroyuki wrote:
> >>> Hi, I updated the stack and reflected comments.
> >>> Against the latest mmotm. (rc7-mm1)
> >>>
> >>> Major changes from previous one is 
> >>>   - page_cgroup allocation/lookup manner is changed.
> >>>     all FLATMEM/DISCONTIGMEM/SPARSEMEM and MEMORY_HOTPLUG is supported.
> >>>   - force_empty is totally rewritten. and a problem that "force_empty takes long time"
> >>>     in previous version is fixed (I think...)
> >>>   - reordered patches.
> >>>      - first half are easy ones.
> >>>      - second half are big ones.
> >>>
> >>> I'm still testing with full debug option. No problem found yet.
> >>> (I'm afraid of race condition which have not been caught yet.)
> >>>
> >>> [1/12]  avoid accounting special mappings not on LRU. (fix)
> >>> [2/12]  move charege() call to swapped-in page under lock_page() (clean up)
> >>> [3/12]  make root cgroup to be unlimited. (change semantics.)
> >>> [4/12]  make page->mapping NULL before calling uncharge (clean up)
> >>> [5/12]  make page->flags to use atomic ops. (changes in infrastructure)
> >>> [6/12]  optimize stat. (clean up)
> >>> [7/12]  add support function for moving account. (new function)
> >>> [8/12]  rewrite force_empty to use move_account. (change semantics.)
> >>> [9/12]  allocate all page_cgroup at boot. (changes in infrastructure)
> >>> [10/12] free page_cgroup from LRU in lazy way (optimize)
> >>> [11/12] add page_cgroup to LRU in lazy way (optimize)
> >>> [12/12] fix race at charging swap  (fix by new logic.)
> >>>
> >>> *Any* comment is welcome.
> >> Kame,
> >>
> >> I'm beginning to review test the patches now. It would be really nice to split
> >> the development patches from the maintenance ones. I think the full patchset has
> >> too many things and is confusing to look at.
> >>
> > I hope I can do....but maybe difficult.
> > If you give me ack, 1,2,4,6, can be pushed at early stage.
> 
> I think (1) might be OK, except for the accounting issues pointed out (change in
> behaviour visible to end user again, sigh! :( ).
But it was just a BUG from my point of view...

quoted text> Is (1) a serious issue? 
considering force_empty(), it's serious.

quoted text> (2) seems OK, except for the locking change for mark_page_accessed. I am looking at
> (4) and (6) currently.
> 
Thanks,
-Kmae

quoted text> -- 
> 	Balbir
> 

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:11 pm)

[PATCH 1/12] memcg avoid accounting special mappings not o ..., KAMEZAWA Hiroyuki, (Wed Sep 24, 11:13 pm)

[PATCH 2/12] memcg move charege() call to swapped-in page ..., KAMEZAWA Hiroyuki, (Wed Sep 24, 11:14 pm)

[PATCH 3/12] memcg make root cgroup unlimited., KAMEZAWA Hiroyuki, (Wed Sep 24, 11:15 pm)

[PATCH 4/12] memcg make page->mapping NULL before calling ..., KAMEZAWA Hiroyuki, (Wed Sep 24, 11:16 pm)

[PATCH 5/12] memcg make page_cgroup->flags atomic, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:17 pm)

[PATCH 6/12] memcg optimize percpu stat, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:18 pm)

[PATCH 7/12] memcg add function to move account, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:27 pm)

[PATCH 8/12] memcg rewrite force empty to move account to root, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:29 pm)

[PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:32 pm)

[PATCH 10/12] memcg free page_cgroup from LRU in lazy, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:33 pm)

[PATCH 11/12] memcg add to LRU in lazy, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:35 pm)

[PATCH 12/12] memcg: fix race at charging swap-in, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:36 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Dave Hansen, (Thu Sep 25, 11:40 am)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Daisuke Nishimura, (Thu Sep 25, 6:00 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 6:17 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 6:22 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 6:43 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:05 pm)

[PATCH(fixed) 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:21 pm)

[PATCH(fixed) 10/12] free page cgroup from LRU in lazy, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:25 pm)

[PATCH(fixed) 11/12] free page cgroup from LRU in add, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:28 pm)

Re: [PATCH 0/12] memcg updates v5, Daisuke Nishimura, (Thu Sep 25, 7:32 pm)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:58 pm)

Re: [PATCH 0/12] memcg updates v5, Daisuke Nishimura, (Thu Sep 25, 8:00 pm)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Thu Sep 25, 8:04 pm)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Thu Sep 25, 9:05 pm)

Re: [PATCH 0/12] memcg updates v5, Daisuke Nishimura, (Thu Sep 25, 10:24 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Daisuke Nishimura, (Thu Sep 25, 10:54 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 11:54 pm)

Re: [PATCH 7/12] memcg add function to move account, Daisuke Nishimura, (Fri Sep 26, 12:30 am)

Re: [PATCH 0/12] memcg updates v5, Balbir Singh, (Fri Sep 26, 1:18 am)

Re: [PATCH 1/12] memcg avoid accounting special mappings n ..., Balbir Singh, (Fri Sep 26, 1:25 am)

Re: [PATCH 2/12] memcg move charege() call to swapped-in p ..., Balbir Singh, (Fri Sep 26, 1:36 am)

Re: [PATCH 3/12] memcg make root cgroup unlimited., Balbir Singh, (Fri Sep 26, 1:41 am)

Re: [PATCH 1/12] memcg avoid accounting special mappings n ..., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:17 am)

Re: [PATCH 2/12] memcg move charege() call to swapped-in p ..., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:18 am)

Re: [PATCH 3/12] memcg make root cgroup unlimited., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:21 am)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 2:22 am)

Re: [PATCH 7/12] memcg add function to move account, KAMEZAWA Hiroyuki, (Fri Sep 26, 2:24 am)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 2:28 am)

Re: [PATCH 3/12] memcg make root cgroup unlimited., Balbir Singh, (Fri Sep 26, 2:29 am)

Re: [PATCH 0/12] memcg updates v5, Balbir Singh, (Fri Sep 26, 2:31 am)

Re: [PATCH 1/12] memcg avoid accounting special mappings n ..., Balbir Singh, (Fri Sep 26, 2:32 am)

Re: [PATCH 4/12] memcg make page->mapping NULL before call ..., Balbir Singh, (Fri Sep 26, 2:47 am)

Re: [PATCH 6/12] memcg optimize percpu stat, Balbir Singh, (Fri Sep 26, 2:53 am)

Re: [PATCH 1/12] memcg avoid accounting special mappings n ..., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:55 am)

Re: [PATCH 3/12] memcg make root cgroup unlimited., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:59 am)

Re: [PATCH 4/12] memcg make page->mapping NULL before call ..., KAMEZAWA Hiroyuki, (Fri Sep 26, 3:07 am)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 3:36 am)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 3:43 am)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 7:53 pm)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 8:19 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Fri Sep 26, 8:25 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Fri Sep 26, 8:47 pm)

Re: [PATCH 5/12] memcg make page_cgroup->flags atomic, Balbir Singh, (Fri Sep 26, 11:58 pm)

Re: [PATCH 7/12] memcg add function to move account, Balbir Singh, (Sat Sep 27, 12:56 am)

Re: Re: [PATCH 7/12] memcg add function to move account, kamezawa.hiroyu, (Sat Sep 27, 1:35 am)

Re: [PATCH 0/12] memcg updates v5, Balbir Singh, (Sun Sep 28, 8:02 pm)

Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Sun Sep 28, 8:27 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Balbir Singh, (Tue Sep 30, 9:03 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 10:07 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Balbir Singh, (Tue Sep 30, 10:30 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 10:32 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 10:41 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Balbir Singh, (Tue Sep 30, 10:59 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 11:12 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 11:17 pm)

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Balbir Singh, (Tue Sep 30, 11:26 pm)


linux-kernel:
Ken Chen	[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Hugh Dickins	Re: Linux 2.6.26-rc1 - pgtable_32.c:178 pmd_bad
Bernhard Beck	[PATCH 001/001] usb-serial: Add ThinkOptics WavIT
Oleg Nesterov	Re: [PATCH 4/5] don't panic if /sbin/init exits or killed
Greg KH	[patch 07/21] rtc-pcf8563: detect polarity of century bit automatically
git:
Jonathan del Strother	Re: [PATCH] Fixing path quoting issues
Gerrit Pape	[PATCH] fix skipping merge-order test with NO_OPENSSL=1.
Linus Torvalds	Re: Implementing branch attributes in git config
Johannes Schindelin	Re: Trying to use git-filter-branch to compress history by removing large, obsolet...
Gerrit Pape	[PATCH] hooks--update: fix test for properly set up project description file
linux-netdev:
David Miller	Re: [PATCH 04/15] tg3: Preserve LAA when device control is released
Jean-Louis Dupond	Re: tg3 driver not advertising 1000mbit
Sven Wegener	[PATCH] ipvs: Add missing locking during connection table hashing and unhashing
David Miller	Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
Stephen Hemminger	[PATCH 2/2] sky2: fix transmit state on resume
git-commits-head:
Linux Kernel Mailing List	[SCSI] scsi ioctl: fix kernel-doc warning
Linux Kernel Mailing List	ALSA: HDA - Correct trivial typos in comments.
Linux Kernel Mailing List	i2c-viapro: Add support for SMBus Process Call transactions
Linux Kernel Mailing List	i2c: Documentation: upgrading clients HOWTO
Linux Kernel Mailing List	[PATCH] fix sysctl_nr_open bugs
openbsd-misc:
Die Gestalt	Re: How to re-build openssl with SHA1 support?
Edwin Eyan Moragas	Re: managing routes for multiple PPPoE connections
Brian Candler	Re: OBSD's perspective on SELinux
Jonathan Schleifer	Why is getaddrinfo breaking POSIX?
Predrag Punosevac	Re: Kernel developers guide/tutorial