>
> On Fri, 2008-09-26 at 09:31 +0900, Kyungmin Park wrote:
>> Hi,
>>
>> A few comments
>>
>> >
>> > Signed-off-by: Vishak G <vishak.g@samsung.com>
>> > Signed-off-by: Rohit Hagargundgi <h.rohit@samsung.com>
>>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>>
>> > ---
>> > diff -uprN a/drivers/mtd/onenand/onenand_base.c
>> > b/drivers/mtd/onenand/onenand_base.c
>> > --- a/drivers/mtd/onenand/onenand_base.c
>> > 2008-09-16
>> > 20:48:12.000000000 +0530
>> > +++ b/drivers/mtd/onenand/onenand_base.c
>> > 2008-09-24
>> > 17:51:34.000000000 +0530
>> > @@ -9,6 +9,10 @@
>> > * auto-placement support, read-while load support,
>> > various fixes
>> > * Copyright (C) Nokia Corporation, 2007
>> > *
>> > + * Vishak G <vishak.g@samsung.com>, Rohit
>> > Hagargundgi
>> > <h.rohit@samsung.com>
>> > + * Flex-OneNAND support
>> > + * Copyright (C) Samsung Electronics, 2008
>> > + *
>> > * This program is free software; you can redistribute
>> > it and/or modify
>> > * it under the terms of the GNU General Public License
>> > version 2 as
>> > * published by the Free Software Foundation.
>> > @@ -27,6 +31,37 @@
>> >
>> > #include <asm/io.h>
>> >
>> > +const static int boundary[] = {
>> > + FLEXONENAND_DIE0_BOUNDARY,
>> > + FLEXONENAND_DIE1_BOUNDARY,
>> > +};
>> > +
>> > +const static int lock[] = {
>> > + FLEXONENAND_DIE0_ISLOCKED,
>> > + FLEXONENAND_DIE1_ISLOCKED,
>> > +};
>> > +
>>
>> static const as others.
>>
>>
>> > diff -uprN a/include/mtd/mtd-abi.h
>> > b/include/mtd/mtd-abi.h
>> > --- a/include/mtd/mtd-abi.h 2008-09-16
>> > 20:48:12.000000000 +0530
>> > +++ b/include/mtd/mtd-abi.h 2008-09-24
>> > 14:09:06.000000000 +0530
>> > @@ -102,7 +102,11 @@ struct nand_oobinfo {
>> > uint32_t useecc;
>> > uint32_t eccbytes;
>> > uint32_t oobfree[8][2];
>> > +#ifdef CONFIG_MTD_ONENAND
>> > + uint32_t eccpos[128];
>> > +#else
>> > uint32_t eccpos[32];
>> > +#endif
>> > };
>> >
>> > struct nand_oobfree {
>> > @@ -117,7 +121,11 @@ struct nand_oobfree {
>> > */
>> > struct nand_ecclayout {
>> > uint32_t eccbytes;
>> > +#ifdef CONFIG_MTD_ONENAND
>> > + uint32_t eccpos[128];
>> > +#else
>> > uint32_t eccpos[64];
>> > +#endif
>> > uint32_t oobavail;
>> > struct nand_oobfree
>> > oobfree[MTD_MAX_OOBFREE_ENTRIES];
>> > };
>
> I do not think stuff like this is going to be accepted
> because you
> change ABI. You should instead introduce new ioctls or add
> sysfs
> support and expose this information via sysfs. This is
> much bigger
> work, but it is needed.
>
> --
> Best regards,
> Artem Bityutskiy (???????? ?????)
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
>
http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
