Re: [PATCH 5/6] bfa: Brocade BFA FC SCSI Driver submission

Previous thread: [PATCH 4/6] bfa: Brocade BFA FC SCSI Driver submission by Jing Huang on Wednesday, September 24, 2008 - 9:07 pm. (1 message)

Next thread: [PATCH 2/6] bfa: Brocade BFA FC SCSI Driver submission by Jing Huang on Wednesday, September 24, 2008 - 9:01 pm. (1 message)
From: Jing Huang
Date: Wednesday, September 24, 2008 - 9:09 pm

From: Jing Huang <huangj@brocade.com>

This patch contains document of brocade specific sysfs interface. It is
created using 2.6.27-rc7 kernel.

Signed-off-by: Jing Huang <huangj@brocade.com>
---
 Documentation/ABI/testing/sysfs-devices-bfa |  600
++++++++++++++++++++++++++++
 1 files changed, 600 insertions(+)

diff -urpN orig/Documentation/ABI/testing/sysfs-devices-bfa
patch/Documentation/ABI/testing/sysfs-devices-bfa
--- orig/Documentation/ABI/testing/sysfs-devices-bfa	1969-12-31
16:00:00.000000000 -0800
+++ patch/Documentation/ABI/testing/sysfs-devices-bfa	2008-09-24
12:08:25.000000000 -0700
@@ -0,0 +1,600 @@
+What:		/sys/devices/<Brocade HBA PCI path>/bfa
+Date:		July 2008
+Contact:	Jing Huang <huangj@brocade.com>
+Description:
+		The /sys/devices/<Brocade HBA device path>/bfa will
contain
+		files and subdirectories to display internal states and
+		statistics of Brocade HBA. It also provides a
configuration and
+		management interface for each HBA instance.
+
+What:		/sys/devices/<Brocade HBA PCI path>/bfa/ioc
+Date:		July 2008
+Contact:	Jing Huang <huangj@brocade.com>
+Description:
+		The /sys/devices/<Brocade HBA device path>/ioc will
contain
+		files and directories to display ioc level attributes
+		and statistics of the HBA.
+
+Files and directories under /sys/devices/<Brocade HBA PCI
path>/bfa/ioc:
+-----------------------------------------------------------------------
+-
+
+bios_ver
+
+	 BIOS version
+
+chip_rev		
+
+	Chip version
+
+fw_ver
+	Firmware version
+
+hw_name
+
+	Hardware name or pci path
+
+hw_ver
+
+	Hardware version
+
+intr
+	Interrupt coalescing setting
+
+manufacturer
+
+	Manufacturer info
+
+model_desc
+	
+	Model description
+
+mpiomode
+
+	mpio mode setting of IOC
+
+name
+	Name of the driver
+
+nwwn
+	World Wide Node Name
+
+optrom_ver
+
+	Option Rom version
+
+port_count
+
+	Port count of the HBA
+
+power
+
+	IOC power state
+
+pwwn
+
+	World Wide Node ...
From: Greg KH
Date: Wednesday, September 24, 2008 - 9:50 pm

A lot of these (like the statistics) look like they should be debugfs
entries instead of sysfs.  Why do they need to be sysfs files, who/what
is going to use these entries?

thanks,

greg k-h
--

From: James Bottomley
Date: Wednesday, September 24, 2008 - 10:18 pm

This is completely the wrong thing to do.  The driver needs to bind to
the Fibre Channel transport class which provides all of these features
in a large measure through infrastructure shareable with the other FC
drivers.  Any other pieces that are brocade specific rather than FC
general can go in host attributes in the same way as the rest of the FC
drivers do it.

James


--

Previous thread: [PATCH 4/6] bfa: Brocade BFA FC SCSI Driver submission by Jing Huang on Wednesday, September 24, 2008 - 9:07 pm. (1 message)

Next thread: [PATCH 2/6] bfa: Brocade BFA FC SCSI Driver submission by Jing Huang on Wednesday, September 24, 2008 - 9:01 pm. (1 message)