Re: [NET-NEXT PATCH] e1000: remove unused Kconfig option for disabling packet split

Previous thread: sound: make OSS sound core optional by Tejun Heo on Wednesday, August 27, 2008 - 1:18 am. (1 message)

Next thread: [PATCH RESEND] sound: make OSS sound core optional by Tejun Heo on Wednesday, August 27, 2008 - 1:19 am. (6 messages)
From: Jeff Kirsher
Date: Wednesday, August 27, 2008 - 1:19 am

From: Jesse Brandeburg <jesse.brandeburg@intel.com>

Since the e1000/e1000e split, no hardware supported by e1000
supports packet split, just remove the Kconfig option and associated
code from arch/* and the driver.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 arch/arm/configs/iop13xx_defconfig              |    1 
 arch/arm/configs/iop32x_defconfig               |    1 
 arch/arm/configs/iop33x_defconfig               |    1 
 arch/arm/configs/ixp23xx_defconfig              |    1 
 arch/arm/configs/kirkwood_defconfig             |    1 
 arch/ia64/configs/generic_defconfig             |    1 
 arch/ia64/configs/gensparse_defconfig           |    1 
 arch/ia64/configs/tiger_defconfig               |    1 
 arch/ia64/configs/zx1_defconfig                 |    1 
 arch/mips/configs/mtx1_defconfig                |    1 
 arch/parisc/configs/a500_defconfig              |    1 
 arch/parisc/configs/c3000_defconfig             |    1 
 arch/powerpc/configs/83xx/mpc832x_rdb_defconfig |    1 
 arch/powerpc/configs/85xx/mpc8560_ads_defconfig |    1 
 arch/powerpc/configs/85xx/mpc85xx_cds_defconfig |    1 
 arch/powerpc/configs/85xx/tqm8548_defconfig     |    1 
 arch/powerpc/configs/cell_defconfig             |    1 
 arch/powerpc/configs/g5_defconfig               |    1 
 arch/powerpc/configs/iseries_defconfig          |    1 
 arch/powerpc/configs/maple_defconfig            |    1 
 arch/powerpc/configs/pasemi_defconfig           |    1 
 arch/powerpc/configs/ppc64_defconfig            |    1 
 arch/powerpc/configs/ppc6xx_defconfig           |    1 
 arch/powerpc/configs/prpmc2800_defconfig        |    1 
 arch/powerpc/configs/pseries_defconfig          |    1 
 arch/sh/configs/r7780mp_defconfig               |    1 
 arch/sparc64/defconfig                          |    1 
 arch/x86/configs/i386_defconfig                 |    1 
 arch/x86/configs/x86_64_defconfig               |    1 
 ...
From: Jeff Garzik
Date: Wednesday, September 3, 2008 - 6:59 am

ACK, except for the defconfig changes.  arch maintainers usually prefer 
to do that themselves.

We'd be continually patch defconfig files, if we did so every time it 
was likely one would be updated by a Kconfig patch.


--

From: Brandeburg, Jesse
Date: Tuesday, September 16, 2008 - 1:01 pm

Here is an updated patch without the defconfig changes

== cut here ==

e1000: remove Kconfig option for packet split and e1000 related code

From: Jesse Brandeburg <jesse.brandeburg@intel.com>

Since the e1000/e1000e split, no hardware supported by e1000
supports packet split, just remove the Kconfig option and associated
code from the driver.

reposted without the defconfig changes, should apply to net-next

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
 drivers/net/Kconfig            |    9 -
 drivers/net/e1000/e1000.h      |   17 --
 drivers/net/e1000/e1000_main.c |  416 +---------------------------------------
 3 files changed, 9 insertions(+), 433 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 4a11296..5da94f3 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1927,15 +1927,6 @@ config E1000
 	  To compile this driver as a module, choose M here. The module
 	  will be called e1000.
 
-config E1000_DISABLE_PACKET_SPLIT
-	bool "Disable Packet Split for PCI express adapters"
-	depends on E1000
-	help
-	  Say Y here if you want to use the legacy receive path for PCI express
-	  hardware.
-
-	  If in doubt, say N.
-
 config E1000E
 	tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support"
 	depends on PCI && (!SPARC32 || BROKEN)
diff --git a/drivers/net/e1000/e1000.h b/drivers/net/e1000/e1000.h
index 19e317e..62f6297 100644
--- a/drivers/net/e1000/e1000.h
+++ b/drivers/net/e1000/e1000.h
@@ -155,8 +155,6 @@ do {									\
 #endif
 
 #define E1000_MNG_VLAN_NONE (-1)
-/* Number of packet split data buffers (not including the header buffer) */
-#define PS_PAGE_BUFFERS (MAX_PS_BUFFERS - 1)
 
 /* wrapper around a pointer to a socket buffer,
  * so a DMA handle can be stored along with the buffer */
@@ -168,14 +166,6 @@ struct e1000_buffer {
 	u16 next_to_watch;
 };
 
-struct e1000_ps_page {
-	struct page *ps_page[PS_PAGE_BUFFERS];
-};
-
-struct e1000_ps_page_dma {
-	u64 ...
From: Jeff Garzik
Date: Wednesday, September 24, 2008 - 7:14 pm

applied


--

Previous thread: sound: make OSS sound core optional by Tejun Heo on Wednesday, August 27, 2008 - 1:18 am. (1 message)

Next thread: [PATCH RESEND] sound: make OSS sound core optional by Tejun Heo on Wednesday, August 27, 2008 - 1:19 am. (6 messages)