Home » Mailing list archives » linux-kernel » 2008 » September » 24

Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Hugh Dickins
Subject: Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex
Date: Wednesday, September 24, 2008 - 12:41 pm

On Wed, 24 Sep 2008, Matt Mackall wrote:

The lock ordering bug is a good reason not to use do_truncate()
in either.  Once Nick's fixup is in mainline, try the unification
based on that, including his #ifndef CONFIG_MMU which is good for
documentation.

But I don't know how ugly all the #ifdef'ing will end up: at the
time you created mm/tiny-shmem.c, we had a stronger embargo on
#ifdefs in *.c than is fashionable today.

If we're hell-bent on #ifdefs throughout mm/shmem.c, I wouldn't
mind scattering some CONFIG_SWAPs in there too, would cut out
lots of overhead when swap unconfigured.  But again, how ugly?

Hugh
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] x86: some lock annotations for user copy paths, Nick Piggin, (Wed Sep 10, 4:37 am)
Re: [patch] x86: some lock annotations for user copy paths, Peter Zijlstra, (Wed Sep 10, 4:41 am)
Re: [patch] x86: some lock annotations for user copy paths, Ingo Molnar, (Wed Sep 10, 4:47 am)
Re: [patch] x86: some lock annotations for user copy paths, Ingo Molnar, (Wed Sep 10, 4:50 am)
Re: [patch] x86: some lock annotations for user copy paths, Ingo Molnar, (Wed Sep 10, 5:12 am)
Re: [patch] x86: some lock annotations for user copy paths, Ingo Molnar, (Wed Sep 10, 5:32 am)
Re: [patch] x86: some lock annotations for user copy paths, Nick Piggin, (Wed Sep 10, 7:30 am)
Re: [patch] x86: some lock annotations for user copy paths, Andi Kleen, (Wed Sep 10, 7:31 am)
Re: [patch] x86: some lock annotations for user copy paths, Nick Piggin, (Wed Sep 10, 7:48 am)
Re: [patch] x86: some lock annotations for user copy paths, Peter Zijlstra, (Wed Sep 10, 8:01 am)
Re: [patch] x86: some lock annotations for user copy paths, Nick Piggin, (Wed Sep 10, 8:12 am)
Re: [patch] x86: some lock annotations for user copy paths, Nick Piggin, (Wed Sep 10, 8:17 am)
Re: [patch] x86: some lock annotations for user copy paths, Nick Piggin, (Wed Sep 10, 8:26 am)
Re: [patch] x86: some lock annotations for user copy paths, Ingo Molnar, (Thu Sep 11, 1:27 am)
Re: [patch] x86: some lock annotations for user copy paths, Nick Piggin, (Thu Sep 11, 3:43 am)
[PATCH] sysfs: fix deadlock, Ingo Molnar, (Fri Sep 12, 2:24 am)
[lockdep] possible circular locking, between &mm->mmap_sem ..., Ingo Molnar, (Sun Sep 14, 12:39 am)
Re: [lockdep] possible circular locking, between &mm->mmap ..., Andrew Morton, (Sun Sep 14, 12:44 am)
[patch] mm: fix locking, inotify_read's ev_mutex vs do_pag ..., Ingo Molnar, (Sun Sep 14, 1:06 am)
Re: [lockdep] possible circular locking, between &mm->mmap ..., Nick Piggin, (Sun Sep 14, 2:36 pm)
Re: [PATCH] sysfs: fix deadlock, Nick Piggin, (Sun Sep 14, 3:02 pm)
[patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Nick Piggin, (Sun Sep 14, 3:12 pm)
Re: [PATCH] sysfs: fix deadlock, Peter Zijlstra, (Mon Sep 15, 2:15 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Andrew Morton, (Wed Sep 17, 1:14 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Matt Mackall, (Wed Sep 17, 1:46 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Ingo Molnar, (Thu Sep 18, 4:12 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Jeremy Fitzhardinge, (Thu Sep 18, 12:29 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Matt Mackall, (Thu Sep 18, 2:11 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Ingo Molnar, (Fri Sep 19, 1:40 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Dave Hansen, (Fri Sep 19, 7:18 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Hugh Dickins, (Sat Sep 20, 9:12 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, David Howells, (Mon Sep 22, 7:54 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Dave Hansen, (Mon Sep 22, 8:14 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Nick Piggin, (Mon Sep 22, 10:32 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, David Howells, (Wed Sep 24, 11:18 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Matt Mackall, (Wed Sep 24, 11:29 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, David Howells, (Wed Sep 24, 11:56 am)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Matt Mackall, (Wed Sep 24, 12:11 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, David Howells, (Wed Sep 24, 12:26 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Hugh Dickins, (Wed Sep 24, 12:29 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Hugh Dickins, (Wed Sep 24, 12:41 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Andrew Morton, (Wed Sep 24, 12:47 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, David Howells, (Wed Sep 24, 12:59 pm)
Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex, Hugh Dickins, (Wed Sep 24, 4:43 pm)