Home » Mailing list archives » linux-kernel » 2008 » September » 24

Re: [PATCH 9/13] memcg: lookup page cgroup (and remove pointer from struct page)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Balbir Singh
Subject: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove pointer from struct page)
Date: Tuesday, September 23, 2008 - 7:09 pm

On Wed, Sep 24, 2008 at 5:18 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:

I've not yet looked at the patch in detail, I just got back from a long travel.


Let's look at the basic requirement, make memory resource controller
not suck with 32 bit systems. I have been thinking of about removing
page_cgroup from struct page only for 32 bit systems (use radix tree),
32 bit systems can have a maximum of 64GB if PAE is enabled, I suspect
radix tree should work there and let the 64 bit systems work as is. If
performance is an issue, I would recommend the 32 bit folks upgrade to
64 bit :) Can we build consensus around this approach?


I can help test your patches on powerpc 64 bit and find a 32 bit
system to test it as well. What do you think about the points above?

Balbir
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/13] memory cgroup updates v4, KAMEZAWA Hiroyuki, (Mon Sep 22, 3:51 am)
[PATCH 1/13] memcg: avoid accounting special mapping, KAMEZAWA Hiroyuki, (Mon Sep 22, 3:55 am)
[PATCH 2/13] memcg: account fault-in swap under lock., KAMEZAWA Hiroyuki, (Mon Sep 22, 3:57 am)
[PATCH 3/13] memcg: nolimit root cgroup, KAMEZAWA Hiroyuki, (Mon Sep 22, 3:58 am)
[PATCH 4/13] memcg: force_empty moving account, KAMEZAWA Hiroyuki, (Mon Sep 22, 4:00 am)
[PATCH 5/13] memcg: cleanup to make mapping null before un ..., KAMEZAWA Hiroyuki, (Mon Sep 22, 4:02 am)
[PATCH 6/13] memcg: optimze per cpu accounting for memcg, KAMEZAWA Hiroyuki, (Mon Sep 22, 4:03 am)
[PATCH 3.5/13] memcg: make page_cgroup flags to be atomic, KAMEZAWA Hiroyuki, (Mon Sep 22, 4:05 am)
[PATCH 3.6/13] memcg: add function to move account., KAMEZAWA Hiroyuki, (Mon Sep 22, 4:09 am)
[PATCH 9/13] memcg: lookup page cgroup (and remove pointer ..., KAMEZAWA Hiroyuki, (Mon Sep 22, 4:12 am)
[PATCH 10/13] memcg: page_cgroup look aside table, KAMEZAWA Hiroyuki, (Mon Sep 22, 4:13 am)
[PATCH 11/13] memcg: lazy LRU free (NEW), KAMEZAWA Hiroyuki, (Mon Sep 22, 4:17 am)
[PATCH 12/13] memcg: lazy LRU add, KAMEZAWA Hiroyuki, (Mon Sep 22, 4:22 am)
[PATCH 13/13] memcg: swap accounting fix, KAMEZAWA Hiroyuki, (Mon Sep 22, 4:24 am)
Re: [PATCH 0/13] memory cgroup updates v4, KAMEZAWA Hiroyuki, (Mon Sep 22, 4:28 am)
Re: [PATCH 4/13] memcg: force_empty moving account, Peter Zijlstra, (Mon Sep 22, 7:23 am)
Re: Re: [PATCH 4/13] memcg: force_empty moving account, kamezawa.hiroyu, (Mon Sep 22, 7:50 am)
Re: [PATCH 9/13] memcg: lookup page cgroup (and remove poi ..., Dave Hansen, (Mon Sep 22, 7:52 am)
Re: Re: [PATCH 4/13] memcg: force_empty moving account, Peter Zijlstra, (Mon Sep 22, 7:56 am)
Re: Re: Re: [PATCH 4/13] memcg: force_empty moving account, kamezawa.hiroyu, (Mon Sep 22, 8:06 am)
Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove ..., kamezawa.hiroyu, (Mon Sep 22, 8:14 am)
Re: Re: Re: [PATCH 4/13] memcg: force_empty moving account, Peter Zijlstra, (Mon Sep 22, 8:32 am)
Re: Re: Re: Re: [PATCH 4/13] memcg: force_empty moving account, kamezawa.hiroyu, (Mon Sep 22, 8:43 am)
Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove ..., Dave Hansen, (Mon Sep 22, 8:47 am)
Re: [PATCH 9/13] memcg: lookup page cgroup (and remove poi ..., Peter Zijlstra, (Mon Sep 22, 8:47 am)
Re: Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and re ..., kamezawa.hiroyu, (Mon Sep 22, 8:57 am)
Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove ..., kamezawa.hiroyu, (Mon Sep 22, 9:04 am)
Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove ..., Peter Zijlstra, (Mon Sep 22, 9:06 am)
Re: Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and re ..., Dave Hansen, (Mon Sep 22, 9:10 am)
Re: Re: Re: Re: [PATCH 9/13] memcg: lookup page cgroup (an ..., kamezawa.hiroyu, (Mon Sep 22, 10:34 am)
Re: [PATCH 9/13] memcg: lookup page cgroup (and remove poi ..., KAMEZAWA Hiroyuki, (Tue Sep 23, 4:48 pm)
Re: [PATCH 9/13] memcg: lookup page cgroup (and remove poi ..., Balbir Singh, (Tue Sep 23, 7:09 pm)
Re: [PATCH 9/13] memcg: lookup page cgroup (and remove poi ..., KAMEZAWA Hiroyuki, (Tue Sep 23, 8:09 pm)
Re: [PATCH 3.6/13] memcg: add function to move account., Daisuke Nishimura, (Tue Sep 23, 11:50 pm)
Re: [PATCH 3.6/13] memcg: add function to move account., KAMEZAWA Hiroyuki, (Wed Sep 24, 12:11 am)
Re: [PATCH 9/13] memcg: lookup page cgroup (and remove poi ..., Balbir Singh, (Wed Sep 24, 1:31 am)
Re: [PATCH 9/13] memcg: lookup page cgroup (and remove poi ..., KAMEZAWA Hiroyuki, (Wed Sep 24, 1:46 am)