Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Russell King - ARM Linux
Date: Monday, September 22, 2008 - 12:59 am

On Sun, Sep 21, 2008 at 06:45:42PM -0700, David Brownell wrote:

I'm not discouraging review.  I'm saying that making inappropriate
comments isn't helpful.

Yes, your comments are right, but are they appropriate to getting
the OMAP watchdog drivers updated in mainline, or are they more
appropriate in a general sense to all watchdog drivers, and therefore
should be separate from that task?


Call it what you want.


I never said that - you're twisting my words as normal.


Yet again you use confrontational language, inflaming this discussion.

Okay, I give up.  Folk here can carry on struggling to get their code
into mainline with endless reviews and getting fed up with having to
constantly rework the code over and over again.

Clearly my views aren't welcome.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/5] omap watchdog updaes, Felipe Balbi, (Fri Sep 19, 3:32 am)
[PATCH 1/5] watchdog: sync linux-omap changes, Felipe Balbi, (Fri Sep 19, 3:32 am)
[PATCH 2/5] watchdog: another ioremap() fix, Felipe Balbi, (Fri Sep 19, 3:32 am)
[PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, Felipe Balbi, (Fri Sep 19, 3:32 am)
Re: [PATCH 5/5] watchdog: introduce platform_data and remo ..., Russell King - ARM Linux, (Fri Sep 19, 12:04 pm)
Re: [PATCH 1/5] watchdog: sync linux-omap changes, Russell King - ARM Linux, (Fri Sep 19, 3:40 pm)
Re: [PATCH 5/5] watchdog: introduce platform_data and remo ..., Russell King - ARM Linux, (Fri Sep 19, 3:51 pm)
Re: [PATCH 1/5] watchdog: sync linux-omap changes, David Brownell, (Fri Sep 19, 5:20 pm)
Re: [PATCH 1/5] watchdog: sync linux-omap changes, David Brownell, (Fri Sep 19, 5:39 pm)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, David Brownell, (Fri Sep 19, 5:41 pm)
Re: [PATCH 5/5] watchdog: introduce platform_data and remo ..., Wim Van Sebroeck, (Fri Sep 19, 10:48 pm)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, Russell King - ARM Linux, (Sat Sep 20, 1:13 am)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, David Brownell, (Sat Sep 20, 8:32 am)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, Russell King - ARM Linux, (Sat Sep 20, 9:11 am)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, Alan Cox, (Sat Sep 20, 10:01 am)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, David Brownell, (Sat Sep 20, 10:18 am)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, Russell King - ARM Linux, (Sat Sep 20, 11:00 am)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, Tony Lindgren, (Sun Sep 21, 11:41 am)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, David Brownell, (Sun Sep 21, 6:45 pm)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, David Brownell, (Sun Sep 21, 7:01 pm)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, Russell King - ARM Linux, (Mon Sep 22, 12:59 am)
Re: [PATCH 3/5] watchdog: cleanup a bit omap_wdt.c, Tony Lindgren, (Mon Sep 22, 2:30 am)