Home » Mailing list archives » linux-kernel » 2008 » September » 21

[PATCH] IDE-TAPE NULL terminate strings.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Mark de Wever
Subject: [PATCH] IDE-TAPE NULL terminate strings.
Date: Sunday, September 21, 2008 - 11:51 am

After updating my kernel to 2.6.26 the output for the ide-tape drive
during booting is garbled eg
ide-tape: hdd <-> ht0: Seagate <98>ß8A51|1À<81>ܺ<98>ß STT20000A rev 8A51|1À<81>ܺ<98>ß

This patch fixes the problem by NULL terminating the strings.

Regards,
Mark de Wever

PS: please CC me since I'm not subscribed.
PPS: there are more problems with my tapestreamer in 2.6.26 but I'll
post a separate message for that.

Signed-off-by: Mark de Wever <koraq@xs4all.nl>
---
 drivers/ide/ide-tape.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 1bce84b..fd87b43 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -2354,6 +2354,10 @@ static void idetape_get_inquiry_results(ide_drive_t *drive)
 	ide_fixstring(product_id, 18, 0);
 	ide_fixstring(fw_rev, 6, 0);
 
+	fw_rev[4] = '\0';
+	vendor_id[8] = '\0';
+	product_id[16] = '\0';
+
 	printk(KERN_INFO "ide-tape: %s <-> %s: %s %s rev %s\n",
 			drive->name, tape->name, vendor_id, product_id, fw_rev);
 }
-- 
1.5.6.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] IDE-TAPE NULL terminate strings., Mark de Wever, (Sun Sep 21, 11:51 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Sergei Shtylyov, (Sun Sep 21, 12:24 pm)
Re: [PATCH] IDE-TAPE NULL terminate strings., Sergei Shtylyov, (Sun Sep 21, 1:08 pm)
Re: [PATCH] IDE-TAPE NULL terminate strings., Mark de Wever, (Sun Sep 21, 1:29 pm)
Re: [PATCH] IDE-TAPE NULL terminate strings., Sergei Shtylyov, (Sun Sep 21, 3:12 pm)
Re: [PATCH] IDE-TAPE NULL terminate strings., Sergei Shtylyov, (Mon Sep 22, 6:16 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Boris Petkov, (Mon Sep 22, 6:56 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Mark de Wever, (Mon Sep 22, 1:41 pm)
Re: [PATCH] IDE-TAPE NULL terminate strings., Sergei Shtylyov, (Mon Sep 22, 2:08 pm)
Re: [PATCH] IDE-TAPE NULL terminate strings., Borislav Petkov, (Tue Sep 23, 12:48 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Sergei Shtylyov, (Tue Sep 23, 2:29 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Boris Petkov, (Tue Sep 23, 6:40 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Mark de Wever, (Tue Sep 23, 9:14 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Mark de Wever, (Tue Sep 23, 9:59 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Sergei Shtylyov, (Tue Sep 23, 10:10 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Boris Petkov, (Tue Sep 23, 10:11 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Mark de Wever, (Tue Sep 23, 10:27 am)
IDE-TAPE regressions [was: [PATCH] IDE-TAPE NULL terminate ..., Mark de Wever, (Tue Sep 23, 2:20 pm)
Re: [PATCH] IDE-TAPE NULL terminate strings., Borislav Petkov, (Wed Sep 24, 12:10 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Sergei Shtylyov, (Wed Sep 24, 2:36 am)
Re: [PATCH] IDE-TAPE NULL terminate strings., Bartlomiej Zolnierki ..., (Sat Sep 27, 10:04 am)
[patch][repost] ide-tape build fix, Mark de Wever, (Tue Oct 7, 11:26 am)
Re: [patch][repost] ide-tape build fix, Borislav Petkov, (Tue Oct 7, 11:33 pm)
Re: [patch][repost] ide-tape build fix, Mark de Wever, (Wed Oct 8, 8:45 am)
Re: [patch][repost] ide-tape build fix, Boris Petkov, (Wed Oct 8, 9:22 am)
Re: [patch][repost] ide-tape build fix, Bartlomiej Zolnierki ..., (Wed Oct 8, 11:37 am)