Home » Mailing list archives » linux-kernel » 2008 » September » 21

Re: [PATCH] serial_core: fix printk format warnings

Previous thread: [PATCH] md: Add support for data integrity to MD by Martin K. Petersen on Saturday, September 20, 2008 - 5:18 pm. (3 messages)

Next thread: [PATCH] [RFC] tracehook: Hook in syscall tracing markers. by Paul Mundt on Saturday, September 20, 2008 - 7:16 pm. (6 messages)
[view original message]
From: Alexander Beregalov
Subject: [PATCH] serial_core: fix printk format warnings
Date: Saturday, September 20, 2008 - 6:11 pm

drivers/serial/serial_core.c:2158: warning: format '%x' expects type
'unsigned int', but argument 4 has type 'long unsigned int'
drivers/serial/serial_core.c:2162: warning: format '%x' expects type
'unsigned int', but argument 4 has type 'long unsigned int

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---

 drivers/serial/serial_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index effd0bd..d531ae9 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -2155,11 +2155,11 @@ uart_report_port(struct uart_driver *drv, struct uart_port *port)
 	switch (port->iotype) {
 	case UPIO_PORT:
 		snprintf(address, sizeof(address),
-			 "I/O 0x%x", port->iobase);
+			 "I/O 0x%lx", port->iobase);
 		break;
 	case UPIO_HUB6:
 		snprintf(address, sizeof(address),
-			 "I/O 0x%x offset 0x%x", port->iobase, port->hub6);
+			 "I/O 0x%lx offset 0x%x", port->iobase, port->hub6);
 		break;
 	case UPIO_MEM:
 	case UPIO_MEM32:
--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] serial_core: fix printk format warnings
Date: Saturday, September 20, 2008 - 6:15 pm

From: Alexander Beregalov <a.beregalov@gmail.com>

This is because of a patch of mine that Andrew added to -mm,
which changed the ioport to be an unsigned long.

I have some updates which I'll send to Andrew which should
cure this.
--


[ message continues ]
Previous thread: [PATCH] md: Add support for data integrity to MD by Martin K. Petersen on Saturday, September 20, 2008 - 5:18 pm. (3 messages)

Next thread: [PATCH] [RFC] tracehook: Hook in syscall tracing markers. by Paul Mundt on Saturday, September 20, 2008 - 7:16 pm. (6 messages)