several wrong sections for probe functions of platform drivers

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Uwe
Date: Tuesday, September 2, 2008 - 2:05 pm

Hello,

I wrote a small python script that extracts the section specifier for
probe functions of platform drivers and warns if it's != __devinit.
The script is attached.

It's not always an error if the probe function is defined using __init,
but then (AFAIK) it should not be passed in the struct platform_driver!?

With Linus' current tree (v2.6.27-rc5-55-gafa153f) I get 215 matches
with

	1x __devexit
	67x __init
	146x no section

and one match that isn't interpreted correctly by my script.

I think the __devexit case is definitly wrong.  I will do a deeper look
and then probably send a patch for that one as a follow up to this mail.

I didn't (yet) checked the other cases, but I expect that most of them
need fixing.

Would it make sense to start collecting such scripts in the vanilla
tree?

I appreciate any constructive feedback.

Best regards
Uwe

-- 
Uwe Kleine-K
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
several wrong sections for probe functions of platform drivers, Uwe , (Tue Sep 2, 2:05 pm)
[PATCH] Fix section for sa11xx-uda1341 platform driver, Uwe Kleine-König, (Mon Sep 8, 5:13 am)