Re: [PATCH -tip/master] x86: io-apic - restore_IO_APIC_setup NULL pointer quick fix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Cyrill Gorcunov
Date: Friday, September 19, 2008 - 3:00 am

[Ingo Molnar - Fri, Sep 19, 2008 at 10:05:20AM +0200]
| 
| * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| 
| > Check if memory was granted first - we don't like NULL deref.
| > It's a *quick* fix. Actually it's better to hadle this error
| > at moment of memory allocation. It's save_mask_IO_APIC_setup
| > route who allocates this memory (just for the record).
| > 
| > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| > ---
| > 
| > I'll handle this in _normal_ way tomorrow. Please review.
| 
| ok, i've applied the quick fix to tip/master - the patch will drop from 
| there on the next integration run.
| 
| 	Ingo
| 

thanks Ingo, it seems there memory leak too. Handling...

		- Cyrill -
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH -tip/master] x86: io-apic - restore_IO_APIC_set ..., Cyrill Gorcunov, (Fri Sep 19, 3:00 am)