login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
September
»
18
Re: [PATCH] gpio_free might sleep, mips architecture
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Ralf Baechle
Subject:
Re: [PATCH] gpio_free might sleep, mips architecture
Date: Thursday, September 18, 2008 - 6:59 am
On Thu, Sep 18, 2008 at 11:32:42AM +0200, Uwe Kleine-König wrote:
quoted text
> Andrew Morton wrote: > > > diff --git a/include/asm-mips/mach-rc32434/gpio.h b/include/asm-mips/mach-rc32434/gpio.h > > > index f946f5f..9b4722e 100644 > > > --- a/include/asm-mips/mach-rc32434/gpio.h > > > +++ b/include/asm-mips/mach-rc32434/gpio.h > > > @@ -13,6 +13,7 @@ > > > #ifndef _RC32434_GPIO_H_ > > > #define _RC32434_GPIO_H_ > > > > > > +#include <linux/kernel.h> > > > #include <linux/types.h> > > > > > > struct rb532_gpio_reg { > > > @@ -88,6 +89,7 @@ static inline int gpio_request(unsigned gpio, const char *label) > > > static inline void gpio_free(unsigned gpio) > > > { > > > /* Not yet implemented */ > > > + might_sleep(); > > > } > > > > > > > There is no gpio_free() in linux-next's include/asm-mips/mach-rc32434/gpio.h > This is OK. This machine type is converted to GPIO lib in linus-next. > So just drop the two hunks for this file. (Note, you only dropped the > addition of might_sleep, but then including linux/kernel.h isn't needed > either.)
A few days ago I've put a patch to move include/asm-mips/ to arch/ like several other architectures already did so you patch may conflict ... Ralf --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] add might_sleep() to all implementations of gpio_free
, Uwe Kleine-König
, (Thu Jul 24, 12:28 am)
Re: [PATCH] add might_sleep() to all implementations of gp ...
, Uwe
, (Thu Jul 24, 12:33 am)
[PATCH] gpio_free might sleep, generic part
, Uwe Kleine-König
, (Mon Sep 15, 1:02 pm)
[PATCH] gpio_free might sleep, arm architecture
, Uwe Kleine-König
, (Mon Sep 15, 1:02 pm)
[PATCH] gpio_free might sleep, mips architecture
, Uwe Kleine-König
, (Mon Sep 15, 1:02 pm)
[PATCH] gpio_free might sleep, blackfin architecture
, Uwe Kleine-König
, (Mon Sep 15, 1:02 pm)
[PATCH] gpio_free might sleep, x86 architecture
, Uwe Kleine-König
, (Mon Sep 15, 1:02 pm)
Re: [PATCH] gpio_free might sleep, arm architecture
, David Brownell
, (Mon Sep 15, 2:21 pm)
Re: [PATCH] gpio_free might sleep, blackfin architecture
, Bryan Wu
, (Mon Sep 15, 7:16 pm)
Re: [PATCH] gpio_free might sleep, x86 architecture
, Ingo Molnar
, (Wed Sep 17, 5:59 am)
Re: [PATCH] gpio_free might sleep, blackfin architecture
, Uwe
, (Wed Sep 17, 12:30 pm)
Re: [PATCH] gpio_free might sleep, mips architecture
, Andrew Morton
, (Wed Sep 17, 2:39 pm)
Re: [PATCH] gpio_free might sleep, mips architecture
, Uwe
, (Thu Sep 18, 2:32 am)
Re: [PATCH] gpio_free might sleep, mips architecture
, Ralf Baechle
, (Thu Sep 18, 6:59 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Michael Trimarchi
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Miklos Szeredi
[patch 14/15] vfs: more path_permission() conversions
Serge E. Hallyn
Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
Bernd Schmidt
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Takashi Iwai
[PATCH 2/2] input: Add LED support to Synaptics device
git
:
Junio C Hamano
Re: mingw, windows, crlf/lf, and git
Eyvind Bernhardsen
Re: Where has "git ls-remote" reference pattern matching gone?
Shawn O. Pearce
Re: Switching from CVS to GIT
Todd Zullinger
Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters
Santi Béjar
Re: How to use git-fmt-merge-msg?
linux-netdev
:
Ramkrishna Vepa
[net-2.6 PATCH 1/10] Neterion: New driver: Driver help file
Mark Anthony
invitation / inquiry
Ingo Molnar
Re: [PATCH 08/16] dma-debug: add core checking functions
David Miller
Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Sascha Hauer
[PATCH 03/12] fec: do not typedef struct types
git-commits-head
:
Linux Kernel Mailing List
amba: struct device - replace bus_id with dev_name(), dev_set_name()
Linux Kernel Mailing List
MIPS: Yosemite: Convert SMP startup lock to arch spinlock.
Linux Kernel Mailing List
ARM: S5PC100: IRQ and timer
Linux Kernel Mailing List
davinci: edma: clear interrupt status for interrupt enabled channels only
Linux Kernel Mailing List
x86, mm, kprobes: fault.c, simplify notify_page_fault()
openbsd-misc
:
Daniel A. Ramaley
Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Matthias Kilian
Re: can't get vesa @ 1280x800 or nv
Tobias Ulmer
Re: Problem after upgrade 4.5 to 4.6: ERR M
Philip Guenther
Re: SIGCHLD and libpthread.so
J.C. Roberts
Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Colocation donated by:
Syndicate