Re: [RFC][PATCH] Remove cgroup member from struct page (v3)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <balbir@...>
Cc: Andrew Morton <akpm@...>, Dave Hansen <dave@...>, Nick Piggin <nickpiggin@...>, <hugh@...>, <menage@...>, <xemul@...>, <linux-kernel@...>, <linux-mm@...>
Date: Thursday, September 18, 2008 - 7:01 am

On Wed, 17 Sep 2008 21:58:08 -0700
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

This is the result on 8cpu box. I think I have to reduce footprint of fastpath of
my patch ;)

Test result of your patch is (2).
==
Xeon 8cpu/2socket/1-node equips 48GB of memory.
run shell/exec benchmark 3 times just after boot.

lps ... loops per sec.
lpm ... loops per min.
(*) Shell tests somtimes fail because of division by zero, etc...

(1). rc6-mm1(2008/9/13 version)
==
Run                                       == 1st ==  == 2nd ==  ==3rd==
Execl Throughput                           2425.2     2534.5     2465.8  (lps)
C Compiler Throughput                      1438.3     1476.3     1459.1  (lpm)
Shell Scripts (1 concurrent)               9360.3     9368.3     9360.0  (lpm)
Shell Scripts (8 concurrent)               3868.0     3870.0     3868.0  (lpm)
Shell Scripts (16 concurrent)              2207.0     2204.0     2201.0  (lpm)
Dc: sqrt(2) to 99 decimal places         101644.3   102184.5   102118.5  (lpm)

(2). (1) +remove-page-cgroup-pointer-v3 (radix-tree + dynamic allocation)
==
Run                                       == 1st ==  == 2nd ==  == 3rd ==
Execl Throughput                           2514.1      2548.9    2648.7  (lps)
C Compiler Throughput                      1353.9      1324.6    1324.7  (lpm)
Shell Scripts (1 concurrent)               8866.7      8871.0    8856.0  (lpm)
Shell Scripts (8 concurrent)               3674.3      3680.0    3677.7  (lpm)
Shell Scripts (16 concurrent)              failed.     failed    2094.3  (lpm)
Dc: sqrt(2) to 99 decimal places          98837.0     98206.9   98250.6  (lpm)

(3). (1) + pre-allocation by "vmalloc" + hash + misc(atomic flags etc..)
==
Run                                       == 1st ==  == 2nd ==  == 3rd ==
Execl Throughput                           2385.4      2579.2    2361.5  (lps)
C Compiler Throughput                      1424.3      1436.3    1430.6  (lpm)
Shell Scripts (1 concurrent)               9222.0      9234.0    9246.7  (lpm)
Shell Scripts (8 concurrent)               3787.7      3799.3    failed  (lpm)
Shell Scripts (16 concurrent)              2165.7      2166.7    failed  (lpm)
Dc: sqrt(2) to 99 decimal places         102228.9    102658.5   104049.8 (lpm)

(4). (3) + get/put page charge/uncharge + lazy lru handling
Run                                       == 1st ==  == 2nd ==  == 3rd ==
Execl Throughput                           2349.4      2335.7    2338.9  (lps)
C Compiler Throughput                      1430.8      1445.0    1435.3  (lpm)
Shell Scripts (1 concurrent)               9250.3      9262.0    9265.0  (lpm)
Shell Scripts (8 concurrent)               3831.0      3834.4    3833.3  (lpm)
Shell Scripts (16 concurrent)              2193.3      2195.3    2196.0  (lpm)
Dc: sqrt(2) to 99 decimal places         102956.8    102886.9   101884.6 (lpm)


It seems "execl" test is affected by footprint and cache hit rate than other
tests. I need some more efforts for reducing overhead in (4).

Note:
(1)'s struct page is 64 bytes.
(2)(3)(4)'s struct page is 56 bytes.
 

-Kame

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 1:47 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Pavel Emelyanov, (Mon Sep 1, 5:03 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 5:17 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Peter Zijlstra, (Mon Sep 1, 9:19 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 3:35 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Pavel Emelyanov, (Mon Sep 1, 5:43 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Sun Aug 31, 10:39 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 11:42 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Sun Aug 31, 8:01 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 3:17 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 3:19 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 5:24 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:02 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 5:58 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:07 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 6:12 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:57 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 8:37 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 11:33 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 8, 11:28 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 8, 11:57 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 12:18 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 3:37 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 12:55 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Nick Piggin, (Mon Sep 8, 11:58 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 12:53 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 1:12 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 8:24 am)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 9:35 pm)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 9:56 pm)
[RFC][PATCH] Remove cgroup member from struct page (v3), Balbir Singh, (Wed Sep 17, 7:28 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 12:43 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 7:01 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 1:15 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Hirokazu Takahashi, (Thu Sep 18, 12:26 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 12:50 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Hirokazu Takahashi, (Thu Sep 18, 2:13 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 1:00 am)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 7:03 am)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 7:27 am)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Tue Sep 9, 10:35 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 8:34 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Wed Sep 3, 3:31 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 11:28 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 12:03 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:09 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 2:24 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:25 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 2:59 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 1:17 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:16 am)