login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
September
»
18
Re: [PATCH 3/4] ext2: Avoid printk floods in the face of directory corruption
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Eugene Teo
Subject:
Re: [PATCH 3/4] ext2: Avoid printk floods in the face of directory corruption
Date: Thursday, September 18, 2008 - 2:46 am
On Sat, Sep 13, 2008 at 11:32 PM, Theodore Ts'o <tytso@mit.edu> wrote: [...]
quoted text
> Eend: > - p = (ext2_dirent *)(kaddr + offs); > - ext2_error (sb, "ext2_check_page", > - "entry in directory #%lu spans the page boundary" > - "offset=%lu, inode=%lu", > - dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs, > - (unsigned long) le32_to_cpu(p->inode)); > + if (!quiet) { > + p = (ext2_dirent *)(kaddr + offs); > + ext2_error (sb, "ext2_check_page",
^^^^^^^^^^^^^^^^^^
quoted text
> + "entry in directory #%lu spans the page boundary" > + "offset=%lu, inode=%lu", > + dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs, > + (unsigned long) le32_to_cpu(p->inode));
Minor issue. Since you are already changing "ext2_check_page" to __func__, you might as well change it here too. Thanks, Eugene --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 1/4] ext3: Fix ext3_dx_readdir hash collision handling
, Theodore Ts'o
, (Sat Sep 13, 8:32 am)
[PATCH 2/4] ext3: truncate block allocated on a failed ext ...
, Theodore Ts'o
, (Sat Sep 13, 8:32 am)
[PATCH 3/4] ext2: Avoid printk floods in the face of direc ...
, Theodore Ts'o
, (Sat Sep 13, 8:32 am)
[PATCH 4/4] ext3: Avoid printk floods in the face of direc ...
, Theodore Ts'o
, (Sat Sep 13, 8:32 am)
Re: [PATCH 1/4] ext3: Fix ext3_dx_readdir hash collision h ...
, Andrew Morton
, (Wed Sep 17, 12:19 pm)
Re: [PATCH 2/4] ext3: truncate block allocated on a failed ...
, Andrew Morton
, (Wed Sep 17, 12:22 pm)
Re: [PATCH 3/4] ext2: Avoid printk floods in the face of d ...
, Andrew Morton
, (Wed Sep 17, 12:25 pm)
Re: [PATCH 3/4] ext2: Avoid printk floods in the face of d ...
, Eric Sandeen
, (Wed Sep 17, 12:30 pm)
Re: [PATCH 4/4] ext3: Avoid printk floods in the face of d ...
, Eugene Teo
, (Wed Sep 17, 5:57 pm)
Re: [PATCH 2/4] ext3: truncate block allocated on a failed ...
, Aneesh Kumar K.V
, (Thu Sep 18, 12:03 am)
Re: [PATCH 3/4] ext2: Avoid printk floods in the face of d ...
, Eugene Teo
, (Thu Sep 18, 2:46 am)
Re: [PATCH 1/4] ext3: Fix ext3_dx_readdir hash collision h ...
, Theodore Tso
, (Wed Oct 1, 3:37 pm)
Re: [PATCH 1/4] ext3: Fix ext3_dx_readdir hash collision h ...
, Andrew Morton
, (Wed Oct 1, 4:33 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
swhiteho
[PATCH 42/51] [GFS2] Move inode deletion out of blocking_cb
FUJITA Tomonori
Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Alex Riesen
Re: [PATCH 4/7] lib: Introduce strnstr()
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Matthew
Re: Linux 2.6.25
git
:
Mike Miller
git message
Stefan Richter
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Jeff King
Re: [PATCH] t7004: test that "git-tag -u" implies "-s"
Christian MICHON
Re: VCS comparison table
Scott Chacon
Re: why not TortoiseGit
linux-netdev
:
Arnaldo Carvalho de Melo
Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Badalian Vyacheslav
Re: tc filter flow hash question
Parav Pandit
ip6 route output() and ip_route_output_key() by drivers
Jarek Poplawski
Re: tc filter flow hash question
git-commits-head
:
Linux Kernel Mailing List
i915: Don't whine when pci_enable_msi() fails.
Linux Kernel Mailing List
usb: musb: fix hanging when rmmod gadget driver
Linux Kernel Mailing List
[ARM] 4671/1: ep93xx: remove obsolete gpio_line_* operations
Linux Kernel Mailing List
NFSv4: Move error handling out of the delegation generic code
Linux Kernel Mailing List
Staging: wlan-ng: Move wlan_mkprintstr() and wlan_hexchar() macros into prism2sta.c
openbsd-misc
:
Vikas N Kumar
Re: Singularity OS
Christian Weisgerber
Re: CARP with a single public IP address
Marco Peereboom
Re: OpenBSD culture?
"RALOVICH, Kristóf"
Re: thinkpad windows refund
Kevin
Re: uvm_mapent_alloc: out of static map entries on 4.3 i386
Colocation donated by:
Syndicate