Re: [RFC][PATCH] Remove cgroup member from struct page (v3)

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...>

To: <balbir@...>

Cc: Andrew Morton <akpm@...>, Dave Hansen <dave@...>, Nick Piggin <nickpiggin@...>, <hugh@...>, <menage@...>, <xemul@...>, <linux-kernel@...>, <linux-mm@...>

Subject: Re: [RFC][PATCH] Remove cgroup member from struct page (v3)

Date: Thursday, September 18, 2008 - 1:00 am

On Wed, 17 Sep 2008 20:57:54 -0700
Balbir Singh wrote:

> Andrew Morton wrote:

> > someone somewhere decided that (Aa + Bb) / Cc < 1.0. What are the values

quoted text

> > of A, B and C and where did they come from? ;)
> >
> > (IOW, your changelog is in the category "sucky", along with 90% of the others)
>
> Yes, I agree, to be honest we discussed the reasons on the mailing list and
> those should go to the changelog. I'll do that in the next version of the
> patches. These are early RFC patches, but the changelog does suck.
>

IIRC, (Aa + Bb) / Cc < 1.0 discussion was following.

Because we have to maintain pointer to page_cgroup in radix-tree (ZONE_NORMAL)

1. memory usage will increase when memory cgroup is enabled.
The amount memory usage increase just depends on the height of radix-tree.

2. memory usage will decrease when memory cgroup is disabled.
This saves 4bytes per 4096bytes. (on x86-32)

Thanks,
-Kame

unsubscribe notice

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 1:47 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, Pavel Emelyanov, (Mon Sep 1, 5:03 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 5:17 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Peter Zijlstra, (Mon Sep 1, 9:19 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 3:35 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Pavel Emelyanov, (Mon Sep 1, 5:43 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Sun Aug 31, 10:39 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 11:42 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Sun Aug 31, 8:01 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, Nick Piggin, (Mon Sep 1, 2:56 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 3:17 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 3:19 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Nick Piggin, (Mon Sep 1, 3:43 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 5:24 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:02 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 5:58 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:07 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 6:12 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:57 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 8:37 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 11:33 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 8, 11:28 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 8, 11:57 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 12:18 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 3:37 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 12:55 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Nick Piggin, (Mon Sep 8, 11:58 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 12:53 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Nick Piggin, (Tue Sep 9, 1:00 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 1:12 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 8:24 am)

Re: Re: [RFC][PATCH] Remove cgroup member from struct page, , (Tue Sep 9, 8:30 am)

[Approach #2] [RFC][PATCH] Remove cgroup member from struct ..., Balbir Singh, (Tue Sep 9, 9:20 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Dave Hansen, (Wed Sep 10, 6:21 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Nick Piggin, (Wed Sep 10, 6:38 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Balbir Singh, (Wed Sep 10, 6:36 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Dave Hansen, (Wed Sep 10, 6:56 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 9:35 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Balbir Singh, (Wed Sep 10, 9:47 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 9:56 pm)

[RFC][PATCH] Remove cgroup member from struct page (v3), Balbir Singh, (Wed Sep 17, 7:28 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Andrew Morton, (Wed Sep 17, 9:40 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 12:43 am)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Balbir Singh, (Thu Sep 18, 12:58 am)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 7:01 am)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Balbir Singh, (Thu Sep 18, 7:56 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 1:15 am)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Hirokazu Takahashi, (Thu Sep 18, 12:26 am)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 12:50 am)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Hirokazu Takahashi, (Thu Sep 18, 2:13 am)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Balbir Singh, (Wed Sep 17, 11:57 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 1:00 am)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., David Miller, (Wed Sep 10, 6:31 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Tue Sep 9, 9:49 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Nick Piggin, (Wed Sep 10, 4:44 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 7:03 am)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Nick Piggin, (Wed Sep 10, 5:02 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 7:27 am)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Balbir Singh, (Wed Sep 10, 10:34 am)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., Balbir Singh, (Tue Sep 9, 10:11 pm)

Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Tue Sep 9, 10:35 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 8:34 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Nick Piggin, (Tue Sep 9, 8:28 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Wed Sep 3, 3:31 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 11:28 pm)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 12:03 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:09 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 2:24 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:25 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 2:59 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 1:17 am)

Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:16 am)

Navigation

Popular discussions


linux-kernel:
Mark Lord	2.6.25-rc8: FTP transfer errors
Andrew Morton	echo mem > /sys/power/state
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Dushan Tcholich	Re: ksoftirqd high cpu load on kernels 2.6.24 to 2.6.27-rc1-mm1
openbsd-misc:

Colocation donated by:

Online users

Syndicate