Home » Mailing list archives » linux-kernel » 2008 » September » 17

[PATCH 19/23] AMD IOMMU: free domain bitmap with its allocation order

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Joerg Roedel
Subject: [PATCH 19/23] AMD IOMMU: free domain bitmap with its allocation order
Date: Wednesday, September 17, 2008 - 9:52 am

The amd_iommu_pd_alloc_bitmap is allocated with a calculated order and
freed with order 1. This is not a bug since the calculated order always
evaluates to 1, but its unclean code. So replace the 1 with the
calculation in the release path.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/amd_iommu_init.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index d8c1a45..a307cf6 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -1145,7 +1145,8 @@ out:
 	return ret;
 
 free:
-	free_pages((unsigned long)amd_iommu_pd_alloc_bitmap, 1);
+	free_pages((unsigned long)amd_iommu_pd_alloc_bitmap,
+		   get_order(MAX_DOMAIN_ID/8));
 
 	free_pages((unsigned long)amd_iommu_pd_table,
 		   get_order(rlookup_table_size));
-- 
1.5.6.4


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/23] AMD IOMMU 2.6.28 updates for review, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 01/23] AMD IOMMU: check for invalid device pointers, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 02/23] AMD IOMMU: move TLB flushing to the map/unma ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 04/23] AMD IOMMU: add branch hints to completion wa ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 05/23] AMD IOMMU: align alloc_coherent addresses pr ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 06/23] AMD IOMMU: add event buffer allocation, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 07/23] AMD IOMMU: save pci segment from ACPI tables, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 08/23] AMD IOMMU: save pci_dev instead of devid, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 09/23] AMD IOMMU: add MSI interrupt support, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 10/23] AMD IOMMU: add event handling code, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 11/23] AMD IOMMU: enable event logging, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 12/23] AMD IOMMU: allow IO page faults from devices, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 13/23] AMD IOMMU: add dma_supported callback, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 14/23] AMD IOMMU: don't assing preallocated protect ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 15/23] AMD IOMMU: some set_device_domain cleanups, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 16/23] AMD IOMMU: avoid unnecessary low zone alloca ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 17/23] AMD IOMMU: replace memset with __GFP_ZERO in ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 18/23] AMD IOMMU: simplify dma_mask_to_pages, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 19/23] AMD IOMMU: free domain bitmap with its alloc ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 20/23] AMD IOMMU: remove unnecessary cast to u64 in ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 21/23] AMD IOMMU: calculate IVHD size with a function, Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 22/23] AMD IOMMU: use cmd_buf_size when freeing the ..., Joerg Roedel, (Wed Sep 17, 9:52 am)
[PATCH 23/23] add AMD IOMMU tree to MAINTAINERS file, Joerg Roedel, (Wed Sep 17, 9:52 am)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, FUJITA Tomonori, (Wed Sep 17, 12:20 pm)
Re: [PATCH 18/23] AMD IOMMU: simplify dma_mask_to_pages, FUJITA Tomonori, (Wed Sep 17, 12:20 pm)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Joerg Roedel, (Wed Sep 17, 12:28 pm)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, FUJITA Tomonori, (Wed Sep 17, 6:29 pm)
Re: [PATCH 18/23] AMD IOMMU: simplify dma_mask_to_pages, Joerg Roedel, (Thu Sep 18, 12:32 am)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Joerg Roedel, (Thu Sep 18, 3:13 am)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Joerg Roedel, (Thu Sep 18, 7:03 am)
Re: [PATCH 18/23] AMD IOMMU: simplify dma_mask_to_pages, FUJITA Tomonori, (Thu Sep 18, 8:57 am)
Re: [PATCH 18/23] AMD IOMMU: simplify dma_mask_to_pages, Joerg Roedel, (Thu Sep 18, 9:39 am)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, FUJITA Tomonori, (Thu Sep 18, 4:10 pm)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Joerg Roedel, (Thu Sep 18, 11:29 pm)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, FUJITA Tomonori, (Fri Sep 19, 3:21 am)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Joerg Roedel, (Fri Sep 19, 10:43 am)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, FUJITA Tomonori, (Fri Sep 19, 11:40 am)
RE: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Keshavamurthy, Anil S, (Fri Sep 19, 11:47 am)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Joerg Roedel, (Fri Sep 19, 12:27 pm)
Re: [PATCH 03/23] AMD IOMMU: implement lazy IO/TLB flushing, Muli Ben-Yehuda, (Sat Sep 20, 10:27 pm)