linux-kernel mailing list

FromSubjectsort iconDate
Takashi Iwai
diet-kconfig: a script to trim unneeded kconfigs
Hi, a topic that just came up in kernel summit is a script to remove unneeded kernel configs automatically to reduce the compile time. Incidentally, I already wrote such a script during the last SUSE hack week a couple of weeks ago, so I'd like to share here, hopefully to give an idea for further improvements. The script checks the currently loaded modules and trims other CONFIG_XXX=m simply, and tries make oldconfig, and writes out the resultant .config in the current directory after some ...
Sep 16, 4:55 pm 2008
Arjan van de Ven
[PATCH] fs: add a sanity check in d_free
From 4ab03e637c357ea70c737cd401732a4d80375173 Mon Sep 17 00:00:00 2001 From: Arjan van de Ven <arjan@linux.intel.com> Date: Tue, 16 Sep 2008 16:51:17 -0700 Subject: [PATCH] fs: add a sanity check in d_free we're seeing some corruption in the dentry->d_alias list that appears like a free of an entry still on the list; this patch adds a WARN_ON() to catch this scenario, as suggested by Al Viro Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> --- fs/dcache.c | 1 + 1 files ...
Sep 16, 4:52 pm 2008
David Woodhouse
[PATCH] Fix autoloading of MacBook Pro backlight driver.
Use new MODULE_DEVICE_TABLE(dmi, ...) facility. There's no need for every driver to screw it up for themselves, when the alias can be generated automatically. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> diff --git a/drivers/video/backlight/mbp_nvidia_bl.c b/drivers/video/backlight/mbp_nvidia_bl.c index 385cba4..06964af 100644 --- a/drivers/video/backlight/mbp_nvidia_bl.c +++ b/drivers/video/backlight/mbp_nvidia_bl.c @@ -111,6 +111,4 @@ module_exit(mbp_exit); ...
Sep 16, 4:25 pm 2008
Matthew Garrett
Re: [PATCH] Fix autoloading of MacBook Pro backlight driver.
Acked-by: Matthew Garrett <mjg@redhat.com> -- Matthew Garrett | mjg59@srcf.ucam.org --
Sep 16, 4:36 pm 2008
David Woodhouse
[PATCH] Automatic MODULE_ALIAS() for DMI match tables.
This makes modpost handle MODULE_DEVICE_TABLE(dmi, xxxx). I had to change the string pointers in the match table to char arrays, and picked a size of 79 bytes almost at random -- do we need to make it bigger than that? I was a bit concerned about the 'bloat' this introduces into the match tables, but they should all be __initdata so it shouldn't matter too much. (Actually, modpost does go through the relocations and look at most of them; it wouldn't be impossible to make it handle string ...
Sep 16, 4:23 pm 2008
Yinghai Lu
[PATCH 4/5] acpi: add acpi_printk v3
use DEFINE_LOGLEVEL_SETUP to set loglevel for acpi v2: use <acpi, "acpi:"> instead v3: use KERN_ACPI Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/acpi/osl.c | 2 ++ include/linux/acpi.h | 1 + 2 files changed, 3 insertions(+) Index: linux-2.6/drivers/acpi/osl.c =================================================================== --- linux-2.6.orig/drivers/acpi/osl.c +++ linux-2.6/drivers/acpi/osl.c @@ -75,6 +75,8 @@ EXPORT_SYMBOL(acpi_in_debugger); extern ...
Sep 16, 4:13 pm 2008
Yinghai Lu
[PATCH 0/5] loglevel=pci:7,acpi:6 support v3
usage: in .h to have #define KERN_PCI "<pci>" in .c to have DEFINE_LOGLEVEL_SETUP(pci, KERN_PCI, "pci:"); then could use printk(KERN_DEBUG KERN_PCI fmt, ...); and command line loglevel=pci:8 you can add different printk to different files of one subsys if you like not just one susbsys one tag, and don't need to update kernel.h to add more tags YH --
Sep 16, 4:13 pm 2008
Yinghai Lu
[PATCH 5/5] apci: dump slit v4
v2: using boot_printk v3: using acpi_printk v4: using prink(KERN_DEBUG KERN_ACPI ... ) Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/acpi/numa.c | 8 ++++++++ 1 file changed, 8 insertions(+) Index: linux-2.6/drivers/acpi/numa.c =================================================================== --- linux-2.6.orig/drivers/acpi/numa.c +++ linux-2.6/drivers/acpi/numa.c @@ -150,6 +150,14 @@ static __init int slit_valid(struct acpi { int i, j; int d = ...
Sep 16, 4:13 pm 2008
Yinghai Lu
[PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v4
so could make subsys easy to add loglevel and xxx_printk v2: make it more genric, so subsys user only need to two line macro v3: add back nameStr, so could find out iommu: and iommu_gart: and etc v4: use printk intead of pci_printk usage: in .h to have #define KERN_PCI "<pci>" in .c to have DEFINE_LOGLEVEL_SETUP(pci, KERN_PCI, "pci:"); then could use printk(KERN_DEBUG KERN_PCI fmt, ...); and command line loglevel=pci:8 you can add different printk to different files of one ...
Sep 16, 4:13 pm 2008
Yinghai Lu
[PATCH 2/5] pci: add pci_printk v4
use DEFINE_LOGLEVEL_SETUP to set loglevel for pci v2: two lines only v3: use <pci, "pci:"> instead v4: use KERN_PCI Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/pci/pci.c | 2 ++ include/linux/pci.h | 2 ++ 2 files changed, 4 insertions(+) Index: linux-2.6/drivers/pci/pci.c =================================================================== --- linux-2.6.orig/drivers/pci/pci.c +++ linux-2.6/drivers/pci/pci.c @@ -1953,6 +1953,8 @@ static int __devinit ...
Sep 16, 4:13 pm 2008
Yinghai Lu
[PATCH 3/5] pci: using pci_printk v2
v2: use printk(KERN_DEBUG KERN_PCI ... Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/pci/probe.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6/drivers/pci/probe.c =================================================================== --- linux-2.6.orig/drivers/pci/probe.c +++ linux-2.6/drivers/pci/probe.c @@ -304,7 +304,7 @@ static int __pci_read_base(struct pci_de } else { res->start = l64; res->end = l64 + ...
Sep 16, 4:13 pm 2008
John Daiker
2.6.27-rc6 BUG: unable to handle kernel paging request
No idea what caused this, but that shall be left for more clever minds than I. x86_64, SMP, 4GB Ram, Gigabyte 965p-ds3 Attached: kernel config kernel oops Website: 'objdump -d vmlinux' of vmlinux in question. http://johndaiker.com/kernel/vmlinux.dump (9 MB tar.gz) John Daiker
Sep 16, 4:00 pm 2008
Ozgur Karatas
PHYSMAP compat code and warning messages lists (2.6.26.5)
Hello, My operating system Debian GNU/Linux "lenny"=20 I am compile new kernel version "2.6.26.5" warning PHYSMAP compat code.. what is PHYSMAP compat code? -> CC [M] drivers/mtd/maps/physmap.o drivers/mtd/maps/physmap.c:252:2: warning: #warning using PHYSMAP compat code and warning message: 1. CC [M] drivers/net/skfp/ess.o drivers/net/skfp/ess.c: In function =E2=80=98ess_send_response=E2=80=99: drivers/net/skfp/ess.c:513: warning: cast from pointer to integer of different ...
Sep 16, 4:04 pm 2008
Jesse Barnes
Re: pci warning regression fix
Oops, I meant to include this in my last pull request; I'll stuff it into my for-linus tree now. Thanks, Jesse --
Sep 16, 3:51 pm 2008
David Miller
pci warning regression fix
Greg, please proactively push this patch of your's upstream as it will kill off a regression list entry: http://marc.info/?l=linux-kernel&m=121976424221858&w=4 Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11439 Subject : [2.6.27-rc4-git4] compilation warnings Submitter : Rufus & Azrael <rufus-azrael@numericable.fr> Date : 2008-08-26 9:37 (18 days old) References : http://marc.info/?l=linux-kernel&m=121974353815440&w=4 Handled-By : Greg KH <gregkh@suse.de> Patch : ...
Sep 16, 3:42 pm 2008
David Miller
[PATCH]: Fix PNP build failure, bugzilla #11276
This fill fix the following regression list entry: Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11276 Subject : build error: CONFIG_OPTIMIZE_INLINING=y causes gcc 4.2 to do stupid things Submitter : Randy Dunlap <randy.dunlap@oracle.com> Date : 2008-08-06 17:18 (38 days old) References : http://marc.info/?l=linux-kernel&m=121804329014332&w=4 http://lkml.org/lkml/2008/7/22/353 Handled-By : Bjorn Helgaas <bjorn.helgaas@hp.com> Patch : http://lkml.org/lkml/2008/7/22/364 with ...
Sep 16, 3:00 pm 2008
Ozgur Karatas
Kernel compile warning message (2.6.26.5)
Warning message list kernel (2.6.26.5) cpu: Intel Celeron D 1. CC [M] drivers/pcmcia/i82365.o drivers/pcmcia/i82365.c: In function =E2=80=98init_i82365=E2=80=99: drivers/pcmcia/i82365.c:1296: warning: ignoring return value of =E2=80=98request_irq=E2=80=99, declared with attribute warn_unused_result 2. CC drivers/pci/search.o drivers/pci/search.c:145: warning: =E2=80=98pci_find_slot=E2=80=99 is depre= cated (declared at drivers/pci/search.c:134) drivers/pci/search.c:145: warning: ...
Sep 16, 4:06 pm 2008
Timur Tabi
dmaengine.c: question about device_alloc_chan_resources
Dan, Haavard, et al, I am making some fixes to the Freescale DMA driver (drivers/dma/fsldma.c), and I've come across a situation I don't understand. Specifically, I have an issue with the return values from fsl_dma_alloc_chan_resources(), which is fsldma's device_alloc_chan_resources() function. fsldma calls dma_async_device_register() for each DMA controller it finds. The problem is that when I use the dmatest driver, this results in device_alloc_chan_resources() being called multiple ...
Sep 16, 2:30 pm 2008
Daniel Walker
aacraid down_interruptible check
I was reviewing the patch below, and I'm a little confused about the added up() call. This semaphore is used to signal an interrupt arriving, where the code below is waiting for the interrupt. The added up() effectively signals that the interrupt arrived even tho it hasn't.. Which means the next down() call won't sleep at all it just falls through .. I don't think that is what's desired, but I though I would ask.. The other question is that it's called conditional on a potentially random ...
Sep 16, 2:30 pm 2008
Chase Douglas
Signal debugging/tracing
I'm debugging a uClibc pthreads issue that occurs during a stress test where many threads are looping many times forking off child processes that exec() other executables. Child processes are writing to a pipe that the parent threads are reading. After some iterations in the loops, the threads that are reading from the pipe using read() are getting EINTR. If you put the read in a loop so that an EINTR is ignored and you just try again, each subsequent read call returns immediately ...
Sep 16, 1:47 pm 2008
Ravikiran G Thirumalai
[2.6.27-rc6 regression] Intermittent boot problem with 2 ...
Hi, Booting 2.6.27-rc6, or the current Linus' git on large x86_64 NUMA wedges intermittently. This happens on machines with more than 4 NUMA nodes. The same kernel boots on similar hardware with fewer NUMA nodes (or boards). 2.6.27-rc3 seemed to boot well on similar configurations, so looks like a regression crept in between 2.6.27-rc3 and rc6. I am trying a few things -- commandline options to eliminate popular suspects (such as unsynced tsc clocksources) as well as git bisect, but wanted ...
Sep 16, 1:04 pm 2008
Németh Márton
[PATCH] cdrom: update ioctl documentation
From: Márton Németh <nm127@freemail.hu> Correct copy-paste problem: CDROMCLOSETRAY is about closing the tray, not opening it. Signed-off-by: Márton Németh <nm127@freemail.hu> --- --- linux-2.6.27-rc6/Documentation/ioctl/cdrom.txt.orig 2008-07-13 23:51:29.000000000 +0200 +++ linux-2.6.27-rc6/Documentation/ioctl/cdrom.txt 2008-09-16 20:29:16.000000000 +0200 @@ -271,14 +271,14 @@ CDROMCLOSETRAY pendant of CDROMEJECT usage: - ioctl(fd, CDROMEJECT, 0); + ioctl(fd, CDROMCLOSETRAY, ...
Sep 16, 12:51 pm 2008
Jonathan Steel
[PATCH] kexec, kernel 2.6.26.5, segmentation fault in ki ...
A segmentation fault can occur in kimage_add_entry in kexec.c when loading a kernel image into memory. The fault occurs because a page is requested by calling kimage_alloc_page with gfp_mask GFP_KERNEL and the function may actually return a page with gfp_mask GFP_HIGHUSER. The high mem page is returned because it was swapped with the kernel page due to the kernel page being a page that will shortly be copied to. This patch ensures that kimage_alloc_page returns a page that was created ...
Sep 16, 12:18 pm 2008
Eric W. Biederman
[PATCH] kexec: segmentation fault in kimage_add_entry
From: Jonathan Steel <jon.steel@esentire.com> A segmentation fault can occur in kimage_add_entry in kexec.c when loading a kernel image into memory. The fault occurs because a page is requested by calling kimage_alloc_page with gfp_mask GFP_KERNEL and the function may actually return a page with gfp_mask GFP_HIGHUSER. The high mem page is returned because it was swapped with the kernel page due to the kernel page being a page that will shortly be copied to. This patch ensures that ...
Sep 16, 3:21 pm 2008
Upgrade Team
Warning Code:USV64MT1
Dear Email Account Owner, This message is from UPGRADING messaging center to all WEBMAIL emailaccount owners. We are currently upgrading our data base and e-mail account center. We are deleting all unused email account to create space for new accounts.To prevent your account from being deactivated you will have to update it. CONFIRM YOUR EMAIL ACCOUNT Email Username : ............... Email Password : .............. Date of Birth : .................. Country or Territory : ...
Sep 16, 11:20 am 2008
Arjan van de Ven
[PATCH] x86: print DMI information in the oops trace
From: Arjan van de Ven <arjan@linux.intel.com> Subject: [PATCH] x86: print DMI information in the oops trace in order to diagnose hard system specific issues, it's useful to have the system name in the oops (as provided by DMI) Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> --- arch/x86/kernel/process_32.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c index 4eb2159..d9f34cf ...
Sep 16, 11:27 am 2008
Yinghai Lu
[PATCH 4/5] acpi: add acpi_printk v2
use DEFINE_LOGLEVEL_SETUP to set loglevel for acpi v2: use <acpi, "acpi:"> instead Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/acpi/osl.c | 2 ++ include/linux/acpi.h | 1 + 2 files changed, 3 insertions(+) Index: linux-2.6/drivers/acpi/osl.c =================================================================== --- linux-2.6.orig/drivers/acpi/osl.c +++ linux-2.6/drivers/acpi/osl.c @@ -75,6 +75,8 @@ EXPORT_SYMBOL(acpi_in_debugger); extern char line_buf[80]; ...
Sep 16, 11:01 am 2008
H. Peter Anvin
Re: [PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v3
Come to think about it, it might help migration pains if we put the prefixes in the opposite order (KERN_DEBUG KERN_PCI). -hpa --
Sep 16, 2:18 pm 2008
Yinghai Lu
[PATCH 0/5] loglevel=pci:7,acpi:6 support
usage: in .c to have DEFINE_LOGLEVEL_SETUP(pci, "pci:"); in .h to have DECLARE_LOGLEVE(pci); then could use pci_printk(KERN_LOG_DEBUG, fmt, ...); and command line loglevel=pci:7 you can add different printk to different files of one subsys if you like not just one susbsys one tag, and don't need to update kernel.h to add more tags YH --
Sep 16, 11:01 am 2008
Yinghai Lu
[PATCH 3/5] pci: using pci_printk
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/pci/probe.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6/drivers/pci/probe.c =================================================================== --- linux-2.6.orig/drivers/pci/probe.c +++ linux-2.6/drivers/pci/probe.c @@ -304,7 +304,7 @@ static int __pci_read_base(struct pci_de } else { res->start = l64; res->end = l64 + sz64; - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: ...
Sep 16, 11:01 am 2008
Yinghai Lu
[PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v3
so could make subsys easy to add loglevel and xxx_printk v2: make it more genric, so subsys user only need to two line macro v3: add back nameStr, so could find out iommu: and iommu_gart: and etc usage: in .c to have DEFINE_LOGLEVEL_SETUP(pci, "pci:"); in .h to have DECLARE_LOGLEVE(pci); then could use pci_printk(KERN_LOG_DEBUG, fmt, ...); and command line loglevel=pci:7 you can add different printk to different files of one subsys if you like Signed-off-by: Yinghai Lu ...
Sep 16, 11:01 am 2008
Yinghai Lu
[PATCH 2/5] pci: add pci_printk v3
use DEFINE_LOGLEVEL_SETUP to set loglevel for pci v2: two lines only v3: use <pci, "pci:"> instead Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/pci/pci.c | 2 ++ include/linux/pci.h | 2 ++ 2 files changed, 4 insertions(+) Index: linux-2.6/drivers/pci/pci.c =================================================================== --- linux-2.6.orig/drivers/pci/pci.c +++ linux-2.6/drivers/pci/pci.c @@ -1953,6 +1953,8 @@ static int __devinit pci_setup(char *str } ...
Sep 16, 11:01 am 2008
H. Peter Anvin
Re: [PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v3
The difference is that things that read the kernel log in userspace will be able to make partial sense of the latter, but not the former. It will thus make the transition smoother. -hpa --
Sep 16, 2:55 pm 2008
Yinghai Lu
[PATCH 5/5] apci: dump slit v3
v2: using boot_printk v3: using acpi_printk Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/acpi/numa.c | 8 ++++++++ 1 file changed, 8 insertions(+) Index: linux-2.6/drivers/acpi/numa.c =================================================================== --- linux-2.6.orig/drivers/acpi/numa.c +++ linux-2.6/drivers/acpi/numa.c @@ -150,6 +150,14 @@ static __init int slit_valid(struct acpi { int i, j; int d = slit->locality_count; + acpi_printk(KERN_LOG_DEBUG, ...
Sep 16, 11:01 am 2008
Marcin Slusarz
Re: [PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v3
maybe #define KERN_LOG_EMERG 0,KERN_EMERG #define KERN_LOG_ALERT 1,KERN_ALERT ... ? or better - create printk2(level, fmt) which prints "<", level, ">", fmt and wrap it with pci_printk / acpi_printk? Marcin --
Sep 16, 12:02 pm 2008
Yinghai Lu
Re: [PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v3
On Tue, Sep 16, 2008 at 12:02 PM, Marcin Slusarz will come out one new version that hpa likes printk(KERN_PCI KERN_DEBUG "sadfasf\n"); YH --
Sep 16, 2:04 pm 2008
Yinghai Lu
Re: [PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v3
according to the code flow, these two is the same... will double check it. YH --
Sep 16, 2:28 pm 2008
Arjan van de Ven
Warning/Oops report of the week of September 16th, 2008
This is the first report where I've dropped oopses that happened to 2.6.25 or earlier kernels. I've also changed the format of the report to split it in "fixed" and "not yet fixed" sections; I hope that makes the report more useful for developers. This week, a total of 1730 oopses and warnings have been reported, compared to 626 reports in the previous week. Per file ...
Sep 16, 9:22 am 2008
Michael Trimarchi
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
hi, I agree :) __________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi http://mail.yahoo.it --
Sep 16, 9:01 am 2008
Folkert van Heusden
PPS (pulse per second) patch inclusion?
Hi, Any chance that the PPS patch will be included in 2.6.28? As currently people have to fall back to things like freebsd for accurate timekeeping using a GPS. Folkert van Heusden -- MultiTail è uno flexible tool per seguire di logfiles e effettuazione di commissioni. Feltrare, provedere da colore, merge, 'diff-view', etc. http://www.vanheusden.com/multitail/ ---------------------------------------------------------------------- Phone: +31-6-41278122, PGP-key: 1F28D8AE, ...
Sep 16, 8:59 am 2008
Alan Cox
Re: [PATCH] x86: Don't use NOPL on 32-bit cpu's because ...
Make the user pass a "vpcworkarounds" boot option... --
Sep 16, 10:00 am 2008
H. Peter Anvin
Re: [PATCH] x86: Don't use NOPL on 32-bit cpu's because ...
<joke> Kernel Tainted: Microsoft </joke> -hpa --
Sep 16, 10:28 am 2008
David Sanders
Re: [PATCH] x86: Don't use NOPL on 32-bit cpu's because ...
I think you still want the nopl enabled for 64-bits. This is how I detect virtual pc. I based it on a google search. Microsoft itself provides no info: #include <stdio.h> #include <signal.h> #include <stdlib.h> void except(int e) { printf("Not in Virtual PC\n"); exit(1); } int main() { signal(SIGILL, except); asm("\n" "mov $0x01, %eax\n" /* function number */ ".byte 0x0f, 0x3f, 0x07, 0x0b\n" /* call VPC */ ); printf("Inside Virtual PC\n"); return ...
Sep 16, 10:48 am 2008
David Sanders
[PATCH] x86: Don't use NOPL on 32-bit cpu's because not ...
From: David Sanders <linux@sandersweb.net> Currently in alternative.c NOPLs are introduced based on the synthetic cpu feature X86_FEATURE_NOPL. However, some systems (like Virtual PC 2007) appear to support it but then will not boot 50% of the time because of the NOPLs (when paravirtualization support is built into kernel). This patch standardizes the treatment of NOPL to be like include/asm-x86/nops.h which only uses NOPLs on 64-bit processors. Applies to 2.6.27-rc6. Signed-off-by: David ...
Sep 16, 8:59 am 2008
David Sanders
Re: [PATCH] x86: Don't use NOPL on 32-bit cpu's because ...
Actually, you can pass noreplace-paravirt, but that is non-obvious to the regular user. --
Sep 16, 10:50 am 2008
H. Peter Anvin
Re: [PATCH] x86: Don't use NOPL on 32-bit cpu's because ...
Oh good grief. VPC is apparently so broken that these instructions work *some* of the time, which may include the first time, but not later. That is an impressive level of cockup. Given that, we should either just rip this code out, or detect VPC (how?). The latter option can be done post-.27, of course; if so, we should just force the bit off for now rather than doing it in the alternatives code. The only reason for doing the latter at all would be to mitigate the overhead of ...
Sep 16, 9:32 am 2008
H. Peter Anvin
Re: [PATCH] x86: Don't use NOPL on 32-bit cpu's because ...
Well, isn't that "interesting". 0F 3F is in the range expected (although not documented) to be used for 3-byte opcode prefixes in the future. It's also the Centaur ALTINST instruction (which I believe have to be enabled via an MSR, so in that way it's not a bad choice.) It's definitely less broken than the official way to detect VMWare, but still pretty daft. (CPUID, MSR or PCI IDs make a lot more sense.) The "official" way to detect Virtual PC is apparently to look for "Microsoft ...
Sep 16, 11:03 am 2008
Matthew Wilcox
Re: [PATCH] vfs: added better file aio_read aio_write op ...
const struct file_operations *f_op; Having said that, BUILD_BUG_ON(!f_op->aio_read) is fine by me ... make the filesystem writer put it in without slowing down anyone at runtime. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." --
Sep 16, 8:41 am 2008
Bodo Eggert
Re: [PATCH] vfs: added better file aio_read aio_write op ...
Why can't the file system registration code set filp->f_op->aio_read to generic_file_aio_read? --
Sep 16, 8:36 am 2008
Bodo Eggert
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Maybe file_pos_write should do this check? --
Sep 16, 8:32 am 2008
Michael Trimarchi
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Hi, Cc: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; Maybe it is clear with an example: +/* + * file_pos_read/write is atomic by using sequence lock on 32bit arch. + */ +static inline loff_t file_pos_read(struct file *file) +{ +#if BITS_PER_LONG == 32 && defined(CONFIG_SMP) + loff_t pos; + unsigned int seq; + + do { + seq = read_seqbegin(&file->f_pos_seqlock); + pos = file->f_pos; + } while ...
Sep 16, 7:57 am 2008
Jacek Poplawski
Re: motherboard recommendations?
I was thinking the same few years ago, but on two Asus boards two had problems. K8V-X SE is the board I have now, it's very bad choice for Linux, it crashes very often when starting X (with DRI) - it's related to buggy BIOS and AGP. On another board SATA was supported after few months and there was constant problem with network (there was long discussion about it on LKML) - networking was working after boot but stops working after a while. It was never fixed, so I don't use this board ...
Sep 16, 7:39 am 2008
John Stoffel
Re: motherboard recommendations?
Jacek> I was thinking the same few years ago, but on two Asus boards Jacek> two had problems. K8V-X SE is the board I have now, it's very Jacek> bad choice for Linux, it crashes very often when starting X Jacek> (with DRI) - it's related to buggy BIOS and AGP. Sure, I can understand your frustration here. I'd be pissed too. :] I spent a bunch of time looking at motherboards and finally settled on the one I got because of good reports. Don't get a recent board, get something that's been ...
Sep 16, 7:55 am 2008
Larry Finger
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
I didn't say it was not possible. What I said is that _ONLY_ the operator's finger could change the state, just like in your laptop. Thus it makes absolutely no difference what state RFKILL thinks it is in. The driver knows what state the software wants, and can read but not write the hardware state. There has to be a bug in RFKILL that got exposed when this commit was included. This regression needs to be fixed ASAP, otherwise 2.6.27 will be released with it. If the RFKILL guys want to fix ...
Sep 16, 12:30 pm 2008
Matthew Garrett
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
Of course it makes a difference. The reason why two states are provided is to allow userspace to distinguish whether it can unblock the device or not. It's clear that b43's rfkill code is astonishingly broken (and that's not a criticism of anyone involved - the documentation's confusing and there weren't any good examples of how it should be implemented). The real question is how the LED state is supposed to be being toggled, and what that's got to do with rfkill. I /think/ that the ...
Sep 16, 4:32 pm 2008
Henrique de Moraes H ...
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
rfkill_force_state(). Must NOT be called from within atomic contextes, something I haven't got around to find a proper way of fixing, and nobody I won't go on the rfkill-allocate/-free stuff, messing with that API means you need to fix a lot of other people's drivers. But you have the rfkill-hw-state-changed now, it is called rfkill_force_state(). The only Read Documentation/rfkill.txt. And the kernel-doc comments on rfkill.c. The rfkill documentation was updated. If you still have ...
Sep 16, 3:37 pm 2008
Matthew Garrett
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
Oh, hey, I suck. This one might stand a better chance of not falling over. diff --git a/drivers/net/wireless/b43/rfkill.c b/drivers/net/wireless/b43/rfkill.c index fec5645..991e318 100644 --- a/drivers/net/wireless/b43/rfkill.c +++ b/drivers/net/wireless/b43/rfkill.c @@ -49,21 +49,18 @@ static void b43_rfkill_update_state(struct b43_wldev *dev) struct b43_rfkill *rfk = &(dev->wl->rfkill); if (!dev->radio_hw_enable) { - rfk->rfkill->state = ...
Sep 16, 2:09 pm 2008
Larry Finger
Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef0 ...
Since commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f entitled "b43/b43legacy: add RFKILL_STATE_HARD_BLOCKED support", the radio LED no longer responds to rfkill switch events. ATM, I do not have a fix, other than reversion of this commit. Larry --
Sep 16, 7:18 am 2008
Larry Finger
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
It locks up tight with a kernel panic when booting. I have a screen picture that I will send separately to Matthew. Larry --
Sep 16, 1:34 pm 2008
Larry Finger
Re: Regression in 2.6.27-rcX caused by commit bc19d ...
This one doesn't crash, but it doesn't turn the light off. I'm done testing for now! John, Revert the patch until the rfkill guys get their house in order. Larry --
Sep 16, 2:07 pm 2008
Carlos Corbacho
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
When I disable the b43 device in my laptop via acer-wmi (which in turn, calls into the laptops firmware), b43 physically cannot re-enable it (a not uncommon case on a lot of laptops). In which case, as far as b43 is concerned, the wireless radio is then in RFKILL_STATE_HARD_BLOCKED, since b43 is unable to re-enable the radio on the hardware. So yes, it is quite possible for b43 to be in RFKILL_STATE_HARD_BLOCKED. -Carlos -- E-Mail: carlos@strangeworlds.co.uk Web: ...
Sep 16, 12:18 pm 2008
Michael Buesch
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
It's kind of bogus that it pokes with the software rfkill state from within the hardware rfkill handler. Please revert this patch. The commit log says nothing about why this is needed and I don't see a point in overriding the state in the rfkill-private data structure from within the driver. -- Greetings Michael. --
Sep 16, 8:42 am 2008
Henrique de Moraes H ...
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
Hmm... if this lack of LED control when HARD_BLOCKED is a problem in rfkill, I will track it down and fix it. The rest of the stuff (b43's usage of rfkill), is a problem for the people who know the b43 driver to fix, I don't dare touch it and break it further. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh --
Sep 16, 3:40 pm 2008
Larry Finger
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
I agree with Michael. From what I know, the only possible reason for having this state would be if user space could somehow affect the state of the hardware switch. As the user's finger is the only such thing, then there is no use for the RFKILL_STATE_HARD_BLOCKED state, particularly when it breaks LED operations. Please revert the patch. Larry --
Sep 16, 10:08 am 2008
Carlos Corbacho
Re: Regression in 2.6.27-rcX caused by commit bc19d ...
Just this should be enough to fix the regression for 2.6.27 (and should be trivial to port to b43legacy) in the immediate term (I was planning to send something similar). The rest of the patch is out-of-scope for 2.6.27, but is definitely along he right lines, IMHO (and it would be good if we can get a working version of it in to 2.6.28). I may try and look at it later, as I do have my b43 hardware handy. -Carlos -- E-Mail: carlos@strangeworlds.co.uk Web: strangeworlds.co.uk GPG Key ...
Sep 16, 1:44 pm 2008
Matthew Garrett
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
RFKILL_STATE_HARD_BLOCKED indicates that the hardware is disabled in a way that userspace can't influence, so sounds like exactly the right state to have here. I still have absolutely no idea what b43 rfkill is supposed to be doing - why on earth is it requesting rfkill-input, and why does it generate keypress events? I /think/ it should e something like the following (untested, I'm not near any of my b43 hardware at the moment). This basically does the following: 1) Split the update ...
Sep 16, 12:51 pm 2008
Michael Buesch
Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b7 ...
Sure it is. It's the common case, if there's a button. But I don't know how to tell the rfkill subsystem about the states and I do not _want_ to. See, that crap code _always_ blew up for every single patch we did. I'm tired of this and I am not interested in that anymore. Please revert that patch and if that makes it work I'm fine with it. I'm still waiting for the sane rfkill API where we have three functions rfkill-allocate rfkill-hw-state-changed rfkill-free That's all I need. All ...
Sep 16, 12:25 pm 2008
Alexander Pazdnikov
Re: 2.6.26.5-rt9
Hello. static inline ftrace_event_irq was removed from include/linux/ftrace.h that was in 2.6.26-rt1 patch /arch/arm/kernel/irq.c:118: error: implicit declaration off function 'ftrace_event_irq' It forced to delete this call, but is it possible to fix it correctly? Otherwise kernel failed to compile. -- Best regards, Alexander Pazdnikov --
Sep 16, 7:16 am 2008
Michael Trimarchi
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Hi, i was thinking about introducing a file_pos_update() not implemented using file_pos_read()/file_pos_write() and taking the seq_lock or disabling preemption only one time __________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi http://mail.yahoo.it --
Sep 16, 6:57 am 2008
Nick Piggin
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
AFAIK, the only way to do an atomic 64 bit store on 32-bit x86 is "cmpxchg8b" (with lock prefix on SMP). That would be far slower I'm sure. --
Sep 16, 7:11 am 2008
Jacek Poplawski
motherboard recommendations?
Could you recommend motherboard which works perfecly stable with Linux? Last time I bought Asus K8V-X SE which was huge mistake - it has serious problems with AGP in Linux. Now I think about Intel chipset - P35 or P45. I want Asus, Gigabyte or MSI board with heat pipe. But I found another issue with audio and network drivers for Asus boards, so maybe I will skip Asus this time? Which motherboard works stable for you? --
Sep 16, 6:57 am 2008
David Sanders
Re: motherboard recommendations?
Intel D975XBX works very stable for me. --
Sep 16, 8:50 am 2008
Chris Snook
Re: motherboard recommendations?
The conventional way of ensuring that a piece of hardware will work well with Linux is to hire a few kernel developers, and ship a hundred samples to other kernel developers around the world, with complete hardware specs. This technique is slow and expensive, and still not foolproof. Alternatively, you could ask for motherboard recommendations on an enthusiast forum, which this mailing list is not. This technique is fast and cheap, but still not foolproof. -- Chris --
Sep 16, 12:22 pm 2008
Jesse Barnes
Re: [PATCH 2.6.27-rc6] PCI: Fix pcie_aspm=force
Thanks, I applied this to my for-linus branch so we can try to get this fixed for 2.6.27. Jesse --
Sep 16, 9:19 am 2008
Alan Cox
Re: [PATCH 2.6.27-rc6] PCI: Fix pcie_aspm=force
On Tue, 16 Sep 2008 14:27:13 +0100 Acked-by: Alan Cox <alan@redhat.com> --
Sep 16, 7:08 am 2008
Sitsofe Wheeler
[PATCH 2.6.27-rc6] PCI: Fix pcie_aspm=force
From: Sitsofe Wheeler <sitsofe@yahoo.com> pcie_aspm=force did not work because aspm_force was being double negated leading to the sanity check failing. Moving a bracket should fix this. Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com> --- drivers/pci/pcie/aspm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index 9a7c9e1..851f5b8 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -527,7 ...
Sep 16, 6:27 am 2008
Chris Snook
Re: How to find out, what "pdflush" is working on
The key word is "ideally". We'd like it to work that way, but it doesn't. Patches to fix this are welcome. -- Chris --
Sep 16, 12:07 pm 2008
Martin Knoblauch
How to find out, what "pdflush" is working on
Hi, I find the following comment in mm/pdflush.c /* * The pdflush threads are worker threads for writing back dirty data. * Ideally, we'd like one thread per active disk spindle. But the disk * topology is very hard to divine at this level. Instead, we take * care in various places to prevent more than one pdflush thread from * performing writeback against a single filesystem. pdflush threads * have the PF_FLUSHER flag set in current->flags to aid in this. */ Is there a way ...
Sep 16, 6:09 am 2008
Xu Yang
Re: looking for a function
Hi Frederic, thank you very much! this is very useful for me. :-) Best regards, Yang --
Sep 16, 7:33 am 2008
Xu Yang
looking for a function
Hi guys, I am looking for a function that can show me the current thread is running on which cpu. e.g I am using pthread to write a multithreaded program, in each thread I would like to insert such kind of function so that I can know on which cpu this thread is running on. which function should be used? thanks for the help!! best regards, Yang --
Sep 16, 5:50 am 2008
Frédéric Weisbecker
Re: looking for a function
And perhaps you should have a look at the sched_switch tracer which will log for you the different context switches. Regards, Frederic. --
Sep 16, 7:29 am 2008
Xu Yang
Re: looking for a function
Hi Arjan, thanks, I will try that! Best regards, Yang --
Sep 16, 7:32 am 2008
Bernd Petrovitsch
Re: looking for a function
Hi! That doesn't make much sense as the same thread can run on a different CPU after each scheduling decision. And - as it is in userspace - scheduling can happen before any assembler op. Bernd -- Firmix Software GmbH http://www.firmix.at/ mobil: +43 664 4416156 fax: +43 1 7890849-55 Embedded Linux Development and Services --
Sep 16, 7:00 am 2008
Chris Snook
Re: looking for a function
getcpu() should do what you want. --
Sep 16, 12:04 pm 2008
Arjan van de Ven
Re: looking for a function
On Tue, 16 Sep 2008 16:11:10 +0200 the getcpu() system call will do what you want. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org --
Sep 16, 7:18 am 2008
Xu Yang
Re: looking for a function
Hi Bernd, thanks for you reply. yes, I know the thread migrates all the time, this is exactly what I would like to observe. I would like to learn about the thread migration of some specific scheduling algorithm. so .... any idea about the function? Best regards, Yang --
Sep 16, 7:11 am 2008
Kirill A. Shutemov
[PATCH] linux/inotify.h: do not include <linux/fcntl.h> ...
<linux/fcntl.h> conflicts with glibc's <fcntl.h>. It breaks building kdelibs, kdepim and pinot. It's regression itroduced by commit 4006553. Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name> Cc: Ulrich Drepper <drepper@redhat.com> Cc: Davide Libenzi <davidel@xmailserver.org> Cc: David Woodhouse <dwmw2@infradead.org> Cc: Andrew Morton <akpm@linux-foundation.org> --- include/linux/inotify.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git ...
Sep 16, 5:22 am 2008
Adrian Bunk
Re: [PATCH] linux/inotify.h: do not include <linux/fcntl ...
Kernel headers and glibc headers are an own story, Ulrich might know best about that. But I'm wondering, why is kdelibs doing <-- snip --> ... #include <fcntl.h> #include <sys/syscall.h> #include <linux/types.h> // Linux kernel headers are documented to not compile #define _S390_BITOPS_H #include <linux/inotify.h> static inline int inotify_init (void) { return syscall (__NR_inotify_init); } ... <-- snip --> pinot even contains a file with the inotify syscall ...
Sep 16, 6:31 am 2008
Adrian Bunk
Re: [PATCH] linux/inotify.h: do not include <linux/fcntl ...
Even if userspace applications shouldn't use it directly this doesn't sound right: We shouldn't force all libc implementations to copy the contents into a private header. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
Sep 16, 9:09 am 2008
Kirill A. Shutemov
Re: [PATCH] linux/inotify.h: do not include <linux/fcntl ...
/usr/include/asm-generic/fcntl.h:117: error: redefinition of 'struct flock' /usr/include/bits/fcntl.h:142: error: previous definition of 'struct flock' /usr/include/asm-generic/fcntl.h:140: error: redefinition of 'struct flock64' /usr/include/bits/fcntl.h:157: error: previous definition of 'struct --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/
Sep 16, 6:02 am 2008
Ulrich Drepper
Re: [PATCH] linux/inotify.h: do not include <linux/fcntl ...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 And? None of these programs should use <linux/inotify.h>. There has for the longest time been a <sys/inotify.h> header which doesn't need any kernel headers. In fact, <linux/inotify.h> should not be exported. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 ...
Sep 16, 7:10 am 2008
Adrian Bunk
Re: [PATCH] linux/inotify.h: do not include <linux/fcntl ...
We should rather fix the actual bug. This breaks the header for users of IN_CLOEXEC/IN_NONBLOCK. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
Sep 16, 5:58 am 2008
Kirill A. Shutemov
Re: [PATCH] linux/inotify.h: do not include <linux/fcntl ...
Ok. Let's unexport <linux/inotify.h>. diff --git a/include/linux/Kbuild b/include/linux/Kbuild index b68ec09..dbb8107 100644 --- a/include/linux/Kbuild +++ b/include/linux/Kbuild @@ -240,7 +240,6 @@ unifdef-y +=3D igmp.h unifdef-y +=3D inet_diag.h unifdef-y +=3D in.h unifdef-y +=3D in6.h -unifdef-y +=3D inotify.h unifdef-y +=3D input.h unifdef-y +=3D ip.h unifdef-y +=3D ipc.h diff --git a/include/linux/inotify.h b/include/linux/inotify.h index bd57857..0188b6a 100644 --- ...
Sep 16, 7:43 am 2008
Oleg Nesterov
Re: sys_paccept: disable paccept() until API design is r ...
Also, the implementation of sys_paccept() is not "perfect", imho. sys_paccept: ret = do_accept(...); if (ret < 0 && signal_pending()) { set_restore_sigmask(); return ret; } It doesn't check that ret == ERESTARTSYS/EINTR. I can't say this is bug, but let's suppose that do_accept() returns (say) -EINVAL, and then the task is interrupted by the signal. Now, if the signal comes after sys_paccept() checks signal_pending(), we return -EINVAL, and the signal handler runs ...
Sep 16, 6:04 am 2008
Ulrich Drepper
Re: sys_paccept: disable paccept() until API design is r ...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 It would unnecessarily require programs to be changed. I've explained that programs cannot efficiently use accept() and poll() when multiple threads are involved. This means in these situations you'll find a This is because none of the other interfaces had (so far) be revised. You use your own opinion as the deciding factor? The behavior differs The signal set wasn't actually my idea. See: I have explained the need already. you ...
Sep 16, 4:17 pm 2008
Michael Kerrisk
sys_paccept: disable paccept() until API design is resolved
Andrew, The patch below disables the new sys_paccept() for now. Please apply for 2.6.27-rc, so that we do not release this API into the wild before a conclusion has been reached about its design. The reasons for disabling paccept() are as follows: * The API is more complex than needed. There is AFAICS no demonstrated use case that the sigset argument of this syscall serves that couldn't equally be served by the use of pselect/ppoll/epoll_pwait + traditional accept(). Roland ...
Sep 16, 5:05 am 2008
Michael Trimarchi
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Is not more efficient here a compare xchg operation? Regards Michael __________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi http://mail.yahoo.it --
Sep 16, 4:11 am 2008
Nick Piggin Sep 16, 5:54 am 2008
Hisashi Hifumi
[PATCH] VFS: make file->f_pos access atomic on 32bit arch
Hi. Currently reading or writing file->f_pos is not atomic on 32bit environment, so two or more simultaneous access can corrupt file->f_pos value. There are some past discussions about this issue, but this is not fixed yet. http://marc.info/?l=linux-kernel&m=120764199819899&w=2 http://marc.info/?l=linux-kernel&m=114490379102476&w=2 Protecting file->f_pos with a lock adds some overhead but I think we should fix this. I used seqlock to serialize the access to file->f_pos. This approach is ...
Sep 16, 3:35 am 2008
Ben Dooks
wdt285: fix sparse warnings
The wdt285.c watchdog driver is producing a number of sparse errors due to missing __user attributes to calls to put_user and copy_to_user, as well as in the prototype of watchdog_write. wdt285.c:144:21: warning: incorrect type in argument 1 (different address spaces) wdt285.c:144:21: expected void [noderef] <asn:1>*to wdt285.c:144:21: got void *<noident> wdt285.c:150:9: warning: incorrect type in initializer (different address spaces) wdt285.c:150:9: expected int const [noderef] ...
Sep 16, 3:31 am 2008
Mark Brown
[PATCH 1/2] mfd: Core support for the WM8400 AudioPlus H ...
The WM8400 is a highly integrated audio CODEC and power management unit optimised for use in mobile multimedia applications. This patch adds core support for the WM8400 to the MFD subsystem. Both I2C and SPI access are supported by the hardware but currently only I2C access is implemented. The code is structured to allow SPI support to be slotted in later. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- Changes since last time: - Don't depend on MFD_CORE, we don't use ...
Sep 16, 2:43 am 2008
Mark Brown
[PATCH 2/2] regulator: Add WM8400 regulator support
The WM8400 provides two programmable DCDC step-down (buck) convertors and four low-dropout (LDO) regulators. This driver provides support for runtime managment of these in the standard regulator API. Support for configuration of the suspend and hibernate mode behaviour of the regulators is not yet included. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- Changes since last time: - Report that the optimum mode is REGULATOR_MODE_NORMAL rather than _IDLE. ...
Sep 16, 2:43 am 2008
Mark Brown
[PATCH 0/2] WM8400 support v2
These patches against the regulator development tree add basic support for the WM8400, an audio CODEC and PMU targeted at multimedia systems, covering basic PMIC functionality only. Since the functionality of the device covers multiple subsystems with arbitration required a core driver is provided in drivers/mfd. I think I've covered all the issues raised last time, erring on the side of split headers rather than unifying them, details in the individual patches. The following changes since ...
Sep 16, 2:42 am 2008
Christoph Hellwig
Re: [PATCH] vfs: added better file aio_read aio_write op ...
A NULL pointer derference is just as clear as the bug.. --
Sep 16, 9:36 am 2008
Marco Stornelli
Re: [PATCH] vfs: added better file aio_read aio_write op ...
BUG_ON it was a way to say: "hey you've used the do_sync_read/write as read/write operation but you don't specified an aio_read/write", but your solutions it's good too. --
Sep 16, 4:13 am 2008
Manish Katiyar
Re: [PATCH] vfs: added better file aio_read aio_write op ...
On Tue, Sep 16, 2008 at 4:43 PM, Marco Stornelli Looks like I made some copy paste error while sending the patch. Below is the updated one. Signed-off-by: Manish Katiyar <mkatiyar@gmail.com> --- fs/read_write.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 9ba495d..b89b707 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -225,7 +225,10 @@ ssize_t do_sync_read(struct file *filp, char __user *buf, size_t ...
Sep 16, 4:31 am 2008
Manish Katiyar
Re: [PATCH] vfs: added better file aio_read aio_write op ...
On Tue, Sep 16, 2008 at 2:59 PM, Marco Stornelli Instead of doing a BUG_ON() why can't we simply fall back to the generic_aio functions since most of the fs tend to do so as below. Signed-off-by: Manish Katiyar <mkatiyar@gmail.com> --- fs/read_write.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 9ba495d..5439bc4 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -225,7 +225,11 @@ ssize_t ...
Sep 16, 4:03 am 2008
Marco Stornelli
[PATCH] vfs: added better file aio_read aio_write operat ...
From: Marco Stornelli <marco.stornelli@gmail.com> If a filesystem in the file operations specifies for read and write operations only do_sync_read and do_sync_write without init aio_read and aio_write, there will be a kernel oops, because the vfs code check the presence of (to read for example) read OR aio_read method, then it calls read if it's pointer is not null. It's not sufficient because if the read function is actually a do_sync_read, it calls aio_read but without checking the presence. I ...
Sep 16, 2:29 am 2008
Cornelius, Martin (DWBI)
RE: Server process stalled during massive thread creatio ...
Hi Chris, thanks for answering my question. I repeated the test, giving the 'netcat' server a much higher priority than the load generators, and indeed, the stalling disappeared. ************************************************ The information contained in, or attached to, this e-mail, may contain confidential information and is intended solely for the use of the individual or entity to whom they are addressed and may be subject to legal privilege. If you have received this e-mail in ...
Sep 16, 2:27 am 2008
Arun R Bharadwaj
[RFC PATCH 1/1]: timers: Enabling timer migration to cpu0
The implentation details of this as follows: A sysfs entry is created at /sys/devices/system/cpu/cpuX/timer_migration. By setting this to 1, timer migration is enabled for that cpu. An important thing to note here is cpu-pinned timers. Timers can be pinned to a particular cpu using the function add_timer_on(). So, such timers should not be migrated. Since the last 3 bits of the tvec_base is guaranteed to be 0, and since the last bit is being used to indicate deferrable timers, I'm using the second ...
Sep 16, 2:13 am 2008
Peter Zijlstra
Re: [RFC PATCH 1/1]: timers: Enabling timer migration to cpu0
You utterly fail to mention hrtimers even though you do touch those as well, what's more - there are hrtimers that need to be run on the cpu Why bother with the CONFIG_ variable - its so little code and it adds to We don't indent preprocessor directives like that, also we don't use idem --
Sep 16, 5:05 am 2008
Arun Bharadwaj
Re: [RFC PATCH 1/1]: timers: Enabling timer migration to cpu0
Thanks for pointing out all my blunders. I'll soon clean up my patch and post it again. --
Sep 16, 9:52 am 2008
Arun Bharadwaj
Re: [RFC PATCH 0/1]: timers: Timer Migration
Here, I've chosen cpu0 just to demonstrate migration of timers. I'm working on the algorithm to choose the best cpu or the best set of cpus to migrate the timers to. This is just the first iteration on which i intend to build upon. What could be a possible way is that, a package can be chosen as the destination for the migrated timers and any one or many cpus in that package can be the target(s). So, this will prevent Thanks for the hint. I'll do that next time. --
Sep 16, 9:47 am 2008
Arjan van de Ven
Re: [RFC PATCH 0/1]: timers: Timer Migration
On Tue, 16 Sep 2008 14:42:31 +0530 while I absolutely like reducing power consumption... I'm not sure this helps or is the right approach. First of all, it's of course absolutely better to fix timers and apps that cause them (and with PowerTOP we fixed basically all the bad stuff). Second, in terms of power; a wake up is a wake up, it doesn't really matter where it happens. Now we could do some consolidation (which realistically needs the range timer feature that's aimed for 2.6.28), ...
Sep 16, 6:53 am 2008
Arun R Bharadwaj
[RFC PATCH 0/1]: timers: Timer Migration
Hi, An idle cpu on which device drivers have initialized timers, has to be frequently woken up to service the timers. So, consolidation of timers onto a fewer number of cpus is important. Migration of timers from idle cpus onto lesser idle cpus is necessary. Currently, timers are migrated during the cpu offline operation. However cpu-hotplug for the sake of idle system power management is too heavy. So, this patch implements a lightweight timer migration framework. Also, in a multi-core, ...
Sep 16, 2:12 am 2008
Andi Kleen
Re: [RFC PATCH 0/1]: timers: Timer Migration
Who would trigger such migrations? I'm not sure it's a good idea to make it fully manually triggered. It would be nicer if it was bound to the scheduler's power saving heuristic. So if the scheduler consolidates I suspect moving all to cpu 0 is too inflexible as Peter already mentioned. (haven't looked at the actual code yet sorry) -Andi --
Sep 16, 5:49 am 2008
Peter Zijlstra
Re: [RFC PATCH 0/1]: timers: Timer Migration
This seems like an exceedingly dumb idea - cpu 0 might be a long long way from x and by pushing all timers to cpu0 you might actually overload cpu 0. Initially you talked about packages an moving timers to busy cpus - If there's anything worth reading in there it should have been mentioned in this email and preferably in some comment in the code and Kconfig help as well. --
Sep 16, 5:05 am 2008
Alexey Dobriyan
Re: [PATCH 3/5] pci: using pci_printk
^^^^^^^^^^^^^^^^^^^^^^^^^^ Brilliant, simply brilliant! Printk haters club is definitely creative, no questions. --
Sep 16, 3:20 am 2008
Yinghai Lu
[PATCH 5/5] apci: dump slit v3
v2: using boot_printk v3: using acpi_printk Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/acpi/numa.c | 8 ++++++++ 1 file changed, 8 insertions(+) Index: linux-2.6/drivers/acpi/numa.c =================================================================== --- linux-2.6.orig/drivers/acpi/numa.c +++ linux-2.6/drivers/acpi/numa.c @@ -150,6 +150,14 @@ static __init int slit_valid(struct acpi { int i, j; int d = slit->locality_count; + acpi_printk(KERN_LOG_DEBUG, ...
Sep 16, 1:52 am 2008
Yinghai Lu
[PATCH 4/5] acpi: add acpi_printk
use DEFINE_LOGLEVEL_SETUP to set loglevel for acpi --- drivers/acpi/osl.c | 2 ++ include/linux/acpi.h | 1 + 2 files changed, 3 insertions(+) Index: linux-2.6/drivers/acpi/osl.c =================================================================== --- linux-2.6.orig/drivers/acpi/osl.c +++ linux-2.6/drivers/acpi/osl.c @@ -75,6 +75,8 @@ EXPORT_SYMBOL(acpi_in_debugger); extern char line_buf[80]; #endif /*ENABLE_DEBUGGER */ +DEFINE_LOGLEVEL_SETUP(acpi); + static unsigned ...
Sep 16, 1:52 am 2008
Cyrill Gorcunov
Re: [PATCH 5/5] apci: dump slit v3
[Yinghai Lu - Tue, Sep 16, 2008 at 01:52:54AM -0700] | v2: using boot_printk | v3: using acpi_printk | | Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> | | --- | drivers/acpi/numa.c | 8 ++++++++ | 1 file changed, 8 insertions(+) | | Index: linux-2.6/drivers/acpi/numa.c | =================================================================== | --- linux-2.6.orig/drivers/acpi/numa.c | +++ linux-2.6/drivers/acpi/numa.c | @@ -150,6 +150,14 @@ static __init int slit_valid(struct acpi | ...
Sep 16, 3:13 am 2008
Robert Richter
Re: [PATCH 3/5] pci: using pci_printk
Wouldn't it be much simpler to have an i/f as for dev_dbg() and also run the log level check only for debug messages? And, the dev_dbg() macro seems to have code that can be binary pached (?) to enable it if the compile option is not set. -Robert #define dev_dbg(dev, format, arg...) \ ({ if (0) dev_printk(KERN_DEBUG, dev, format, ##arg); 0; }) -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com --
Sep 16, 10:18 am 2008
Yinghai Lu
[PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v2
so could make subsys easy to add loglevel and xxx_printk v2: make it more genric, so subsys user only need to two line macro Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- arch/x86/kernel/vmlinux_32.lds.S | 1 + arch/x86/kernel/vmlinux_64.lds.S | 2 ++ include/asm-generic/vmlinux.lds.h | 8 ++++++++ include/linux/init.h | 36 ++++++++++++++++++++++++++++++++++++ include/linux/kernel.h | 9 +++++++++ init/main.c | 28 ...
Sep 16, 1:52 am 2008
Yinghai Lu
[PATCH 3/5] pci: using pci_printk
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/pci/probe.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6/drivers/pci/probe.c =================================================================== --- linux-2.6.orig/drivers/pci/probe.c +++ linux-2.6/drivers/pci/probe.c @@ -304,7 +304,7 @@ static int __pci_read_base(struct pci_de } else { res->start = l64; res->end = l64 + sz64; - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: ...
Sep 16, 1:52 am 2008
Yinghai Lu
[PATCH 2/5] pci: add pci_printk v2
use DEFINE_LOGLEVEL_SETUP to set loglevel for pci v2: two lines only Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/pci/pci.c | 2 ++ include/linux/pci.h | 2 ++ 2 files changed, 4 insertions(+) Index: linux-2.6/drivers/pci/pci.c =================================================================== --- linux-2.6.orig/drivers/pci/pci.c +++ linux-2.6/drivers/pci/pci.c @@ -1953,6 +1953,8 @@ static int __devinit pci_setup(char *str } early_param("pci", pci_setup); ...
Sep 16, 1:52 am 2008
sonic zhang
[PATCH] [kgdb]switch master cpu after gdb thread command ...
In blackfin SMP architecture, different core has its own L1 SRAM and MMR memory, which code running on the other core can't access. In current kgdb impelemntation, cpus are represented by thread with minus prefix. If user wants gdb to switch to the thread of the other cpu, kgdb should: 1. signal current master cpu to enter kgdb_wait 2. release the specific waiting passive cpu 3. exit kgdb exception loop on current master cpu 4. trap the release cpu into kgdb exception loop The kgdb arch ...
Sep 16, 1:37 am 2008
Eli Cohen
Re: LRO num of frags limit
By the way, we need to introduce two kinds of "max_aggr" fields to struct net_lro_mgr. The reason is that when LRO is used in the mode in which SKBs are linked, the above limitation does not exist. One will be used for drivers which use lro_receive_skb() (which does not have a limit) and one for drivers which use lro_receive_frags(). This will require changing all the drivers that use LRO. --
Sep 16, 8:25 am 2008
Eli Cohen
LRO num of frags limit
Hi, looking at the LRO code, at __lro_proc_segment(), it seems that the network driver can configure lro_mgr->max_aggr to any value it wants while the number of fragments aggregated must not exceed MAX_SKB_FRAGS (since we only use a single SKB to aggregate fragments, allocated by lro_gen_skb()). Moreover, even if the driver does limit lro_mgr->max_aggr to MAX_SKB_FRAGS, it might still cause overflow since subsequent aggregations are done at lro_add_frags() which is called before checking ...
Sep 16, 12:36 am 2008
Ben Hutchings
Re: LRO num of frags limit
So you must set max_aggr to I would be interested to see that, anyway. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. --
Sep 16, 3:40 am 2008
Randy.Dunlap
Re: linux-next: Tree for September 16 (cpustr.h)
I'm seeing lots of gcc warnings from the generated cpustr.h file, like so: arch/x86/boot/mkcpustr > arch/x86/boot/cpustr.h gcc -Wp,-MD,arch/x86/boot/.cpu.o.d -nostdinc -isystem /usr/lib/gcc/x86_6= 4-redhat-linux/4.1.1/include -D__KERNEL__ -Iinclude -Iinclude2 -I/home/rdun= lap/linsrc/linux-next-20080916/include -I/home/rdunlap/linsrc/linux-next-20= 080916/arch/x86/include -include include/linux/autoconf.h -I/home/rdunlap/l= insrc/linux-next-20080916/arch/x86/boot -Iarch/x86/boot ...
Sep 16, 11:50 am 2008
Takashi Iwai
Re: linux-next: Tree for September 16
At Tue, 16 Sep 2008 17:34:15 +1000, Thanks for a quick action! This can help to reduce bisection time when a regression is known to be on a certain subsystem tree. Takashi --
Sep 16, 11:00 am 2008
Stephen Rothwell
Re: [PATCH -next] blkdev.h: fix warnings when CONFIG_BLOCK=n
Hi Al, I suspect this is caused by commit 44e95e9e8be95ec9ac6b0678e491883d99c0cfd8 ("beginning of methods conversion") from your bdev tree. (the commit id is from next-20090816) --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Sep 16, 3:16 pm 2008
Stephen Rothwell
linux-next: Tree for September 16
Hi all, News: I have added a file (Next/SHA1s) that contains the SHA1 of the head of each merged tree. Hopefully people will find it useful. Changes since next-20080913: New trees: scsi-post-merge and bdev (these are both rebased onto the end of linux-next as they depend on some constituent trees). The pxa tree gained a conflict against Linus' tree. The x86 tree lost two conflicts. The tip-core tree lost a build fix patch. The kvm tree gained a conflict against the x86 ...
Sep 16, 12:34 am 2008
H. Peter Anvin
Re: linux-next: Tree for September 16 (cpustr.h)
Yes, there is a patch that adds a 9th cpuflags word, which this code doesn't handle. The warning is real, there is an #error in mkcpustr.c which is supposed to trigger, but doesn't because of a typo: #if NCAPFLAGS > 8 # error "Need to adjust the boot code handling of CPUID strings" #endif (The actual variable is called NCAPINTS.) Attached is a completely untested patch for this problem. -hpa
Sep 16, 1:48 pm 2008
Jens Axboe
Re: [PATCH -next] blkdev.h: fix warnings when CONFIG_BLOCK=n
Not sure which tree that build problem came from, it isn't from the block git tree. -- Jens Axboe --
Sep 16, 2:50 pm 2008
Randy.Dunlap
[PATCH -next] blkdev.h: fix warnings when CONFIG_BLOCK=n
From: Randy Dunlap <randy.dunlap@oracle.com> Fix lots of build warnings when CONFIG_BLOCK=n: linux-next-20080916/include/linux/blkdev.h:1093: warning: 'struct block_device' declared inside parameter list linux-next-20080916/include/linux/blkdev.h:1093: warning: its scope is only this definition or declaration, which is probably not what you want linux-next-20080916/include/linux/blkdev.h:1097: warning: 'struct gendisk' declared inside parameter ...
Sep 16, 12:29 pm 2008
Hinko Kocevar
Cris USB host driver for 2.6.26
Hi, I've 'ported' 2.6.19 cris architecture cris v10 USB host driver from 2.6.19 to 2.6.26. Could someone take a look at the diff attached. I'm experiencing some difficulties with interrupt driven traffic, while USB to serial converter and USB mass storage seem to work. Thank you, Hinko --
Sep 16, 12:32 am 2008
Bily
insmod problem
hi,all; I want to insert an module:yaffs.ko into my kernel2.6.26,but i meet this question: [\u@\h \W]$insmod yaffs.ko yaffs: unknown relocation: 40 insmod: cannot insert 'yaffs.ko': invalid module format and my busybox version is v1.11.1; may anyone tell me why ?thanks! Bily 2008-09-13 --
Sep 16, 12:15 am 2008
Peter Zijlstra
Re: max_clock of the patch "sched_clock: fix cpu_clock()"
Nope, it wont (nor would the old), but having irqs disabled for that long would be something worth fixing. --
Sep 15, 9:48 pm 2008
Lin Ming
max_clock of the patch "sched_clock: fix cpu_clock()"
Hi, Peter, I have a question of the max_clock in below patch, commit 354879bb977e06695993435745f06a0f6d39ce2b Author: Peter Zijlstra <a.p.zijlstra@chello.nl> Date: Mon Aug 25 17:15:34 2008 +0200 sched_clock: fix cpu_clock() The original code to calculate min_clock and max_clock is, min_clock = scd->tick_gtod + delta_jiffies * TICK_NSEC; max_clock = min_clock + TICK_NSEC; Now it's changed to, min_clock = wrap_max(scd->tick_gtod, scd->clock); max_clock = scd->tick_gtod + ...
Sep 15, 8:01 pm 2008
sonic zhang
[PATCH][kgdb][v3] Make mem access function weak in kgdb. ...
L1 instruction memory and MMR memory on blackfin can not be accessed by common functions probe_kernel_read() and probe_kernel_write(). Blackfin asks for 2/4 byte align access to MMR memory and DMA access to L1 instruction memory. These functions need to be reimplemented in architecture specific kgdb.c. Update documentation and prototypes as well. Signed-off-by: Sonic Zhang <sonic.adi@gmail.com> --- include/linux/kgdb.h | 42 ++++++++++++++++++++++++++++++++++++++++-- kernel/kgdb.c | ...
Sep 15, 6:49 pm 2008
Robert Hancock
Re: Buffer I/O error on device sr0, logical block 793066
"Track following error" comes right from the drive, it can't read the disc properly. Scratched perhaps? --
Sep 15, 6:36 pm 2008
Justin Mattock
Re: Buffer I/O error on device sr0, logical block 793066
That was weired, the dvd played probably 25% then all of a sudden freeze(only mplayer everything was fine); then a reboot, then the dvd played all the way through without any issues. I did a few days prior clean the lens on the disk drive, so maybe this had something todo with(can't see how), Maybe the lens is so clean, it can pickup on scratches on the disk, Anyways better to post when something like this occurs than not at all. regards; -- Justin P. Mattock --
Sep 15, 8:08 pm 2008
Yinghai Lu
[PATCH 1/3] add DEFINE_LOGLEVEL_SETUP
so could make subsys easy to add loglevel and xxx_printk Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- arch/x86/kernel/vmlinux_32.lds.S | 1 + arch/x86/kernel/vmlinux_64.lds.S | 2 ++ include/asm-generic/vmlinux.lds.h | 8 ++++++++ include/linux/init.h | 17 +++++++++++++++++ include/linux/kernel.h | 9 +++++++++ init/main.c | 27 ++++++++++++++++++++++++++- 6 files changed, 63 insertions(+), 1 deletion(-) Index: ...
Sep 15, 6:28 pm 2008
Yinghai Lu
[PATCH 2/3] pci: add pci_printk
use DEFINE_LOGLEVEL_SETUP to set loglevel for pci Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/pci/pci.c | 7 +++++++ include/linux/pci.h | 6 ++++++ 2 files changed, 13 insertions(+) Index: linux-2.6/drivers/pci/pci.c =================================================================== --- linux-2.6.orig/drivers/pci/pci.c +++ linux-2.6/drivers/pci/pci.c @@ -1953,6 +1953,13 @@ static int __devinit pci_setup(char *str } early_param("pci", pci_setup); +static ...
Sep 15, 6:28 pm 2008
Yinghai Lu
[PATCH 3/3] pci: using pci_printk
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/pci/probe.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6/drivers/pci/probe.c =================================================================== --- linux-2.6.orig/drivers/pci/probe.c +++ linux-2.6/drivers/pci/probe.c @@ -304,7 +304,7 @@ static int __pci_read_base(struct pci_de } else { res->start = l64; res->end = l64 + sz64; - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: ...
Sep 15, 6:28 pm 2008
Hiroshi Shimamoto
[PATCH -tip] uaccess: fix parameters inversion for __cop ...
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> The following patch changes to use __copy_from_user_inatomic(), but the passing parameters incorrect. x86: some lock annotations for user copy paths, v3 - add annotation back to clear_user() - change probe_kernel_address() to _inatomic*() method Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> --- include/linux/uaccess.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git ...
Sep 15, 6:04 pm 2008
Ingo Molnar Sep 15, 10:42 pm 2008
Steven Noonan
Re: [PATCH -tip] uaccess: fix parameters inversion for _ ...
On Mon, Sep 15, 2008 at 6:04 PM, Hiroshi Shimamoto Thank you! This issue was causing a kernel panic on my machine when netfilter was enabled. - Steven --
Sep 15, 6:21 pm 2008
Arnaldo Carvalho de Melo
Re: [PATCH v2] Rewrite Linux Makefile name
Remendo número três! Next language por supuesto! :-P - Arnaldo --
Sep 15, 6:18 pm 2008
Jeff Garzik
[PATCH v2] Rewrite Linux Makefile name
This is yet another test patch. It kicks ass, eh? Not-signed-off-by: Jeff Garzik <jgarzik@redhat.com> diff --git a/Makefile b/Makefile index 4ff83ea..7d06a3e 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 27 EXTRAVERSION = -rc6 -NAME = Rotary Wombat +NAME = Patch Wombat Numero Dos # *DOCUMENTATION* # To see a list of typical targets execute "make help" --
Sep 15, 5:26 pm 2008
Steven Noonan
Re: [PATCH v2] Rewrite Linux Makefile name
It should go in mainline, ASAP! ;) - Steven --
Sep 15, 5:33 pm 2008
Jeff Garzik
[PATCH] Rewrite Linux Makefile name
This is a test, please ignore. Not-signed-off-by: Jeff Garzik <jgarzik@blahblah.com> --- diff --git a/Makefile b/Makefile index 4ff83ea..7d06a3e 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 27 EXTRAVERSION = -rc6 -NAME = Rotary Wombat +NAME = Patch Wombat Numero Uno # *DOCUMENTATION* # To see a list of typical targets execute "make help" --
Sep 15, 5:02 pm 2008
Theodore Tso
Re: ext3 mount infinite loop over orphan list issue, ple ...
As you point out, this problem has been fixed in 2.6.27-rc1. Unfortunately, it is a problem which has been around for a very long time --- perhaps since ext3 was first written. No one had noticed the problem for a very long time; in fact the first time someone reported it as far I know was June 6, 2008, when Sami Liedes found it via a synthetic testing program, fsfuzzer, which creates filesystems, then corrupts them randomly and then sees whether or not they cause the kernel to panic or hang ...
Sep 16, 5:53 am 2008
Amit D. Chaudhary
Re: ext3 mount infinite loop over orphan list issue, ple ...
Hello Ted, Thanks for noting that the problem does happen in the real world, though rarely or users do not narrow it down. Yes, it makes sense for all regressions to be fixed before releasing 2.6.27. I have put your suggestion about the Rescue CD & patch to kernel to the Ubuntu forums & bug. The latter would solve it only for one distribution, it is a start. Good point about the Rescue CD, I will get one from other distributions next time, if needed. There is no way of skipping ...
Sep 16, 9:42 am 2008
Alessio Sangalli
Re: Driver for tightly coupled memory
Well, interesting, that is why I asked here before writing code. In this case however, do you imply that a device driver will just do all the genalloc stuff? In this case it has to know about the TCM details, and problems may arise if more than one driver wants to use this feature. Or, are you suggesting to write a small TCM driver that will do the gen_pool_create() and gen_pool_add() and then export the struct gen_pool for use by other drivers that may require it? I mentioned implementing ...
Sep 16, 3:49 pm 2008
Alessio Sangalli
Re: Driver for tightly coupled memory
I disagree, something like a TCM can very well be present in any architecture, after all it's some kind of fast memory mapped to an address, nothing special from a software point of view. I will ask on I think I will write a module that implements a software FIFO. One function to allocate a FIFO n words deep, a "push" and a "pop" and similar. The calling module will have to setup the FIFO and use it probably in ISRs or similar (the policy will totally remain in the caller module). Any ...
Sep 16, 10:39 am 2008
Ben Nizette
Re: Driver for tightly coupled memory
I'd feel uncomfortable about picking an arbitrary function for the TCM to accomplish. Why don't you just set up a genalloc on that RAM and let the user use it for what they will? If a driver needs a quick FIFO it can attempt to get the RAM for said FIFO from the genalloc and fall back to main memory otherwise. Simple, flexible, easy :-) --Ben. --
Sep 16, 3:27 pm 2008
Ben Nizette
Re: Driver for tightly coupled memory
Generally the genalloc pool will be set up exactly once, at boot, by the platform code. Then yes indeed the pool can be exported for driver use. --Ben. --
Sep 16, 4:04 pm 2008
Alessio Sangalli
Re: Driver for tightly coupled memory
Oh thanks now it's clear. bye as --
Sep 16, 4:52 pm 2008
Ben Dooks
Re: Driver for tightly coupled memory
This isn't the right list to be discussing this on, try looking for linux-arm-kernel instead. It will get your question to the attention -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' --
Sep 16, 2:35 am 2008
Corentin Chary
Re: [PATCH -mm] eeepc: depends on RFKILL
Yep, it should depends on RFKILL, and I should start porting asus-laptop to rfkill. Thanks for this patch. --
Sep 16, 12:05 am 2008
roel kluin
[PATCH ?] ACPI: pr->id is unsigned
since pr->id is unsigned, shouldn't something like the patch below be applied? Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c index e36422a..75c0f76 100644 --- a/drivers/acpi/processor_core.c +++ b/drivers/acpi/processor_core.c @@ -667,7 +667,7 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device) return 0; } - BUG_ON((pr->id >= nr_cpu_ids) || (pr->id < 0)); + BUG_ON((pr->id >= ...
Sep 15, 6:32 pm 2008
Thomas Renninger
Re: [PATCH ?] ACPI: pr->id is unsigned
Just removing "pr->id < 0" condition should be the right fix. For such an easy patch in the ACPI subsystem it's enough to only post to the linux-acpi mailing list, no need to bother the whole world. Thanks for finding this, do you mind to repost a new version? Thomas --
Sep 16, 1:45 am 2008
Yoichi Yuasa
Re: [PATCH] [MIPS] vr41xx: unsigned irq cannot be negative
On Mon, 15 Sep 2008 20:50:54 -0400 Acked-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> Yoichi --
Sep 15, 7:02 pm 2008
Sergei Shtylyov
Re: [PATCH] [MIPS] vr41xx: unsigned irq cannot be negative
Hello. How about this: ret = cascade->get_irq(irq); if (ret < 0) atomic_inc(&irq_err_count); else irq_dispatch(ret); WBR, Sergei --
Sep 16, 3:44 am 2008
Ralf Baechle
Re: [PATCH] [MIPS] vr41xx: unsigned irq cannot be negative
On Mon, Sep 15, 2008 at 08:50:54PM -0400, roel kluin wrote: Thanks, applied. Ralf --
Sep 16, 1:58 am 2008
roel kluin
[PATCH] [MIPS] vr41xx: unsigned irq cannot be negative
unsigned irq cannot be negative Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- diff --git a/arch/mips/vr41xx/common/irq.c b/arch/mips/vr41xx/common/irq.c index cba36a2..92dd1a0 100644 --- a/arch/mips/vr41xx/common/irq.c +++ b/arch/mips/vr41xx/common/irq.c @@ -72,6 +72,7 @@ static void irq_dispatch(unsigned int irq) cascade = irq_cascade + irq; if (cascade->get_irq != NULL) { unsigned int source_irq = irq; + int ret; desc = irq_desc + source_irq; if ...
Sep 15, 5:50 pm 2008
Matthew Ranostay
Re: hda_intel (sigmatel) defunct in mmotm 2008-09-13-03-09
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Bug fix patch at: http://mailman.alsa-project.org/pipermail/alsa-devel/2008-September/010767.html Thanks, Matt Ranostay -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkjPxgAACgkQ7s2wy7nhBHULRQCeM0uqdR/rIPRHl+YhMKuZqIg7 NxEAoKQDzb2zw05UyY+i48Y2G65KZkoA =CQnT -----END PGP SIGNATURE----- --
Sep 16, 7:43 am 2008
Krzysztof Helt
Re: [Linux-fbdev-devel] [fbdev] Lockdep error
On Mon, 15 Sep 2008 16:21:52 +0400 Does the patch below fix the problem for you? Kind regards, Krzysztof diff -urp linux-ref/drivers/video/console/fbcon.c linux-mm/drivers/video/console/fbcon.c --- linux-ref/drivers/video/console/fbcon.c 2008-09-05 23:38:47.000000000 +0200 +++ linux-mm/drivers/video/console/fbcon.c 2008-09-16 23:30:52.309604454 +0200 @@ -2400,11 +2400,15 @@ static int fbcon_blank(struct vc_data *v if (!fbcon_is_inactive(vc, info)) { if (ops->blank_state != blank) ...
Sep 16, 2:39 pm 2008
Marco Stornelli
Re: [PATCH 1/1] avr32: added mem kernel command line opt ...
From: Marco Stornelli <marco.stornelli@gmail.com> Now is it ok? Sorry but it's the first time I submit a patch for the kernel. Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com> --- --- linux-2.6.26.3/arch/avr32/kernel/setup.c.orig 2008-09-15 11:30:00.000000000 +0200 +++ linux-2.6.26.3/arch/avr32/kernel/setup.c 2008-09-16 09:06:31.000000000 +0200 @@ -283,6 +283,25 @@ static int __init early_parse_fbmem(char } early_param("fbmem", early_parse_fbmem); +/* + * Pick out the memory ...
Sep 16, 12:14 am 2008
Haavard Skinnemoen
Re: [PATCH 1/1] avr32: added mem kernel command line opt ...
Please see Documentation/email-clients.txt. Thunderbird apparently has I've fixed it up, but I recommend that you send a few patches to yourself and try to fix your setup. It's not much of a problem for a small patch like this, but longer, more complicated ones may take quite some time to unmangle. The rest of the patch looks good. Although avr32 only supports 32-bit physical addresses, I believe resource_size_t is more correct than unsigned long. Applied, thanks. Haavard --
Sep 16, 1:06 am 2008
Peter Zijlstra
Re: [PATCH] introduce boot_printk()
doesn't sound like an easily extensible interface, better would be extending printk with a KERN_subsys tag like proposed. Perhaps Jason has better ideas - iirc he worked on something similar. --
Sep 16, 7:26 am 2008
H. Peter Anvin
Re: [PATCH] introduce boot_printk()
First of all, what is the "v" here, and why not just have printk(KERN_PCI KERN_DEBUG "...\n"); ... and we can do #define PCI_DEBUG KERN_PCI KERN_DEBUG even. We do have a need for special macros when we're doing device-specific prefixes, of course. If that is what your "v" is meant to be, then there was an implicit topic shift in the discussion thread. -hpa --
Sep 16, 11:53 am 2008
H. Peter Anvin
Re: [PATCH] introduce boot_printk()
That would be my thinking too. -hpa --
Sep 16, 9:06 am 2008
Yinghai Lu
Re: [PATCH] introduce boot_printk()
will be printk(KERN_PCI, KERN_DEBUG ".....") ? and it will be ...KERN_PCI will be int? YH --
Sep 16, 9:42 am 2008
H. Peter Anvin
Re: [PATCH] introduce boot_printk()
pci_printk(v, KERN_ACPI KERN_DEBUG "...\n"); ^^^^ ^^^^^^^^^ Not only do you have duplication, here, but inconsistency... -hpa --
Sep 16, 11:31 am 2008
H. Peter Anvin
Re: [PATCH] introduce boot_printk()
Uh? You can add the subsys tags elsewhere if you prefer too. However, there are a few important differences to keep in mind. Tags get logged in the dmesg buffer even if not printed to the kernel, whereas a jump-based architecture will not just suppress the output, but even the formatting of the output. Either is a good thing for certain things, and a bad thing for other things. I personally think the kind of things discussed belong in the category of "always put in the dmesg ...
Sep 16, 10:53 am 2008
Yinghai Lu
Re: [PATCH] introduce boot_printk()
how about pci_printk(v, KERN_DEBUG "...\n"); will put <pci> <7> ...\n in dmesg bug, and let vprintk get rid of <pci> like <7> is that what you want? YH --
Sep 16, 11:37 am 2008
H. Peter Anvin
Re: [PATCH] introduce boot_printk()
And the point of this, other than sheer verbosity? -hpa --
Sep 16, 11:15 am 2008
Yinghai Lu
Re: [PATCH] introduce boot_printk()
you still can use pci_printk(v, KERN_PCI KERN_DEBUG "...\n"); if vprintk is expanded to handle KERN_PCI and other tags... or even you could use pci_printk(v, KERN_ACPI KERN_DEBUG "...\n"); YH --
Sep 16, 11:10 am 2008
Yinghai Lu Sep 16, 12:24 pm 2008
Yinghai Lu
Re: [PATCH] introduce boot_printk()
it seem using pci_printk or acpi_printk.. could be more flexible. otherwise will need to keep update linux/kernel.h to add so call subsys tags... use only need to have DEFINE_LOGLEVEL_SETUP(xxx) in c and have DECLARE_LOGLEVEL(xxx) in .h then just use xxx_printk YH --
Sep 16, 10:45 am 2008
Jeremy Fitzhardinge
Re: [PATCH] introduce boot_printk()
#define X86_DEBUG KERN_DEBUG SUBSYS_X86 ... printk(X86_DEBUG "woozle failed the wibble\n); J --
Sep 16, 10:44 am 2008
Yinghai Lu
Re: [PATCH] introduce boot_printk()
and in real subsys could have as many the xxx_printk that user want... YH --
Sep 16, 10:47 am 2008
Yinghai Lu
Re: [PATCH] introduce boot_printk()
let every file or componet of subsystem could control the print out via loglevel=pci_any_name:7 YH --
Sep 16, 11:24 am 2008
Sebastien Dugue
Re: [PATCH HACK] powerpc: quick hack to get a functional ...
Hi Anton, Yes, I've been following that thread back then and my hack is based on your patch. So yes, it seems to be the same problem and it lies in the way -rt handles the fasteoi flow. But looking at the comments from the XICS code, it seems that its wired for level only interrupts. Therefore without any more specs, it's still not clear to me that there's not a bug with the way the xics handles eHEA interrupts. Are the eHEA interrupts really level interrupts? If so why do they ...
Sep 16, 5:22 am 2008
Anton Vorontsov
Re: [PATCH HACK] powerpc: quick hack to get a functional ...
On Mon, Sep 15, 2008 at 03:13:32PM +0200, Sebastien Dugue wrote: There is a known bug in the -rt kernels, the bug causes handlers to lose edge interrupts. See this patch: -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 --
Sep 16, 4:59 am 2008
Bosko Radivojevic
Re: GRE keepalives, again
Hi again. Problem is - fib_validate_source() explicitly doesn't allow any local address to be specified as source address. I figured out I'm not the first in need for different behavior. One of the solutions I've found is forward_shared patch [http://www.ssi.bg/~ja/forward_shared-2.6.25-2.diff] which exists for centuries. Actually, it is not working for me but it is addressing the same thing - forwarding packets with local addresses. I've solved my problem (Cisco's GRE keepalive and Linux) ...
Sep 15, 5:20 pm 2008
Ben Dooks
Re: wdt285: fix sparse warnings
I've changed the int pointer, as it is used numerous times, but left the void as it is only used in the copy_to_user. -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' --
Sep 16, 3:31 am 2008
Chris Mason
Re: [PATCH 01/27] nilfs2: add document
Normally, compilebench has read phases that time how quickly the FS can read the files after a bunch of operations. The runs above didn't include the read phase, but in order to be fair to all the filesystems, compilebench figures out the native readdir order of the FS so it can create files in the optimal order for each fs. It does this by creating all the files in its datasets and using readdir to find out what order the FS returns. The files are all deleted and the real runs start. It ...
Sep 16, 6:38 am 2008
konishi.ryusuke
Re: [PATCH 18/27] nilfs2: pathname operations
Hi Pekka! Yeah, that's quite right. nilfs_transaction_end() should not call nilfs_construct_segment() in the error case, and this double error handling seems to be avoidable. The ``commit'' argument of nilfs_transaction_end() is insufficient because it does not cancel the commit state. I'd like to correct these error hanlings by adding nilfs_transaction_abort() as you told me. Thank you for the comment. Regards, Ryusuke --
Sep 15, 10:31 pm 2008
Eduard - Gabriel Mun ...
Re: [RFC PATCH] Script for generating Documentation/dont ...
Thanks, it makes sense. It seems like diff can't handle such scenarios at all. I suppose Linux should supply its own diff tool (which uses regular diff, but implements proper file matching). Maybe git-diff alone could be included in the tarballs, I'll look into it. Cheers, --
Sep 15, 8:26 pm 2008
Oleg Nesterov
Re: + itimers-fix-itimer-many-thread-hang.patch added to ...
Great. Please also remove tasklist_lock from thread_group_cputime_alloc_smp(), it is not needed. I'd also suggest to kill if (sig->cputime.totals) return 0; , the caller has already checked this. Please note also that thread_group_cputime_clone_thread() doesn't need the second argument. Very minor nit, but thread_group_cputime_alloc_smp() doesn't really need get_cpu() + put_cpu_no_resched(), it can use smp_processor_id(). Oleg. --
Sep 16, 4:13 am 2008
Dmitry Adamushko
Re: [x86-tip, patch] rework of the microcode splitup
The thing is that it looks like there are 2 headers that contain the size. 'hdr' taken by get_totalsize() is not the same as 'hdr' from which total_size is calculated here. :^) A quick search didn't reveal any docs describing the AMD microcode -- Best regards, Dmitry Adamushko --
Sep 16, 2:43 pm 2008
Dave Chinner
Re: 2.6.27-rc6: lockdep warning: iprune_mutex at shrink_ ...
<sigh> We need a FAQ for this one. It's a false positive. Google for an explanation - I've explained it 4 or 5 times in the past year and asked that the lockdep folk invent a special annotation for the iprune_mutex (or memory reclaim) because of the way it can cause recursion into the filesystem and hence invert lock orders without causing deadlocks..... Cheers, Dave. -- Dave Chinner david@fromorbit.com --
Sep 15, 7:52 pm 2008
Dave Chinner
Re: 2.6.27-rc6: lockdep warning: iprune_mutex at shrink_ ...
The delay will be probably due to how slow the system can be when it runs out of memory, not from the lockdep report. Cheers, Dave. -- Dave Chinner david@fromorbit.com --
Sep 16, 12:03 am 2008
Grant Coady
Re: 2.6.27-rc6: lockdep warning: iprune_mutex at shrink_ ...
Yeah, but a 30 second dreadlock? It's a long wait wondering what's gone down or not ;) Grant. --
Sep 15, 9:31 pm 2008
Alexander Beregalov
Re: 2.6.27-rc6: lockdep warning: iprune_mutex at shrink_ ...
Hi Dave Yes, you already explained a similar message to me, but it was a bug, not false positive. http://lkml.org/lkml/2008/7/3/29 http://lkml.org/lkml/2008/7/3/315 I will try to bisect. It is not a OOM case. --
Sep 16, 12:35 am 2008
Serge E. Hallyn Sep 16, 4:08 pm 2008
Dave Hansen
Re: [RFC v5][PATCH 8/8] Dump open file descriptors
Dude, you don't need to cast to void*. -- Dave --
Sep 16, 8:54 am 2008
Bastian Blank
Re: [RFC v5][PATCH 2/8] General infrastructure for check ...
No. Arithmetic on void pointer is not allowed by the standard. This is a gcc extension. It's okay to be used in the Linux kernel but not in general. The second cast (from char * to void *) however is useless. Bastian -- Prepare for tomorrow -- get ready. -- Edith Keeler, "The City On the Edge of Forever", stardate unknown --
Sep 16, 5:27 am 2008
Dave Hansen
Re: [RFC v5][PATCH 8/8] Dump open file descriptors
One of the big things I'm looking for in these file patches is to make sure that we can expand some day to lots of mounts and lots of filesystem namespaces. This tells me that we probably need a per-process vfsroot (which is also a shared object). We probably need to make a note in the task structure as well as here. -- Dave --
Sep 16, 9:55 am 2008
Serge E. Hallyn
Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
If you were to rename objref_index to next_free_ref, I think that'd be helpful. (I also don't think 'obj' should in the name at all, and you should just s/objref/id/, but that's really too much pain) thanks, -serge --
Sep 16, 3:09 pm 2008
Serge E. Hallyn
Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
Acked-by: Serge Hallyn <serue@us.ibm.com> Thanks, Oren, I actually think this is quite nice and readable. Though three questions below. First one is, since you've mentioned having multiple threads doing checkpoint, won't you need some locking? What is the point of the 'type'? By that I mean: is it meant to catch bugs in the implementation, or bad What exactly will objref_index be used for? I don't see any real --
Sep 16, 1:54 pm 2008
Dave Hansen
Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
I'd much rather see all this documentation put properly inline with the I have some nits about some of that. I'd prefer to see the main code flow of the functions get taken out of the if(){} blocks and put at the first indenting level (cr_obj_new() could use this). One other nit would be to try and get rid of some of the '?:' use. I personally find those hard to read and we don't use them that heavily in the core kernel. For instance, the above can be written: obj = ...
Sep 16, 9:48 am 2008
Oren Laadan
Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
yes. The hash table is maintained in the kernel during checkpoint/restart, adding shared objects to the hash table when they are first seen. An object can be a 'struct file', 'struct mm_struct', etc. When an object is added, it's reference count is incremented to ensure that the pointer is still valid for as long as it's in the hash table. Similarly, when we remove an object from the hash, we need to decrement the reference count. This is done in cr_obj_ref_grab(), ...
Sep 16, 2:36 pm 2008
Serge E. Hallyn
Re: [RFC v5][PATCH 8/8] Dump open file descriptors
More to the point, you're not preventing them being unfrozen, so I think Right, so you may as well drop this. You're not protecting from userspace here, right? You're protecting against a bogus max_fds. --
Sep 16, 4:03 pm 2008
hermann pitton
Re: [linux-dvb] Multiproto API/Driver Update
I don't doubt it. But holding the members of a whole community as captives over several years is a even much more severe issue. Alone for reading the thousands of mails, how can I build the f*, there is no compensation and that alone is a reason to have serious doubts about such kind of support or keep that out of linuxtv too. To accuse Steve now, his major captive, of something, Manu is far away to even come close to be allowed to do such, if you look at it in whole, is a further ...
Sep 15, 7:55 pm 2008
Adrian Bunk
Re: [git patches] net driver fixes
Among the patches David rejected based on what Linus said was Thomas' patch [1]. It is not a "really important bug" and does not affect "huge number of users". But it passes Documentation/stable_kernel_rules.txt, and can we agree that if it gets submitted for 2.6.27.1 it will likely pass review and get applied? cu Adrian [1] http://article.gmane.org/gmane.linux.network/105810 -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. ...
Sep 16, 7:46 am 2008
Adrian Bunk
Re: [git patches] net driver fixes
Such a fix is even suitable for -stable. If something is considered suitable for -stable, but not for -rc with one month to go before the release of the kernel, then there's something wrong in the process. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
Sep 16, 1:39 am 2008
Adrian Bunk
Re: [git patches] net driver fixes
I'm eagerly awaiting to slap this at Linus the next time he dares to directly apply a patch that only fixes a sparse warning outside of a merge window... ;-) More seriously, there's a difference between Linus' "another random improvement" and an "is even suitable for -stable". I'm not reading Linus' (Cc'ed) statement the way that a patch that is appropriate for 2.6.27.1 is not appropriate for -rc now. If I'm misreading Linus on this it might make sense if they'd discuss ...
Sep 16, 5:15 am 2008
Theodore Tso
Re: [git patches] net driver fixes
Well, remember that patches that get published for -stable do have to go through an extra review process. It's not true that any "obviously correct" bug fix gets automatically published in -stable. Sometimes bug fixes do get rejected for -stable because they are too risky, or require more time for testing in the -rc series before they are deemed suitable for -stable. Looking at 2.6.26, there is currently about 195 patches queued up, which is certainly not all of the bugs fixed during the ...
Sep 16, 6:54 am 2008
Adrian Bunk
Re: [git patches] net driver fixes
And if it goes in during the next merge window it can immediately go into 2.6.27.1 (and even 2.6.26.y if it's still maintained), since the fix fulfills Documentation/stable_kernel_rules.txt . cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
Sep 16, 2:40 am 2008
Simon Horman
Re: [git patches] net driver fixes
On Mon, Sep 15, 2008 at 02:11:59PM -0700, David Miller wrote: [snip] Hi Dave, can you confirm that the commit message requirement stands even if the SHA1 ID references Linus' tree? I personally think that is reasonable, I just want to confirm that is the requirement. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en --
Sep 15, 7:01 pm 2008
Jarek Poplawski
Re: [git patches] net driver fixes
Probably he can read. Jarek P. PS: --
Sep 16, 4:43 am 2008
Arjan van de Ven
Re: [git patches] net driver fixes
On Tue, 16 Sep 2008 09:54:08 -0400 also note that Linus said "regression or on the kerneloops list"; if it has any kind of backtrace, it'll be there if it's a common problem that hits many users. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org --
Sep 16, 7:02 am 2008
Thomas Bogendoerfer
Re: [git patches] net driver fixes
that was my feeling as well, but if David wants to see it in the next merge window, it's his decision. It's not a important fix as the user base is obviuosly pretty small. And I didn't know about that bug, when the merge windows was open, so I couldn't fix it "in time". Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ] --
Sep 16, 2:18 am 2008
Adrian Bunk
Re: [git patches] net driver fixes
Thomas' patch [1] will fixes a bug of a kind that will likely never make it to your list. And the same also e.g. goes for bugs where your machine is completely dead (no SysRq possible) with nothing in the logs. The kerneloops lists are quite valuable, but they can never cover all classes of fatal bugs. cu Adrian [1] http://article.gmane.org/gmane.linux.network/105810 -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been ...
Sep 16, 7:34 am 2008
Thomas Bogendoerfer
Re: [git patches] net driver fixes
the pci_disable_device() is done on an enabled device, so your I thought about the solution, but the pci device is completely setup and enabled in the init function so disabling it at that point and enabling it in open() again sounds silly to me. pci_enable_enable/disable is already done in .init/.remove and .suspend/.resume, so it looked more obviuos to not let close() do the pci_disable_device(). Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary ...
Sep 16, 8:21 am 2008
Adrian Bunk
Re: [git patches] net driver fixes
The kerneloops list is helpful, and improving it is great, but it will You miss my point: We agree that the kerneloops list is not perfect. And usually the bugs with a trace that go into the list are the ones that are easier to debug and fix, while the others might be much harder to debug. If one takes Linus' "simple rule of thumb" literally then a hard to debug bug without any messages anywhere mustn't be fixed outside of a merge window. This literal reading is what doesn't make ...
Sep 16, 8:43 am 2008
Adrian Bunk
Re: [git patches] net driver fixes
Note that my emails are not meant against David personally - he just seems to have gotten from pushing too much to pushing too few, with such illogical results. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
Sep 16, 3:48 am 2008
Arjan van de Ven
Re: [git patches] net driver fixes
On Tue, 16 Sep 2008 17:34:10 +0300 not sure; just we need to catch doing pci_disable_device on a non-enabled device as a WARN_ON. and the patch looks quite wrong, the real answer should be to do the that's being worked on, by storing the crash data in some non-volatile if you want perfection, you're not going to get it. "Perfect is the enemy of good" If you want to help make things better (as opposed to perfect), you're very welcome to help out, be it with suggestions on how to ...
Sep 16, 7:48 am 2008
Michael Tokarev
Re: PARAVIRT_GUEST bug? [was: Stable regression: usb-sto ...
Jeremy Fitzhardinge wrote: I stand corrected. I meant to say CONFIG_PARAVIRT, not CONFIG_PARAVIRT_GUEST: # diff -U0 config.working config.bad --- config.working 2008-09-16 22:09:14.844324435 +0400 +++ .config.bad 2008-09-16 22:10:04.914320258 +0400 @@ -4 +4 @@ -# Tue Sep 16 21:47:31 2008 +# Tue Sep 16 22:10:04 2008 @@ -181 +181 @@ -# CONFIG_PARAVIRT is not set +CONFIG_PARAVIRT=y /mjt --
Sep 16, 11:15 am 2008
Michael Tokarev
PARAVIRT_GUEST bug? [was: Stable regression: usb-storage ...
Michael Tokarev wrote: [usb-storage hangs on asus M2NPV-VM (nVidia GeForce 6150/nForce 430) After seeing similar situation on another motherboard, I become curious. Here's the result: M3A78-EM motherboard (also from Asus), AMD780G/SB700 etc. Updating to one of the latest bios makes the system unbootable. Kernel hangs on boot right after displaying SLUB: Genslabs=12, HWalign=64, Order=0-1, MinObjects=4, CPUs=2, Nodes=1 Reverting to the older BIOS or disabling PARAVIRT_GUEST in ...
Sep 16, 1:11 am 2008
Jeremy Fitzhardinge
Re: PARAVIRT_GUEST bug? [was: Stable regression: usb-sto ...
PARAVIRT_GUEST doesn't enable anything by itself; it just makes other config options appear. What other config options are you enabling? That is, what's the diff between a working and a non-working .config? J --
Sep 16, 10:19 am 2008
karthikeyan S
Re: A bug (probably) in stop_all_threads
Sure, I can definitely send the patch. I haven't sent a patch before, and I am not fully aware of the process to follow. It might take a little bit if time, but I will try to send it very soon. --
Sep 16, 1:28 am 2008
karthikeyan S
Re: A bug (probably) in stop_all_threads
Hi Willy, Thanks for getting back. Yes, I tried to set the state to TASK_INTERRUPTIBLE. It solves the issue. The other processes now get a chance to handle the SIGSTOP sent to them. -karthik --
Sep 15, 10:49 pm 2008
Willy Tarreau
Re: A bug (probably) in stop_all_threads
in order not to waste your time, here is how to proceed : go to the directory where both your new kernel and old kernel are. Here is how you do then : $ diff -urN linux-2.4.36-bad linux-2.4.36-goot > my-patch.diff (ensure that you don't have lots of old or temporary files in it). You might have to run a "make distclean" in each dir first. Then integrate the result as inline text into your mail, and as an added bonus, other people will be able to comment on your ...
Sep 16, 2:28 am 2008
Willy Tarreau
Re: A bug (probably) in stop_all_threads
Hi karthik, Just a quick note to tell you that I have not missed your mail, I just need some time to analyse your report and the code related to it. Have you tried setting TASK_INTERRUPTIBLE as you suggest ? At first sight, it seems to make sense. Regards, Willy --
Sep 15, 10:17 pm 2008
Willy Tarreau
Re: A bug (probably) in stop_all_threads
OK, that will help me review the current code and compare it with 2.6. If you could send me your patch, it will even save me more time. Based on your report, it's very likely that it will get merged. Thanks, Willy --
Sep 15, 11:22 pm 2008
karthikeyan S
Re: A bug (probably) in stop_all_threads
Willy, Thank you for the info. I downloaded a 2.4.36 version from kernel.org, there is no stop_all_threads() at all in that version. do_coredump() mechanism seems to have been changed. It does not call stop_all_threads(). I am not sure which 2.4 version we are using for our device that have stop_all_threads(). And also I am not sure from where our guys had picked up the "dump core for all threads" patch which includes the stop_all_threads function. Had this function been there ever in ...
Sep 16, 12:30 pm 2008
Willy Tarreau
Re: A bug (probably) in stop_all_threads
No, I don't think so. But you should check Redhat and SuSE kernels, they were heavily patched to support an early version of the 2.6 O(1) scheduler, NPTL threads and things like this. As a result, there were a large number of changes in this area and your patches might come from there. Also check for Andrea Arcangelli's patches (2.4-aa), they were approximately the ones that constituted the SuSE kernels by that time. I'm pretty sure that you'll find what you're looking for from No, but that ...
Sep 16, 1:21 pm 2008
Alan Cox
Re: Allow 8250 to work on sparc.
There are lots of variations between hardware of all kinds but the big That still isn't a kernel problem but a udev one and one for the udev lists ? Alan --
Sep 16, 3:54 am 2008
Mark Fortescue
Re: Allow 8250 to work on sparc.
Hi Alan, At the driver level there are lots of varients but I was under the impression that at the user level, the interface is common for async serial ports. Latency can be an issue, but can it be read/changed via the user <-> kernel interface in a way that is not common to all async serial ports? If not, it is transparent at the programming interface for user level code so the USB serial ports are no different at this level to classic PC AT serial ports and as such I see no reason ...
Sep 16, 6:15 am 2008
Mike Galbraith
Re: [Bug #11308] tbench regression on each kernel releas ...
Bisecting 26->27 yet again turned up a repeatable downturn in netperf throughput. There is no difference at this point with tbench. Bisect says first bad commit is 847106f, a security merge. Post bisection sanity checkouts say... v2.6.26-21-g2069f45 16384 87380 1 1 60.00 98435.13 16384 87380 1 1 60.01 99259.90 16384 87380 1 1 60.01 99325.61 16384 87380 1 1 60.00 99039.84 v2.6.26-343-g847106f 16384 87380 1 ...
Sep 16, 5:28 am 2008
Ilpo Järvinen
Re: [Bug #11308] tbench regression on each kernel releas ...
I assume that c142bda458a gave a good results as well... One additional sanity check could be to rebase security 6f0f0fd4963 on top of the c142bda458a and then see if bisection among those security commits on top yields to the the same result... Though I doubt it can change much because there was not that much relevant non-security things in the merge in question. -- i. --
Sep 16, 7:07 am 2008
Jaswinder Singh
Re: [Bug #11272] BUG: parport_serial in 2.6.27-rc1 for N ...
Hello all, I am sorry for delay. I have tested parport_pc and also tried with pcmcia_cs, only thing I get is disappointment. So I give up :-( Now I switched to usbserial. usbserial drivers are working great !! Now I do not want to use parport_pc and pcmcia_cs atleast for 2 years, I hope in 2 years this will be solved ;) In the mean time, If you think my problem is solved just ping to me I will test and let you know the results. Thank you for all your support and ...
Sep 16, 8:25 am 2008
Zhang Rui
Re: [Bug #11471] GPE storm detected, kernel freezes
this has already been fixed in -rc6. please refer to http://bugzilla.kernel.org/show_bug.cgi?id=11471#c22 so I think this should be removed from the list. thanks, rui --
Sep 15, 10:50 pm 2008
Ingo Molnar
Re: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang.
it's already in tip/sched/posix-cpu-timers, so please send a delta patch against tip/master: http://people.redhat.com/mingo/tip.git/README i'd suggest to move all the scheduler-internal accounting functions into kernel/sched_stats.h. AFAICS there's no scheduler-external user of these APIs. The most widely used external APIs is thread_group_cputime_smp(), and that is out of line already. (except on UP where it's trivial) Ingo --
Sep 16, 1:39 am 2008
Ingo Molnar
Re: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang.
i dont know ... lets try that simplification as a delta patch, ok? Please check the before/after size of 'vmlinux' in a 'make defconfig' [with SMP disabled after make defconfig] UP build. If there's visible size difference then Roland's point holds. Ingo --
Sep 16, 1:41 am 2008
Kiyoshi Ueda
Re: [PATCH 02/13] block: add request submission interface
Hi Boaz, Jens, They might look simlar but don't have much in common actually. I could refactor them like the attached patch, but I'm not sure this is a correct way and this is cleaner than the current code. (e.g. blk_execute_rq_nowait() can't be called with irqs-disabled, but blk_insert_request() and my blk_submit_request() can be called with irqs-disabled.) So I'd leave them as it is unless you or others strongly prefer the attached patch... Anyway, I would like to leave the ...
Sep 16, 9:06 am 2008
Jens Axboe
Re: [PATCH 02/13] block: add request submission interface
If it wasn't for the _irq vs _irqsave, I would apply it. But I agree, your current approach is fine. -- Jens Axboe --
Sep 16, 10:02 am 2008
Kiyoshi Ueda
Re: [PATCH 02/13] block: add request submission interface
Hi Jens, OK, I'll rebase my patches for for-2.6.28 of your block git and repost the block bits. Maybe I need a time to confirm whether the diffrences between 2.6.27-rc6 and the block git affect my patches. (Hopefully, I'd like to repost this week.) Thanks, Kiyoshi Ueda --
Sep 16, 11:12 am 2008
Thomas Jarosch
Re: RFC: [patch] log fatal signals like SIGSEGV
Thank you for your feedback Marcin, it was really helpful. The log message above is a good start. There's also the "print-fatal-signals" kernel parameter which prints out much more than just the basic info: ======================= sleep/3277: potentially unexpected fatal signal 11. code at 001b7571: 89 d3 3d 01 f0 ff ff 73 01 c3 53 e8 00 00 00 00 Pid: 3277, comm: sleep Not tainted (2.6.26-2.i2nsmp #7) EIP: 0073:[<001b7571>] EFLAGS: 00000246 CPU: 0 EIP is at 0x1b7571 EAX: fffffdfc EBX: ...
Sep 16, 5:59 am 2008
Marcin Slusarz
Re: RFC: [patch] log fatal signals like SIGSEGV
It looks much better now. But I don't think it will go in as is. Maybe you can disable it by default and create a sysctl switch? Marcin --
Sep 16, 10:42 am 2008
Lai Jiangshan Sep 15, 8:30 pm 2008
Lai Jiangshan
Re: [PATCH -mm 2/2] cgroup: use multibuf for tasks file
I think open cgroup.tasks to read is not a critical path. --
Sep 15, 6:37 pm 2008
Li Zefan
Re: [PATCH -mm 2/2] cgroup: use multibuf for tasks file
This patch does not only add runtime overhead, but also make code much more complex, so the code is harder to read and harder to maintain, and object size is increased, which means increased memory footprint. And is there any reason not using plain vmalloc? Don't bloat the kernel without good reasons IMO... --
Sep 15, 7:16 pm 2008
Andi Kleen
Re: [PATCH 0/3] fix GART to respect device's dma_mask ab ...
Huh? That is what the need_iommu() logic in gart_map_sg() does. An I'm not aware of any bugs in this area. Did you actually see that failure in practice? I don't see how it could happen. -Andi -- ak@linux.intel.com --
Sep 15, 5:54 pm 2008
FUJITA Tomonori
Re: [PATCH 0/3] fix GART to respect device's dma_mask ab ...
On Tue, 16 Sep 2008 19:58:24 +0200 What do you mean? For example, some aacraid cards have 31bit dma mask. What guarantees that IOMMUs's dma_alloc_coherent don't return a I think that the patch is a pretty straightforward, it just the same thing that IOMMUs with > 32bits virtual address space do. We can do better with the simple patch. But I'm ok with dropping the patch for GART since we can live without the patch, as you said. --
Sep 16, 4:53 pm 2008
FUJITA Tomonori
Re: [PATCH 0/3] fix GART to respect device's dma_mask ab ...
On Tue, 16 Sep 2008 02:54:32 +0200 What the need_iommu() does is seeing if GART needs to do virtual mappings or not. (After need_iommu() checking) What this patchset does is to guarantee No, I did not. This patchset does the right thing theoretically, I think, but if such problem never happens for GART, I'll drop the patch for GART. Joerg? --
Sep 16, 6:20 am 2008
Andi Kleen
Re: [PATCH 0/3] fix GART to respect device's dma_mask ab ...
Ah you care about masks < 32bit? Those always are handled elsewhere in the block layer (using the bounce_pfn mechanism) or in various other ways in other subsystems. e.g. on networking the rule is that you just don't announce direct SG when you have less than 32bit mask. And the others like sound generally don't use map_sg()/map_single(), but instead pre allocate something with dma_alloc_coherent() or similar. Also what would you do if it this check fails? There is no suitable fallback ...
Sep 16, 6:43 am 2008
FUJITA Tomonori
Re: [PATCH 0/3] fix GART to respect device's dma_mask ab ...
On Tue, 16 Sep 2008 15:43:35 +0200 I don't think that the bounce guarantees that dma_alloc_coherent() I'm not familiar with what the networking does, for example, seems that b44 sets dev->dma_mask to DMA_30BIT_MASK and b44_start_xmit() does: mapping = ssb_dma_map_single(bp->sdev, skb->data, len, DMA_TO_DEVICE); if (ssb_dma_mapping_error(bp->sdev, mapping) || mapping + len > DMA_30BIT_MASK) { struct sk_buff *bounce_skb; /* Chip can't handle DMA to/from >1GB, use bounce buffer */ if ...
Sep 16, 10:13 am 2008
Andi Kleen
Re: [PATCH 0/3] fix GART to respect device's dma_mask ab ...
dma_alloc_coherent() is not used for block IO data. And dma_alloc_coherent() b44 (and related designs like the bcm wireless chipset) It's not worth to handle this strange case. The drivers do anyways. These are very cheap devices which are only rarely used in systems with >2GB and for those cases the existing bouncing setup works fine. -Andi -- ak@linux.intel.com --
Sep 16, 10:58 am 2008
Andi Kleen
Re: [PATCH 0/3] fix GART to respect device's dma_mask ab ...
AFAIK all subsystems deal with it on their own. That is because i386 is the same (no remapping pci_map_* at all) and subsystems are usually They will stay failures because GFP_DMA bouncing can not be really done today in the pci_map_* layer. With a lot of effort you could probably fix all that, but I doubt it would be worth the effort for the few devices left with DMA masks < 32bit. -- ak@linux.intel.com --
Sep 16, 9:20 am 2008
Joerg Roedel
Re: [PATCH 0/3] fix GART to respect device's dma_mask ab ...
I am not aware of any failures which are fixed by these patches. But in theory there could be failures. Joerg -- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony ...
Sep 16, 8:52 am 2008
Thomas Gleixner
Re: 2.6.27-rc6: nohz + s2ram = need to press keys to get ...
Is the timer_list output is from that "sleepy" state ? If not please provide one. Thanks, tglx --
Sep 16, 7:16 am 2008
Thomas Gleixner
Re: 2.6.27-rc6: nohz + s2ram = need to press keys to get ...
Does the patch below fix it ? Thanks, tglx ---- diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 1876b52..eb8736f 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -69,6 +69,9 @@ void clockevents_set_mode(struct clock_event_device *dev, dev->set_mode(mode, dev); dev->mode = mode; } + + if (mode == CLOCK_EVT_MODE_SHUTDOWN) + dev->next_event.tv64 = KTIME_MAX; } /** diff --git a/kernel/time/tick-broadcast.c ...
Sep 16, 10:02 am 2008
Cyrill Gorcunov
Re: [Bugme-new] [Bug 11543] New: kernel panic: softlocku ...
[Thomas Gleixner - Tue, Sep 16, 2008 at 07:14:40AM -0700] | On Mon, 15 Sep 2008, Joshua Hoblitt wrote: | | > In addition to the deadlocks, we still have the watchdog warning: | > | > [ 0.460034] Testing NMI watchdog ... | > [ 0.532557] WARNING: CPU#0: NMI appears to be stuck (0->0)! | > [ 0.533301] Please report this to bugzilla.kernel.org, | > [ 0.536635] and attach the output of the 'dmesg' command. | > | > Perhaps an HPET problem: | > | > [ 0.993800] hpet0: at MMIO ...
Sep 16, 10:56 am 2008
Joshua Hoblitt
Re: [Bugme-new] [Bug 11543] New: kernel panic: softlocku ...
In addition to the deadlocks, we still have the watchdog warning: [ 0.460034] Testing NMI watchdog ... [ 0.532557] WARNING: CPU#0: NMI appears to be stuck (0->0)! [ 0.533301] Please report this to bugzilla.kernel.org, [ 0.536635] and attach the output of the 'dmesg' command. Perhaps an HPET problem: [ 0.993800] hpet0: at MMIO 0xfed00000, IRQs 2, 8, 31 [ 0.999969] hpet0: 3 32-bit timers, 25000000 Hz [ 1.004396] ACPI: RTC can wake from S4 [ 1.006637] Clockevents: ...
Sep 15, 7:54 pm 2008
Thomas Gleixner
Re: [Bugme-new] [Bug 11543] New: kernel panic: softlocku ...
Can you try nmi_watchdog=2 ? Thanks, tglx --
Sep 16, 7:14 am 2008
Cyrill Gorcunov
Re: [Bugme-new] [Bug 11543] New: kernel panic: softlocku ...
[Cyrill Gorcunov - Tue, Sep 16, 2008 at 09:56:29PM +0400] ... | | And get apic=debug a try too please. I remember there | was a problem with SB600 on ACPI side (but they should | be already fixed) | | - Cyrill - Sorry Thomas, I meant to send the message to Joshua - Cyrill - --
Sep 16, 10:57 am 2008
Suresh Siddha
Re: [patch 0/7] x86, cpa: cpa related changes to be inli ...
hmm. Me the culprit :( There are more places in the kernel which takes pgd_lock using spin_lock_irqsave() construct. Need to fix all such places to use spin_lock(). Will fix it and send a more tested patch set early next week, after I return from the conferences. thanks, suresh --
Sep 15, 10:44 pm 2008
Jarod Wilson
Re: [PATCH 02/18] lirc serial port receiver/transmitter ...
Current git tree works for receiving IR signals via lirc_serial (tested by Janne) and via lirc_mceusb2 (tested by me). Something is still slightly haywire with lirc_i2c though. It registers fine, but IR signals simply aren't making it to lircd. Probably unrelated to the dynamic device num changes, looking into it. -- Jarod Wilson jarod@redhat.com --
Sep 15, 9:08 pm 2008
Tejun Heo
Re: XFS shutting down due to IO timeout on SATA disk (pa ...
Hello, The only patch which could have affected the result is the off-by-one one; however, FLUSH timeout is a bit unexpected failure mode for the problem. Can you please keep the system running for a whlie and see whether the problem occurs? Thanks. -- tejun --
Sep 16, 10:35 am 2008
Mark Lord
Re: XFS shutting down due to IO timeout on SATA disk (pa ...
.. No, the failures happen randomly at customer sites, and only since they "upgraded" to SLES10 with libata. I think the PSUs are probably just fine. Time to hack the drivers to give proper status on the timeouts, too; otherwise we won't ever have any clue as to what is really happening. Cheers --
Sep 15, 8:49 pm 2008
Bruno
Re: XFS shutting down due to IO timeout on SATA disk (pa ...
Hello, I don't have other drives of the same model, but 3 ones slightly smaller in size and previous generation, those are just a few months older (but also have way more uptime), see below for the smartctl output. I've never seen ATA errors on them. These other drives are running on AMD based platform, SB600 SATA with AHCI. Just for the record, on the VIA there were no errors yet with 2.6.27-rc6-git3 though I ran some compiling on it. As such it *could* be that one of the patches pushed ...
Sep 16, 1:21 am 2008
Grant Grundler
Re: XFS shutting down due to IO timeout on SATA disk (pa ...
On Mon, Sep 15, 2008 at 1:43 PM, Tejun Heo <tj@kernel.org> wrote: The "raw" values are "vendor defined". Often the 6 bytes of raw data are split up into 1 or 2 byte wide fields. Any volunteers to submit a patch to smartmontools to dump "raw values" as hexidecimal by default? 441778176 == 0x1a550000 Need to see if the vendor will provide documentation to decode these values. AFAICT, it's not safe to directly compare raw values between vendors since the raw values don't mean exactly ...
Sep 16, 8:07 am 2008
Sebastien Dugue Sep 16, 3:38 am 2008
Sebastien Dugue
Re: [PATCH 2/2] ehea: fix mutex and spinlock use
OK, your call, you know the code better than I do. But the locking could at least be pushed into ehea_update_firmware_handles() and ehea_update_bcmc_registrations() instead of being at each call site. Thanks, --
Sep 15, 11:57 pm 2008
Thomas Klein
Re: [PATCH 2/2] ehea: fix mutex and spinlock use
It unfortunately can't. As I already mentioned "it must be assured that no function that modifies the list's content can be called while another list update is in progress". This means that for example ehea_broadcast_reg_helper() may not run during a list update. That's why the locks surround these function calls as well. --
Sep 16, 2:13 am 2008
Roland Dreier Sep 16, 10:23 am 2008
Pavel Emelyanov Sep 16, 5:23 am 2008
KAMEZAWA Hiroyuki
memcg: lazy_lru (was Re: [RFC] [PATCH 8/9] memcg: remove ...
On Fri, 12 Sep 2008 09:12:48 -0700 I'm now writing *lazy* lru handing via per-cpu struct like pagevec. It seems works well (but not so fast as expected on 2cpu box....) I need more tests but it's not so bad to share the logic at this stage. I added 3 patches on to this set. (my old set need bug fix.) == [1] patches/page_count.patch ....get_page()/put_page() via page_cgroup. [2] patches/lazy_lru_free.patch ....free page_cgroup from LRU in lazy way. [3] patches/lazy_lru_add.patch ....add ...
Sep 16, 5:13 am 2008
kamezawa.hiroyu
Re: Re: [RFC][PATCH 11/9] lazy lru free vector for memcg
I thought schedule_on_each_cpu() watis for completion of the work. I'll check it, again. Thank you for review. Regards, -Kame --
Sep 16, 6:02 am 2008
KAMEZAWA Hiroyuki
[RFC][PATCH 10/9] get/put page at charge/uncharge
While page_cgroup() has reference to the page, it doesn't increment page->count. Now, the page and its page_cgroup has one-to-one relationship and there is no dynamic allocation. But the behavior of global LRU and memory resource controller is not synchronized. What this means is - LRU handling cost is not high. (because there is no synchronization) - We have to be afraid of "reuse" of the page. Synchronizing global LRU and memcg's LRU means to make the cost of LRU handling twice. ...
Sep 16, 5:17 am 2008
KAMEZAWA Hiroyuki
[RFC][PATCH 11/9] lazy lru free vector for memcg
Free page_cgroup from its LRU in batched manner. When uncharge() is called, page is pushed ontto per-cpu vector and removed from LRU. This is depends on increment-page-count-via-page-cgroup patch. Because page_cgroup has refcnt to the page, we don't have to be afraid that the page is reused while it's on vector. Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --- mm/memcontrol.c | 163 +++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 155 ...
Sep 16, 5:19 am 2008
KAMEZAWA Hiroyuki
[RFC] [PATCH 12/9] lazy lru add vie per cpu vector for memcg.
Delaying add_to_lru() and do it by batch. For delaying, PCG_LRU flag is added. If PCG_LRU is set, page is on LRU and unchage() have to call remove from lru. If not, the page is not added to LRU. For avoid race, all flags are modified under lock_page_cgroup(). Lazy-add logic reuses Lazy-free's one. Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --- include/linux/page_cgroup.h | 4 + mm/memcontrol.c | 91 ++++++++++++++++++++++++++++++++++++++------ ...
Sep 16, 5:21 am 2008
Roland Dreier Sep 16, 9:45 am 2008
Jeremy Fitzhardinge Sep 16, 10:33 am 2008
Rik van Riel
Re: 2.6.27-rc5-mm1
On Tue, 16 Sep 2008 14:09:17 -0400 OK, with pci=nomsi the system boots up fine and the bnx2 driver works. Looks like the MSI code in linux-next is broken on the Dell PE 1950. -- All rights reversed. --
Sep 16, 4:01 pm 2008
Rik van Riel
Re: 2.6.27-rc5-mm1
On Mon, 15 Sep 2008 16:00:58 -0700 The linux-next tree fails in the same way. Here is the dmesg output from the broadcom driver: Broadcom NetXtreme II Gigabit Ethernet Driver bnx2 v1.8.0 (Aug 14, 2008) vendor=8086 device=2690 bnx2 0000:05:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16 eth0: Broadcom NetXtreme II BCM5708 1000Base-T (B2) PCI-X 64-bit 133MHz found at mem f8000000, IRQ 16, node addr 00:19:b9:ee:6c:4a vendor=8086 device=3510 vendor=8086 device=3500 vendor=8086 ...
Sep 16, 11:09 am 2008
Elias Oltmanns
Re: [PATCH 4/4] Add documentation for hard disk shock pr ...
Thanks for reviewing, Randy. In addition to your annotations, I've made various adjustments reflecting changes to the interface as they have evolved in the discussion over the last two weeks. Please feel free to point out some more mistakes and shortcomings ;-). Regards, Elias From: Elias Oltmanns <eo@nebensachen.de> Subject: [PATCH] Add documentation for hard disk shock protection interface Put some information (and pointers to more) into the kernel's doc tree, describing briefly ...
Sep 16, 9:53 am 2008
Brandeburg, Jesse
Re: [NET-NEXT PATCH] e1000: remove unused Kconfig option ...
Here is an updated patch without the defconfig changes == cut here == e1000: remove Kconfig option for packet split and e1000 related code From: Jesse Brandeburg <jesse.brandeburg@intel.com> Since the e1000/e1000e split, no hardware supported by e1000 supports packet split, just remove the Kconfig option and associated code from the driver. reposted without the defconfig changes, should apply to net-next Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- ...
Sep 16, 1:01 pm 2008
Pekka Paalanen
[PATCH 3/7] ftrace: add trace_vprintk()
From 5579d3e6471201524697d1cc32fb37f1a4f70f95 Mon Sep 17 00:00:00 2001 From: Pekka Paalanen <pq@iki.fi> Date: Sun, 14 Sep 2008 17:27:05 +0300 Subject: [PATCH] ftrace: add trace_vprintk() trace_vprintk() for easier implementation of tracer specific *_printk functions. Add check check for no_tracer, and implement __ftrace_printk() as a wrapper. Signed-off-by: Pekka Paalanen <pq@iki.fi> --- kernel/trace/trace.c | 24 ++++++++++++++++++------ kernel/trace/trace.h | 1 + 2 files changed, ...
Sep 16, 11:58 am 2008
Steven Rostedt
Re: [PATCH 3/7] ftrace: add trace_vprintk()
Nice! Acked-by: Steven Rostedt <rostedt@goodmis.org> -- Steve --
Sep 16, 1:06 pm 2008
Pekka Paalanen
[PATCH 7/7] ftrace: inject markers via trace_marker file.
From 9be308e4ea3af69cebb29930757d6457f762866d Mon Sep 17 00:00:00 2001 From: Pekka Paalanen <pq@iki.fi> Date: Sun, 14 Sep 2008 22:34:35 +0300 Subject: [PATCH] ftrace: inject markers via trace_marker file. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Allow a user to inject a marker (TRACE_PRINT entry) into the trace ring buffer. The related file operations are derived from code by Frédéric Weisbecker <fweisbec@gmail.com>. Signed-off-by: Pekka ...
Sep 16, 12:06 pm 2008
Steven Rostedt Sep 16, 1:11 pm 2008
Pekka Paalanen
[PATCH 6/7] mmiotrace: remove left-over marker cruft.
From abd3cadc69143804cf4b0cf1d6fcadda5daad903 Mon Sep 17 00:00:00 2001 From: Pekka Paalanen <pq@iki.fi> Date: Sun, 14 Sep 2008 20:50:55 +0300 Subject: [PATCH] mmiotrace: remove left-over marker cruft. Signed-off-by: Pekka Paalanen <pq@iki.fi> --- arch/x86/mm/mmio-mod.c | 64 --------------------------------------------- include/linux/mmiotrace.h | 3 +- 2 files changed, 1 insertions(+), 66 deletions(-) diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c index ...
Sep 16, 12:03 pm 2008
Pekka Paalanen
[PATCH 2/7] ftrace: move mmiotrace functions out of trace.c.
From 743cab2763d3e8d9f4d3b82a02fcdc5ad8a13c04 Mon Sep 17 00:00:00 2001 From: Pekka Paalanen <pq@iki.fi> Date: Sun, 14 Sep 2008 16:53:05 +0300 Subject: [PATCH] ftrace: move mmiotrace functions out of trace.c. Moves the mmiotrace specific functions from trace.c to trace_mmiotrace.c. Functions trace_wake_up(), tracing_get_trace_entry(), and tracing_generic_entry_update() are therefore made available outside trace.c. Signed-off-by: Pekka Paalanen <pq@iki.fi> --- kernel/trace/trace.c ...
Sep 16, 11:56 am 2008
Pekka Paalanen
[PATCH 4/7] x86 mmiotrace: implement mmiotrace_printk().
From ca4db25e22b79fd77f4a7c6bb812e605379840a0 Mon Sep 17 00:00:00 2001 From: Pekka Paalanen <pq@iki.fi> Date: Sun, 14 Sep 2008 18:37:46 +0300 Subject: [PATCH] x86 mmiotrace: implement mmiotrace_printk(). Offer mmiotrace users a function to inject markers from inside the kernel. This depends on the trace_vprintk() patch. Signed-off-by: Pekka Paalanen <pq@iki.fi> --- arch/x86/mm/mmio-mod.c | 19 ++++++++++++++++++- arch/x86/mm/testmmiotrace.c | 4 ++++ ...
Sep 16, 12:00 pm 2008
Frédéric Weisbecker
Re: Tracing/ftrace: trouble with trace_entries and trace_pipe
As I said to you, I met the same bug of this early quit of the pipe. But I should give here more details. This bug occurs with -tip (a version pulled 2 days ago so trace.c didn't change). I never saw it with other tracers than mmiotrace. I had no problem with sched_switch or function tracer. It happened when I was writing the tracer marker. So I'm not sure if the origin is here. If I'm not wrong it happened whithout adding mark messages too. Can you tell me if your pipe quits when you add ...
Sep 16, 1:57 am 2008
Pekka Paalanen
[PATCH 5/7] mmiotrace: handle TRACE_PRINT entries.
From 6a458e250857907e16cb16799392fccbfd5f0f4a Mon Sep 17 00:00:00 2001 From: Pekka Paalanen <pq@iki.fi> Date: Sun, 17 Aug 2008 18:15:13 +0300 Subject: [PATCH] mmiotrace: handle TRACE_PRINT entries. Also make trace_seq_print_cont() non-static, and add a newline if the seq buffer can't hold all data. Signed-off-by: Pekka Paalanen <pq@iki.fi> --- kernel/trace/trace.c | 31 +++++++++++-------------------- kernel/trace/trace.h | 19 +++++++++++++++++++ ...
Sep 16, 12:02 pm 2008
Pekka Paalanen
Re: [PATCH 5/7] mmiotrace: handle TRACE_PRINT entries.
On Tue, 16 Sep 2008 16:11:20 -0400 (EDT) Good question. It seems to be used a lot. :-) commit 6e21828743247270d09a86756a0c11702500dbfb Author: Richard Knutsson <ricknu-0@student.ltu.se> Date: Sat Sep 30 23:27:11 2006 -0700 [PATCH] Generic boolean This patch defines: * a generic boolean-type, named 'bool' * aliases to 0 and 1, named 'false' and 'true' Removing colliding definitions of 'bool', 'false' and 'true'. Signed-off-by: Richard Knutsson ...
Sep 16, 2:24 pm 2008
Pekka Paalanen
Re: Tracing/ftrace: trouble with trace_entries and trace_pipe
On Mon, 15 Sep 2008 17:14:34 -0400 (EDT) Yes, it returned a very different number. This is Ingo's tip/master, sorry for not being explicit. Checked-out on Sunday. Echoing the following numbers to trace_entries triggers it: 200, 64, 640, 16422, 16422, 16422, 164220... so the ridiculously small number 64 does something bad. After 640, I read back something less than 200. Each following write increases that number by 46. 16422 is the default before writing anything. That is even stranger than ...
Sep 16, 11:01 am 2008
Pekka Paalanen
[PATCH 1/7] x86 mmiotrace: fix a rare memory leak.
From da74191de5e5a3c0adee0604757d19b2faf8ec79 Mon Sep 17 00:00:00 2001 From: Pekka Paalanen <pq@iki.fi> Date: Sat, 23 Aug 2008 14:32:22 +0300 Subject: [PATCH] x86 mmiotrace: fix a rare memory leak. Signed-off-by: Pekka Paalanen <pq@iki.fi> --- arch/x86/mm/mmio-mod.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c index 635b50e..754bd1e 100644 --- a/arch/x86/mm/mmio-mod.c +++ b/arch/x86/mm/mmio-mod.c @@ -307,8 ...
Sep 16, 11:54 am 2008
Paul E. McKenney
Re: [PATCH, RFC] v4 scalable classic RCU implementation
Hello, Manfred! Not necessarily. If all CPUs corresponding to this rcu_state struct have checked in already, we don't even get to this loop -- see the The outer loop, yes. The inner loop only for those rcu_state structs With the definition of "O()" being the worst-case execution time, yes. But this worst case could only happen when the system was mostly idle, in which case the added overhead should not be too horribly bad. If the system was busy enough that each CPU ran at least one ...
Sep 16, 10:30 am 2008
Paul E. McKenney
Re: [PATCH, RFC] v4 scalable classic RCU implementation
Good point! Indeed, if you had a 1024-CPU box acting as (say) a router/hub using the Linux-kernel protocol stacks with no user-mode processing, then you could indeed have the system mostly busy with no user-space code running, and thus no quiescent states. However, last I checked, almost all 1024-CPU boxes run HPC workloads mostly in user mode, so this scenario would not occur. However, again, if it does come up, I would add an additional level of state machine to the ...
Sep 16, 11:22 am 2008
Manfred Spraul
Re: [PATCH, RFC] v4 scalable classic RCU implementation
No: "was mostly running cpu_idle()". A cpu_idle() cpu could execute lots of irqs and softirqs. So the worst case would be a system with 1 cpu/node for reserved for irq handling. The "idle" cpu would be always in no_hz mode, even though it might be 100% busy handling irqs. The remaning cpus might be 100% busy handling user space. And every quiescent state will end up in that O(NR_CPUS) loop. -- Manfred --
Sep 16, 10:48 am 2008
Manfred Spraul
Re: [PATCH, RFC] v4 scalable classic RCU implementation
Hi Paul, I'm still comparing my implementation with your code: - f is called once for each cpu in the system, correct? - if at least one cpu is in nohz mode, this loop will be needed for every grace period. That means an O(NR_CPUS) loop with disabled local interrupts :-( Is that correct? Unfortunately, my solution is even worse: My rcu_irq_exit() acquires a global spinlock when called on a nohz cpus. A few cpus in cpu_idle, nohz, executing 50k network interrupts/sec would ...
Sep 16, 9:52 am 2008
Ricard Wanderlof
Re: [PATCH 00/10] AXFS: Advanced XIP filesystem
NAND is significantly faster when writing than NOR, read speed is of the same magnitude, possibly slower in many cases. /Ricard -- Ricard Wolf Wanderlöf ricardw(at)axis.com Axis Communications AB, Lund, Sweden www.axis.com Phone +46 46 272 2016 Fax +46 46 13 61 30 "With Free Software you are employing the best programmers on the planet" --
Sep 15, 11:57 pm 2008
Jared Hulbert
Re: [PATCH 00/10] AXFS: Advanced XIP filesystem
Right. Specifically, read bandwidth is on the same order of magnitude. However the read latency of NAND is a couple orders of magnitude higher (100ns vs 20,000ns) so it depends on what you are doing. --
Sep 16, 8:30 am 2008
Sergei Shtylyov
Re: [PATCH 2/5] ide: ->ide_dma_clear_irq() -> ->clear_irq()
Hello. But its implementations will have to depend on it anyway. And clearing the IDE interrupt in general already depends on the transfer mode -- the BMIDE interrupt which is a (delayed) reflection of INTRQ is cleared implicitly by the dma_end() method -- except in at least sgiioc4 driver. BTW, sgiioc4 seems another candidate for clear_irq() implementation -- currently clearing is done implicitly by the read_status() method (I don't quite understand why it clears DMA error ...
Sep 16, 2:16 am 2008
Tom Tucker
Re: NFS regression? Odd delays and lockups accessing an ...
Iain: I'm assuming you'll do this in advance of any patch from me? I was simply going to add printk to the various shutdown paths and see if we could get some finer grained debug output since the generic transport debug output was too verbose. Let me know and I'll help if I can, --
Sep 16, 4:38 am 2008
Tom Tucker Sep 16, 8:58 am 2008
Ian Campbell
Re: NFS regression? Odd delays and lockups accessing an ...
(dropping the e1000 guys, it seems unnecessary to keep spamming them with this issue when it's unlikely to be anything to do with them. I've left their list on for now so they know. I'd suggest dropping it from any replies.) FYI I've repro'd with=20 commit a551b98d5f6fce5897d497abd8bfb262efb33d2a Merge: d1c6d2e... 50bed2e... Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Thu Sep 11 11:50:15 2008 -0700 =20 Merge branch ...
Sep 15, 10:48 pm 2008
Ian Campbell
Re: NFS regression? Odd delays and lockups accessing an ...
I'm actually Ian. (I don't actually mind that much, the other way round You mean logging on the client or server side? I'm currently bisecting client. I'm happy to add some extra prints there if you point me in the direction of the code paths of interest. Ian. -- Ian Campbell Current Noise: Anathema - Leave No Trace I haven't lost my mind; I know exactly where I left it. --
Sep 16, 8:03 am 2008
Ian Campbell
Re: NFS regression? Odd delays and lockups accessing an ...
Thanks. It's running 2.6.25.7 although I can massage a more recent patch if needed. (I'm a bit less keen to run a variety of random kernels on that machine). Ian. -- Ian Campbell Current Noise: The Ocean - Protoerozoic - Rhyacian - Untimely Meditations We may not return the affection of those who like us, but we always respect their good judgement. --
Sep 16, 9:24 am 2008
Ingo Molnar
Re: [RFC 0/4] dynamically allocate arch specific system ...
why does it need to allocate a single irq/vector pair? Why is a regular interrupt not good? Ingo --
Sep 16, 1:24 am 2008
Dean Nelson
Re: [RFC 0/4] dynamically allocate arch specific system ...
When you speak of a 'regular interrupt' I assume you are referring to simply the irq number, with the knowledge of what vector and CPU(s) it is mapped to being hidden? sgi-gru driver The GRU is not an actual external device that is connected to an IOAPIC. The gru is a hardware mechanism that is embedded in the node controller (UV hub) that directly connects to the cpu socket. Any cpu (with permission) can do direct loads and stores to the gru. Some of these stores will result in an ...
Sep 16, 1:46 pm 2008
Lazy
Re: SKB BUG: Invalid truesize (412) len=28, ipsec related ?
with this patch i got some more info c02ef322>] __netdev_alloc_skb+0x22/0x50 [<f88c4ea5>] e1000_clean_rx_irq+0x3f5/0x500 [e1000] [<f88c468d>] e1000_clean+0x3d/0xc0 [e1000] [<c02f69ee>] net_rx_action+0x14e/0x1a0 [<c0129014>] __do_softirq+0xd4/0xf0 [<c0129068>] do_softirq+0x38/0x40 [<c01055ae>] do_IRQ+0x3e/0x80 [<c010380b>] common_interrupt+0x23/0x28 [<c010142c>] mwait_idle_with_hints+0x3c/0x50 SKB BUG: Invalid truesize (340) size=468, sizeof(sk_buff)=212 last reallocate at: ...
Sep 16, 5:40 am 2008
Bryan Wu
Re: [PATCH] gpio_free might sleep, blackfin architecture
On Tue, Sep 16, 2008 at 4:02 AM, Uwe Kleine-König It looks fine for me, thanks a lot. --
Sep 15, 7:16 pm 2008
Kok, Auke Sep 16, 10:22 am 2008
Tim Bird
Re: [patch 5/3] fastboot: sync the async execution befor ...
Sorry for the massively late response. Don't know how I missed this thread earlier, but I can answer that from my standpoint. At Sony we have a "no modules if possible" policy to reduce kernel footprint. The size difference for a kernel compiled with modules vs one with external modules is about 10% IRRC. -- Tim ============================= Tim Bird Architecture Group Chair, CE Linux Forum Senior Staff Engineer, Sony Corporation of America ============================= --
Sep 16, 3:19 pm 2008
Rusty Russell
Re: [PATCH 1/7] dynamic debug v2 - infrastructure
Hi Jason, Couple of nit-picks about the module part of this patch. First, this could This loop seems way more complex than it needs to be. Perhaps pull these two out into a setup_verbose_debug() func which is a noop for !CONFIG_DYNAMIC_PRINTK_DEBUG, and drop all the casts? Thanks, Rusty. --
Sep 15, 5:03 pm 2008
Luming Yu
Re: [RFC PATCH] set TASK_TRACED before arch_ptrace code ...
The reason is not as complicated as I thought. It is because x86 strace don't test TCB_WAITEXECVE. please take a look at defs.h (strace-4.5.16), the flag is defined as follows: #ifdef LINUX # if defined(ALPHA) || defined(SPARC) || defined(SPARC64) || defined(POWERPC) || defined(IA64) || defined(HPPA) || defined(SH) || defined(SH64) || defined(S390) || defined(S390X) || defined(ARM) # define TCB_WAITEXECVE 02000 /* ignore SIGTRAP after exceve */ # endif I'm not an strace expert, so I ...
Sep 16, 1:50 am 2008
Yan Li
Re: [PATCH 1/2] VMware detection support for x86 and x86-64
I found that in this situation we can't use PCI info. My intention to do this is to fix the false warning from arch/x86/kernel/cpu/mtrr/main.c (around L695). When booting a VMware guest we got: "WARNING: strange, CPU MTRRs all blank?" For VMware guest this warning is false, just as that for a KVM guest. This code is from mtrr_trim_uncached_memory(), and used by setup_arch(), which is used far before PCI is ready. Therefore I think we can only use DMI here. Any idea? Thanks! -- ...
Sep 16, 6:32 am 2008
previous daytodaynext day
September 15, 2008September 16, 2008September 17, 2008