Home » Mailing list archives » linux-kernel » 2008 » September » 16

Re: [PATCH] vfs: added better file aio_read aio_write operations presence check

Previous thread: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch by Bodo Eggert on Tuesday, September 16, 2008 - 8:32 am. (1 message)

Next thread: [PATCH] x86: Don't use NOPL on 32-bit cpu's because not all systems support it. by David Sanders on Tuesday, September 16, 2008 - 8:59 am. (7 messages)
[view original message]
From: Bodo Eggert
Subject: Re: [PATCH] vfs: added better file aio_read aio_write operations presence check
Date: Tuesday, September 16, 2008 - 8:36 am

Why can't the file system registration code set filp->f_op->aio_read to
generic_file_aio_read?

--


[ message continues ]
[view original message]
From: Matthew Wilcox
Subject: Re: [PATCH] vfs: added better file aio_read aio_write operations presence check
Date: Tuesday, September 16, 2008 - 8:41 am

const struct file_operations    *f_op;

Having said that, BUILD_BUG_ON(!f_op->aio_read) is fine by me ... make
the filesystem writer put it in without slowing down anyone at runtime.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--


[ message continues ]
Previous thread: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch by Bodo Eggert on Tuesday, September 16, 2008 - 8:32 am. (1 message)

Next thread: [PATCH] x86: Don't use NOPL on 32-bit cpu's because not all systems support it. by David Sanders on Tuesday, September 16, 2008 - 8:59 am. (7 messages)