Re: + itimers-fix-itimer-many-thread-hang.patch added to -mm tree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Oleg Nesterov
Date: Tuesday, September 16, 2008 - 4:13 am

On 09/15, Frank Mayhar wrote:

Great.

Please also remove tasklist_lock from thread_group_cputime_alloc_smp(),
it is not needed.

I'd also suggest to kill

	if (sig->cputime.totals)
		return 0;

, the caller has already checked this.


Please note also that thread_group_cputime_clone_thread() doesn't need
the second argument.


Very minor nit, but thread_group_cputime_alloc_smp() doesn't really
need get_cpu() + put_cpu_no_resched(), it can use smp_processor_id().

Oleg.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: + itimers-fix-itimer-many-thread-hang.patch added to - ..., Oleg Nesterov, (Tue Sep 16, 4:13 am)