login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
September
»
15
Re: [PATCH] cgroups: don't depend on CONFIG_MM_OWNER
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Pekka Enberg <penberg@...>
To: Paul Menage <menage@...>
Cc: <akpm@...>, <linux-kernel@...>, <balbir@...>
Subject:
Re: [PATCH] cgroups: don't depend on CONFIG_MM_OWNER
Date: Monday, September 15, 2008 - 1:56 pm
Hi Paul, Paul Menage wrote:
quoted text
> On Sun, Sep 14, 2008 at 10:37 AM, Pekka J Enberg <penberg@cs.helsinki.fi> wrote: >> From: Pekka Enberg <penberg@cs.helsinki.fi> >> >> The revoke patches, for example, select CONFIG_MM_OWNER independently of >> cgroups. Therefore, don't depend on CONFIG_MM_OWNER in cgroup specific code. > > Yes, the existing code doesn't seem quite right - if !CONFIG_MM_OWNER > then we don't need to even define a trivial version of > cgroup_mm_owner_callbacks() > > But your patch is too specific - tying the existance of > cgroup_mm_owner_callbacks() to the memory controller would break other > controllers (e.g. the memrlimit or swap controllers, which also want > to use it) > > How about: > > - any cgroup that needs mm-owner callbacks selects an option > CGROUP_MM_OWNER_CALLBACK > > - CGROUP_MM_OWNER_CALLBACK selects MM_OWNER and triggers the > definition of a non-trivial cgroup_mm_owner_callbacks() function
Yeah, sounds good to me. I just want to be able to select CONFIG_MM_OWNER separately for my revoke patches. Pekka --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] cgroups: don't depend on CONFIG_MM_OWNER
, Pekka J Enberg
, (Sun Sep 14, 1:37 pm)
Re: [PATCH] cgroups: don't depend on CONFIG_MM_OWNER
, Paul Menage
, (Mon Sep 15, 1:55 pm)
Re: [PATCH] cgroups: don't depend on CONFIG_MM_OWNER
, Pekka Enberg
, (Mon Sep 15, 1:56 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
david
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman
[PATCH 009/196] Chinese: add translation of sparse.txt
Andrew Morton
Re: -mm merge plans for 2.6.23 -- sys_fallocate
Stephen Rothwell
Announce: Linux-next (Or Andrew's dream :-))
git
:
linux-netdev
:
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
David Miller
[GIT]: Networking
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Wenji Wu
A Linux TCP SACK Question
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
508 guests
online.
Syndicate