On 257, 09 13, 2008 at 06:47:19 +0900, Akinobu Mita wrote:
quoted text
> __asr_toggle() is always called with asr_lock held.
> But there is unnecessary spin_unlock() call in __asr_toggle().
>=20
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Andrey Panin <pazke@donpac.ru>

Acked-by: Andrey Panin <pazke@donpac.ru>

quoted text
> ---
>  drivers/watchdog/ibmasr.c |    1 -
>  1 file changed, 1 deletion(-)
>=20
> Index: 2.6-git/drivers/watchdog/ibmasr.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
quoted text
> --- 2.6-git.orig/drivers/watchdog/ibmasr.c
> +++ 2.6-git/drivers/watchdog/ibmasr.c
> @@ -85,7 +85,6 @@ static void __asr_toggle(void)
> =20
>  	outb(reg & ~asr_toggle_mask, asr_write_addr);
>  	reg =3D inb(asr_read_addr);
> -	spin_unlock(&asr_lock);
>  }
> =20
>  static void asr_toggle(void)
>=20

--=20
Andrey Panin		| Linux and UNIX system administrator
pazke@donpac.ru		| PGP key: wwwkeys.pgp.net