* Dean Nelson <dcn@sgi.com> wrote:

quoted text
> +		ret = __grab_irq_vector(NON_IRQ_DESC, syscall_vector,
> +					&cpu_possible_map);
> +		spin_unlock_irqrestore(&vector_lock, flags);
> +		if (ret == false) {
> +			printk("lg: couldn't reserve syscall %u\n",
> +			       syscall_vector);
> +			return -EBUSY;
> +		}

please use __grab_irq_vector() to standard return type: -EINVAL (or 
-EBUSY) on failure, vector on success. That will get rid of the 'ret == 
false' ugliness too.

	Ingo
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/