On Wed 2008-09-10 20:07:08, Frans Pop wrote:
quoted text
> On Wednesday 10 September 2008, Linus Torvalds wrote:
> > On Wed, 10 Sep 2008, Frans Pop wrote:
> > > But I would not expect the RTC to get changed when the resume is
> > > successful. Or does it just get updated with every resume step
> > > without a reset to the pre-trace value on completion?
> >
> > Indeed. We don't know where the bug happens when tracing, so each
> > trace-point just writes its hash value into it. And nothing restores
> > it, since nothing knows that the resume is "done" (a lot of problems
> > happen due to X interactions much later than the 'core' resume thing).
> 
> Right. How about this patch then?
> 
> ---
> From: Frans Pop <elendil@planet.nl>
> 
> As pm_trace uses the system's hardware clock to save its magic
> value, users of that option should be warned that using this debug
> option will result in an incorrect system time after resume.
>     
> Signed-off-by: Frans Pop <elendil@planet.nl>

ACK.

quoted text
> diff --git a/Documentation/power/s2ram.txt b/Documentation/power/s2ram.txt
> index b05f512..2ebdc60 100644
> --- a/Documentation/power/s2ram.txt
> +++ b/Documentation/power/s2ram.txt
> @@ -54,3 +54,21 @@ used to run with "radeonfb" (it's an ATI Radeon mobility). It turns out
>  that "radeonfb" simply cannot resume that device - it tries to set the
>  PLL's, and it just _hangs_. Using the regular VGA console and letting X
>  resume it instead works fine.
> +
> +NOTE
> +====
> +pm_trace uses the system's Real Time Clock (RTC) to save the magic number.
> +Reason for this is that the RTC is the only reliably available piece of
> +hardware during resume operations where a value can be set that will
> +survive a reboot.
> +
> +Consequence is that after a resume (even if it is successful) your system
> +clock will have a value corresponding to the magic mumber instead of the
> +correct date/time! It is therefore advisable to use a program like ntp-date
> +or rdate to reset the correct date/time from an external time source when
> +using this trace option.
> +
> +As the clock keeps ticking it is also essential that the reboot is done
> +quickly after the resume failure. The trace option does not use the seconds
> +or the low order bits of the minutes of the RTC, but a too long delay will
> +corrupt the magic value.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/