[PATCH] ibmasr: remove unnecessary spin_unlock()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Akinobu Mita
Date: Saturday, September 13, 2008 - 2:47 am

__asr_toggle() is always called with asr_lock held.
But there is unnecessary spin_unlock() call in __asr_toggle().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Andrey Panin <pazke@donpac.ru>
---
 drivers/watchdog/ibmasr.c |    1 -
 1 file changed, 1 deletion(-)

Index: 2.6-git/drivers/watchdog/ibmasr.c
===================================================================
--- 2.6-git.orig/drivers/watchdog/ibmasr.c
+++ 2.6-git/drivers/watchdog/ibmasr.c
@@ -85,7 +85,6 @@ static void __asr_toggle(void)
 
 	outb(reg & ~asr_toggle_mask, asr_write_addr);
 	reg = inb(asr_read_addr);
-	spin_unlock(&asr_lock);
 }
 
 static void asr_toggle(void)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ibmasr: remove unnecessary spin_unlock(), Akinobu Mita, (Sat Sep 13, 2:47 am)
Re: [PATCH] ibmasr: remove unnecessary spin_unlock(), Andrey Panin, (Mon Sep 15, 4:12 am)