Re: [PATCH 4/4] Add kernel doc for the completion, fix kernel-doc-nano-HOWTO.txt

Previous thread: [PATCH 3/4] Various arch/powerpc changes to support the 750GX cpufreq driver by Kevin Diggs on Monday, August 25, 2008 - 4:03 am. (1 message)

Next thread: linux-next: build failure by Stephen Rothwell on Monday, August 25, 2008 - 4:28 am. (3 messages)
From: Kevin Diggs
Date: Monday, August 25, 2008 - 4:25 am

This patch adds kernel doc for the completion feature. It is in kernel/sched.c
and include/linux/completion.h.

An error in the split-man.pl PERL snippet in kernel-doc-nano-HOWTO.txt is
also fixed.

My name is Kevin Diggs and I approve this patch.

Signed-off-by: Kevin Diggs <kevdig@hypersurf.com>
Index: Documentation/kernel-doc-nano-HOWTO.txt
===================================================================
--- Documentation/kernel-doc-nano-HOWTO.txt.orig	2008-08-13 02:18:53.000000000 -0700
+++ Documentation/kernel-doc-nano-HOWTO.txt	2008-08-19 14:21:43.000000000 -0700
@@ -168,10 +168,10 @@ if ($#ARGV < 0) {
  mkdir $ARGV[0],0777;
  $state = 0;
  while (<STDIN>) {
-    if (/^\.TH \"[^\"]*\" 4 \"([^\"]*)\"/) {
+    if (/^\.TH \"[^\"]*\" 9 \"([^\"]*)\"/) {
  	if ($state == 1) { close OUT }
  	$state = 1;
-	$fn = "$ARGV[0]/$1.4";
+	$fn = "$ARGV[0]/$1.9";
  	print STDERR "Creating $fn\n";
  	open OUT, ">$fn" or die "can't open $fn: $!\n";
  	print OUT $_;
Index: include/linux/completion.h
===================================================================
--- include/linux/completion.h.orig	2008-08-13 00:56:52.000000000 -0700
+++ include/linux/completion.h	2008-08-20 01:47:21.000000000 -0700
@@ -10,6 +10,18 @@

  #include <linux/wait.h>

+/**
+ * struct completion - structure used to maintain state for a "completion"
+ *
+ * This is the opaque structure used to maintain the state for a "completion".
+ * Completions currently use a FIFO to queue threads that have to wait for
+ * the "completion" event.
+ *
+ * See also:  complete(), wait_for_completion() (and friends _timeout,
+ * _interruptible, _interruptible_timeout, and _killable), init_completion(),
+ * and macros DECLARE_COMPLETION(), DECLARE_COMPLETION_ONSTACK(), and
+ * INIT_COMPLETION().
+ */
  struct completion {
  	unsigned int done;
  	wait_queue_head_t wait;
@@ -21,6 +33,14 @@ struct completion {
  #define COMPLETION_INITIALIZER_ONSTACK(work) \
  	({ init_completion(&work); work; })

+/**
+ * ...
From: Ingo Molnar
Date: Monday, August 25, 2008 - 5:42 am

this patch is whitespace damaged. Could you resend it as attachment, or 
set up your email client as per Documentation/email-clients.txt?

	Ingo
--

From: Ingo Molnar
Date: Tuesday, August 26, 2008 - 1:32 am

applied to tip/sched/devel - thanks Kevin!

	Ingo
--

From: Randy Dunlap
Date: Friday, September 12, 2008 - 11:44 am

Ack and thanks, but next time, please describe the error that is being
fixed.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--

Previous thread: [PATCH 3/4] Various arch/powerpc changes to support the 750GX cpufreq driver by Kevin Diggs on Monday, August 25, 2008 - 4:03 am. (1 message)

Next thread: linux-next: build failure by Stephen Rothwell on Monday, August 25, 2008 - 4:28 am. (3 messages)