Re: [RFC/PATCH] dontdiff: generate from gitignore

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Friday, September 12, 2008 - 10:36 am

On Fri, 12 Sep 2008, Randy Dunlap wrote:

t's not quite as simple as that, though.

The .gitignore files are fundamentally location hierarchy-aware, so a 
ignore entry in one subdirectory only affects that subdirectory 
(recursively), so if you flatten then, you should take that into account.

As far as I can tell, your script will generate lots of incorrect entries 
due to this. Eg, it will generate

	parse.[ch]

as a dontdiff pattern, because scripts/genksyms/.gitignore has that, but 
that means that now it will ignore parse.c in all the _other_ places, 
where it *isn't* a generated file (ie mm/parse.c).

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[path] don't diff generated firmware files, Arjan van de Ven, (Mon Sep 1, 3:09 pm)
Re: [path] don't diff generated firmware files, Alexey Dobriyan, (Mon Sep 1, 4:14 pm)
Re: [path] don't diff generated firmware files, Randy Dunlap, (Fri Sep 12, 10:17 am)
[PATCH] dontdiff: more updates to be closer to gitignore, Randy Dunlap, (Fri Sep 12, 10:17 am)
[RFC/PATCH] dontdiff: generate from gitignore, Randy Dunlap, (Fri Sep 12, 10:18 am)
Re: [RFC/PATCH] dontdiff: generate from gitignore, Linus Torvalds, (Fri Sep 12, 10:36 am)
Re: [RFC/PATCH] dontdiff: generate from gitignore, Randy Dunlap, (Fri Sep 12, 10:41 am)
Re: [RFC/PATCH] dontdiff: generate from gitignore, Kai Henningsen, (Fri Sep 12, 1:32 pm)