Re: [RFC][PATCH] sunrpc: fix oops in rpc_create() when the mount namespace is unshared

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Chuck Lever
Date: Thursday, September 11, 2008 - 9:39 am

Cedric-

On Sep 11, 2008, at Sep 11, 2008, 5:02 AM, Cedric Le Goater wrote:

Today's patch looks reasonable to me.  I would add a FIXME comment in  
net/sunrpc/clnt.c near the site of the fix.


As a final note, I don't think this is an issue only for NFS mounts.   
The problem is with how AUTH_SYS RPC credentials are formed.

cl_nodename is a copy of utsname kept in the rpc_clnt structure for  
efficiency.  I think the auth_unix code has to be more sensitive to  
which utsname is "in effect" for each RPC request.  We probably can't  
use the same utsname for all RPC requests for the life of an RPC  
client.  And since RPC credentials are cached, we should be more  
careful about which cached credential is selected.

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC][PATCH] sunrpc: fix oops in rpc_create() when the ..., Eric W. Biederman, (Tue Sep 9, 11:20 am)
Re: [RFC][PATCH] sunrpc: fix oops in rpc_create() when the ..., Eric W. Biederman, (Wed Sep 10, 1:02 pm)
Re: [RFC][PATCH] sunrpc: fix oops in rpc_create() when the ..., Eric W. Biederman, (Thu Sep 11, 3:27 am)
Re: [RFC][PATCH] sunrpc: fix oops in rpc_create() when the ..., Chuck Lever, (Thu Sep 11, 9:39 am)