Home » Mailing list archives » linux-kernel » 2008 » September » 11

Re: [PATCH 1/3] 24-bit types: typedef and macros for accessing 3-byte arrays as integers

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Chris Leech
Subject: Re: [PATCH 1/3] 24-bit types: typedef and macros for accessing 3-byte arrays as integers
Date: Wednesday, September 10, 2008 - 6:51 pm

On Wed, Sep 10, 2008 at 9:11 AM, Boaz Harrosh <bharrosh@panasas.com> wrote:

I haven't seen padding added simply because of a nested structure
boundary, but I'm not up on all the ABIs for the different
architectures.  Obviously a containing structure would want to have
the 24-bit type adjacent to an 8-bit type, or have it's own packed
attribute if needed.

It shouldn't hurt, in this case the members shouldn't be expected to
have more than byte alignment anyway, but I can't see how it would
help.

If there's a particular arch that might be a problem I'm happy to look
into it, but I don't want to start throwing packed attributes around
just in case.

Chris
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/3] 24-bit types: typedef and macros for accessing ..., Chris Leech, (Fri Sep 5, 9:57 am)
[PATCH 2/3] 24-bit types: convert iSCSI to use the __be24 ..., Chris Leech, (Fri Sep 5, 9:57 am)
[PATCH 3/3] 24-bit types: Convert Open-FCoE to use __be24 ..., Chris Leech, (Fri Sep 5, 9:57 am)
Re: [Open-FCoE] [PATCH 2/3] 24-bit types: convert iSCSI to ..., Mike Christie, (Fri Sep 5, 10:03 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Boaz Harrosh, (Sun Sep 7, 2:36 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Boaz Harrosh, (Sun Sep 7, 2:57 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Chris Leech, (Sun Sep 7, 8:56 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Boaz Harrosh, (Sun Sep 7, 10:21 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Chris Leech, (Sun Sep 7, 10:52 am)
[PATCH] 24-bit types: typedef and functions for accessing ..., Chris Leech, (Tue Sep 9, 3:59 pm)
Re: [PATCH] 24-bit types: typedef and functions for access ..., Boaz Harrosh, (Wed Sep 10, 5:57 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Christoph Hellwig, (Wed Sep 10, 7:07 am)
Re:[PATCH 1/3] 24-bit types: typedef and macros for access ..., Dave Kleikamp, (Wed Sep 10, 8:40 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Boaz Harrosh, (Wed Sep 10, 9:11 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Boaz Harrosh, (Wed Sep 10, 9:25 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Chris Leech, (Wed Sep 10, 9:25 am)
Re: [Open-FCoE] [PATCH 1/3] 24-bit types: typedef and macr ..., Chris Leech, (Wed Sep 10, 10:45 am)
Re: [Open-FCoE] [PATCH 1/3] 24-bit types: typedef and macr ..., Boaz Harrosh, (Wed Sep 10, 11:04 am)
Re: [Open-FCoE] [PATCH 1/3] 24-bit types: typedef and macr ..., Dave Kleikamp, (Wed Sep 10, 11:23 am)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Dave Kleikamp, (Wed Sep 10, 12:20 pm)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Chris Leech, (Wed Sep 10, 6:51 pm)
Re: [PATCH 1/3] 24-bit types: typedef and macros for acces ..., Boaz Harrosh, (Thu Sep 11, 1:30 am)