linux-kernel mailing list

FromSubjectsort iconDate
Rodolfo Giometti
LinuxPPS (RESUBMIT 7): the PPS Linux implementation.
This patch set adds the PPS support into Linux. PPS means "pulse per second" and its API is specified by RFC 2783 (Pulse-Per-Second API for UNIX-like Operating Systems, Version 1.0). The code has been tested with the NTPD program (http://www.eecis.udel.edu/~mills/ntp/html/index.html) and several GPS antennae. Changelog RESUBMIT 6 -> 7: * A new line discipline has been added in order to leave untouched the serial ports code (as suggested by Alan). * n_tty.c exports only GPL symbols...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 01/10] LinuxPPS core support.
This patch adds the kernel side of the PPS support currently named "LinuxPPS". PPS means "pulse per second" and a PPS source is just a device which provides a high precision signal each second so that an application can use it to adjust system clock time. Common use is the combination of the NTPD as userland program with a GPS receiver as PPS source to obtain a wallclock-time with sub-millisecond synchronisation to UTC. To obtain this goal the userland programs shoud use the PPS API specifica...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 02/10] PPS: userland header file for PPS API.
This patch adds into the PPS's documentation directory a possible implementation of the PPS API (RFC 2783) by using the LinuxPPS's char devices. This file is not just an example but it can be used into real systems. :) Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- Documentation/pps/timepps.h | 195 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 195 insertions(+), 0 deletions(-) create mode 100644 Documentation/pps/timepps.h diff --git a/Documentation/pps/time...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 03/10] PPS: documentation programs and examples.
Here some utilities and examples about the PPS API and the LinuxPPS support. * ppsldisc.c shows how to manage PPS line discipline; * ppstest.c implements an useful testing program, while * ppsfind tries to help the user into finding a specific PPS source by using its name or path. Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- Documentation/pps/Makefile | 28 ++++++++ Documentation/pps/ppsfind | 17 +++++ Documentation/pps/ppsldisc.c | 46 +++++++++++++ Docume...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 04/10] PPS: LinuxPPS clients support.
Each PPS source can be registered/deregistered into the system by using special modules called "clients". They simply define the PPS sources' attributes and implement the time signal registartion mechanism. This patch adds a special directory for such clients and adds a dummy client that can be useful to test system integrity on real systems. Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- drivers/pps/Kconfig | 2 + drivers/pps/Makefile | 1 + drivers/pps/...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 05/10] ldisc: new dcd_change() method for line discip...
Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- Documentation/tty.txt | 4 ++++ include/linux/tty_ldisc.h | 8 ++++++++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/Documentation/tty.txt b/Documentation/tty.txt index 8e65c44..3fc812a 100644 --- a/Documentation/tty.txt +++ b/Documentation/tty.txt @@ -100,6 +100,10 @@ write_wakeup() - May be called at any point between open and close. is permitted to call the driver write method from this functio...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods.
Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- drivers/char/n_tty.c | 54 +++++++++++++++++++++++++++++-------------------- include/linux/tty.h | 16 ++++++++++++++ 2 files changed, 48 insertions(+), 22 deletions(-) diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c index 708c2b1..8458ded 100644 --- a/drivers/char/n_tty.c +++ b/drivers/char/n_tty.c @@ -26,7 +26,7 @@ * * 2002/03/18 Implemented n_tty_wakeup to send SIGIO POLL_OUTs to * waiting writing processe...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 07/10] tty: new PPS line discipline.
Add a new line discipline for "pulse per second" devices connected to a serial port. Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- include/linux/tty.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/linux/tty.h b/include/linux/tty.h index 826d695..1857db2 100644 --- a/include/linux/tty.h +++ b/include/linux/tty.h @@ -24,7 +24,7 @@ */ #define NR_UNIX98_PTY_DEFAULT 4096 /* Default maximum for Unix98 ptys */ #define NR_UNIX98_PTY_MAX ...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 08/10] PPS: serial clients support.
Adds support, by using the PPS line discipline, for the PPS sources connected with the CD (Carrier Detect) pin of a serial port. Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- drivers/pps/clients/Kconfig | 7 ++ drivers/pps/clients/Makefile | 1 + drivers/pps/clients/pps-ldisc.c | 154 +++++++++++++++++++++++++++++++++++++++ drivers/serial/8250.c | 13 +++ include/linux/serial_core.h | 10 ++- 5 files changed, 184 insertions(+), 1 deletions(-) cre...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 09/10] PPS: parallel port clients support.
Adds support for the PPS sources connected with the interrupt pin of a parallel port. Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- drivers/char/lp.c | 61 +++++++++++++++++++++++++++++++++++++++++++ drivers/pps/clients/Kconfig | 10 +++++++ include/linux/parport.h | 22 +++++++++++++++ 3 files changed, 93 insertions(+), 0 deletions(-) diff --git a/drivers/char/lp.c b/drivers/char/lp.c index 3f2719b..84e0bb0 100644 --- a/drivers/char/lp.c +++ b/drivers/cha...
Sep 10, 3:52 am 2008
Rodolfo Giometti
[PATCH 10/10] PPS: low level IRQ timestamps recording.
Add low level IRQ timestamps recording for x86 (32 and 64 bits) platforms and enable UART clients in order to use it. This improves PPS precision. :) Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- arch/x86/kernel/irq_32.c | 17 +++++++++++++++++ arch/x86/kernel/irq_64.c | 21 +++++++++++++++++++-- drivers/pps/Kconfig | 12 ++++++++++++ include/linux/pps.h | 1 + include/linux/serial_core.h | 7 ++++++- 5 files changed, 55 insertions(+), 3 delet...
Sep 10, 3:52 am 2008
Rodolfo Giometti
PXA fb overlay support (RESUBMIT 2).
This patch set implements the port of the old pxafb overlay support for 2.6.22 to the latest kernel version. It also adds the mmap() methods and fixes up an issue related to the consistent memory allocation error which causes a segfault during mmap(). Rodolfo --
Sep 10, 4:07 am 2008
Rodolfo Giometti
[PATCH 1/2] pxafb: frame buffer overlay support for PXA27x.
From: Rodolfo Giometti <giometti@linux.it> Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- arch/arm/mach-pxa/include/mach/regs-lcd.h | 39 + drivers/video/Kconfig | 6 + drivers/video/Makefile | 1 + drivers/video/pxafb.c | 75 ++- drivers/video/pxafb.h | 74 ++ drivers/video/pxafb_overlay.c | 1476 +++++++++++++++++++++++++++++ 6 files changed, 1654 insertions(+), 17 deleti...
Sep 10, 4:07 am 2008
Rodolfo Giometti
[PATCH 2/2] PXA: add configurable consistent memory DMA size.
From: Rodolfo Giometti <giometti@linux.it> Signed-off-by: Rodolfo Giometti <giometti@linux.it> --- arch/arm/mach-pxa/include/mach/memory.h | 13 +++++++++++++ drivers/video/Kconfig | 11 +++++++++++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-pxa/include/mach/memory.h b/arch/arm/mach-pxa/include/mach/memory.h index 552eb7f..247c2ef 100644 --- a/arch/arm/mach-pxa/include/mach/memory.h +++ b/arch/arm/mach-pxa/include/mach/memory....
Sep 10, 4:07 am 2008
Miloslav
[PATCH 2/2] audit: Handle embedded NUL in TTY input auditing
From: Miloslav Trmac <mitr@redhat.com> Data read from a TTY can contain an embedded NUL byte (e.g. after pressing Ctrl-2, or sent to a PTY). After the previous patch, the data would be logged only up to the first NUL. This patch modifies the AUDIT_TTY record to always use the hexadecimal format, which does not terminate at the first NUL byte. The vast majority of recorded TTY input data will contain either ' ' or '\n', so the hexadecimal format would have been used anyway. Signed-off-b...
Sep 10, 6:29 pm 2008
Paul Menage
[PATCH] Eliminate race in css_set refcounting
Eliminate race in css_set refcounting This patch replaces the use of krefs in struct css_set with a plain atomic_t, and ensures that the reference count of a css_set never hits zero outside of a write_lock(&css_set_lock) critical section This prevents a race between find_css_set() and put_css_set*() where the reference count can hit zero when the css_set object is still accessible to readers of the hash table. Signed-off-by: Paul Menage <menage@google.com> --- This patch applies...
Sep 10, 6:25 pm 2008
Miloslav
[PATCH 1/2] audit: fix NUL handling in untrusted strings
From: Miloslav Trmac <mitr@redhat.com> audit_string_contains_control() stops checking at the first NUL byte. If audit_string_contains_control() returns FALSE, audit_log_n_untrustedstring() submits the complete string - including the NUL byte and all following bytes, up to the specified maximum length - to audit_log_n_string(), which copies the data unchanged into the audit record. The audit record can thus contain a NUL byte (and some unchecked data after that). Because the user-space aud...
Sep 10, 6:23 pm 2008
Pavel Machek
catch calls of acpi_driver_data on pointer of wrong type
Catch attempts to use of acpi_driver_data on pointers of wrong type. Signed-off-by: Pavel Machek <pavel@suse.cz> Cc: Hannes Reinecke <hare@suse.de> --- commit 76c9074075cd9208cf386f37ebd932a00557643a tree 02589a15c23f430c7728560e4ba51077d41a6eff parent d4a51ebfa2ffc3320d7eab269dc1ca84e86719f5 author Pavel <pavel@amd.ucw.cz> Wed, 10 Sep 2008 16:10:28 +0200 committer Pavel <pavel@amd.ucw.cz> Wed, 10 Sep 2008 16:10:28 +0200 include/acpi/acpi_bus.h | 2 +- 1 files c...
Sep 10, 10:11 am 2008
Alain Knaff
[update4] [PATCH] init: bzip2 or lzma -compressed kernels an...
From: Alain Knaff <alain@knaff.lu> This is an updated version of my bzip2/lzma patch It is based on an idea by Christian Ludwig, includes support for compressing the kernel with bzip2 or lzma rather than gzip. Both compressors give smaller sizes than gzip. Lzma's decompresses faster than bzip2. It also supports ramdisks and initramfs' compressed using these two compressors. The functionality has been successfully used for a couple of years by the udpcast project This version appli...
Sep 10, 6:18 pm 2008
Andrei Gusev
deadlock in setting schedule parameters
Hello! I played witch scheduler settings. After doing something like: echo -n 1000000 >sched_rt_period_us command is looked. I found in kernel.log Sep 11 00:39:34 zaratustra Sep 11 00:39:34 zaratustra Pid: 4495, comm: bash Tainted: G W (2.6.26.3 #12) Sep 11 00:39:34 zaratustra EIP: 0060:[<c0213fc7>] EFLAGS: 00210246 CPU: 0 Sep 11 00:39:34 zaratustra EIP is at div64_u64+0x57/0x80 Sep 11 00:39:34 zaratustra EAX: 0000389f EBX: 00000000 ECX: 00000000 EDX: 00000000 Sep 11 00:39:3...
Sep 10, 5:15 pm 2008
Jiri Slaby
tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27
Hi, is it possible to push tpm-correct-tpm-timeouts-to-jiffies-conversion.patch (the patch header follows) into 2.6.27, please? From: Marcin Obara <marcin_obara@users.sourceforge.net> This patch fixes timeouts conversion to jiffies, by replacing msecs_to_jiffies() calls with usecs_to_jiffies(). According to TCG TPM Specification Version 1.2 Revision 103 (pages 166, 167) TPM timeouts and durations are returned in microseconds (usec) not in miliseconds (msec). Signed-off-by: Marcin Oba...
Sep 10, 6:11 pm 2008
Andrew Morton
Re: tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -&g...
On Thu, 11 Sep 2008 00:11:37 +0200 Why? I wasn't aware that this fixed anything which anyone had observed (pokes tongue out at the changelog). --
Sep 10, 6:22 pm 2008
Bartlomiej Zolnierki...
[git pull] IDE fixes
Hi, Hopefully the last pull request before 2.6.27-final: * Fixes hpt366 crash with HPT374 controllers (Masoud Sharbiani and Sergei Shtylyov). * Adds ide-scsi to feature-removal-schedule.txt, which I forgot to do while deprecating the driver (FUJITA Tomonori). BTW I'll be leaving for KS+LPC on Saturday's morning so I may be a bit unresponsive for a while (preparations, travelling and a "time zone change syndrome"). Linus, please pull from: master.kernel.org:/pub/scm/linux/ker...
Sep 10, 4:47 pm 2008
Todor Gyumyushev
kernel bug
Linux macmini 2.6.26.3 #7 SMP Wed Sep 10 00:54:37 EEST 2008 x86_64 GNU/Linux Gnu C 4.3.1 Gnu make 3.81 binutils 2.18.0.20080103 util-linux 2.13.1.1 mount 2.13.1.1 module-init-tools 3.4 e2fsprogs 1.41.0 Linux C Library 2.7 Dynamic linker (ldd) 2.7 Procps 3.2.7 Net-tools 1.60 Console-tools 0.2.3 Sh-utils 6.10 udev 125 wirele...
Sep 10, 4:35 pm 2008
Geert Uytterhoeven
[patch 2/2] m68k: Update defconfigs for 2.6.27-rc6
From: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/m68k/configs/amiga_defconfig | 53 ++++++++++++++++++----------- arch/m68k/configs/apollo_defconfig | 53 ++++++++++++++++++----------- arch/m68k/configs/atari_defconfig | 60 +++++++++++++++++++-------------- arch/m68k/configs/bvme6000_defconfig | 52 ++++++++++++++++++----------- arch/m68k/configs/hp300_defconfig | 52 ++++++++++++++++++----------- a...
Sep 10, 4:15 pm 2008
Geert Uytterhoeven
[patch 1/2] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA
From: Geert Uytterhoeven <geert@linux-m68k.org> commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342): sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG. Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Paul Mundt <lethal@linux-sh.org> Acked-by: Ma...
Sep 10, 4:15 pm 2008
Geert Uytterhoeven
[patch 0/2] m68k patches for 2.6.27
Hi Linus, Here are two more patches for m68k for 2.6.27: [1] [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA [2] [PATCH] m68k: Update defconfigs for 2.6.27-rc6 The first one fixes a regression in m68k allmodconfig. The second one is the classical defconfig update after all Kconfig changes have settled. Please apply. Also please note that Andrew no longer tracks m68k patches, as the m68k tree is in linux-next. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -...
Sep 10, 4:15 pm 2008
Jan Engelhardt
kbuild: Unnecessary recompiles on path change
Hi, I notice that my kernels get needlessy recompiled if I access the source tree through a different directory. In other words, /lo/linux is the kernel tree, and `mount --bind /lo /home/jengelh/lo` is in effect. I see the absolute path being stored in .*.o.cmd files, which seems like all the explanation I need. I do remember that I left a comment when something like that was afloating: http://www.nabble.com/-RFC-PATCH-3-6--kbuild:-convert-include-and-source-paths-td17064... As of v...
Sep 10, 4:15 pm 2008
Daniel J Blueman
[2.6.27-rc6, patch] fix SWIOTLB oops...
With SWIOTLB being enabled and straight-forward page allocation failure [1], the swiotlb_alloc_coherent fall-back path hits an issue [2], resulting in my webcam failing to work. At the time of oops, RDI is clearly a pointer to a structure which has arrived as NULL, leading to the typo in swiotlb_map_single's callsite arguments. Correctly passing the device structure [3] addresses the issue and gets my webcam working again (the allocation failure still occuring). Please apply, Daniel --- ...
Sep 10, 4:07 pm 2008
Sven Wegener
md: Check for memory allocation failure in faulty personality
It's a fault injection module, but I don't think we should oops here. Signed-off-by: Sven Wegener <sven.wegener@stealer.net> --- drivers/md/faulty.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Other personalities return -EIO, when something like this happens, but I don't see a reason why we shouldn't return the more appropriate -ENOMEM here. diff --git a/drivers/md/faulty.c b/drivers/md/faulty.c index 268547d..f26c1f9 100644 --- a/drivers/md/faulty.c +++ b/drivers/m...
Sep 10, 3:42 pm 2008
Mikael Pettersson
[PATCH 2.6.27-rc6] pci: fix resource_size_t type errors
Fix type errors introduced by commits 9bf8a1a79d549a0cf3b26c88d1ac8cdf07deafee and 76fbc263ff7e42ce8b21b8aee176e3c74b45f81a, "pci: debug extra pci resources range" and "pci: debug extra pci bus resources". These commits added printks of resource_size_t values using "%llx" formats. This is wrong for two reasons: - resource_size_t may be u32 or u64, depending on arch and config options, but "%llx" only works with 64-bit integers; if there is a size mismatch, printk's argument pointer will move pa...
Sep 10, 3:42 pm 2008
Jesse Barnes
Re: [PATCH 2.6.27-rc6] pci: fix resource_size_t type errors
Thanks Mikael, but I already integrated patches from Johann to fix this issue (53bc88701be91e7f631ad31418b32392aa952e9b and 4ca8a7726fb0e8094fdb56f2ae2d69fcf9254eae in my for-linus tree). I've queued it up for 2.6.27. Thanks, Jesse --
Sep 10, 4:02 pm 2008
Sven Wegener
[PATCH] i2c-dev: Return correct error code on class_create()...
We need to convert the error pointer from class_create(), else we'll return the successful return code from register_chrdev() on failure. Signed-off-by: Sven Wegener <sven.wegener@stealer.net> --- drivers/i2c/i2c-dev.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index af4491f..307d976 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -583,8 +583,10 @@ static int __init i2c_dev_init(void) got...
Sep 10, 3:30 pm 2008
Arjan van de Ven
Oops/Warning report for the week of September 10th, 2008
The http://www.kerneloops.org website collects kernel oops and warning reports from various mailing lists and bugzillas as well as with a client users can install to auto-submit oopses. Below is a top 13 list of the traces collected in the last 7 days. (Reports prior to 2.6.23 have been omitted in collecting the top 10) This week, a total of 3106 oopses and warnings have been reported, compared to 1758 reports in the previous week. Per file statistics 295 fs/jbd/journal.c 226 fs/sysfs/dir.c ...
Sep 10, 3:16 pm 2008
Thomas Gleixner
Re: Oops/Warning report for the week of September 10th, 2008
Fixed by the latest updates/fixes to clock events core and hpet code. Working on a backport to 25/26 right now. Thanks, tglx --
Sep 10, 3:36 pm 2008
Justin Mattock
[19.666764] Disabling IRQ #23
hello; I accidently erased the original thread appologize for starting a new one of the same, I've been noticing this message(below) appear every "X" amount of boot's(maybe ten or so); normally upon booting leaving me unable to login. below is dmesg of the message: [ 0.000000] Linux version 2.6.27-rc6 (root@unix) (gcc version 4.1.3 20080623 (prerelease) (Debian 4.1.2-23)) #22 SMP Tue Sep 9 18:46:38 PDT 2008 [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: 000000000...
Sep 10, 3:06 pm 2008
Yinghai Lu
Re: [19.666764] Disabling IRQ #23
On Wed, Sep 10, 2008 at 12:06 PM, Justin Mattock uhci and ehci share one irq. and irq handers for them all registered.... or there is hub under that uhci again... YH --
Sep 10, 3:36 pm 2008
Justin Mattock
Re: [19.666764] Disabling IRQ #23
Not sure, let me disable ehci_hcd for a while to see if this message appears -- Justin P. Mattock --
Sep 10, 3:39 pm 2008
Mark Brown
[PATCH 0/2] WM8400 support
These patches against the regulator development tree add basic support for the WM8400, an audio CODEC and PMU targeted at multimedia systems, covering basic PMIC functionality only. Since the functionality of the device covers multiple subsystems with arbitration required a core driver is provided in drivers/mfd. Samuel, I guess it makes sense to merge this via the regulator tree? --
Sep 10, 2:28 pm 2008
Mark Brown
[PATCH 1/2] mfd: Core support for the WM8400 AudioPlus HiFi ...
The WM8400 is a highly integrated audio CODEC and power management unit optimised for use in mobile multimedia applications. This patch adds core support for the WM8400 to the MFD subsystem. Both I2C and SPI access are supported by the hardware but currently only I2C access is implemented. The code is structureed to allow SPI support to be slotted in later. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- drivers/mfd/Kconfig | 9 + drivers/mfd/Makef...
Sep 10, 2:28 pm 2008
Liam Girdwood
Re: [PATCH 1/2] mfd: Core support for the WM8400 AudioPlus H...
I would probably rename this since it's really resetting the codec cache > +#define WM8400_MIC1SHRT_IRQ_ENA
Sep 10, 2:47 pm 2008
Mark Brown
Re: [PATCH 1/2] mfd: Core support for the WM8400 AudioPlus H...
The notify in the name was supposed to cover that (implying that it's notifying the core rather than actually doing the reset) but it's obviously not doing the job. I think wm8400_reset_codec_reg_cache() Yeah, I considered doing that but decided that it was more trouble than it was worth - the device has far fewer functions than the WM8350. --
Sep 10, 3:13 pm 2008
Liam Girdwood
Re: [PATCH 1/2] mfd: Core support for the WM8400 AudioPlus H...
Wouldn't splitting out audio from power at least half the size of the header. Imho probably making it easier to track down definitions per function. Liam --
Sep 10, 3:38 pm 2008
Mark Brown
[PATCH 2/2] regulator: Add WM8400 regulator support
The WM8400 provides two programmable DCDC step-down (buck) convertors and four low-dropout (LDO) regulators. This driver provides support for runtime managment of these in the standard regulator API. Support for configuration of the suspend and hibernate mode behaviour of the regulators is not yet included. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile | 1 + drivers/regulator/wm8...
Sep 10, 2:28 pm 2008
Liam Girdwood
Re: [PATCH 2/2] regulator: Add WM8400 regulator support
This should return NORMAL by default. Probably best to add a lookup table for IDLE & STANDBY if supported. Cheers Liam --
Sep 10, 2:39 pm 2008
Mark Brown
Re: [PATCH 2/2] regulator: Add WM8400 regulator support
Yeah, I've changed it to NORMAL for now. I'll add the lookup table in a followup patch later along with things like support for configuring the suspend modes of the device if that's OK? --
Sep 10, 3:40 pm 2008
Liam Girdwood Sep 10, 3:58 pm 2008
Marcel Holtmann
Re: [PATCH 1/2 v6] cfg80211: Add new wireless regulatory inf...
thanks for the write-up and examples. I like it a lot and gives driver maintainers a nice understanding what to do. While reading through it, I came to think about regulatory_hint(). So is there a use case where would give it the alpha2 code and the domain itself at the same time? If not, then it would make more sense to split this into two functions. Maybe something regulatory_alpha2_hint() and regulatory_domain_hint(). Just a thought. Regards Marcel --
Sep 10, 2:17 pm 2008
Luis R. Rodriguez
Re: [PATCH 1/2 v6] cfg80211: Add new wireless regulatory inf...
On Wed, Sep 10, 2008 at 11:17 AM, Marcel Holtmann Nope, you either pass an alpha2 or an rd domain which is built by you (and in that rd structure you can set the alpha2 to your iso3166 That's how I had it originally but decided to condense it to one routine since as you could see they pretty much do the same thing except the case where the rd is provided it calls set_regdom(). Setting it back to use two routines if fine by me too. What is better? Can we just get this merged and then we can flip...
Sep 10, 4:18 pm 2008
Marcel Holtmann
Re: [PATCH 1/2 v6] cfg80211: Add new wireless regulatory inf...
my take on this is that if from an API perspective you can only use one parameter or the other, then it should be two functions. Regards Marcel --
Sep 10, 6:07 pm 2008
previous daytodaynext day
September 9, 2008September 10, 2008September 11, 2008