Home » Mailing list archives » linux-kernel » 2008 » September » 10

[patch 1/2] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Geert Uytterhoeven <geert@...>
To: Linus Torvalds <torvalds@...>, Magnus Damm <magnus.damm@...>, Mauro Carvalho Chehab <mchehab@...>
Cc: <linux-m68k@...>, <linux-kernel@...>, Paul Mundt <lethal@...>, <video4linux-list@...>, Magnus Damm <damm@...>
Subject: [patch 1/2] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA
Date: Wednesday, September 10, 2008 - 4:15 pm

From: Geert Uytterhoeven <geert@linux-m68k.org>

commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342):
sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced
VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the
dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG.

Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Magnus Damm <damm@igel.co.jp>
---
This broke m68k allmodconfig (which still selects Sun-3). I assume it also
affects the other NO_DMA platforms like h8300, m32r, s390, and PCI-less
SPARC?

 drivers/media/video/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -968,7 +968,7 @@ config VIDEO_PXA27x
 
 config VIDEO_SH_MOBILE_CEU
 	tristate "SuperH Mobile CEU Interface driver"
-	depends on VIDEO_DEV
+	depends on VIDEO_DEV && HAS_DMA
 	select SOC_CAMERA
 	select VIDEOBUF_DMA_CONTIG
 	---help---

-- 
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 1/2] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA, Geert Uytterhoeven, (Wed Sep 10, 4:15 pm)