Re: [Xen-devel] Re: [PATCH 1 of 7] x86: add _PAGE_IOMAP pte flag for IO mappings

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeremy Fitzhardinge
Date: Wednesday, September 10, 2008 - 9:38 am

Avi Kivity wrote:

Hm, is that actually true enough to define it?  Could we rename it
something like _PAGE_NOSTRUCTPAGE or something a bit more specific than
"special"?


But _PAGE_SPECIAL is only set in a few places.  It's not set in ioremap
mappings and so on.  Should it be?

There's also the hiccup that it gets set in a pte with pte_mkspecial() -
but at that point its too late because you've already constructed the
pte and done the pfn->mfn conversion.  _PAGE_IOMAP can only be set when
you initially construct the pte out of a frame number and a pgprot.

    J
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0 of 7] x86: lay groundwork for Xen domain 0 support, Jeremy Fitzhardinge, (Sun Sep 7, 3:21 pm)
[PATCH 1 of 7] x86: add _PAGE_IOMAP pte flag for IO mappings, Jeremy Fitzhardinge, (Sun Sep 7, 3:21 pm)
[PATCH 2 of 7] x86: remove duplicate early_ioremap declara ..., Jeremy Fitzhardinge, (Sun Sep 7, 3:21 pm)
[PATCH 3 of 7] x86: add early_memremap(), Jeremy Fitzhardinge, (Sun Sep 7, 3:21 pm)
[PATCH 4 of 7] x86: use early_memremap() in setup.c, Jeremy Fitzhardinge, (Sun Sep 7, 3:21 pm)
[PATCH 5 of 7] x86-64: don't check for map replacement, Jeremy Fitzhardinge, (Sun Sep 7, 3:21 pm)
[PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table, Jeremy Fitzhardinge, (Sun Sep 7, 3:21 pm)
[PATCH 7 of 7] x86: always explicitly map acpi memory, Jeremy Fitzhardinge, (Sun Sep 7, 3:21 pm)
Re: [Xen-devel] [PATCH 7 of 7] x86: always explicitly map ..., Jeremy Fitzhardinge, (Sun Sep 7, 5:02 pm)
Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table, Jeremy Fitzhardinge, (Sun Sep 7, 5:03 pm)
Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table, Jeremy Fitzhardinge, (Mon Sep 8, 9:29 am)
Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table, Jeremy Fitzhardinge, (Mon Sep 8, 12:41 pm)
Re: [PATCH 1 of 7] x86: add _PAGE_IOMAP pte flag for IO ma ..., Jeremy Fitzhardinge, (Tue Sep 9, 7:47 am)
Re: [Xen-devel] Re: [PATCH 1 of 7] x86: add _PAGE_IOMAP pt ..., Jeremy Fitzhardinge, (Tue Sep 9, 8:48 am)
Re: [Xen-devel] Re: [PATCH 1 of 7] x86: add _PAGE_IOMAP pt ..., Jeremy Fitzhardinge, (Wed Sep 10, 9:38 am)
Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table, Jeremy Fitzhardinge, (Wed Sep 10, 9:49 am)
Re: [Xen-devel] Re: [PATCH 1 of 7] x86: add _PAGE_IOMAP pt ..., Jeremy Fitzhardinge, (Wed Sep 10, 10:27 am)
Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table, Jeremy Fitzhardinge, (Thu Sep 11, 11:36 am)
Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table, Jeremy Fitzhardinge, (Thu Sep 11, 2:07 pm)