Yes. umount filesystems on any device in the dock, and issue the "power off
dock" command (i.e. tell the kernel to *eject* the dock). This is *very*
important, although the ThinkPad firmware/hardware will _try_ to protect the
electronics if you just pull the laptop off the dock while it is still
powered (but it might just not be able to do it, so Don't Do That!).
Anyway, if your dock led is going off before you remove the laptop from the
dock, you're doing everything correctly as far as the hardware is concerned.
And the kernel will scream bloody murder if you remove a device with live
filesystems in it, so it should be trivial to check if that part is being
taken care of by your userspace as well. Not that something like this would
be an excuse to fail to suspend/resume after being undocked, mind you.
Your uneducated guess might well be right, there are a lot of patches for
dock that are not in mainline yet. You clearly are experiencing some sort
of Linux bug, that much is pretty clear to me.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--