[PATCH #blk-for-2.8] init: DEBUG_BLOCK_EXT_DEVT requires explicit root= param

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Bartlomiej Zolnierkiewicz <bzolnier@...>
Cc: Jens Axboe <jens.axboe@...>, Stephen Rothwell <sfr@...>, <linux-next@...>, LKML <linux-kernel@...>, Ingo Molnar <mingo@...>, <dm-devel@...>
Date: Monday, September 1, 2008 - 7:00 am

DEBUG_BLOCK_EXT_DEVT shuffles SCSI and IDE device numbers and root
device number set using rdev become meaningless.  Root devices should
be explicitly specified using textual names.  Warn about it if root
can't be found and DEBUG_BLOCK_EXT_DEVT is enabled.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
There are other ways to specify device numbers directly (ie. root=8:0)
and DEBUG_BLOCK_EXT_DEVT being a debug option I don't think it
warrants a complex logic, so I just added simple warning message.

 init/do_mounts.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: work/init/do_mounts.c
===================================================================
--- work.orig/init/do_mounts.c
+++ work/init/do_mounts.c
@@ -263,6 +263,10 @@ retry:
 		printk("Please append a correct \"root=\" boot option; here are the available partitions:\n");
 
 		printk_all_partitions();
+#ifdef CONFIG_DEBUG_BLOCK_EXT_DEVT
+		printk("DEBUG_BLOCK_EXT_DEVT is enabled, you need to specify "
+		       "explicit textual name for \"root=\" boot option.\n");
+#endif
 		panic("VFS: Unable to mount root fs on %s", b);
 	}
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
linux-next: Tree for August 27, Stephen Rothwell, (Wed Aug 27, 4:34 am)
Re: linux-next: Tree for August 27, Bartlomiej Zolnierkiewicz..., (Wed Aug 27, 6:06 am)
Re: linux-next: Tree for August 27, Bartlomiej Zolnierkiewicz..., (Wed Aug 27, 10:57 am)
Re: linux-next: Tree for August 27, Ingo Molnar, (Thu Aug 28, 5:08 am)
Re: linux-next: Tree for August 27, Stephen Rothwell, (Wed Aug 27, 9:25 pm)
Re: linux-next: Tree for August 27, Bartlomiej Zolnierkiewicz..., (Wed Aug 27, 3:45 pm)
Re: linux-next: Tree for August 27, Bartlomiej Zolnierkiewicz..., (Thu Aug 28, 8:10 pm)
Re: linux-next: Tree for August 27, Jens Axboe, (Fri Aug 29, 3:05 am)
Re: linux-next: Tree for August 27, Tejun Heo, (Fri Aug 29, 5:37 am)
Re: linux-next: Tree for August 27, Jens Axboe, (Fri Aug 29, 5:42 am)
Re: linux-next: Tree for August 27, Bartlomiej Zolnierkiewicz..., (Fri Aug 29, 3:23 pm)
Re: linux-next: Tree for August 27, Tejun Heo, (Sat Aug 30, 5:10 am)
Re: linux-next: Tree for August 27, Bartlomiej Zolnierkiewicz..., (Sun Aug 31, 9:38 am)
[PATCH #blk-for-2.8] init: DEBUG_BLOCK_EXT_DEVT requires exp..., Tejun Heo, (Mon Sep 1, 7:00 am)
Re: [PATCH #blk-for-2.8] init: DEBUG_BLOCK_EXT_DEVT requires..., Bartlomiej Zolnierkiewicz..., (Mon Sep 1, 12:34 pm)
Re: linux-next: Tree for August 27, Stephen Rothwell, (Fri Aug 29, 4:36 am)